* [PATCH 3/3] Usb: core: buffer: fixed the checkpatch warning
@ 2015-04-18 14:52 Nizam Haider
2015-04-28 10:59 ` Greg KH
0 siblings, 1 reply; 5+ messages in thread
From: Nizam Haider @ 2015-04-18 14:52 UTC (permalink / raw)
To: gregkh; +Cc: linux-usb, linux-kernel, Nizam Haider
Fixed two warnings sizeof name and clank line after declaration
Signed-off-by: Nizam Haider <nizamhaider786@gmail.com>
---
drivers/usb/core/buffer.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/core/buffer.c b/drivers/usb/core/buffer.c
index 684ef70..04125b6 100644
--- a/drivers/usb/core/buffer.c
+++ b/drivers/usb/core/buffer.c
@@ -62,7 +62,7 @@ int hcd_buffer_create(struct usb_hcd *hcd)
size = pool_max[i];
if (!size)
continue;
- snprintf(name, sizeof name, "buffer-%d", size);
+ snprintf(name, sizeof(name), "buffer-%d", size);
hcd->pool[i] = dma_pool_create(name, hcd->self.controller,
size, size, 0);
if (!hcd->pool[i]) {
@@ -87,6 +87,7 @@ void hcd_buffer_destroy(struct usb_hcd *hcd)
for (i = 0; i < HCD_BUFFER_POOLS; i++) {
struct dma_pool *pool = hcd->pool[i];
+
if (pool) {
dma_pool_destroy(pool);
hcd->pool[i] = NULL;
--
1.8.1.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 3/3] Usb: core: buffer: fixed the checkpatch warning
2015-04-18 14:52 [PATCH 3/3] Usb: core: buffer: fixed the checkpatch warning Nizam Haider
@ 2015-04-28 10:59 ` Greg KH
0 siblings, 0 replies; 5+ messages in thread
From: Greg KH @ 2015-04-28 10:59 UTC (permalink / raw)
To: Nizam Haider; +Cc: linux-usb, linux-kernel
On Sat, Apr 18, 2015 at 08:22:36PM +0530, Nizam Haider wrote:
> Fixed two warnings sizeof name and clank line after declaration
"clank"?
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 3/3] Usb: core: buffer: fixed the checkpatch warning
@ 2015-04-29 10:49 Nizam Haider
0 siblings, 0 replies; 5+ messages in thread
From: Nizam Haider @ 2015-04-29 10:49 UTC (permalink / raw)
To: gregkh; +Cc: linux-usb, linux-kernel, Nizam Haider
Fixed two warnings sizeof name and Blank line after declaration
Signed-off-by: Nizam Haider <nizamhaider786@gmail.com>
---
drivers/usb/core/buffer.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/core/buffer.c b/drivers/usb/core/buffer.c
index 684ef70..04125b6 100644
--- a/drivers/usb/core/buffer.c
+++ b/drivers/usb/core/buffer.c
@@ -62,7 +62,7 @@ int hcd_buffer_create(struct usb_hcd *hcd)
size = pool_max[i];
if (!size)
continue;
- snprintf(name, sizeof name, "buffer-%d", size);
+ snprintf(name, sizeof(name), "buffer-%d", size);
hcd->pool[i] = dma_pool_create(name, hcd->self.controller,
size, size, 0);
if (!hcd->pool[i]) {
@@ -87,6 +87,7 @@ void hcd_buffer_destroy(struct usb_hcd *hcd)
for (i = 0; i < HCD_BUFFER_POOLS; i++) {
struct dma_pool *pool = hcd->pool[i];
+
if (pool) {
dma_pool_destroy(pool);
hcd->pool[i] = NULL;
--
1.8.1.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 3/3] Usb: core: buffer: fixed the checkpatch warning
2015-04-28 11:47 Nizam Haider
@ 2015-04-28 18:18 ` Greg KH
0 siblings, 0 replies; 5+ messages in thread
From: Greg KH @ 2015-04-28 18:18 UTC (permalink / raw)
To: Nizam Haider; +Cc: linux-usb, linux-kernel
On Tue, Apr 28, 2015 at 05:17:11PM +0530, Nizam Haider wrote:
> Fixed two warnings sizeof name and Blank line after declaration
>
> Signed-off-by: Nizam Haider <nizamhaider786@gmail.com>
> ---
> drivers/usb/core/buffer.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Where are patches 1/3 and 2/3?
Please resend them all properly.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 3/3] Usb: core: buffer: fixed the checkpatch warning
@ 2015-04-28 11:47 Nizam Haider
2015-04-28 18:18 ` Greg KH
0 siblings, 1 reply; 5+ messages in thread
From: Nizam Haider @ 2015-04-28 11:47 UTC (permalink / raw)
To: gregkh; +Cc: linux-usb, linux-kernel, Nizam Haider
Fixed two warnings sizeof name and Blank line after declaration
Signed-off-by: Nizam Haider <nizamhaider786@gmail.com>
---
drivers/usb/core/buffer.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/core/buffer.c b/drivers/usb/core/buffer.c
index 684ef70..04125b6 100644
--- a/drivers/usb/core/buffer.c
+++ b/drivers/usb/core/buffer.c
@@ -62,7 +62,7 @@ int hcd_buffer_create(struct usb_hcd *hcd)
size = pool_max[i];
if (!size)
continue;
- snprintf(name, sizeof name, "buffer-%d", size);
+ snprintf(name, sizeof(name), "buffer-%d", size);
hcd->pool[i] = dma_pool_create(name, hcd->self.controller,
size, size, 0);
if (!hcd->pool[i]) {
@@ -87,6 +87,7 @@ void hcd_buffer_destroy(struct usb_hcd *hcd)
for (i = 0; i < HCD_BUFFER_POOLS; i++) {
struct dma_pool *pool = hcd->pool[i];
+
if (pool) {
dma_pool_destroy(pool);
hcd->pool[i] = NULL;
--
1.8.1.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-04-29 16:20 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-18 14:52 [PATCH 3/3] Usb: core: buffer: fixed the checkpatch warning Nizam Haider
2015-04-28 10:59 ` Greg KH
2015-04-28 11:47 Nizam Haider
2015-04-28 18:18 ` Greg KH
2015-04-29 10:49 Nizam Haider
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).