[PATCH] x86: Fix mkcapflags.sh bash-ism again

[PATCH] x86: Fix mkcapflags.sh bash-ism again

[Sylvain BERTRAND]

Chocked while compiling linux with dash shell instead of bash shell.
See:
http://pubs.opengroup.org/onlinepubs/009695399/utilities/xcu_chap02.html#tag_02_09_05

Cc: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Sylvain BERTRAND <sylvain.bertrand@gmail.com>
---

Forgot that one. More to come.

--- a/arch/x86/kernel/cpu/mkcapflags.sh
+++ b/arch/x86/kernel/cpu/mkcapflags.sh
@@ -6,7 +6,7 @@
 IN=$1
 OUT=$2
 
-function dump_array()
+dump_array()
 {
 	ARRAY=$1
 	SIZE=$2

[tip:x86/build] x86/build: Fix mkcapflags.sh bash-ism

[tip-bot for Sylvain BERTRAND]

Commit-ID:  e85bd9892c4f10fd20fc575e62327efb7c77015d
Gitweb:     http://git.kernel.org/tip/e85bd9892c4f10fd20fc575e62327efb7c77015d
Author:     Sylvain BERTRAND <sylvain.bertrand@gmail.com>
AuthorDate: Mon, 29 Dec 2014 16:43:24 +0100
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Thu, 19 Feb 2015 02:21:00 +0100

x86/build: Fix mkcapflags.sh bash-ism

Chocked while compiling linux with dash shell instead of bash
shell. See:

  http://pubs.opengroup.org/onlinepubs/009695399/utilities/xcu_chap02.html#tag_02_09_05

Signed-off-by: Sylvain BERTRAND <sylvain.bertrand@gmail.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/20141229154324.GA27533@dhcppc1
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 arch/x86/kernel/cpu/mkcapflags.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/cpu/mkcapflags.sh b/arch/x86/kernel/cpu/mkcapflags.sh
index 36d99a3..3f20710 100644
--- a/arch/x86/kernel/cpu/mkcapflags.sh
+++ b/arch/x86/kernel/cpu/mkcapflags.sh
@@ -6,7 +6,7 @@
 IN=$1
 OUT=$2
 
-function dump_array()
+dump_array()
 {
 	ARRAY=$1
 	SIZE=$2

Re: [PATCH] x86: Fix mkcapflags.sh bash-ism again

[sylvain.bertrand]

While compiling linux, dash shell reports a bash-ism:

/src/linux-4.0/arch/x86/kernel/cpu/mkcapflags.sh: 9: /src/linux-4.0/arch/x86/kernel/cpu/mkcapflags.sh: Syntax error: "(" unexpected

See:
http://pubs.opengroup.org/onlinepubs/009695399/utilities/xcu_chap02.html#tag_02_09_05

Cc: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Sylvain BERTRAND <sylvain.bertrand@gmail.com>
---
Forgot that fix:
--- a/arch/x86/kernel/cpu/mkcapflags.sh
+++ b/arch/x86/kernel/cpu/mkcapflags.sh
@@ -6,7 +6,7 @@
 IN=$1
 OUT=$2
 
-function dump_array()
+dump_array()
 {
 	ARRAY=$1
 	SIZE=$2

Re: [PATCH] x86: Fix mkcapflags.sh bash-ism again

[sylvain.bertrand]

On Mon, Apr 27, 2015 at 03:21:02PM +0000, sylvain.bertrand@gmail.com wrote:
> While compiling linux, dash shell reports a bash-ism:
> 
> /src/linux-4.0/arch/x86/kernel/cpu/mkcapflags.sh: 9: /src/linux-4.0/arch/x86/kernel/cpu/mkcapflags.sh: Syntax error: "(" unexpected
> 
> See:
> http://pubs.opengroup.org/onlinepubs/009695399/utilities/xcu_chap02.html#tag_02_09_05
> 
> Cc: Ingo Molnar <mingo@kernel.org>
> Signed-off-by: Sylvain BERTRAND <sylvain.bertrand@gmail.com>
> ---
> Forgot that fix:
> --- a/arch/x86/kernel/cpu/mkcapflags.sh
> +++ b/arch/x86/kernel/cpu/mkcapflags.sh
> @@ -6,7 +6,7 @@
>  IN=$1
>  OUT=$2
>  
> -function dump_array()
> +dump_array()
>  {
>  	ARRAY=$1
>  	SIZE=$2

What's up with this patch?

regards,

-- 
Sylvain

Re: [PATCH] x86: Fix mkcapflags.sh bash-ism again

[Ingo Molnar]

* sylvain.bertrand@gmail.com <sylvain.bertrand@gmail.com> wrote:

> On Mon, Apr 27, 2015 at 03:21:02PM +0000, sylvain.bertrand@gmail.com wrote:
> > While compiling linux, dash shell reports a bash-ism:
> > 
> > /src/linux-4.0/arch/x86/kernel/cpu/mkcapflags.sh: 9: /src/linux-4.0/arch/x86/kernel/cpu/mkcapflags.sh: Syntax error: "(" unexpected
> > 
> > See:
> > http://pubs.opengroup.org/onlinepubs/009695399/utilities/xcu_chap02.html#tag_02_09_05
> > 
> > Cc: Ingo Molnar <mingo@kernel.org>
> > Signed-off-by: Sylvain BERTRAND <sylvain.bertrand@gmail.com>
> > ---
> > Forgot that fix:
> > --- a/arch/x86/kernel/cpu/mkcapflags.sh
> > +++ b/arch/x86/kernel/cpu/mkcapflags.sh
> > @@ -6,7 +6,7 @@
> >  IN=$1
> >  OUT=$2
> >  
> > -function dump_array()
> > +dump_array()
> >  {
> >  	ARRAY=$1
> >  	SIZE=$2
> 
> What's up with this patch?

It's upstream, as commit:

  e85bd9892c4f x86/build: Fix mkcapflags.sh bash-ism

thanks,

	Ingo