[PATCH] staging: rtl8192u: Modify if, else if conditions to remove unnecessary equality checks. This change was detected with the help of coccinelle tool.

[PATCH] staging: rtl8192u: Modify if, else if conditions to remove unnecessary equality checks. This change was detected with the help of coccinelle tool.

[Dhere, Chaitanya (C.)]

Signed-off-by: Chaitanya Dhere <cvijaydh@visteon.com>
Reply-To: 

---
 drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
index d2e8b12..30b0135 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
@@ -1364,12 +1364,11 @@ static void ieee80211_associate_complete_wq(struct work_struct *work)
 		ieee->LinkDetectInfo.NumRecvDataInPeriod= 1;
 	}
 	ieee->link_change(ieee->dev);
-	if(ieee->is_silent_reset == 0){
+	if (!ieee->is_silent_reset) {
 		printk("============>normal associate\n");
 	notify_wx_assoc_event(ieee);
 	}
-	else if(ieee->is_silent_reset == 1)
-	{
+	else if (ieee->is_silent_reset) {
 		printk("==================>silent reset associate\n");
 		ieee->is_silent_reset = false;
 	}
-- 
1.9.1

Re: [PATCH] staging: rtl8192u: Modify if, else if conditions to remove unnecessary equality checks. This change was detected with the help of coccinelle tool.

[gregkh]

On Mon, May 18, 2015 at 04:00:00PM +0000, Dhere, Chaitanya (C.) wrote:
> Signed-off-by: Chaitanya Dhere <cvijaydh@visteon.com>

Your subject line is too long :(

Put some information in the change log area here please, above the
signed-off-by line.

> Reply-To: 

Why is this here?

Please fix up and resend.

thanks,

greg k-h

Re: [PATCH] staging: rtl8192u: Modify if, else if conditions to remove unnecessary equality checks. This change was detected with the help of coccinelle tool.

[Paul Gortmaker]

[[PATCH] staging: rtl8192u: Modify if, else if conditions to remove unnecessary equality checks. This change was detected with the help of coccinelle tool.] On 18/05/2015 (Mon 16:00) Dhere, Chaitanya (C.) wrote:

> Signed-off-by: Chaitanya Dhere <cvijaydh@visteon.com>
> Reply-To: 
> 
> ---
>  drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
> index d2e8b12..30b0135 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
> @@ -1364,12 +1364,11 @@ static void ieee80211_associate_complete_wq(struct work_struct *work)
>  		ieee->LinkDetectInfo.NumRecvDataInPeriod= 1;
>  	}
>  	ieee->link_change(ieee->dev);
> -	if(ieee->is_silent_reset == 0){
> +	if (!ieee->is_silent_reset) {
>  		printk("============>normal associate\n");
>  	notify_wx_assoc_event(ieee);
>  	}

In addition to Greg's comments, I'd ask while here, what about the
misleading lack of indent on the notify_wx_assoc_event() call above?
That would concern me more than trivial equality check changes that
gcc will no doubt optimize to the same thing.

> -	else if(ieee->is_silent_reset == 1)
> -	{
> +	else if (ieee->is_silent_reset) {

But why leave the "else if" vs an "else"?  You know this:

staging/rtl8192u/ieee80211/ieee80211.h: bool is_silent_reset;

and you've already tested "if (!ieee->is_silent_reset)".  By
definition, a bool can have only two values and you've already
tested for one of them, so...

Paul.
--

>  		printk("==================>silent reset associate\n");
>  		ieee->is_silent_reset = false;
>  	}
> -- 
> 1.9.1