From: Mark Brown <broonie@kernel.org>
To: "Zha, Qipeng" <qipeng.zha@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Yang, Fei" <fei.yang@intel.com>,
"Zhong, Huiquan" <huiquan.zhong@intel.com>,
"Chen, Jason CJ" <jason.cj.chen@intel.com>,
"Zheng, Qi" <qi.zheng@intel.com>
Subject: Re: [PATCH] regmap: add virtual PMIC IPC bus support
Date: Tue, 19 May 2015 13:09:15 +0100 [thread overview]
Message-ID: <20150519120915.GJ2761@sirena.org.uk> (raw)
In-Reply-To: <C6287702A945AC47BE5DB5DFD4B5C6DD018B6A03@SHSMSX104.ccr.corp.intel.com>
[-- Attachment #1: Type: text/plain, Size: 932 bytes --]
On Tue, May 19, 2015 at 04:57:00AM +0000, Zha, Qipeng wrote:
> >Why is this being added to the regmap core rather than being implemented
> >in using the reg_write() and reg_read() callbacks in the core driver for
> >the PMIC?
> Thanks. I don't receive this message before in eamil.
> Current regmap only support register access using several bus: i2c, spi, ac97 ...
> But register access for intel pmic are done by hardware ipc, so we add such support in regmap core,
> To make pmic subdevice drivers can use generic regmap r/w API to access registers.
That doesn't really address my concern - we already have the reg_read()
and reg_write() interface so devices can use regmap without a bus in the
core. The question is if this is something that's going to be used by
many devices so there's code to share or if it's something that's only
going to be used by this PMIC in which case keeping it in the driver
should be easier.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-05-19 12:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-20 23:38 [PATCH] regmap: add virtual PMIC IPC bus support qipeng.zha
2015-04-20 16:05 ` Mark Brown
2015-05-18 8:10 ` Zha, Qipeng
2015-05-18 11:21 ` Mark Brown
2015-05-19 4:57 ` Zha, Qipeng
2015-05-19 12:09 ` Mark Brown [this message]
2015-05-20 1:02 ` Zha, Qipeng
2015-05-20 11:04 ` Mark Brown
2015-05-20 17:22 ` Yang, Fei
2015-06-10 15:51 ` Yang, Fei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150519120915.GJ2761@sirena.org.uk \
--to=broonie@kernel.org \
--cc=fei.yang@intel.com \
--cc=huiquan.zhong@intel.com \
--cc=jason.cj.chen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=qi.zheng@intel.com \
--cc=qipeng.zha@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).