From: Steven Rostedt <rostedt@goodmis.org>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Ankit Gupta <ankgupta@codeaurora.org>,
gavidov@codeaurora.org, sdharia@codeaurora.org,
mlocke@codeaurora.org, linux-arm-msm@vger.kernel.org,
gregkh@linuxfoundation.org, ivan.ivanov@linaro.org,
linux-kernel@vger.kernel.org, svarbanov@mm-sol.com,
galak@codeaurora.org, agross@codeaurora.org
Subject: Re: [PATCH] spmi: add command tracepoints for SPMI
Date: Tue, 19 May 2015 22:47:01 -0400 [thread overview]
Message-ID: <20150519224701.7ac87489@grimm.local.home> (raw)
In-Reply-To: <555BD719.80508@codeaurora.org>
On Tue, 19 May 2015 17:36:41 -0700
Stephen Boyd <sboyd@codeaurora.org> wrote:
> +Steven Rostedt
>
> On 05/18/15 14:51, Ankit Gupta wrote:
> > Add tracepoints to retrieve information about read, write
> > and non-data commands. For performance measurement support
> > tracepoints are added at the beginning and at the end of
> > transfers. Following is a list showing the new tracepoint
> > events. The "cmd" parameter here represents the opcode, SID,
> > and full 16-bit address.
> >
> > spmi_write_begin: cmd and data buffer.
> > spmi_write_end : cmd and return value.
> > spmi_read_begin : cmd.
> > spmi_read_end : cmd, return value and data buffer.
> > spmi_cmd : cmd.
> >
> > The reason that cmd appears at both the beginning and at
> > the end event is that SPMI drivers can request commands
> > concurrently. cmd helps in matching the corresponding
> > events.
> >
> > SPMI tracepoints can be enabled like:
> >
> > echo 1 >/sys/kernel/debug/tracing/events/spmi/enable
> >
> > and will dump messages that can be viewed in
> > /sys/kernel/debug/tracing/trace that look like:
> >
> > ... spmi_read_begin: opc=56 sid=00 addr=0x0000
> > ... spmi_read_end: opc=56 sid=00 addr=0x0000 ret=0 len=02 buf=0x[01-40]
> > ... spmi_write_begin: opc=48 sid=00 addr=0x0000 len=3 buf=0x[ff-ff-ff]
> >
> > Signed-off-by: Ankit Gupta <ankgupta@codeaurora.org>
> > Signed-off-by: Gilad Avidov <gavidov@codeaurora.org>
> > Suggested-by: Sagar Dharia <sdharia@codeaurora.org>
> > ---
>
> Your Signed-off-by should be last.
>
The tracing part looks fine to me. For that:
Acked-by: Steven Rostedt <rostedt@goodmis.org>
-- Steve
next prev parent reply other threads:[~2015-05-20 2:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-18 21:51 [PATCH] spmi: add command tracepoints for SPMI Ankit Gupta
2015-05-20 0:36 ` Stephen Boyd
2015-05-20 2:47 ` Steven Rostedt [this message]
2015-05-20 15:08 ` Ankit Gupta
2015-05-20 18:29 ` Stephen Boyd
2015-05-20 18:58 ` Steven Rostedt
2015-05-21 19:37 ` Stephen Boyd
2015-05-21 20:26 ` Ankit Gupta
2015-05-21 19:39 ` Stephen Boyd
2015-05-21 23:24 ` Ankit Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150519224701.7ac87489@grimm.local.home \
--to=rostedt@goodmis.org \
--cc=agross@codeaurora.org \
--cc=ankgupta@codeaurora.org \
--cc=galak@codeaurora.org \
--cc=gavidov@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=ivan.ivanov@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mlocke@codeaurora.org \
--cc=sboyd@codeaurora.org \
--cc=sdharia@codeaurora.org \
--cc=svarbanov@mm-sol.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).