From: Steven Rostedt <rostedt@goodmis.org>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Ankit Gupta <ankgupta@codeaurora.org>,
gavidov@codeaurora.org, sdharia@codeaurora.org,
mlocke@codeaurora.org, linux-arm-msm@vger.kernel.org,
gregkh@linuxfoundation.org, ivan.ivanov@linaro.org,
linux-kernel@vger.kernel.org, svarbanov@mm-sol.com,
galak@codeaurora.org, agross@codeaurora.org
Subject: Re: [PATCH] spmi: add command tracepoints for SPMI
Date: Wed, 20 May 2015 14:58:07 -0400 [thread overview]
Message-ID: <20150520145807.63f62ca7@gandalf.local.home> (raw)
In-Reply-To: <20150520182955.GR31753@codeaurora.org>
On Wed, 20 May 2015 11:29:55 -0700
Stephen Boyd <sboyd@codeaurora.org> wrote:
> > I see no reason to spend to 4-8 bytes when spmi spec allows for maximum
> > buffer size of 16. Do you suggest changing the API of read_cmd()?
> > >
>
> Is that a maximum buffer size of 16 bytes? I'd prefer consistency
> with the API that's being traced, that's all. Changing it to u8
> to save a few bytes probably doesn't make any difference if the
> architecture passes function arguments in CPU registers which are
> 32 or 64 bits wide or if the function can be inlined enough by
> the compiler to where the len parameter is kept in a register.
>
I believe the worry is about wasting bytes in the ring buffer if not
necessary. But we do that in other tracepoints, so it's really up to
the maintainer.
-- Steve
next prev parent reply other threads:[~2015-05-20 18:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-18 21:51 [PATCH] spmi: add command tracepoints for SPMI Ankit Gupta
2015-05-20 0:36 ` Stephen Boyd
2015-05-20 2:47 ` Steven Rostedt
2015-05-20 15:08 ` Ankit Gupta
2015-05-20 18:29 ` Stephen Boyd
2015-05-20 18:58 ` Steven Rostedt [this message]
2015-05-21 19:37 ` Stephen Boyd
2015-05-21 20:26 ` Ankit Gupta
2015-05-21 19:39 ` Stephen Boyd
2015-05-21 23:24 ` Ankit Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150520145807.63f62ca7@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=agross@codeaurora.org \
--cc=ankgupta@codeaurora.org \
--cc=galak@codeaurora.org \
--cc=gavidov@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=ivan.ivanov@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mlocke@codeaurora.org \
--cc=sboyd@codeaurora.org \
--cc=sdharia@codeaurora.org \
--cc=svarbanov@mm-sol.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).