* [PATCH] staging: comedi: fix coding style issues
@ 2015-05-16 4:16 Geliang Tang
2015-05-18 11:37 ` Ian Abbott
0 siblings, 1 reply; 7+ messages in thread
From: Geliang Tang @ 2015-05-16 4:16 UTC (permalink / raw)
To: abbotti, hsweeten, gregkh; +Cc: devel, linux-kernel, Geliang Tang
1) Fixed an error found by checkpatch.pl.
ERROR: space required after that ',' (ctx:VxV)
./drivers/ni_mio_common.c:3764
2) Changed "register 0x%x" to "register=0x%x" to keep the consistency
of this file.
3) The kernel version is next-20150515, 4.1.0-rc3.
Signed-off-by: Geliang Tang <geliangtang@163.com>
---
drivers/staging/comedi/drivers/ni_mio_common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/ni_mio_common.c b/drivers/staging/comedi/drivers/ni_mio_common.c
index 9dfd4e6..6cc304a 100644
--- a/drivers/staging/comedi/drivers/ni_mio_common.c
+++ b/drivers/staging/comedi/drivers/ni_mio_common.c
@@ -3761,7 +3761,7 @@ static unsigned int ni_gpct_to_stc_register(struct comedi_device *dev,
if (reg < ARRAY_SIZE(ni_gpct_to_stc_regmap)) {
regmap = &ni_gpct_to_stc_regmap[reg];
} else {
- dev_warn(dev->class_dev,"%s: unhandled register 0x%x\n",
+ dev_warn(dev->class_dev, "%s: unhandled register=0x%x\n",
__func__, reg);
return 0;
}
--
2.3.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] staging: comedi: fix coding style issues
2015-05-16 4:16 [PATCH] staging: comedi: fix coding style issues Geliang Tang
@ 2015-05-18 11:37 ` Ian Abbott
2015-05-20 14:54 ` [PATCH v2] " Geliang Tang
0 siblings, 1 reply; 7+ messages in thread
From: Ian Abbott @ 2015-05-18 11:37 UTC (permalink / raw)
To: Geliang Tang, hsweeten, gregkh; +Cc: devel, linux-kernel
On 16/05/15 05:16, Geliang Tang wrote:
> 1) Fixed an error found by checkpatch.pl.
> ERROR: space required after that ',' (ctx:VxV)
> ./drivers/ni_mio_common.c:3764
> 2) Changed "register 0x%x" to "register=0x%x" to keep the consistency
> of this file.
> 3) The kernel version is next-20150515, 4.1.0-rc3.
You shouldn't mention point 3 in the commit message as it will look a
bit strange when it ends up in the commit log. If you need to mention
that, it should go after the commit message, separated from the patch by
a "---" line like this:
Body of commit message goes here.
Signed off by and Cc lines go here.
---
Additional patch commentary goes here.
---
Actual patch goes here.
Git will ignore the additional commentary when the patch is applied.
>
> Signed-off-by: Geliang Tang <geliangtang@163.com>
> ---
> drivers/staging/comedi/drivers/ni_mio_common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/drivers/ni_mio_common.c b/drivers/staging/comedi/drivers/ni_mio_common.c
> index 9dfd4e6..6cc304a 100644
> --- a/drivers/staging/comedi/drivers/ni_mio_common.c
> +++ b/drivers/staging/comedi/drivers/ni_mio_common.c
> @@ -3761,7 +3761,7 @@ static unsigned int ni_gpct_to_stc_register(struct comedi_device *dev,
> if (reg < ARRAY_SIZE(ni_gpct_to_stc_regmap)) {
> regmap = &ni_gpct_to_stc_regmap[reg];
> } else {
> - dev_warn(dev->class_dev,"%s: unhandled register 0x%x\n",
> + dev_warn(dev->class_dev, "%s: unhandled register=0x%x\n",
> __func__, reg);
> return 0;
> }
>
Apart from that niggle, the patch looks good!
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2] staging: comedi: fix coding style issues
2015-05-18 11:37 ` Ian Abbott
@ 2015-05-20 14:54 ` Geliang Tang
2015-05-24 20:11 ` Greg KH
0 siblings, 1 reply; 7+ messages in thread
From: Geliang Tang @ 2015-05-20 14:54 UTC (permalink / raw)
To: Ian Abbott, hsweeten, gregkh; +Cc: devel, linux-kernel, geliangtang
[-- Attachment #1: Type: text/plain, Size: 2009 bytes --]
On Mon, May 18, 2015 at 12:37:09PM +0100, Ian Abbott wrote:
> On 16/05/15 05:16, Geliang Tang wrote:
> >1) Fixed an error found by checkpatch.pl.
> > ERROR: space required after that ',' (ctx:VxV)
> > ./drivers/ni_mio_common.c:3764
> >2) Changed "register 0x%x" to "register=0x%x" to keep the consistency
> > of this file.
> >3) The kernel version is next-20150515, 4.1.0-rc3.
>
> You shouldn't mention point 3 in the commit message as it will look a bit
> strange when it ends up in the commit log. If you need to mention that, it
> should go after the commit message, separated from the patch by a "---" line
> like this:
>
> Body of commit message goes here.
>
> Signed off by and Cc lines go here.
> ---
> Additional patch commentary goes here.
> ---
> Actual patch goes here.
>
> Git will ignore the additional commentary when the patch is applied.
>
> >
> >Signed-off-by: Geliang Tang <geliangtang@163.com>
> >---
> > drivers/staging/comedi/drivers/ni_mio_common.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/drivers/staging/comedi/drivers/ni_mio_common.c b/drivers/staging/comedi/drivers/ni_mio_common.c
> >index 9dfd4e6..6cc304a 100644
> >--- a/drivers/staging/comedi/drivers/ni_mio_common.c
> >+++ b/drivers/staging/comedi/drivers/ni_mio_common.c
> >@@ -3761,7 +3761,7 @@ static unsigned int ni_gpct_to_stc_register(struct comedi_device *dev,
> > if (reg < ARRAY_SIZE(ni_gpct_to_stc_regmap)) {
> > regmap = &ni_gpct_to_stc_regmap[reg];
> > } else {
> >- dev_warn(dev->class_dev,"%s: unhandled register 0x%x\n",
> >+ dev_warn(dev->class_dev, "%s: unhandled register=0x%x\n",
> > __func__, reg);
> > return 0;
> > }
> >
>
> Apart from that niggle, the patch looks good!
>
> Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
>
> --
> -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
> -=( Web: http://www.mev.co.uk/ )=-
Thank you for your review. I revised the patch as you suggested.
Here it is.
[-- Attachment #2: 0001-staging-comedi-fix-coding-style-issues.patch --]
[-- Type: text/plain, Size: 1309 bytes --]
>From d864f6af18a44031a241e10e64d98f9e6b8c0660 Mon Sep 17 00:00:00 2001
From: Geliang Tang <geliangtang@163.com>
Date: Wed, 20 May 2015 14:26:13 +0000
Subject: [PATCH v2] staging: comedi: fix coding style issues
1) Fixed an error found by checkpatch.pl.
ERROR: space required after that ',' (ctx:VxV)
./drivers/ni_mio_common.c:3764
2) Changed "register 0x%x" to "register=0x%x" to keep the consistency
of this file.
Signed-off-by: Geliang Tang <geliangtang@163.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
---
Changes in v2:
- remove the kernel version in the commit message.
---
drivers/staging/comedi/drivers/ni_mio_common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/ni_mio_common.c b/drivers/staging/comedi/drivers/ni_mio_common.c
index 9dfd4e6..6cc304a 100644
--- a/drivers/staging/comedi/drivers/ni_mio_common.c
+++ b/drivers/staging/comedi/drivers/ni_mio_common.c
@@ -3761,7 +3761,7 @@ static unsigned int ni_gpct_to_stc_register(struct comedi_device *dev,
if (reg < ARRAY_SIZE(ni_gpct_to_stc_regmap)) {
regmap = &ni_gpct_to_stc_regmap[reg];
} else {
- dev_warn(dev->class_dev,"%s: unhandled register 0x%x\n",
+ dev_warn(dev->class_dev, "%s: unhandled register=0x%x\n",
__func__, reg);
return 0;
}
--
2.3.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2] staging: comedi: fix coding style issues
2015-05-20 14:54 ` [PATCH v2] " Geliang Tang
@ 2015-05-24 20:11 ` Greg KH
2015-05-25 14:20 ` [PATCH v3 0/2] " Geliang Tang
0 siblings, 1 reply; 7+ messages in thread
From: Greg KH @ 2015-05-24 20:11 UTC (permalink / raw)
To: Geliang Tang; +Cc: Ian Abbott, hsweeten, devel, linux-kernel
On Wed, May 20, 2015 at 02:54:16PM +0000, Geliang Tang wrote:
> On Mon, May 18, 2015 at 12:37:09PM +0100, Ian Abbott wrote:
> > On 16/05/15 05:16, Geliang Tang wrote:
> > >1) Fixed an error found by checkpatch.pl.
> > > ERROR: space required after that ',' (ctx:VxV)
> > > ./drivers/ni_mio_common.c:3764
> > >2) Changed "register 0x%x" to "register=0x%x" to keep the consistency
> > > of this file.
> > >3) The kernel version is next-20150515, 4.1.0-rc3.
> >
> > You shouldn't mention point 3 in the commit message as it will look a bit
> > strange when it ends up in the commit log. If you need to mention that, it
> > should go after the commit message, separated from the patch by a "---" line
> > like this:
> >
> > Body of commit message goes here.
> >
> > Signed off by and Cc lines go here.
> > ---
> > Additional patch commentary goes here.
> > ---
> > Actual patch goes here.
> >
> > Git will ignore the additional commentary when the patch is applied.
> >
> > >
> > >Signed-off-by: Geliang Tang <geliangtang@163.com>
> > >---
> > > drivers/staging/comedi/drivers/ni_mio_common.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > >diff --git a/drivers/staging/comedi/drivers/ni_mio_common.c b/drivers/staging/comedi/drivers/ni_mio_common.c
> > >index 9dfd4e6..6cc304a 100644
> > >--- a/drivers/staging/comedi/drivers/ni_mio_common.c
> > >+++ b/drivers/staging/comedi/drivers/ni_mio_common.c
> > >@@ -3761,7 +3761,7 @@ static unsigned int ni_gpct_to_stc_register(struct comedi_device *dev,
> > > if (reg < ARRAY_SIZE(ni_gpct_to_stc_regmap)) {
> > > regmap = &ni_gpct_to_stc_regmap[reg];
> > > } else {
> > >- dev_warn(dev->class_dev,"%s: unhandled register 0x%x\n",
> > >+ dev_warn(dev->class_dev, "%s: unhandled register=0x%x\n",
> > > __func__, reg);
> > > return 0;
> > > }
> > >
> >
> > Apart from that niggle, the patch looks good!
> >
> > Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
> >
> > --
> > -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
> > -=( Web: http://www.mev.co.uk/ )=-
>
> Thank you for your review. I revised the patch as you suggested.
> Here it is.
> >From d864f6af18a44031a241e10e64d98f9e6b8c0660 Mon Sep 17 00:00:00 2001
> From: Geliang Tang <geliangtang@163.com>
> Date: Wed, 20 May 2015 14:26:13 +0000
> Subject: [PATCH v2] staging: comedi: fix coding style issues
>
> 1) Fixed an error found by checkpatch.pl.
> ERROR: space required after that ',' (ctx:VxV)
> ./drivers/ni_mio_common.c:3764
> 2) Changed "register 0x%x" to "register=0x%x" to keep the consistency
> of this file.
That's multiple things in one patch :(
Also, this is an attachment, which I can't apply, please resend it as a
proper email.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v3 0/2] staging: comedi: fix coding style issues
2015-05-24 20:11 ` Greg KH
@ 2015-05-25 14:20 ` Geliang Tang
2015-05-25 14:20 ` [PATCH v3 1/2] staging: comedi: fix checkpatch error Geliang Tang
0 siblings, 1 reply; 7+ messages in thread
From: Geliang Tang @ 2015-05-25 14:20 UTC (permalink / raw)
To: Greg KH; +Cc: Geliang Tang, Ian Abbott, hsweeten, devel, linux-kernel
On Sun, May 24, 2015 at 01:11:08PM -0700, Greg KH wrote:
> That's multiple things in one patch :(
>
> Also, this is an attachment, which I can't apply, please resend it as a
> proper email.
Thanks for your reply. I split it into two patches, as you suggested.
Here are them.
---
Changes in v3:
- split it into two patches.
Changes in v2:
- remove the kernel version in the commit message.
---
Geliang Tang (2):
staging: comedi: fix checkpatch error
staging: comedi: keep the consistency
drivers/staging/comedi/drivers/ni_mio_common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.3.4
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v3 1/2] staging: comedi: fix checkpatch error
2015-05-25 14:20 ` [PATCH v3 0/2] " Geliang Tang
@ 2015-05-25 14:20 ` Geliang Tang
2015-05-25 14:20 ` [PATCH v3 2/2] staging: comedi: keep the consistency Geliang Tang
0 siblings, 1 reply; 7+ messages in thread
From: Geliang Tang @ 2015-05-25 14:20 UTC (permalink / raw)
To: Greg KH; +Cc: Geliang Tang, Ian Abbott, hsweeten, devel, linux-kernel
Fixed an error found by checkpatch.pl.
ERROR: space required after that ',' (ctx:VxV)
./drivers/ni_mio_common.c:3764
Signed-off-by: Geliang Tang <geliangtang@163.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
---
drivers/staging/comedi/drivers/ni_mio_common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/ni_mio_common.c b/drivers/staging/comedi/drivers/ni_mio_common.c
index 9dfd4e6..f01ef89 100644
--- a/drivers/staging/comedi/drivers/ni_mio_common.c
+++ b/drivers/staging/comedi/drivers/ni_mio_common.c
@@ -3761,7 +3761,7 @@ static unsigned int ni_gpct_to_stc_register(struct comedi_device *dev,
if (reg < ARRAY_SIZE(ni_gpct_to_stc_regmap)) {
regmap = &ni_gpct_to_stc_regmap[reg];
} else {
- dev_warn(dev->class_dev,"%s: unhandled register 0x%x\n",
+ dev_warn(dev->class_dev, "%s: unhandled register 0x%x\n",
__func__, reg);
return 0;
}
--
2.3.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v3 2/2] staging: comedi: keep the consistency
2015-05-25 14:20 ` [PATCH v3 1/2] staging: comedi: fix checkpatch error Geliang Tang
@ 2015-05-25 14:20 ` Geliang Tang
0 siblings, 0 replies; 7+ messages in thread
From: Geliang Tang @ 2015-05-25 14:20 UTC (permalink / raw)
To: Greg KH; +Cc: Geliang Tang, Ian Abbott, hsweeten, devel, linux-kernel
Changed "register 0x%x" to "register=0x%x" to keep the consistency
of this file.
Signed-off-by: Geliang Tang <geliangtang@163.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
---
drivers/staging/comedi/drivers/ni_mio_common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/ni_mio_common.c b/drivers/staging/comedi/drivers/ni_mio_common.c
index f01ef89..6cc304a 100644
--- a/drivers/staging/comedi/drivers/ni_mio_common.c
+++ b/drivers/staging/comedi/drivers/ni_mio_common.c
@@ -3761,7 +3761,7 @@ static unsigned int ni_gpct_to_stc_register(struct comedi_device *dev,
if (reg < ARRAY_SIZE(ni_gpct_to_stc_regmap)) {
regmap = &ni_gpct_to_stc_regmap[reg];
} else {
- dev_warn(dev->class_dev, "%s: unhandled register 0x%x\n",
+ dev_warn(dev->class_dev, "%s: unhandled register=0x%x\n",
__func__, reg);
return 0;
}
--
2.3.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-05-25 14:22 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-16 4:16 [PATCH] staging: comedi: fix coding style issues Geliang Tang
2015-05-18 11:37 ` Ian Abbott
2015-05-20 14:54 ` [PATCH v2] " Geliang Tang
2015-05-24 20:11 ` Greg KH
2015-05-25 14:20 ` [PATCH v3 0/2] " Geliang Tang
2015-05-25 14:20 ` [PATCH v3 1/2] staging: comedi: fix checkpatch error Geliang Tang
2015-05-25 14:20 ` [PATCH v3 2/2] staging: comedi: keep the consistency Geliang Tang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).