[EDT][PATCH 1/1] dma/pl330.c : Initialize pl330 pointer after NULL check of pch pointer

[EDT][PATCH 1/1] dma/pl330.c : Initialize pl330 pointer after NULL check of pch pointer

[Maninder Singh]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=windows-1252, Size: 1062 bytes --]

 EP-AA9D1F29B02341529D96C06444D8471D

Hi,
Subject: [PATCH 1/1] dma/pl330.c : Initialize pl330 pointer after NULL check of pch pointer

Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
Reviewed-By: Vaneet Narang <v.narang@samsung.com>
---
 drivers/dma/pl330.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
index a7d9d30..7e27144 100644
--- a/drivers/dma/pl330.c
+++ b/drivers/dma/pl330.c
@@ -2581,12 +2581,14 @@ pl330_prep_dma_memcpy(struct dma_chan *chan, dma_addr_t dst,
 {
 	struct dma_pl330_desc *desc;
 	struct dma_pl330_chan *pch = to_pchan(chan);
-	struct pl330_dmac *pl330 = pch->dmac;
+	struct pl330_dmac *pl330;
 	int burst;
 
 	if (unlikely(!pch || !len))
 		return NULL;
 
+	pl330 = pch->dmac;
+
 	desc = __pl330_prep_dma_memcpy(pch, dst, src, len);
 	if (!desc)
 		return NULL;
-- 
1.7.1

Thanks 
Maninder Singhÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

Re: [EDT][PATCH 1/1] dma/pl330.c : Initialize pl330 pointer after NULL check of pch pointer

[Vinod Koul]

On Tue, May 19, 2015 at 05:00:27AM +0000, Maninder Singh wrote:
>  EP-AA9D1F29B02341529D96C06444D8471D
Whats this, please sned patch ina proper format, git format-patch is your
friend, use it

> 
> Hi,
> Subject: [PATCH 1/1] dma/pl330.c : Initialize pl330 pointer after NULL check of pch pointer
patch title doesn't match expectations, use the right subsystem name, and
also please explain why yoy are doing this
> 
> Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
> Reviewed-By: Vaneet Narang <v.narang@samsung.com>
> ---
>  drivers/dma/pl330.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
> index a7d9d30..7e27144 100644
> --- a/drivers/dma/pl330.c
> +++ b/drivers/dma/pl330.c
> @@ -2581,12 +2581,14 @@ pl330_prep_dma_memcpy(struct dma_chan *chan, dma_addr_t dst,
>  {
>  	struct dma_pl330_desc *desc;
>  	struct dma_pl330_chan *pch = to_pchan(chan);
> -	struct pl330_dmac *pl330 = pch->dmac;
> +	struct pl330_dmac *pl330;
>  	int burst;
>  
>  	if (unlikely(!pch || !len))
>  		return NULL;
>  
> +	pl330 = pch->dmac;
> +
>  	desc = __pl330_prep_dma_memcpy(pch, dst, src, len);
>  	if (!desc)
>  		return NULL;
> -- 
> 1.7.1
> 
> Thanks 
> Maninder Singh\x13¢éì¹»\x1c®&Þ~º&¶\x18¬–+-±éݶ\x17¥Šw®žË›±ÊâmçfiéàŠw¢žØ^n‡r¡ö¦zË\x1a?ëh™¨è­Ú&¢ø\x1e®G«?éh®\x03(­éšŽŠÝ¢j"?ú\x1a¶^[m§ÿï?êäz¹Þ–Šàþf£¢·hšˆ§~ˆmš
Nice signature!

-- 
~Vinod

Re: [EDT][PATCH 1/1] dma/pl330.c : Initialize pl330 pointer after NULL check of pch pointer

[Maninder Singh]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=windows-1252, Size: 2429 bytes --]

EP-AA9D1F29B02341529D96C06444D8471D
Hi Vinod

>On Tue, May 19, 2015 at 05:00:27AM +0000, Maninder Singh wrote:
>>  EP-AA9D1F29B02341529D96C06444D8471D
>Whats this, please sned patch ina proper format, git format-patch is your
>friend, use it
>

This is auto generated no. from editor, so please ignore it, and i am resubmitting the patch, thanks for your feedback.

>> 
>> Hi,
>> Subject: [PATCH 1/1] dma/pl330.c : Initialize pl330 pointer after NULL check of pch pointer
>patch title doesn't match expectations, use the right subsystem name, and
>also please explain why yoy are doing this

Ok according to comments resubmitting . Please check new patch if it is appropriate. because this patch is also generated by git,
But i think editor does some malfunctioning.

>> 
>> Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
>> Reviewed-By: Vaneet Narang <v.narang@samsung.com>
>> ---
>>  drivers/dma/pl330.c |    4 +++-
---cut---
>> Thanks 
>> Maninder Singh
>Nice signature!
>
>-- 
>~Vinod

>From 76a6ef435065c10a0476038e8a08016878488dcb Mon Sep 17 00:00:00 2001
From: Maninder Singh <maninder1.s@samsung.com>
Date: Mon, 18 May 2015 17:53:11 +0530
Subject: [PATCH 1/1] dmaengine: pl330: Initialize pl330 for pl330_prep_dma_memcpy after NULL check of pch

Currently pch pointer is already dereferenced before NULL check and thus we are getting below warning:
warn: variable dereferenced before check 'pch'

So initialize struct pl330_dmac *pl330 after NULL check of dma_pl330_chan *pch.

Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
Reviewed-by: Vaneet Narang <v.narang@samsung.com>
---
 drivers/dma/pl330.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
index a7d9d30..7e27144 100644
--- a/drivers/dma/pl330.c
+++ b/drivers/dma/pl330.c
@@ -2581,12 +2581,14 @@ pl330_prep_dma_memcpy(struct dma_chan *chan, dma_addr_t dst,
 {
 	struct dma_pl330_desc *desc;
 	struct dma_pl330_chan *pch = to_pchan(chan);
-	struct pl330_dmac *pl330 = pch->dmac;
+	struct pl330_dmac *pl330;
 	int burst;
 
 	if (unlikely(!pch || !len))
 		return NULL;
 
+	pl330 = pch->dmac;
+
 	desc = __pl330_prep_dma_memcpy(pch, dst, src, len);
 	if (!desc)
 		return NULL;
-- 
1.7.1

Thanks
Maninder
............
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

Re: [EDT][PATCH 1/1] dma/pl330.c : Initialize pl330 pointer after NULL check of pch pointer

[Vinod Koul]

On Fri, May 22, 2015 at 03:19:00AM +0000, Maninder Singh wrote:
> EP-AA9D1F29B02341529D96C06444D8471D
> Hi Vinod
> 
> >On Tue, May 19, 2015 at 05:00:27AM +0000, Maninder Singh wrote:
> >>  EP-AA9D1F29B02341529D96C06444D8471D
> >Whats this, please sned patch ina proper format, git format-patch is your
> >friend, use it
> >
> 
> This is auto generated no. from editor, so please ignore it, and i am resubmitting the patch, thanks for your feedback.
> 
> >> 
> >> Hi,
> >> Subject: [PATCH 1/1] dma/pl330.c : Initialize pl330 pointer after NULL check of pch pointer
> >patch title doesn't match expectations, use the right subsystem name, and
> >also please explain why yoy are doing this
> 
> Ok according to comments resubmitting . Please check new patch if it is appropriate. because this patch is also generated by git,
> But i think editor does some malfunctioning.
Hint here is NOT to use editor to send patches, git send-email is your
friend. Also do consider wrapping your lines appropriately

Below looks much better, but the mailer has screwed it up and am unable to
apply, so please resend with git send-mail.

Thanks
-- 
~Vinod 

> 
> >> 
> >> Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
> >> Reviewed-By: Vaneet Narang <v.narang@samsung.com>
> >> ---
> >>  drivers/dma/pl330.c |    4 +++-
> ---cut---
> >> Thanks 
> >> Maninder Singh
> >Nice signature!
> >
> >-- 
> >~Vinod
> 
> From 76a6ef435065c10a0476038e8a08016878488dcb Mon Sep 17 00:00:00 2001
> From: Maninder Singh <maninder1.s@samsung.com>
> Date: Mon, 18 May 2015 17:53:11 +0530
> Subject: [PATCH 1/1] dmaengine: pl330: Initialize pl330 for pl330_prep_dma_memcpy after NULL check of pch
> 
> Currently pch pointer is already dereferenced before NULL check and thus we are getting below warning:
> warn: variable dereferenced before check 'pch'
> 
> So initialize struct pl330_dmac *pl330 after NULL check of dma_pl330_chan *pch.
> 
> Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
> Reviewed-by: Vaneet Narang <v.narang@samsung.com>
> ---
>  drivers/dma/pl330.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
> index a7d9d30..7e27144 100644
> --- a/drivers/dma/pl330.c
> +++ b/drivers/dma/pl330.c
> @@ -2581,12 +2581,14 @@ pl330_prep_dma_memcpy(struct dma_chan *chan, dma_addr_t dst,
>  {
>  	struct dma_pl330_desc *desc;
>  	struct dma_pl330_chan *pch = to_pchan(chan);
> -	struct pl330_dmac *pl330 = pch->dmac;
> +	struct pl330_dmac *pl330;
>  	int burst;
>  
>  	if (unlikely(!pch || !len))
>  		return NULL;
>  
> +	pl330 = pch->dmac;
> +
>  	desc = __pl330_prep_dma_memcpy(pch, dst, src, len);
>  	if (!desc)
>  		return NULL;
> -- 
> 1.7.1
> 
> Thanks
> Maninder
> ............

--