* [PATCH] pinctrl: zynq: change error code for pinctrl_register failure
@ 2015-05-26 4:18 Masahiro Yamada
2015-05-26 8:12 ` Arnd Bergmann
0 siblings, 1 reply; 6+ messages in thread
From: Masahiro Yamada @ 2015-05-26 4:18 UTC (permalink / raw)
To: linux-gpio
Cc: Masahiro Yamada, Sören Brinkmann, Michal Simek,
Linus Walleij, linux-kernel, linux-arm-kernel
pinctrl_register() could fail for memory unrelated errors.
Returning -EINVAL (or -ENODEV) seems more suitable for here.
At least, the other pinctrl drivers do so.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
drivers/pinctrl/pinctrl-zynq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/pinctrl-zynq.c b/drivers/pinctrl/pinctrl-zynq.c
index 04748a4..0ff653c 100644
--- a/drivers/pinctrl/pinctrl-zynq.c
+++ b/drivers/pinctrl/pinctrl-zynq.c
@@ -1141,7 +1141,7 @@ static int zynq_pinctrl_probe(struct platform_device *pdev)
pctrl->pctrl = pinctrl_register(&zynq_desc, &pdev->dev, pctrl);
if (!pctrl->pctrl)
- return -ENOMEM;
+ return -EINVAL;
platform_set_drvdata(pdev, pctrl);
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] pinctrl: zynq: change error code for pinctrl_register failure
2015-05-26 4:18 [PATCH] pinctrl: zynq: change error code for pinctrl_register failure Masahiro Yamada
@ 2015-05-26 8:12 ` Arnd Bergmann
2015-05-26 8:20 ` Masahiro Yamada
2015-05-26 18:37 ` Sören Brinkmann
0 siblings, 2 replies; 6+ messages in thread
From: Arnd Bergmann @ 2015-05-26 8:12 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Masahiro Yamada, linux-gpio, Linus Walleij, Michal Simek,
linux-kernel, Sören Brinkmann
On Tuesday 26 May 2015 13:18:29 Masahiro Yamada wrote:
> diff --git a/drivers/pinctrl/pinctrl-zynq.c b/drivers/pinctrl/pinctrl-zynq.c
> index 04748a4..0ff653c 100644
> --- a/drivers/pinctrl/pinctrl-zynq.c
> +++ b/drivers/pinctrl/pinctrl-zynq.c
> @@ -1141,7 +1141,7 @@ static int zynq_pinctrl_probe(struct platform_device *pdev)
>
> pctrl->pctrl = pinctrl_register(&zynq_desc, &pdev->dev, pctrl);
> if (!pctrl->pctrl)
> - return -ENOMEM;
> + return -EINVAL;
>
> platform_set_drvdata(pdev, pctrl);
>
>
One choice seems as bad as the other to me ;-)
Could we add a pinctrl_register_reason() variant that returns a meaningful
error code as ERR_PTR?
Arnd
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] pinctrl: zynq: change error code for pinctrl_register failure
2015-05-26 8:12 ` Arnd Bergmann
@ 2015-05-26 8:20 ` Masahiro Yamada
2015-05-26 18:37 ` Sören Brinkmann
1 sibling, 0 replies; 6+ messages in thread
From: Masahiro Yamada @ 2015-05-26 8:20 UTC (permalink / raw)
To: Arnd Bergmann
Cc: linux-arm-kernel, linux-gpio, Linus Walleij, Michal Simek,
Linux Kernel Mailing List, Sören Brinkmann
Hi Arnd,
2015-05-26 17:12 GMT+09:00 Arnd Bergmann <arnd@arndb.de>:
> On Tuesday 26 May 2015 13:18:29 Masahiro Yamada wrote:
>> diff --git a/drivers/pinctrl/pinctrl-zynq.c b/drivers/pinctrl/pinctrl-zynq.c
>> index 04748a4..0ff653c 100644
>> --- a/drivers/pinctrl/pinctrl-zynq.c
>> +++ b/drivers/pinctrl/pinctrl-zynq.c
>> @@ -1141,7 +1141,7 @@ static int zynq_pinctrl_probe(struct platform_device *pdev)
>>
>> pctrl->pctrl = pinctrl_register(&zynq_desc, &pdev->dev, pctrl);
>> if (!pctrl->pctrl)
>> - return -ENOMEM;
>> + return -EINVAL;
>>
>> platform_set_drvdata(pdev, pctrl);
>>
>>
>
> One choice seems as bad as the other to me ;-)
>
> Could we add a pinctrl_register_reason() variant that returns a meaningful
> error code as ERR_PTR?
I also thought of it.
I was wondering why pinctrl_register() did not return ERR_PTR.
Can we migrate to ERR_PTR in the long run?
[1] Add pinctrl_register_reason()
[2] Replace pinctrl_register() in each driver with
pinctrl_register_reason() one by one
[3] Eventually, pinctrl_register will disappear
[4] Rename pinctrl_register_reason() into pinctrl_register()
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] pinctrl: zynq: change error code for pinctrl_register failure
2015-05-26 8:12 ` Arnd Bergmann
2015-05-26 8:20 ` Masahiro Yamada
@ 2015-05-26 18:37 ` Sören Brinkmann
2015-05-27 1:18 ` Masahiro Yamada
2015-06-01 15:00 ` Linus Walleij
1 sibling, 2 replies; 6+ messages in thread
From: Sören Brinkmann @ 2015-05-26 18:37 UTC (permalink / raw)
To: Arnd Bergmann
Cc: linux-arm-kernel, Masahiro Yamada, linux-gpio, Linus Walleij,
Michal Simek, linux-kernel
On Tue, 2015-05-26 at 10:12AM +0200, Arnd Bergmann wrote:
> On Tuesday 26 May 2015 13:18:29 Masahiro Yamada wrote:
> > diff --git a/drivers/pinctrl/pinctrl-zynq.c b/drivers/pinctrl/pinctrl-zynq.c
> > index 04748a4..0ff653c 100644
> > --- a/drivers/pinctrl/pinctrl-zynq.c
> > +++ b/drivers/pinctrl/pinctrl-zynq.c
> > @@ -1141,7 +1141,7 @@ static int zynq_pinctrl_probe(struct platform_device *pdev)
> >
> > pctrl->pctrl = pinctrl_register(&zynq_desc, &pdev->dev, pctrl);
> > if (!pctrl->pctrl)
> > - return -ENOMEM;
> > + return -EINVAL;
> >
> > platform_set_drvdata(pdev, pctrl);
> >
> >
>
> One choice seems as bad as the other to me ;-)
>
> Could we add a pinctrl_register_reason() variant that returns a meaningful
> error code as ERR_PTR?
I agree with Arnd. As long as we don't get a precise error code we can
just keep the current one.
Sören
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] pinctrl: zynq: change error code for pinctrl_register failure
2015-05-26 18:37 ` Sören Brinkmann
@ 2015-05-27 1:18 ` Masahiro Yamada
2015-06-01 15:00 ` Linus Walleij
1 sibling, 0 replies; 6+ messages in thread
From: Masahiro Yamada @ 2015-05-27 1:18 UTC (permalink / raw)
To: Sören Brinkmann
Cc: Arnd Bergmann, linux-gpio, Linus Walleij,
Linux Kernel Mailing List, Michal Simek, linux-arm-kernel
Hi Sören,
2015-05-27 3:37 GMT+09:00 Sören Brinkmann <soren.brinkmann@xilinx.com>:
> On Tue, 2015-05-26 at 10:12AM +0200, Arnd Bergmann wrote:
>> On Tuesday 26 May 2015 13:18:29 Masahiro Yamada wrote:
>> > diff --git a/drivers/pinctrl/pinctrl-zynq.c b/drivers/pinctrl/pinctrl-zynq.c
>> > index 04748a4..0ff653c 100644
>> > --- a/drivers/pinctrl/pinctrl-zynq.c
>> > +++ b/drivers/pinctrl/pinctrl-zynq.c
>> > @@ -1141,7 +1141,7 @@ static int zynq_pinctrl_probe(struct platform_device *pdev)
>> >
>> > pctrl->pctrl = pinctrl_register(&zynq_desc, &pdev->dev, pctrl);
>> > if (!pctrl->pctrl)
>> > - return -ENOMEM;
>> > + return -EINVAL;
>> >
>> > platform_set_drvdata(pdev, pctrl);
>> >
>> >
>>
>> One choice seems as bad as the other to me ;-)
>>
>> Could we add a pinctrl_register_reason() variant that returns a meaningful
>> error code as ERR_PTR?
>
> I agree with Arnd. As long as we don't get a precise error code we can
> just keep the current one.
OK. Let's not do this way.
I will try pinctrl_register_reason().
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] pinctrl: zynq: change error code for pinctrl_register failure
2015-05-26 18:37 ` Sören Brinkmann
2015-05-27 1:18 ` Masahiro Yamada
@ 2015-06-01 15:00 ` Linus Walleij
1 sibling, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2015-06-01 15:00 UTC (permalink / raw)
To: Sören Brinkmann
Cc: Arnd Bergmann, linux-arm-kernel, Masahiro Yamada, linux-gpio,
Michal Simek, linux-kernel
On Tue, May 26, 2015 at 8:37 PM, Sören Brinkmann
<soren.brinkmann@xilinx.com> wrote:
> On Tue, 2015-05-26 at 10:12AM +0200, Arnd Bergmann wrote:
>> Could we add a pinctrl_register_reason() variant that returns a meaningful
>> error code as ERR_PTR?
>
> I agree with Arnd. As long as we don't get a precise error code we can
> just keep the current one.
pinctrl_register_cause() please.
Cause-and-effect, not "age of reason".
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-06-01 15:01 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-26 4:18 [PATCH] pinctrl: zynq: change error code for pinctrl_register failure Masahiro Yamada
2015-05-26 8:12 ` Arnd Bergmann
2015-05-26 8:20 ` Masahiro Yamada
2015-05-26 18:37 ` Sören Brinkmann
2015-05-27 1:18 ` Masahiro Yamada
2015-06-01 15:00 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).