[PATCH] pvpanic: handle missing _STA correctly

[PATCH] pvpanic: handle missing _STA correctly

[Radim Krčmář]

pvpanic was not properly detected when _STA was missing.

ACPI 6.0 April 2015, 6.3.7 _STA (Status)
  If a device object (including the processor object) does not have an
  _STA object, then OSPM assumes that all of the above bits are set
  (i.e., the device is present, enabled, shown in the UI, and
  functioning).

Not adhering to the specification made pvpanic dormant under QEMU 2.3.

Suggested-by: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
---
 drivers/platform/x86/pvpanic.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/platform/x86/pvpanic.c b/drivers/platform/x86/pvpanic.c
index 073a90a63dbc..7b6860333267 100644
--- a/drivers/platform/x86/pvpanic.c
+++ b/drivers/platform/x86/pvpanic.c
@@ -95,8 +95,7 @@ static int pvpanic_add(struct acpi_device *device)
 	acpi_status status;
 	u64 ret;
 
-	status = acpi_evaluate_integer(device->handle, "_STA", NULL,
-				       &ret);
+	status = acpi_bus_get_status_handle(device->handle, &ret);
 
 	if (ACPI_FAILURE(status) || (ret & 0x0B) != 0x0B)
 		return -ENODEV;
-- 
2.4.2

Re: [PATCH] pvpanic: handle missing _STA correctly

[Igor Mammedov]

On Fri, 29 May 2015 22:18:52 +0200
Radim Krčmář <rkrcmar@redhat.com> wrote:

> pvpanic was not properly detected when _STA was missing.
> 
> ACPI 6.0 April 2015, 6.3.7 _STA (Status)
>   If a device object (including the processor object) does not have an
>   _STA object, then OSPM assumes that all of the above bits are set
>   (i.e., the device is present, enabled, shown in the UI, and
>   functioning).
> 
> Not adhering to the specification made pvpanic dormant under QEMU 2.3.
> 
> Suggested-by: Igor Mammedov <imammedo@redhat.com>
> Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>

> ---
>  drivers/platform/x86/pvpanic.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/platform/x86/pvpanic.c b/drivers/platform/x86/pvpanic.c
> index 073a90a63dbc..7b6860333267 100644
> --- a/drivers/platform/x86/pvpanic.c
> +++ b/drivers/platform/x86/pvpanic.c
> @@ -95,8 +95,7 @@ static int pvpanic_add(struct acpi_device *device)
>  	acpi_status status;
>  	u64 ret;
>  
> -	status = acpi_evaluate_integer(device->handle, "_STA", NULL,
> -				       &ret);
> +	status = acpi_bus_get_status_handle(device->handle, &ret);
>  
>  	if (ACPI_FAILURE(status) || (ret & 0x0B) != 0x0B)
>  		return -ENODEV;

Re: [PATCH] pvpanic: handle missing _STA correctly'

[Darren Hart]

On Mon, Jun 01, 2015 at 09:33:22AM +0200, Igor Mammedov wrote:
> On Fri, 29 May 2015 22:18:52 +0200
> Radim Krčmář <rkrcmar@redhat.com> wrote:
> 
> > pvpanic was not properly detected when _STA was missing.
> > 
> > ACPI 6.0 April 2015, 6.3.7 _STA (Status)
> >   If a device object (including the processor object) does not have an
> >   _STA object, then OSPM assumes that all of the above bits are set
> >   (i.e., the device is present, enabled, shown in the UI, and
> >   functioning).
> > 
> > Not adhering to the specification made pvpanic dormant under QEMU 2.3.
> > 
> > Suggested-by: Igor Mammedov <imammedo@redhat.com>
> > Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
> Reviewed-by: Igor Mammedov <imammedo@redhat.com>

Queued, thanks.

-- 
Darren Hart
Intel Open Source Technology Center