From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: David Decotigny <ddecotig@gmail.com>
Cc: devel@driverdev.osuosl.org, HPDD-discuss@ml01.01.org,
Andreas Dilger <andreas.dilger@intel.com>,
Liang Zhen <liang.zhen@intel.com>, Peng Tao <bergwolf@gmail.com>,
Doug Oucharek <doug.s.oucharek@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Oleg Drokin <oleg.drokin@intel.com>,
Amir Shehata <amir.shehata@intel.com>,
Isaac Huang <he.huang@intel.com>
Subject: Re: [PATCH v1] staging: lustre: libcfs: add __user annotation in libcfs_ioctl_data
Date: Tue, 2 Jun 2015 10:31:15 +0900 [thread overview]
Message-ID: <20150602013115.GB23940@kroah.com> (raw)
In-Reply-To: <CAG88wWYSZvS+NByVH3APY-nyF+Di6q_EJPMMXZg9yY4f8rVGHw@mail.gmail.com>
On Mon, Jun 01, 2015 at 12:21:30PM -0700, David Decotigny wrote:
> Thanks for reviewing.
>
> The 2 struct members were not marked as __user, which this patch does
> here. This was causing warnings with copy from/to user (see commit
> description). This patch also propagates the annotation to the couple
> of functions that are using those members.
Lustre's structures are a total mess of kernel and user pointers and
trying to properly mark them as which they are supposed to be at what
point in time is a very difficult task. People keep trying and get it
wrong, so I suggest just leaving this alone until the developers unwind
the structure mess as that will be necessary for this code to get merged
into the main part of the kernel.
sorry,
greg k-h
next prev parent reply other threads:[~2015-06-02 1:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-26 4:40 [PATCH v1] staging: lustre: libcfs: add __user annotation in libcfs_ioctl_data David Decotigny
2015-05-31 2:27 ` Greg Kroah-Hartman
2015-06-01 19:21 ` David Decotigny
2015-06-02 1:31 ` Greg Kroah-Hartman [this message]
2015-06-02 17:29 ` [HPDD-discuss] " Simmons, James A.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150602013115.GB23940@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=HPDD-discuss@ml01.01.org \
--cc=amir.shehata@intel.com \
--cc=andreas.dilger@intel.com \
--cc=bergwolf@gmail.com \
--cc=ddecotig@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=doug.s.oucharek@intel.com \
--cc=he.huang@intel.com \
--cc=liang.zhen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).