* [PATCH block/for-4.2/writeback] bdi: fix wrong error return value in cgwb_create()
@ 2015-06-04 21:20 Tejun Heo
0 siblings, 0 replies; only message in thread
From: Tejun Heo @ 2015-06-04 21:20 UTC (permalink / raw)
To: Jens Axboe; +Cc: linux-kernel, linux-mm, Dan Carpenter
On wb_congested_get_create() failure, cgwb_create() forgot to set @ret
to -ENOMEM ending up returning 0. Fix it so that it returns -ENOMEM.
Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
---
mm/backing-dev.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/mm/backing-dev.c b/mm/backing-dev.c
index 887d72a8..436bb53 100644
--- a/mm/backing-dev.c
+++ b/mm/backing-dev.c
@@ -554,8 +554,10 @@ static int cgwb_create(struct backing_dev_info *bdi,
goto err_ref_exit;
wb->congested = wb_congested_get_create(bdi, blkcg_css->id, gfp);
- if (!wb->congested)
+ if (!wb->congested) {
+ ret = -ENOMEM;
goto err_fprop_exit;
+ }
wb->memcg_css = memcg_css;
wb->blkcg_css = blkcg_css;
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2015-06-04 21:20 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-04 21:20 [PATCH block/for-4.2/writeback] bdi: fix wrong error return value in cgwb_create() Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).