* [PATCH bp] EDAC, mce_amd_inj: inj_type can be static
2015-06-05 11:24 [bp:for-next 15/22] drivers/edac/mce_amd_inj.c:47:21: sparse: symbol 'inj_type' was not declared. Should it be static? kbuild test robot
@ 2015-06-05 11:24 ` kbuild test robot
2015-06-05 13:33 ` Borislav Petkov
0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2015-06-05 11:24 UTC (permalink / raw)
To: Aravind Gopalakrishnan
Cc: kbuild-all, Borislav Petkov, Doug Thompson,
Mauro Carvalho Chehab, linux-media, linux-edac, linux-kernel
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
mce_amd_inj.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/edac/mce_amd_inj.c b/drivers/edac/mce_amd_inj.c
index 2a0c829..46a6b0e 100644
--- a/drivers/edac/mce_amd_inj.c
+++ b/drivers/edac/mce_amd_inj.c
@@ -44,7 +44,7 @@ static const char * const flags_options[] = {
};
/* Set default injection to SW_INJ */
-enum injection_type inj_type = SW_INJ;
+static enum injection_type inj_type = SW_INJ;
#define MCE_INJECT_SET(reg) \
static int inj_##reg##_set(void *data, u64 val) \
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [bp:for-next 15/22] drivers/edac/mce_amd_inj.c:47:21: sparse: symbol 'inj_type' was not declared. Should it be static?
@ 2015-06-05 11:24 kbuild test robot
2015-06-05 11:24 ` [PATCH bp] EDAC, mce_amd_inj: inj_type can be static kbuild test robot
0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2015-06-05 11:24 UTC (permalink / raw)
To: Aravind Gopalakrishnan
Cc: kbuild-all, Borislav Petkov, Doug Thompson,
Mauro Carvalho Chehab, linux-media, linux-edac, linux-kernel
tree: git://git.kernel.org/pub/scm/linux/kernel/git/bp/bp for-next
head: 6db4e6b99ba0dad4e42612a546a99ccdbd766561
commit: 0451d14d05618e5fcbdc5017a30e3d609ddc8229 [15/22] EDAC, mce_amd_inj: Modify flags attribute to use string arguments
reproduce:
# apt-get install sparse
git checkout 0451d14d05618e5fcbdc5017a30e3d609ddc8229
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by >>)
>> drivers/edac/mce_amd_inj.c:47:21: sparse: symbol 'inj_type' was not declared. Should it be static?
drivers/edac/mce_amd_inj.c:320:1: sparse: symbol '__UNIQUE_ID_author__COUNTER__' has multiple initializers (originally initialized at drivers/edac/mce_amd_inj.c:319)
Please review and possibly fold the followup patch.
---
0-DAY kernel test infrastructure Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH bp] EDAC, mce_amd_inj: inj_type can be static
2015-06-05 11:24 ` [PATCH bp] EDAC, mce_amd_inj: inj_type can be static kbuild test robot
@ 2015-06-05 13:33 ` Borislav Petkov
0 siblings, 0 replies; 3+ messages in thread
From: Borislav Petkov @ 2015-06-05 13:33 UTC (permalink / raw)
To: kbuild test robot
Cc: Aravind Gopalakrishnan, kbuild-all, Borislav Petkov,
Doug Thompson, Mauro Carvalho Chehab, linux-media, linux-edac,
linux-kernel
On Fri, Jun 05, 2015 at 07:24:26PM +0800, kbuild test robot wrote:
>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
> mce_amd_inj.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/edac/mce_amd_inj.c b/drivers/edac/mce_amd_inj.c
> index 2a0c829..46a6b0e 100644
> --- a/drivers/edac/mce_amd_inj.c
> +++ b/drivers/edac/mce_amd_inj.c
> @@ -44,7 +44,7 @@ static const char * const flags_options[] = {
> };
>
> /* Set default injection to SW_INJ */
> -enum injection_type inj_type = SW_INJ;
> +static enum injection_type inj_type = SW_INJ;
>
> #define MCE_INJECT_SET(reg) \
> static int inj_##reg##_set(void *data, u64 val) \
Thanks kbuild test robot, applied!
:-D
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-06-05 13:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-05 11:24 [bp:for-next 15/22] drivers/edac/mce_amd_inj.c:47:21: sparse: symbol 'inj_type' was not declared. Should it be static? kbuild test robot
2015-06-05 11:24 ` [PATCH bp] EDAC, mce_amd_inj: inj_type can be static kbuild test robot
2015-06-05 13:33 ` Borislav Petkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).