* [PATCH] Staging: comedi: daqboard2000: fixed whitespace coding style issue
@ 2015-06-05 23:27 Dennis Chen
2015-06-06 5:28 ` Sudip Mukherjee
2015-06-06 14:37 ` Dan Carpenter
0 siblings, 2 replies; 3+ messages in thread
From: Dennis Chen @ 2015-06-05 23:27 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel
>From 843d038eec5ac2c59d3138f19ae52828098c7d50 Mon Sep 17 00:00:00 2001
From: Dennis Chen <barracks510@gmail.com>
Date: Fri, 5 Jun 2015 15:42:37 -0700
Subject: [PATCH] Staging: comedi: daqboard2000: fixed whitespace coding style
issue
Fixed whitespace coding style issue.
Signed-off-by: Dennis Chen <barracks510@gmail.com>
---
drivers/staging/comedi/drivers/daqboard2000.c | 112 +++++++++++++-------------
1 file changed, 56 insertions(+), 56 deletions(-)
diff --git a/drivers/staging/comedi/drivers/daqboard2000.c b/drivers/staging/comedi/drivers/daqboard2000.c
index f97d18d..b2c6bc6 100644
--- a/drivers/staging/comedi/drivers/daqboard2000.c
+++ b/drivers/staging/comedi/drivers/daqboard2000.c
@@ -32,72 +32,72 @@ http://www.comedi.org in the comedi_nonfree_firmware tarball.
Configuration options: not applicable, uses PCI auto config
*/
/*
- This card was obviously never intended to leave the Windows world,
- since it lacked all kind of hardware documentation (except for cable
- pinouts, plug and pray has something to catch up with yet).
-
- With some help from our swedish distributor, we got the Windows sourcecode
- for the card, and here are the findings so far.
-
- 1. A good document that describes the PCI interface chip is 9080db-106.pdf
- available from http://www.plxtech.com/products/io/pci9080
-
- 2. The initialization done so far is:
- a. program the FPGA (windows code sans a lot of error messages)
- b.
-
- 3. Analog out seems to work OK with DAC's disabled, if DAC's are enabled,
- you have to output values to all enabled DAC's until result appears, I
- guess that it has something to do with pacer clocks, but the source
- gives me no clues. I'll keep it simple so far.
-
- 4. Analog in.
- Each channel in the scanlist seems to be controlled by four
- control words:
-
- Word0:
- +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
- ! | | | ! | | | ! | | | ! | | | !
- +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
-
- Word1:
- +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
- ! | | | ! | | | ! | | | ! | | | !
- +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
+ This card was obviously never intended to leave the Windows world,
+ since it lacked all kind of hardware documentation (except for cable
+ pinouts, plug and pray has something to catch up with yet).
+
+ With some help from our swedish distributor, we got the Windows
+ sourcecode for the card, and here are the findings so far.
+
+ 1. A good document that describes the PCI interface chip is
+ 9080db-106.pdf available from http://www.plxtech.com/products/io/pci9080
+
+ 2. The initialization done so far is:
+ a. program the FPGA (windows code sans a lot of error messages)
+ b.
+
+ 3. Analog out seems to work OK with DAC's disabled, if DAC's are
+ enabled, you have to output values to all enabled DAC's until result
+ appears, I guess that it has something to do with pacer clocks, but the
+ source gives me no clues. I'll keep it simple so far.
+
+ 4. Analog in.
+ Each channel in the scanlist seems to be controlled by four
+ control words:
+
+ Word0:
+ +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
+ ! | | | ! | | | ! | | | ! | | | !
+ +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
+
+ Word1:
+ +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
+ ! | | | ! | | | ! | | | ! | | | !
+ +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
| | | | | | |
- +------+------+ | | | | +-- Digital input (??)
+ +------+------+ | | | | +-- Digital input (??)
| | | | +---- 10 us settling time
| | | +------ Suspend acquisition (last to scan)
| | +-------- Simultaneous sample and hold
| +---------- Signed data format
+------------------------- Correction offset low
- Word2:
- +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
- ! | | | ! | | | ! | | | ! | | | !
- +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
- | | | | | | | | | |
- +-----+ +--+--+ +++ +++ +--+--+
- | | | | +----- Expansion channel
+ Word2:
+ +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
+ ! | | | ! | | | ! | | | ! | | | !
+ +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
+ | | | | | | | | | |
+ +-----+ +--+--+ +++ +++ +--+--+
+ | | | | +----- Expansion channel
| | | +----------- Expansion gain
- | | +--------------- Channel (low)
+ | | +--------------- Channel (low)
| +--------------------- Correction offset high
+----------------------------- Correction gain low
- Word3:
- +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
- ! | | | ! | | | ! | | | ! | | | !
- +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
- | | | | | | | | |
- +------+------+ | | +-+-+ | | +-- Low bank enable
- | | | | | +---- High bank enable
- | | | | +------ Hi/low select
- | | | +---------- Gain (1,?,2,4,8,16,32,64)
- | | +-------------- differential/single ended
- | +---------------- Unipolar
- +------------------------- Correction gain high
-
- 999. The card seems to have an incredible amount of capabilities, but
- trying to reverse engineer them from the Windows source is beyond my
+ Word3:
+ +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
+ ! | | | ! | | | ! | | | ! | | | !
+ +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
+ | | | | | | | | |
+ +----+--------+ | | +-+-+ | | +-- Low bank enable
+ | | | | | +---- High bank enable
+ | | | | +------ Hi/low select
+ | | | +---------- Gain (1,?,2,4,8,16,32,64)
+ | | +-------------- differential/single ended
+ | +---------------- Unipolar
+ +------------------------- Correction gain high
+
+ 999. The card seems to have an incredible amount of capabilities, but
+ trying to reverse engineer them from the Windows source is beyond my
patience.
*/
--
2.4.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Staging: comedi: daqboard2000: fixed whitespace coding style issue
2015-06-05 23:27 [PATCH] Staging: comedi: daqboard2000: fixed whitespace coding style issue Dennis Chen
@ 2015-06-06 5:28 ` Sudip Mukherjee
2015-06-06 14:37 ` Dan Carpenter
1 sibling, 0 replies; 3+ messages in thread
From: Sudip Mukherjee @ 2015-06-06 5:28 UTC (permalink / raw)
To: Dennis Chen; +Cc: gregkh, devel, linux-kernel
On Fri, Jun 05, 2015 at 04:27:48PM -0700, Dennis Chen wrote:
> From 843d038eec5ac2c59d3138f19ae52828098c7d50 Mon Sep 17 00:00:00 2001
> From: Dennis Chen <barracks510@gmail.com>
> Date: Fri, 5 Jun 2015 15:42:37 -0700
> Subject: [PATCH] Staging: comedi: daqboard2000: fixed whitespace coding style
> issue
>
> Fixed whitespace coding style issue.
this will not apply anymore. The comment has already been fixed by:
12cba5c9df23 ('staging: comedi: daqboard2000: Use preferred comment style')
regards
sudip
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Staging: comedi: daqboard2000: fixed whitespace coding style issue
2015-06-05 23:27 [PATCH] Staging: comedi: daqboard2000: fixed whitespace coding style issue Dennis Chen
2015-06-06 5:28 ` Sudip Mukherjee
@ 2015-06-06 14:37 ` Dan Carpenter
1 sibling, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2015-06-06 14:37 UTC (permalink / raw)
To: Dennis Chen; +Cc: gregkh, devel, linux-kernel
On Fri, Jun 05, 2015 at 04:27:48PM -0700, Dennis Chen wrote:
> >From 843d038eec5ac2c59d3138f19ae52828098c7d50 Mon Sep 17 00:00:00 2001
> From: Dennis Chen <barracks510@gmail.com>
> Date: Fri, 5 Jun 2015 15:42:37 -0700
> Subject: [PATCH] Staging: comedi: daqboard2000: fixed whitespace coding style
> issue
Sudip is right. Also don't include these lines.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-06-06 14:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-05 23:27 [PATCH] Staging: comedi: daqboard2000: fixed whitespace coding style issue Dennis Chen
2015-06-06 5:28 ` Sudip Mukherjee
2015-06-06 14:37 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).