Re: [PATCH 0/3] EDAC: add DDR4 flag, misc improvements

From: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
To: lukasz.anaczkowski@intel.com
Cc: dougthompson@xmission.com, bp@alien8.de,
	linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
	Tony Luck <tony.luck@intel.com>,
	Aristeu Rozanski <aris@redhat.com>
Subject: Re: [PATCH 0/3] EDAC: add DDR4 flag, misc improvements
Date: Tue, 9 Jun 2015 08:54:42 -0300	[thread overview]
Message-ID: <20150609085442.4ce53e78@recife.lan> (raw)
In-Reply-To: <1433850192-9866-1-git-send-email-lukasz.anaczkowski@intel.com>

Hi Lukasz,

Em Tue,  9 Jun 2015 13:43:09 +0200
lukasz.anaczkowski@intel.com escreveu:

> From: Lukasz Anaczkowski <lukasz.anaczkowski@intel.com>
> 
> Series of patches that makes sb_edac more flexible for adding
> support for future platforms.
> 
> Jim Snow (3):
>   EDAC: add DDR4 flag
>   sb_edac: virtualize several hard-coded functions
>   sb_edac: support for duplicate device IDs
> 
>  drivers/edac/sb_edac.c | 95 ++++++++++++++++++++++++++++++++++++++++----------
>  include/linux/edac.h   |  6 ++--
>  2 files changed, 80 insertions(+), 21 deletions(-)

The patches look interesting, but, specially in the case of patch 3/3,
it is hard to review them without the patches that add support for
future platforms that require multi-bus. I can't, for example,
understand, so far, the need of "allow_dups" function parameter for
sbridge_get_all_devices().

So, I'd like to see this patch series together with the patches
adding support for those new "multi-bus" platforms.

Thanks,
Mauro