From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: "Moore, Robert" <robert.moore@intel.com>
Cc: "Zheng, Lv" <lv.zheng@intel.com>,
"Wysocki, Rafael J" <rafael.j.wysocki@intel.com>,
Len Brown <lenb@kernel.org>,
"open list:ACPI COMPONENT AR..." <linux-acpi@vger.kernel.org>,
"open list:ACPI COMPONENT AR..." <devel@acpica.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] acpi: update struct acpi_table_tpm2
Date: Tue, 9 Jun 2015 18:42:30 +0300 [thread overview]
Message-ID: <20150609154230.GA5750@jsakkine-mobl1> (raw)
In-Reply-To: <20150609151919.GA4453@jsakkine-mobl1>
On Tue, Jun 09, 2015 at 06:19:19PM +0300, Jarkko Sakkinen wrote:
> On Tue, Jun 09, 2015 at 02:21:12PM +0000, Moore, Robert wrote:
> > ACPICA usually defines any "related" data structures, just for user
> > convenience.
>
> If you want to keep it, it's fine for me but we still probably use the
> internal structure for it in tpm_crb driver (as tpm_tis uses internal
> structure for CRB).
Let me open this a little bit. Everytime we want to do some small change to
control area (lets say TCG adds some flag) we would have to cycle them
through you.
And the changes are not coupled with ACPI in any possible way. This is
only adds more maintenance burden to you and also to us. This structure
is the main control structure for the CRB driver and will be refined
many times in the future. There is no any kind of use to its fields
outside of the CRB driver.
/Jarkko
next prev parent reply other threads:[~2015-06-09 15:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-08 13:38 [PATCH] acpi: update struct acpi_table_tpm2 Jarkko Sakkinen
2015-06-08 20:52 ` Moore, Robert
2015-06-09 9:17 ` Jarkko Sakkinen
2015-06-09 14:21 ` Moore, Robert
2015-06-09 15:19 ` Jarkko Sakkinen
2015-06-09 15:42 ` Jarkko Sakkinen [this message]
2015-06-09 16:12 ` Moore, Robert
2015-06-09 16:13 ` Jarkko Sakkinen
2015-06-09 16:16 ` Moore, Robert
2015-06-09 16:33 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150609154230.GA5750@jsakkine-mobl1 \
--to=jarkko.sakkinen@linux.intel.com \
--cc=devel@acpica.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lv.zheng@intel.com \
--cc=rafael.j.wysocki@intel.com \
--cc=robert.moore@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).