From: "Moore, Robert" <robert.moore@intel.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: "Zheng, Lv" <lv.zheng@intel.com>,
"Wysocki, Rafael J" <rafael.j.wysocki@intel.com>,
Len Brown <lenb@kernel.org>,
"open list:ACPI COMPONENT AR..." <linux-acpi@vger.kernel.org>,
"open list:ACPI COMPONENT AR..." <devel@acpica.org>,
open list <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] acpi: update struct acpi_table_tpm2
Date: Tue, 9 Jun 2015 14:21:12 +0000 [thread overview]
Message-ID: <94F2FBAB4432B54E8AACC7DFDE6C92E37D2F2BE7@ORSMSX112.amr.corp.intel.com> (raw)
In-Reply-To: <20150609091757.GB4968@jsakkine-mobl1>
ACPICA usually defines any "related" data structures, just for user convenience.
> -----Original Message-----
> From: Jarkko Sakkinen [mailto:jarkko.sakkinen@linux.intel.com]
> Sent: Tuesday, June 09, 2015 2:18 AM
> To: Moore, Robert
> Cc: Zheng, Lv; Wysocki, Rafael J; Len Brown; open list:ACPI COMPONENT
> AR...; open list:ACPI COMPONENT AR...; open list
> Subject: Re: [PATCH] acpi: update struct acpi_table_tpm2
>
> On Mon, Jun 08, 2015 at 08:52:02PM +0000, Moore, Robert wrote:
> > It looks like there is a change to the TCPA table also.
>
> Right. I'll update that too.
>
> I strongly think that the struct acpi_tpm2_control should not be in
> actbl3.h. It is not defined in the TCG ACPI specification. It is defined
> in
>
> http://www.trustedcomputinggroup.org/resources/pc_client_platform_tpm_prof
> ile_ptp_specification
>
> FIFO control structures are internal for to the TPM subsystem and so
> should be CRB control structures (and we have already inside tpm_crb.c).
>
> The structure ended up there probably because it was combined with the
> TPM2 table in that Microsoft specification.
>
> /Jarkko
next prev parent reply other threads:[~2015-06-09 14:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-08 13:38 [PATCH] acpi: update struct acpi_table_tpm2 Jarkko Sakkinen
2015-06-08 20:52 ` Moore, Robert
2015-06-09 9:17 ` Jarkko Sakkinen
2015-06-09 14:21 ` Moore, Robert [this message]
2015-06-09 15:19 ` Jarkko Sakkinen
2015-06-09 15:42 ` Jarkko Sakkinen
2015-06-09 16:12 ` Moore, Robert
2015-06-09 16:13 ` Jarkko Sakkinen
2015-06-09 16:16 ` Moore, Robert
2015-06-09 16:33 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94F2FBAB4432B54E8AACC7DFDE6C92E37D2F2BE7@ORSMSX112.amr.corp.intel.com \
--to=robert.moore@intel.com \
--cc=devel@acpica.org \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lv.zheng@intel.com \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).