linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Christoph Lameter <cl@linux.com>
Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	Minchan Kim <minchan@kernel.org>,
	Pekka Enberg <penberg@kernel.org>,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	Michal Hocko <mhocko@suse.cz>,
	David Rientjes <rientjes@google.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	sergey.senozhatsky.work@gmail.com, Joe Perches <joe@perches.com>
Subject: Re: [RFC][PATCH 0/5] do not dereference NULL pools in pools' destroy() functions
Date: Thu, 11 Jun 2015 10:40:56 -0700	[thread overview]
Message-ID: <20150611104056.5d2122dd.akpm@linux-foundation.org> (raw)
In-Reply-To: <alpine.DEB.2.11.1506111212530.18426@east.gentwo.org>

On Thu, 11 Jun 2015 12:26:11 -0500 (CDT) Christoph Lameter <cl@linux.com> wrote:

> On Tue, 9 Jun 2015, Andrew Morton wrote:
> 
> > > > More than half of the kmem_cache_destroy() callsites are declining that
> > > > value by open-coding the NULL test.  That's reality and we should recognize
> > > > it.
> > >
> > > Well that may just indicate that we need to have a look at those
> > > callsites and the reason there to use a special cache at all.
> >
> > This makes no sense.  Go look at the code.
> > drivers/staging/lustre/lustre/llite/super25.c, for example.  It's all
> > in the basic unwind/recover/exit code.
> 
> That is screwed up code. I'd do that without the checks simply with a
> series of kmem_cache_destroys().

So go and review some of the many other callers which do this.



  reply	other threads:[~2015-06-11 17:38 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-09 12:04 [RFC][PATCH 0/5] do not dereference NULL pools in pools' destroy() functions Sergey Senozhatsky
2015-06-09 12:04 ` [RFC][PATCH 1/5] mm/slab_common: allow NULL cache pointer in kmem_cache_destroy() Sergey Senozhatsky
2015-06-17 23:14   ` David Rientjes
2015-06-17 23:52     ` Sergey Senozhatsky
2015-06-19 15:50       ` Julia Lawall
2015-08-06 14:21         ` Sergey Senozhatsky
2015-08-06 14:27           ` Julia Lawall
2015-08-06 14:29             ` Sergey Senozhatsky
2015-06-20 16:25       ` Julia Lawall
2015-07-16  8:26         ` Sergey Senozhatsky
2015-06-09 12:04 ` [RFC][PATCH 2/5] mm/mempool: allow NULL `pool' pointer in mempool_destroy() Sergey Senozhatsky
2015-06-17 23:21   ` David Rientjes
2015-06-17 23:54     ` Sergey Senozhatsky
2015-06-09 12:04 ` [RFC][PATCH 3/5] mm/dmapool: allow NULL `pool' pointer in dma_pool_destroy() Sergey Senozhatsky
2015-06-17 23:22   ` David Rientjes
2015-06-09 12:04 ` [RFC][PATCH 4/5] mm/zpool: allow NULL `zpool' pointer in zpool_destroy_pool() Sergey Senozhatsky
2015-06-10 20:59   ` Dan Streetman
2015-06-10 23:58     ` Sergey Senozhatsky
2015-06-11  0:48       ` Joe Perches
2015-06-11  0:59         ` Sergey Senozhatsky
2015-06-11  1:01           ` Dan Streetman
2015-06-09 12:04 ` [RFC][PATCH 5/5] mm/zsmalloc: allow NULL `pool' pointer in zs_destroy_pool() Sergey Senozhatsky
2015-06-09 21:25 ` [RFC][PATCH 0/5] do not dereference NULL pools in pools' destroy() functions Andrew Morton
2015-06-10  0:06   ` Joe Perches
2015-06-10  4:39     ` [PATCH] checkpatch: Add some <foo>_destroy functions to NEEDLESS_IF tests Joe Perches
2015-06-10  5:52       ` [PATCH V2] " Joe Perches
2015-06-10 10:18         ` Sergey Senozhatsky
2015-06-11  9:41         ` Julia Lawall
2015-06-11  9:51           ` Sergey Senozhatsky
2015-06-11  9:55             ` Julia Lawall
2015-07-14 23:03         ` Andrew Morton
2015-07-15  0:27           ` Sergey Senozhatsky
2015-06-10  5:46     ` [RFC][PATCH 0/5] do not dereference NULL pools in pools' destroy() functions Julia Lawall
2015-06-10  6:41       ` Sergey Senozhatsky
2015-06-10  6:44         ` Julia Lawall
2015-06-10  6:52           ` Sergey Senozhatsky
2015-06-10  1:11   ` Christoph Lameter
2015-06-10  1:51     ` Andrew Morton
2015-06-10  2:00       ` Christoph Lameter
2015-06-10  2:17         ` Andrew Morton
2015-06-10  4:47           ` Joe Perches
2015-06-11 17:26           ` Christoph Lameter
2015-06-11 17:40             ` Andrew Morton [this message]
2015-06-10  2:04     ` Sergey Senozhatsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150611104056.5d2122dd.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=cl@linux.com \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.cz \
    --cc=minchan@kernel.org \
    --cc=penberg@kernel.org \
    --cc=rientjes@google.com \
    --cc=sergey.senozhatsky.work@gmail.com \
    --cc=sergey.senozhatsky@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).