From: David Rientjes <rientjes@google.com>
To: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Minchan Kim <minchan@kernel.org>,
Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Michal Hocko <mhocko@suse.cz>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
sergey.senozhatsky.work@gmail.com
Subject: Re: [RFC][PATCH 3/5] mm/dmapool: allow NULL `pool' pointer in dma_pool_destroy()
Date: Wed, 17 Jun 2015 16:22:46 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.10.1506171621400.8203@chino.kir.corp.google.com> (raw)
In-Reply-To: <1433851493-23685-4-git-send-email-sergey.senozhatsky@gmail.com>
On Tue, 9 Jun 2015, Sergey Senozhatsky wrote:
> dma_pool_destroy() does not tolerate a NULL dma_pool pointer
> argument and performs a NULL-pointer dereference. This requires
> additional attention and effort from developers/reviewers and
> forces all dma_pool_destroy() callers to do a NULL check
>
> if (pool)
> dma_pool_destroy(pool);
>
> Or, otherwise, be invalid dma_pool_destroy() users.
>
> Tweak dma_pool_destroy() and NULL-check the pointer there.
>
> Proposed by Andrew Morton.
>
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> Reported-by: Andrew Morton <akpm@linux-foundation.org>
> LKML-reference: https://lkml.org/lkml/2015/6/8/583
Acked-by: David Rientjes <rientjes@google.com>
next prev parent reply other threads:[~2015-06-17 23:23 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-09 12:04 [RFC][PATCH 0/5] do not dereference NULL pools in pools' destroy() functions Sergey Senozhatsky
2015-06-09 12:04 ` [RFC][PATCH 1/5] mm/slab_common: allow NULL cache pointer in kmem_cache_destroy() Sergey Senozhatsky
2015-06-17 23:14 ` David Rientjes
2015-06-17 23:52 ` Sergey Senozhatsky
2015-06-19 15:50 ` Julia Lawall
2015-08-06 14:21 ` Sergey Senozhatsky
2015-08-06 14:27 ` Julia Lawall
2015-08-06 14:29 ` Sergey Senozhatsky
2015-06-20 16:25 ` Julia Lawall
2015-07-16 8:26 ` Sergey Senozhatsky
2015-06-09 12:04 ` [RFC][PATCH 2/5] mm/mempool: allow NULL `pool' pointer in mempool_destroy() Sergey Senozhatsky
2015-06-17 23:21 ` David Rientjes
2015-06-17 23:54 ` Sergey Senozhatsky
2015-06-09 12:04 ` [RFC][PATCH 3/5] mm/dmapool: allow NULL `pool' pointer in dma_pool_destroy() Sergey Senozhatsky
2015-06-17 23:22 ` David Rientjes [this message]
2015-06-09 12:04 ` [RFC][PATCH 4/5] mm/zpool: allow NULL `zpool' pointer in zpool_destroy_pool() Sergey Senozhatsky
2015-06-10 20:59 ` Dan Streetman
2015-06-10 23:58 ` Sergey Senozhatsky
2015-06-11 0:48 ` Joe Perches
2015-06-11 0:59 ` Sergey Senozhatsky
2015-06-11 1:01 ` Dan Streetman
2015-06-09 12:04 ` [RFC][PATCH 5/5] mm/zsmalloc: allow NULL `pool' pointer in zs_destroy_pool() Sergey Senozhatsky
2015-06-09 21:25 ` [RFC][PATCH 0/5] do not dereference NULL pools in pools' destroy() functions Andrew Morton
2015-06-10 0:06 ` Joe Perches
2015-06-10 4:39 ` [PATCH] checkpatch: Add some <foo>_destroy functions to NEEDLESS_IF tests Joe Perches
2015-06-10 5:52 ` [PATCH V2] " Joe Perches
2015-06-10 10:18 ` Sergey Senozhatsky
2015-06-11 9:41 ` Julia Lawall
2015-06-11 9:51 ` Sergey Senozhatsky
2015-06-11 9:55 ` Julia Lawall
2015-07-14 23:03 ` Andrew Morton
2015-07-15 0:27 ` Sergey Senozhatsky
2015-06-10 5:46 ` [RFC][PATCH 0/5] do not dereference NULL pools in pools' destroy() functions Julia Lawall
2015-06-10 6:41 ` Sergey Senozhatsky
2015-06-10 6:44 ` Julia Lawall
2015-06-10 6:52 ` Sergey Senozhatsky
2015-06-10 1:11 ` Christoph Lameter
2015-06-10 1:51 ` Andrew Morton
2015-06-10 2:00 ` Christoph Lameter
2015-06-10 2:17 ` Andrew Morton
2015-06-10 4:47 ` Joe Perches
2015-06-11 17:26 ` Christoph Lameter
2015-06-11 17:40 ` Andrew Morton
2015-06-10 2:04 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1506171621400.8203@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=minchan@kernel.org \
--cc=penberg@kernel.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).