* [patch] checkpatch: Fixes: tag lines are allowed to be long
@ 2015-07-14 11:07 Dan Carpenter
2015-07-15 4:11 ` Joe Perches
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2015-07-14 11:07 UTC (permalink / raw)
To: Andy Whitcroft
Cc: Joe Perches, linux-kernel, gregkh, Jes.Sorensen, sparmaintainer,
driverdev-devel, Tim Sell
A lot of the Fixes: tags go over the 75 character limit and that's ok.
Fixes: 2a076f40d8c9 ('checkpatch, SubmittingPatches: suggest line wrapping commit messages at 75 columns')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
The other common cause of false positives it Oops output but I don't
have an idea how to filter for that.
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 90e1edc..537973b 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2310,7 +2310,7 @@ sub process {
# Check for line lengths > 75 in commit log, warn once
if ($in_commit_log && !$commit_log_long_line &&
- length($line) > 75) {
+ length($line) > 75 && !($line =~ /^Fixes:/)) {
WARN("COMMIT_LOG_LONG_LINE",
"Possible unwrapped commit description (prefer a maximum 75 chars per line)\n" . $herecurr);
$commit_log_long_line = 1;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] checkpatch: Fixes: tag lines are allowed to be long
2015-07-14 11:07 [patch] checkpatch: Fixes: tag lines are allowed to be long Dan Carpenter
@ 2015-07-15 4:11 ` Joe Perches
0 siblings, 0 replies; 2+ messages in thread
From: Joe Perches @ 2015-07-15 4:11 UTC (permalink / raw)
To: Dan Carpenter
Cc: Andy Whitcroft, linux-kernel, gregkh, Jes.Sorensen,
sparmaintainer, driverdev-devel, Tim Sell
On Tue, 2015-07-14 at 14:07 +0300, Dan Carpenter wrote:
> A lot of the Fixes: tags go over the 75 character limit and that's ok.
>
> Fixes: 2a076f40d8c9 ('checkpatch, SubmittingPatches: suggest line wrapping commit messages at 75 columns')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> The other common cause of false positives it Oops output but I don't
> have an idea how to filter for that.
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 90e1edc..537973b 100755[0-9a-f
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2310,7 +2310,7 @@ sub process {
>
> # Check for line lengths > 75 in commit log, warn once
> if ($in_commit_log && !$commit_log_long_line &&
> - length($line) > 75) {
> + length($line) > 75 && !($line =~ /^Fixes:/)) {
> WARN("COMMIT_LOG_LONG_LINE",
> "Possible unwrapped commit description (prefer a maximum 75 chars per line)\n" . $herecurr);
> $commit_log_long_line = 1;
Maybe some combination of:
^\s*>
^.*\[\s*timestamp\s*\]
^\s*\[\<0-9a-f\>\]
oops:
BUG: Unable to
Unable to
Followed by any blank line to reset
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-07-15 4:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-14 11:07 [patch] checkpatch: Fixes: tag lines are allowed to be long Dan Carpenter
2015-07-15 4:11 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).