* [PATCH pm] PM / hibernate: swsusp_page_is_valid() can be static
2015-07-14 8:23 [pm:bleeding-edge 10/17] kernel/power/snapshot.c:928:5: sparse: symbol 'swsusp_page_is_valid' was not declared. Should it be static? kbuild test robot
@ 2015-07-14 8:23 ` kbuild test robot
2015-07-14 12:12 ` Chen, Yu C
0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2015-07-14 8:23 UTC (permalink / raw)
To: Chen Yu
Cc: kbuild-all, Rafael J. Wysocki, Lee, Chun-Yi, linux-pm,
Pavel Machek, Len Brown, linux-kernel
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
snapshot.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/power/snapshot.c b/kernel/power/snapshot.c
index ebbb995..0e4112f4 100644
--- a/kernel/power/snapshot.c
+++ b/kernel/power/snapshot.c
@@ -925,7 +925,7 @@ static void swsusp_unset_page_forbidden(struct page *page)
memory_bm_clear_bit(forbidden_pages_map, page_to_pfn(page));
}
-int swsusp_page_is_valid(struct page *page)
+static int swsusp_page_is_valid(struct page *page)
{
return valid_pages_map ?
memory_bm_test_bit(valid_pages_map, page_to_pfn(page)) : 0;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [pm:bleeding-edge 10/17] kernel/power/snapshot.c:928:5: sparse: symbol 'swsusp_page_is_valid' was not declared. Should it be static?
@ 2015-07-14 8:23 kbuild test robot
2015-07-14 8:23 ` [PATCH pm] PM / hibernate: swsusp_page_is_valid() can be static kbuild test robot
0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2015-07-14 8:23 UTC (permalink / raw)
To: Chen Yu
Cc: kbuild-all, Rafael J. Wysocki, Lee, Chun-Yi, linux-pm,
Pavel Machek, Len Brown, linux-kernel
tree: git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git bleeding-edge
head: 4835ff4dabfa392ba9f10218231ea8b6972d9459
commit: d09d85e88f60a6e4d9f8159556f024bd588f11f0 [10/17] PM / hibernate: make sure each resuming page is in current memory zones
reproduce:
# apt-get install sparse
git checkout d09d85e88f60a6e4d9f8159556f024bd588f11f0
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by >>)
>> kernel/power/snapshot.c:928:5: sparse: symbol 'swsusp_page_is_valid' was not declared. Should it be static?
kernel/power/snapshot.c:1354:14: sparse: symbol 'alloc_normal' was not declared. Should it be static?
Please review and possibly fold the followup patch.
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH pm] PM / hibernate: swsusp_page_is_valid() can be static
2015-07-14 8:23 ` [PATCH pm] PM / hibernate: swsusp_page_is_valid() can be static kbuild test robot
@ 2015-07-14 12:12 ` Chen, Yu C
0 siblings, 0 replies; 3+ messages in thread
From: Chen, Yu C @ 2015-07-14 12:12 UTC (permalink / raw)
To: Wu, Fengguang
Cc: kbuild-all, Rafael J. Wysocki, Lee, Chun-Yi, linux-pm,
Pavel Machek, Brown, Len, linux-kernel
> -----Original Message-----
> From: Wu, Fengguang
> Sent: Tuesday, July 14, 2015 4:24 PM
> To: Chen, Yu C
> Cc: kbuild-all@01.org; Rafael J. Wysocki; Lee, Chun-Yi; linux-
> pm@vger.kernel.org; Pavel Machek; Brown, Len; linux-
> kernel@vger.kernel.org
> Subject: [PATCH pm] PM / hibernate: swsusp_page_is_valid() can be static
>
>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
> snapshot.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/power/snapshot.c b/kernel/power/snapshot.c index
> ebbb995..0e4112f4 100644
> --- a/kernel/power/snapshot.c
> +++ b/kernel/power/snapshot.c
> @@ -925,7 +925,7 @@ static void swsusp_unset_page_forbidden(struct
> page *page)
> memory_bm_clear_bit(forbidden_pages_map,
> page_to_pfn(page)); }
>
> -int swsusp_page_is_valid(struct page *page)
> +static int swsusp_page_is_valid(struct page *page)
> {
> return valid_pages_map ?
> memory_bm_test_bit(valid_pages_map,
> page_to_pfn(page)) : 0;
OK, thanks Fengguang
Best Regards,
Yu
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-07-14 12:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-14 8:23 [pm:bleeding-edge 10/17] kernel/power/snapshot.c:928:5: sparse: symbol 'swsusp_page_is_valid' was not declared. Should it be static? kbuild test robot
2015-07-14 8:23 ` [PATCH pm] PM / hibernate: swsusp_page_is_valid() can be static kbuild test robot
2015-07-14 12:12 ` Chen, Yu C
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).