* Re: next-20150716 build: 4 failures 88 warnings (next-20150716)
[not found] <E1ZFg2R-0001bO-R5@optimist>
@ 2015-07-16 13:41 ` Mark Brown
2015-07-16 13:48 ` Catalin Marinas
2015-07-16 21:29 ` Andrew Morton
0 siblings, 2 replies; 4+ messages in thread
From: Mark Brown @ 2015-07-16 13:41 UTC (permalink / raw)
To: Andrew Morton, Kirill A. Shutemov, Toshi Kani, Matthew Wilcox,
Catalin Marinas, Will Deacon
Cc: kernel-build-reports, linaro-kernel, linux-next, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 578 bytes --]
On Thu, Jul 16, 2015 at 11:05:11AM +0100, Build bot for Mark Brown wrote:
Today's linux-next fails to build an arm64 allnoconfig due to "mm: make
GUP handle pfn mapping unless FOLL_GET is requested" which causes:
> arm64-allnoconfig
> ../mm/gup.c:51:4: error: implicit declaration of function 'update_mmu_cache' [-Werror=implicit-function-declaration]
The update_mmu_cache() function is defined unconditionally in
asm/tlbflush.h so there is presumably some path of conditional
inclusions which causes it not to get declared in an allnoconfig - I
didn't chase that down yet.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: next-20150716 build: 4 failures 88 warnings (next-20150716)
2015-07-16 13:41 ` next-20150716 build: 4 failures 88 warnings (next-20150716) Mark Brown
@ 2015-07-16 13:48 ` Catalin Marinas
2015-07-16 14:01 ` Mark Brown
2015-07-16 21:29 ` Andrew Morton
1 sibling, 1 reply; 4+ messages in thread
From: Catalin Marinas @ 2015-07-16 13:48 UTC (permalink / raw)
To: Mark Brown
Cc: Andrew Morton, Kirill A. Shutemov, Toshi Kani, Matthew Wilcox,
Will Deacon, kernel-build-reports, linaro-kernel, linux-next,
linux-kernel
On Thu, Jul 16, 2015 at 02:41:52PM +0100, Mark Brown wrote:
> On Thu, Jul 16, 2015 at 11:05:11AM +0100, Build bot for Mark Brown wrote:
>
> Today's linux-next fails to build an arm64 allnoconfig due to "mm: make
> GUP handle pfn mapping unless FOLL_GET is requested" which causes:
>
> > arm64-allnoconfig
> > ../mm/gup.c:51:4: error: implicit declaration of function 'update_mmu_cache' [-Werror=implicit-function-declaration]
>
> The update_mmu_cache() function is defined unconditionally in
> asm/tlbflush.h so there is presumably some path of conditional
> inclusions which causes it not to get declared in an allnoconfig - I
> didn't chase that down yet.
Maybe we should move it to asm/pgtable.h like many other architectures.
--
Catalin
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: next-20150716 build: 4 failures 88 warnings (next-20150716)
2015-07-16 13:48 ` Catalin Marinas
@ 2015-07-16 14:01 ` Mark Brown
0 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2015-07-16 14:01 UTC (permalink / raw)
To: Catalin Marinas
Cc: Andrew Morton, Kirill A. Shutemov, Toshi Kani, Matthew Wilcox,
Will Deacon, kernel-build-reports, linaro-kernel, linux-next,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 506 bytes --]
On Thu, Jul 16, 2015 at 02:48:36PM +0100, Catalin Marinas wrote:
> On Thu, Jul 16, 2015 at 02:41:52PM +0100, Mark Brown wrote:
> > The update_mmu_cache() function is defined unconditionally in
> > asm/tlbflush.h so there is presumably some path of conditional
> > inclusions which causes it not to get declared in an allnoconfig - I
> > didn't chase that down yet.
> Maybe we should move it to asm/pgtable.h like many other architectures.
Seems likely to be more robust in future if we're consistent...
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: next-20150716 build: 4 failures 88 warnings (next-20150716)
2015-07-16 13:41 ` next-20150716 build: 4 failures 88 warnings (next-20150716) Mark Brown
2015-07-16 13:48 ` Catalin Marinas
@ 2015-07-16 21:29 ` Andrew Morton
1 sibling, 0 replies; 4+ messages in thread
From: Andrew Morton @ 2015-07-16 21:29 UTC (permalink / raw)
To: Mark Brown
Cc: Kirill A. Shutemov, Toshi Kani, Matthew Wilcox, Catalin Marinas,
Will Deacon, kernel-build-reports, linaro-kernel, linux-next,
linux-kernel
On Thu, 16 Jul 2015 14:41:52 +0100 Mark Brown <broonie@kernel.org> wrote:
> On Thu, Jul 16, 2015 at 11:05:11AM +0100, Build bot for Mark Brown wrote:
>
> Today's linux-next fails to build an arm64 allnoconfig due to "mm: make
> GUP handle pfn mapping unless FOLL_GET is requested" which causes:
>
> > arm64-allnoconfig
> > ../mm/gup.c:51:4: error: implicit declaration of function 'update_mmu_cache' [-Werror=implicit-function-declaration]
>
> The update_mmu_cache() function is defined unconditionally in
> asm/tlbflush.h so there is presumably some path of conditional
> inclusions which causes it not to get declared in an allnoconfig - I
> didn't chase that down yet.
I did te obvious:
--- a/mm/gup.c~mm-make-gup-handle-pfn-mapping-unless-foll_get-is-requested-fix
+++ a/mm/gup.c
@@ -12,7 +12,9 @@
#include <linux/sched.h>
#include <linux/rwsem.h>
#include <linux/hugetlb.h>
+
#include <asm/pgtable.h>
+#include <asm/tlbflush.h>
#include "internal.h"
I don't have arm64 toolchain here, but it fixed the error on arm and
that's what mm/memory.c does.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-07-16 21:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <E1ZFg2R-0001bO-R5@optimist>
2015-07-16 13:41 ` next-20150716 build: 4 failures 88 warnings (next-20150716) Mark Brown
2015-07-16 13:48 ` Catalin Marinas
2015-07-16 14:01 ` Mark Brown
2015-07-16 21:29 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).