* [PATCH] kexec: Remove the unnecessary conditional judgement to simplify the code logic
@ 2015-06-06 6:14 Minfei Huang
2015-06-15 9:28 ` Dave Young
2015-07-27 13:44 ` Vivek Goyal
0 siblings, 2 replies; 6+ messages in thread
From: Minfei Huang @ 2015-06-06 6:14 UTC (permalink / raw)
To: ebiederm, vgoyal; +Cc: kexec, linux-kernel, Minfei Huang
From: Minfei Huang <mnfhuang@gmail.com>
Transforming PFN(Page Frame Number) to struct page is never failure, so
we can simplify the code logic to do the image->control_page assignment
directly in the loop, and remove the unnecessary conditional judgement.
Signed-off-by: Minfei Huang <mnfhuang@gmail.com>
---
kernel/kexec.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/kernel/kexec.c b/kernel/kexec.c
index 7a36fdc..4589899 100644
--- a/kernel/kexec.c
+++ b/kernel/kexec.c
@@ -796,11 +796,10 @@ static struct page *kimage_alloc_crash_control_pages(struct kimage *image,
/* If I don't overlap any segments I have found my hole! */
if (i == image->nr_segments) {
pages = pfn_to_page(hole_start >> PAGE_SHIFT);
+ image->control_page = hole_end;
break;
}
}
- if (pages)
- image->control_page = hole_end;
return pages;
}
--
2.2.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] kexec: Remove the unnecessary conditional judgement to simplify the code logic
2015-06-06 6:14 [PATCH] kexec: Remove the unnecessary conditional judgement to simplify the code logic Minfei Huang
@ 2015-06-15 9:28 ` Dave Young
2015-07-25 9:11 ` Minfei Huang
2015-07-27 13:44 ` Vivek Goyal
1 sibling, 1 reply; 6+ messages in thread
From: Dave Young @ 2015-06-15 9:28 UTC (permalink / raw)
To: Minfei Huang; +Cc: ebiederm, vgoyal, kexec, linux-kernel, Minfei Huang
On 06/06/15 at 02:14pm, Minfei Huang wrote:
> From: Minfei Huang <mnfhuang@gmail.com>
>
> Transforming PFN(Page Frame Number) to struct page is never failure, so
> we can simplify the code logic to do the image->control_page assignment
> directly in the loop, and remove the unnecessary conditional judgement.
>
> Signed-off-by: Minfei Huang <mnfhuang@gmail.com>
> ---
> kernel/kexec.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/kernel/kexec.c b/kernel/kexec.c
> index 7a36fdc..4589899 100644
> --- a/kernel/kexec.c
> +++ b/kernel/kexec.c
> @@ -796,11 +796,10 @@ static struct page *kimage_alloc_crash_control_pages(struct kimage *image,
> /* If I don't overlap any segments I have found my hole! */
> if (i == image->nr_segments) {
> pages = pfn_to_page(hole_start >> PAGE_SHIFT);
> + image->control_page = hole_end;
> break;
> }
> }
> - if (pages)
> - image->control_page = hole_end;
>
> return pages;
> }
Acked-by: Dave Young <dyoung@redhat.com>
Thanks
Dave
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] kexec: Remove the unnecessary conditional judgement to simplify the code logic
2015-06-15 9:28 ` Dave Young
@ 2015-07-25 9:11 ` Minfei Huang
0 siblings, 0 replies; 6+ messages in thread
From: Minfei Huang @ 2015-07-25 9:11 UTC (permalink / raw)
To: vgoyal, Dave Young; +Cc: ebiederm, kexec, linux-kernel, Minfei Huang
Hi, Vivek.
Since Dave acked this patch, Could you help to merge it?
Thanks
Minfei
On 06/15/15 at 05:28pm, Dave Young wrote:
> On 06/06/15 at 02:14pm, Minfei Huang wrote:
> > From: Minfei Huang <mnfhuang@gmail.com>
> >
> > Transforming PFN(Page Frame Number) to struct page is never failure, so
> > we can simplify the code logic to do the image->control_page assignment
> > directly in the loop, and remove the unnecessary conditional judgement.
> >
> > Signed-off-by: Minfei Huang <mnfhuang@gmail.com>
> > ---
> > kernel/kexec.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/kernel/kexec.c b/kernel/kexec.c
> > index 7a36fdc..4589899 100644
> > --- a/kernel/kexec.c
> > +++ b/kernel/kexec.c
> > @@ -796,11 +796,10 @@ static struct page *kimage_alloc_crash_control_pages(struct kimage *image,
> > /* If I don't overlap any segments I have found my hole! */
> > if (i == image->nr_segments) {
> > pages = pfn_to_page(hole_start >> PAGE_SHIFT);
> > + image->control_page = hole_end;
> > break;
> > }
> > }
> > - if (pages)
> > - image->control_page = hole_end;
> >
> > return pages;
> > }
>
> Acked-by: Dave Young <dyoung@redhat.com>
>
> Thanks
> Dave
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] kexec: Remove the unnecessary conditional judgement to simplify the code logic
2015-06-06 6:14 [PATCH] kexec: Remove the unnecessary conditional judgement to simplify the code logic Minfei Huang
2015-06-15 9:28 ` Dave Young
@ 2015-07-27 13:44 ` Vivek Goyal
2015-07-28 4:30 ` Simon Horman
1 sibling, 1 reply; 6+ messages in thread
From: Vivek Goyal @ 2015-07-27 13:44 UTC (permalink / raw)
To: Minfei Huang; +Cc: ebiederm, kexec, linux-kernel, Minfei Huang
On Sat, Jun 06, 2015 at 02:14:12PM +0800, Minfei Huang wrote:
> From: Minfei Huang <mnfhuang@gmail.com>
>
> Transforming PFN(Page Frame Number) to struct page is never failure, so
> we can simplify the code logic to do the image->control_page assignment
> directly in the loop, and remove the unnecessary conditional judgement.
>
> Signed-off-by: Minfei Huang <mnfhuang@gmail.com>
Looks good to me.
Acked-by: Vivek Goyal <vgoyal@redhat.com>
Thanks
Vivek
> ---
> kernel/kexec.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/kernel/kexec.c b/kernel/kexec.c
> index 7a36fdc..4589899 100644
> --- a/kernel/kexec.c
> +++ b/kernel/kexec.c
> @@ -796,11 +796,10 @@ static struct page *kimage_alloc_crash_control_pages(struct kimage *image,
> /* If I don't overlap any segments I have found my hole! */
> if (i == image->nr_segments) {
> pages = pfn_to_page(hole_start >> PAGE_SHIFT);
> + image->control_page = hole_end;
> break;
> }
> }
> - if (pages)
> - image->control_page = hole_end;
>
> return pages;
> }
> --
> 2.2.2
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] kexec: Remove the unnecessary conditional judgement to simplify the code logic
2015-07-27 13:44 ` Vivek Goyal
@ 2015-07-28 4:30 ` Simon Horman
2015-07-28 4:42 ` Minfei Huang
0 siblings, 1 reply; 6+ messages in thread
From: Simon Horman @ 2015-07-28 4:30 UTC (permalink / raw)
To: Vivek Goyal; +Cc: Minfei Huang, Minfei Huang, kexec, ebiederm, linux-kernel
On Mon, Jul 27, 2015 at 09:44:53AM -0400, Vivek Goyal wrote:
> On Sat, Jun 06, 2015 at 02:14:12PM +0800, Minfei Huang wrote:
> > From: Minfei Huang <mnfhuang@gmail.com>
> >
> > Transforming PFN(Page Frame Number) to struct page is never failure, so
> > we can simplify the code logic to do the image->control_page assignment
> > directly in the loop, and remove the unnecessary conditional judgement.
> >
> > Signed-off-by: Minfei Huang <mnfhuang@gmail.com>
>
> Looks good to me.
>
> Acked-by: Vivek Goyal <vgoyal@redhat.com>
FWIW, this probably needs to be reposted to Andrew Morton with appropriate
Acks and CCs in order to proceed into his tree and then Linus's.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] kexec: Remove the unnecessary conditional judgement to simplify the code logic
2015-07-28 4:30 ` Simon Horman
@ 2015-07-28 4:42 ` Minfei Huang
0 siblings, 0 replies; 6+ messages in thread
From: Minfei Huang @ 2015-07-28 4:42 UTC (permalink / raw)
To: Simon Horman; +Cc: Vivek Goyal, Minfei Huang, kexec, ebiederm, linux-kernel
On 07/28/15 at 01:30pm, Simon Horman wrote:
> On Mon, Jul 27, 2015 at 09:44:53AM -0400, Vivek Goyal wrote:
> > On Sat, Jun 06, 2015 at 02:14:12PM +0800, Minfei Huang wrote:
> > > From: Minfei Huang <mnfhuang@gmail.com>
> > >
> > > Transforming PFN(Page Frame Number) to struct page is never failure, so
> > > we can simplify the code logic to do the image->control_page assignment
> > > directly in the loop, and remove the unnecessary conditional judgement.
> > >
> > > Signed-off-by: Minfei Huang <mnfhuang@gmail.com>
> >
> > Looks good to me.
> >
> > Acked-by: Vivek Goyal <vgoyal@redhat.com>
>
> FWIW, this probably needs to be reposted to Andrew Morton with appropriate
> Acks and CCs in order to proceed into his tree and then Linus's.
Thanks.
I will repost it to Andrew Morton.
Thanks
Minfei
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-07-28 4:42 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-06 6:14 [PATCH] kexec: Remove the unnecessary conditional judgement to simplify the code logic Minfei Huang
2015-06-15 9:28 ` Dave Young
2015-07-25 9:11 ` Minfei Huang
2015-07-27 13:44 ` Vivek Goyal
2015-07-28 4:30 ` Simon Horman
2015-07-28 4:42 ` Minfei Huang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).