* [PATCH V3 0/8] clean up wlan_bssdef.h
@ 2015-07-28 4:41 Joshua Clayton
2015-07-28 4:41 ` [PATCH V3 1/8] staging: rtl8712: fix buggy size calculation Joshua Clayton
` (16 more replies)
0 siblings, 17 replies; 27+ messages in thread
From: Joshua Clayton @ 2015-07-28 4:41 UTC (permalink / raw)
To: Larry Finger, Florian Schilhabel, Greg Kroah-Hartman,
Sudip Mukherjee, Nitin Kuppelur, Joshua Clayton,
Vaishali Thakkar, Tapasweni Pathak, Daniel Baluta,
Melike Yurtoglu, Max Perepelitsyn, Aya Mahfouz,
Cristina Opriceana, Dogukan Ergun, Julia Lawall, Dan Carpenter,
Haneen Mohammed, Rickard Strandqvist
Cc: devel, linux-kernel
The main goal of this series is to get rid of a needless typedef
in the rtl8712 wlan driver.
In the course of fixing that, I found a bug that can (at least in theory)
lead to a overrun during a memcpy, as well as an identical struct with
a different name, which use the typedef.
Finally after cleaning up the typedef, change the name of the primary
variable that used the typedef from "SupportedRates" to "rates", to
conform to kernel coding style.
Changes since V1:
Do not make other logic changes while Changing the name of SupportedRates
New patch 3/6 fixes a buggy comment that referred to the typedef
Changes sinve V2:
broke former patch 4, which was too big for git-send-email into 3 parts
Joshua Clayton (8):
staging: rtl8712: fix buggy size calculation
staging: rtl8712: simplify size calculation
staging: rtl8712: fix comment
staging: rtl8712: removed unused wrapper structs
staging: rtl8712: remove duplicate struct
staging: rtl8712: rename function
staging: rtl8712: remove typedefs
staging: rtl8712: change SupportedRates to rates
drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
drivers/staging/rtl8712/rtl871x_event.h | 2 +-
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
9 files changed, 64 insertions(+), 139 deletions(-)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
Date: Mon, 27 Jul 2015 21:41:09 -0700
Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
The main goal of this series is to get rid of a needless typedef
in the rtl8712 wlan driver.
In the course of fixing that, I found a bug that can (at least in theory)
lead to a overrun during a memcpy, as well as an identical struct with
a different name, which use the typedef.
Finally after cleaning up the typedef, change the name of the primary
variable that used the typedef from "SupportedRates" to "rates", to
conform to kernel coding style.
Changes since V1:
Do not make other logic changes while Changing the name of SupportedRates
New patch 3/6 fixes a buggy comment that referred to the typedef
Changes sinve V2:
broke former patch 4, which was too big for git-send-email into 3 parts
Joshua Clayton (8):
staging: rtl8712: fix buggy size calculation
staging: rtl8712: simplify size calculation
staging: rtl8712: fix comment
staging: rtl8712: removed unused wrapper structs
staging: rtl8712: remove duplicate struct
staging: rtl8712: rename function
staging: rtl8712: remove typedefs
staging: rtl8712: change SupportedRates to rates
drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
drivers/staging/rtl8712/rtl871x_event.h | 2 +-
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
9 files changed, 64 insertions(+), 139 deletions(-)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
Date: Mon, 27 Jul 2015 21:41:09 -0700
Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
The main goal of this series is to get rid of a needless typedef
in the rtl8712 wlan driver.
In the course of fixing that, I found a bug that can (at least in theory)
lead to a overrun during a memcpy, as well as an identical struct with
a different name, which use the typedef.
Finally after cleaning up the typedef, change the name of the primary
variable that used the typedef from "SupportedRates" to "rates", to
conform to kernel coding style.
Changes since V1:
Do not make other logic changes while Changing the name of SupportedRates
New patch 3/6 fixes a buggy comment that referred to the typedef
Changes sinve V2:
broke former patch 4, which was too big for git-send-email into 3 parts
Joshua Clayton (8):
staging: rtl8712: fix buggy size calculation
staging: rtl8712: simplify size calculation
staging: rtl8712: fix comment
staging: rtl8712: removed unused wrapper structs
staging: rtl8712: remove duplicate struct
staging: rtl8712: rename function
staging: rtl8712: remove typedefs
staging: rtl8712: change SupportedRates to rates
drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
drivers/staging/rtl8712/rtl871x_event.h | 2 +-
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
9 files changed, 64 insertions(+), 139 deletions(-)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
Date: Mon, 27 Jul 2015 21:41:09 -0700
Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
The main goal of this series is to get rid of a needless typedef
in the rtl8712 wlan driver.
In the course of fixing that, I found a bug that can (at least in theory)
lead to a overrun during a memcpy, as well as an identical struct with
a different name, which use the typedef.
Finally after cleaning up the typedef, change the name of the primary
variable that used the typedef from "SupportedRates" to "rates", to
conform to kernel coding style.
Changes since V1:
Do not make other logic changes while Changing the name of SupportedRates
New patch 3/6 fixes a buggy comment that referred to the typedef
Changes sinve V2:
broke former patch 4, which was too big for git-send-email into 3 parts
Joshua Clayton (8):
staging: rtl8712: fix buggy size calculation
staging: rtl8712: simplify size calculation
staging: rtl8712: fix comment
staging: rtl8712: removed unused wrapper structs
staging: rtl8712: remove duplicate struct
staging: rtl8712: rename function
staging: rtl8712: remove typedefs
staging: rtl8712: change SupportedRates to rates
drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
drivers/staging/rtl8712/rtl871x_event.h | 2 +-
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
9 files changed, 64 insertions(+), 139 deletions(-)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
Date: Mon, 27 Jul 2015 21:41:09 -0700
Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
The main goal of this series is to get rid of a needless typedef
in the rtl8712 wlan driver.
In the course of fixing that, I found a bug that can (at least in theory)
lead to a overrun during a memcpy, as well as an identical struct with
a different name, which use the typedef.
Finally after cleaning up the typedef, change the name of the primary
variable that used the typedef from "SupportedRates" to "rates", to
conform to kernel coding style.
Changes since V1:
Do not make other logic changes while Changing the name of SupportedRates
New patch 3/6 fixes a buggy comment that referred to the typedef
Changes sinve V2:
broke former patch 4, which was too big for git-send-email into 3 parts
Joshua Clayton (8):
staging: rtl8712: fix buggy size calculation
staging: rtl8712: simplify size calculation
staging: rtl8712: fix comment
staging: rtl8712: removed unused wrapper structs
staging: rtl8712: remove duplicate struct
staging: rtl8712: rename function
staging: rtl8712: remove typedefs
staging: rtl8712: change SupportedRates to rates
drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
drivers/staging/rtl8712/rtl871x_event.h | 2 +-
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
9 files changed, 64 insertions(+), 139 deletions(-)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
Date: Mon, 27 Jul 2015 21:41:09 -0700
Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
The main goal of this series is to get rid of a needless typedef
in the rtl8712 wlan driver.
In the course of fixing that, I found a bug that can (at least in theory)
lead to a overrun during a memcpy, as well as an identical struct with
a different name, which use the typedef.
Finally after cleaning up the typedef, change the name of the primary
variable that used the typedef from "SupportedRates" to "rates", to
conform to kernel coding style.
Changes since V1:
Do not make other logic changes while Changing the name of SupportedRates
New patch 3/6 fixes a buggy comment that referred to the typedef
Changes sinve V2:
broke former patch 4, which was too big for git-send-email into 3 parts
Joshua Clayton (8):
staging: rtl8712: fix buggy size calculation
staging: rtl8712: simplify size calculation
staging: rtl8712: fix comment
staging: rtl8712: removed unused wrapper structs
staging: rtl8712: remove duplicate struct
staging: rtl8712: rename function
staging: rtl8712: remove typedefs
staging: rtl8712: change SupportedRates to rates
drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
drivers/staging/rtl8712/rtl871x_event.h | 2 +-
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
9 files changed, 64 insertions(+), 139 deletions(-)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
Date: Mon, 27 Jul 2015 21:41:09 -0700
Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
The main goal of this series is to get rid of a needless typedef
in the rtl8712 wlan driver.
In the course of fixing that, I found a bug that can (at least in theory)
lead to a overrun during a memcpy, as well as an identical struct with
a different name, which use the typedef.
Finally after cleaning up the typedef, change the name of the primary
variable that used the typedef from "SupportedRates" to "rates", to
conform to kernel coding style.
Changes since V1:
Do not make other logic changes while Changing the name of SupportedRates
New patch 3/6 fixes a buggy comment that referred to the typedef
Changes sinve V2:
broke former patch 4, which was too big for git-send-email into 3 parts
Joshua Clayton (8):
staging: rtl8712: fix buggy size calculation
staging: rtl8712: simplify size calculation
staging: rtl8712: fix comment
staging: rtl8712: removed unused wrapper structs
staging: rtl8712: remove duplicate struct
staging: rtl8712: rename function
staging: rtl8712: remove typedefs
staging: rtl8712: change SupportedRates to rates
drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
drivers/staging/rtl8712/rtl871x_event.h | 2 +-
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
9 files changed, 64 insertions(+), 139 deletions(-)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
Date: Mon, 27 Jul 2015 21:41:09 -0700
Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
The main goal of this series is to get rid of a needless typedef
in the rtl8712 wlan driver.
In the course of fixing that, I found a bug that can (at least in theory)
lead to a overrun during a memcpy, as well as an identical struct with
a different name, which use the typedef.
Finally after cleaning up the typedef, change the name of the primary
variable that used the typedef from "SupportedRates" to "rates", to
conform to kernel coding style.
Changes since V1:
Do not make other logic changes while Changing the name of SupportedRates
New patch 3/6 fixes a buggy comment that referred to the typedef
Changes sinve V2:
broke former patch 4, which was too big for git-send-email into 3 parts
Joshua Clayton (8):
staging: rtl8712: fix buggy size calculation
staging: rtl8712: simplify size calculation
staging: rtl8712: fix comment
staging: rtl8712: removed unused wrapper structs
staging: rtl8712: remove duplicate struct
staging: rtl8712: rename function
staging: rtl8712: remove typedefs
staging: rtl8712: change SupportedRates to rates
drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
drivers/staging/rtl8712/rtl871x_event.h | 2 +-
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
9 files changed, 64 insertions(+), 139 deletions(-)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
Date: Mon, 27 Jul 2015 21:41:09 -0700
Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
The main goal of this series is to get rid of a needless typedef
in the rtl8712 wlan driver.
In the course of fixing that, I found a bug that can (at least in theory)
lead to a overrun during a memcpy, as well as an identical struct with
a different name, which use the typedef.
Finally after cleaning up the typedef, change the name of the primary
variable that used the typedef from "SupportedRates" to "rates", to
conform to kernel coding style.
Changes since V1:
Do not make other logic changes while Changing the name of SupportedRates
New patch 3/6 fixes a buggy comment that referred to the typedef
Changes sinve V2:
broke former patch 4, which was too big for git-send-email into 3 parts
Joshua Clayton (8):
staging: rtl8712: fix buggy size calculation
staging: rtl8712: simplify size calculation
staging: rtl8712: fix comment
staging: rtl8712: removed unused wrapper structs
staging: rtl8712: remove duplicate struct
staging: rtl8712: rename function
staging: rtl8712: remove typedefs
staging: rtl8712: change SupportedRates to rates
drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
drivers/staging/rtl8712/rtl871x_event.h | 2 +-
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
9 files changed, 64 insertions(+), 139 deletions(-)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
Date: Mon, 27 Jul 2015 21:41:09 -0700
Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
The main goal of this series is to get rid of a needless typedef
in the rtl8712 wlan driver.
In the course of fixing that, I found a bug that can (at least in theory)
lead to a overrun during a memcpy, as well as an identical struct with
a different name, which use the typedef.
Finally after cleaning up the typedef, change the name of the primary
variable that used the typedef from "SupportedRates" to "rates", to
conform to kernel coding style.
Changes since V1:
Do not make other logic changes while Changing the name of SupportedRates
New patch 3/6 fixes a buggy comment that referred to the typedef
Changes sinve V2:
broke former patch 4, which was too big for git-send-email into 3 parts
Joshua Clayton (8):
staging: rtl8712: fix buggy size calculation
staging: rtl8712: simplify size calculation
staging: rtl8712: fix comment
staging: rtl8712: removed unused wrapper structs
staging: rtl8712: remove duplicate struct
staging: rtl8712: rename function
staging: rtl8712: remove typedefs
staging: rtl8712: change SupportedRates to rates
drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
drivers/staging/rtl8712/rtl871x_event.h | 2 +-
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
9 files changed, 64 insertions(+), 139 deletions(-)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
Date: Mon, 27 Jul 2015 21:41:09 -0700
Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
The main goal of this series is to get rid of a needless typedef
in the rtl8712 wlan driver.
In the course of fixing that, I found a bug that can (at least in theory)
lead to a overrun during a memcpy, as well as an identical struct with
a different name, which use the typedef.
Finally after cleaning up the typedef, change the name of the primary
variable that used the typedef from "SupportedRates" to "rates", to
conform to kernel coding style.
Changes since V1:
Do not make other logic changes while Changing the name of SupportedRates
New patch 3/6 fixes a buggy comment that referred to the typedef
Changes sinve V2:
broke former patch 4, which was too big for git-send-email into 3 parts
Joshua Clayton (8):
staging: rtl8712: fix buggy size calculation
staging: rtl8712: simplify size calculation
staging: rtl8712: fix comment
staging: rtl8712: removed unused wrapper structs
staging: rtl8712: remove duplicate struct
staging: rtl8712: rename function
staging: rtl8712: remove typedefs
staging: rtl8712: change SupportedRates to rates
drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
drivers/staging/rtl8712/rtl871x_event.h | 2 +-
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
9 files changed, 64 insertions(+), 139 deletions(-)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
Date: Mon, 27 Jul 2015 21:41:09 -0700
Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
The main goal of this series is to get rid of a needless typedef
in the rtl8712 wlan driver.
In the course of fixing that, I found a bug that can (at least in theory)
lead to a overrun during a memcpy, as well as an identical struct with
a different name, which use the typedef.
Finally after cleaning up the typedef, change the name of the primary
variable that used the typedef from "SupportedRates" to "rates", to
conform to kernel coding style.
Changes since V1:
Do not make other logic changes while Changing the name of SupportedRates
New patch 3/6 fixes a buggy comment that referred to the typedef
Changes sinve V2:
broke former patch 4, which was too big for git-send-email into 3 parts
Joshua Clayton (8):
staging: rtl8712: fix buggy size calculation
staging: rtl8712: simplify size calculation
staging: rtl8712: fix comment
staging: rtl8712: removed unused wrapper structs
staging: rtl8712: remove duplicate struct
staging: rtl8712: rename function
staging: rtl8712: remove typedefs
staging: rtl8712: change SupportedRates to rates
drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
drivers/staging/rtl8712/rtl871x_event.h | 2 +-
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
9 files changed, 64 insertions(+), 139 deletions(-)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
Date: Mon, 27 Jul 2015 21:41:09 -0700
Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
The main goal of this series is to get rid of a needless typedef
in the rtl8712 wlan driver.
In the course of fixing that, I found a bug that can (at least in theory)
lead to a overrun during a memcpy, as well as an identical struct with
a different name, which use the typedef.
Finally after cleaning up the typedef, change the name of the primary
variable that used the typedef from "SupportedRates" to "rates", to
conform to kernel coding style.
Changes since V1:
Do not make other logic changes while Changing the name of SupportedRates
New patch 3/6 fixes a buggy comment that referred to the typedef
Changes sinve V2:
broke former patch 4, which was too big for git-send-email into 3 parts
Joshua Clayton (8):
staging: rtl8712: fix buggy size calculation
staging: rtl8712: simplify size calculation
staging: rtl8712: fix comment
staging: rtl8712: removed unused wrapper structs
staging: rtl8712: remove duplicate struct
staging: rtl8712: rename function
staging: rtl8712: remove typedefs
staging: rtl8712: change SupportedRates to rates
drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
drivers/staging/rtl8712/rtl871x_event.h | 2 +-
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
9 files changed, 64 insertions(+), 139 deletions(-)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
Date: Mon, 27 Jul 2015 21:41:09 -0700
Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
The main goal of this series is to get rid of a needless typedef
in the rtl8712 wlan driver.
In the course of fixing that, I found a bug that can (at least in theory)
lead to a overrun during a memcpy, as well as an identical struct with
a different name, which use the typedef.
Finally after cleaning up the typedef, change the name of the primary
variable that used the typedef from "SupportedRates" to "rates", to
conform to kernel coding style.
Changes since V1:
Do not make other logic changes while Changing the name of SupportedRates
New patch 3/6 fixes a buggy comment that referred to the typedef
Changes sinve V2:
broke former patch 4, which was too big for git-send-email into 3 parts
Joshua Clayton (8):
staging: rtl8712: fix buggy size calculation
staging: rtl8712: simplify size calculation
staging: rtl8712: fix comment
staging: rtl8712: removed unused wrapper structs
staging: rtl8712: remove duplicate struct
staging: rtl8712: rename function
staging: rtl8712: remove typedefs
staging: rtl8712: change SupportedRates to rates
drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
drivers/staging/rtl8712/rtl871x_event.h | 2 +-
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
9 files changed, 64 insertions(+), 139 deletions(-)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
Date: Mon, 27 Jul 2015 21:41:09 -0700
Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
The main goal of this series is to get rid of a needless typedef
in the rtl8712 wlan driver.
In the course of fixing that, I found a bug that can (at least in theory)
lead to a overrun during a memcpy, as well as an identical struct with
a different name, which use the typedef.
Finally after cleaning up the typedef, change the name of the primary
variable that used the typedef from "SupportedRates" to "rates", to
conform to kernel coding style.
Changes since V1:
Do not make other logic changes while Changing the name of SupportedRates
New patch 3/6 fixes a buggy comment that referred to the typedef
Changes sinve V2:
broke former patch 4, which was too big for git-send-email into 3 parts
Joshua Clayton (8):
staging: rtl8712: fix buggy size calculation
staging: rtl8712: simplify size calculation
staging: rtl8712: fix comment
staging: rtl8712: removed unused wrapper structs
staging: rtl8712: remove duplicate struct
staging: rtl8712: rename function
staging: rtl8712: remove typedefs
staging: rtl8712: change SupportedRates to rates
drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
drivers/staging/rtl8712/rtl871x_event.h | 2 +-
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
9 files changed, 64 insertions(+), 139 deletions(-)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
Date: Mon, 27 Jul 2015 21:41:09 -0700
Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
The main goal of this series is to get rid of a needless typedef
in the rtl8712 wlan driver.
In the course of fixing that, I found a bug that can (at least in theory)
lead to a overrun during a memcpy, as well as an identical struct with
a different name, which use the typedef.
Finally after cleaning up the typedef, change the name of the primary
variable that used the typedef from "SupportedRates" to "rates", to
conform to kernel coding style.
Changes since V1:
Do not make other logic changes while Changing the name of SupportedRates
New patch 3/6 fixes a buggy comment that referred to the typedef
Changes sinve V2:
broke former patch 4, which was too big for git-send-email into 3 parts
Joshua Clayton (8):
staging: rtl8712: fix buggy size calculation
staging: rtl8712: simplify size calculation
staging: rtl8712: fix comment
staging: rtl8712: removed unused wrapper structs
staging: rtl8712: remove duplicate struct
staging: rtl8712: rename function
staging: rtl8712: remove typedefs
staging: rtl8712: change SupportedRates to rates
drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
drivers/staging/rtl8712/rtl871x_event.h | 2 +-
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
9 files changed, 64 insertions(+), 139 deletions(-)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
Date: Mon, 27 Jul 2015 21:41:09 -0700
Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
The main goal of this series is to get rid of a needless typedef
in the rtl8712 wlan driver.
In the course of fixing that, I found a bug that can (at least in theory)
lead to a overrun during a memcpy, as well as an identical struct with
a different name, which use the typedef.
Finally after cleaning up the typedef, change the name of the primary
variable that used the typedef from "SupportedRates" to "rates", to
conform to kernel coding style.
Changes since V1:
Do not make other logic changes while Changing the name of SupportedRates
New patch 3/6 fixes a buggy comment that referred to the typedef
Changes sinve V2:
broke former patch 4, which was too big for git-send-email into 3 parts
Joshua Clayton (8):
staging: rtl8712: fix buggy size calculation
staging: rtl8712: simplify size calculation
staging: rtl8712: fix comment
staging: rtl8712: removed unused wrapper structs
staging: rtl8712: remove duplicate struct
staging: rtl8712: rename function
staging: rtl8712: remove typedefs
staging: rtl8712: change SupportedRates to rates
drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
drivers/staging/rtl8712/rtl871x_event.h | 2 +-
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
9 files changed, 64 insertions(+), 139 deletions(-)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
Date: Mon, 27 Jul 2015 21:41:09 -0700
Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
The main goal of this series is to get rid of a needless typedef
in the rtl8712 wlan driver.
In the course of fixing that, I found a bug that can (at least in theory)
lead to a overrun during a memcpy, as well as an identical struct with
a different name, which use the typedef.
Finally after cleaning up the typedef, change the name of the primary
variable that used the typedef from "SupportedRates" to "rates", to
conform to kernel coding style.
Changes since V1:
Do not make other logic changes while Changing the name of SupportedRates
New patch 3/6 fixes a buggy comment that referred to the typedef
Changes sinve V2:
broke former patch 4, which was too big for git-send-email into 3 parts
Joshua Clayton (8):
staging: rtl8712: fix buggy size calculation
staging: rtl8712: simplify size calculation
staging: rtl8712: fix comment
staging: rtl8712: removed unused wrapper structs
staging: rtl8712: remove duplicate struct
staging: rtl8712: rename function
staging: rtl8712: remove typedefs
staging: rtl8712: change SupportedRates to rates
drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
drivers/staging/rtl8712/rtl871x_event.h | 2 +-
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
9 files changed, 64 insertions(+), 139 deletions(-)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
Date: Mon, 27 Jul 2015 21:41:09 -0700
Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
The main goal of this series is to get rid of a needless typedef
in the rtl8712 wlan driver.
In the course of fixing that, I found a bug that can (at least in theory)
lead to a overrun during a memcpy, as well as an identical struct with
a different name, which use the typedef.
Finally after cleaning up the typedef, change the name of the primary
variable that used the typedef from "SupportedRates" to "rates", to
conform to kernel coding style.
Changes since V1:
Do not make other logic changes while Changing the name of SupportedRates
New patch 3/6 fixes a buggy comment that referred to the typedef
Changes sinve V2:
broke former patch 4, which was too big for git-send-email into 3 parts
Joshua Clayton (8):
staging: rtl8712: fix buggy size calculation
staging: rtl8712: simplify size calculation
staging: rtl8712: fix comment
staging: rtl8712: removed unused wrapper structs
staging: rtl8712: remove duplicate struct
staging: rtl8712: rename function
staging: rtl8712: remove typedefs
staging: rtl8712: change SupportedRates to rates
drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
drivers/staging/rtl8712/rtl871x_event.h | 2 +-
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
9 files changed, 64 insertions(+), 139 deletions(-)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
Date: Mon, 27 Jul 2015 21:41:09 -0700
Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
The main goal of this series is to get rid of a needless typedef
in the rtl8712 wlan driver.
In the course of fixing that, I found a bug that can (at least in theory)
lead to a overrun during a memcpy, as well as an identical struct with
a different name, which use the typedef.
Finally after cleaning up the typedef, change the name of the primary
variable that used the typedef from "SupportedRates" to "rates", to
conform to kernel coding style.
Changes since V1:
Do not make other logic changes while Changing the name of SupportedRates
New patch 3/6 fixes a buggy comment that referred to the typedef
Changes sinve V2:
broke former patch 4, which was too big for git-send-email into 3 parts
Joshua Clayton (8):
staging: rtl8712: fix buggy size calculation
staging: rtl8712: simplify size calculation
staging: rtl8712: fix comment
staging: rtl8712: removed unused wrapper structs
staging: rtl8712: remove duplicate struct
staging: rtl8712: rename function
staging: rtl8712: remove typedefs
staging: rtl8712: change SupportedRates to rates
drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
drivers/staging/rtl8712/rtl871x_event.h | 2 +-
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
9 files changed, 64 insertions(+), 139 deletions(-)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
Date: Mon, 27 Jul 2015 21:41:09 -0700
Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
The main goal of this series is to get rid of a needless typedef
in the rtl8712 wlan driver.
In the course of fixing that, I found a bug that can (at least in theory)
lead to a overrun during a memcpy, as well as an identical struct with
a different name, which use the typedef.
Finally after cleaning up the typedef, change the name of the primary
variable that used the typedef from "SupportedRates" to "rates", to
conform to kernel coding style.
Changes since V1:
Do not make other logic changes while Changing the name of SupportedRates
New patch 3/6 fixes a buggy comment that referred to the typedef
Changes sinve V2:
broke former patch 4, which was too big for git-send-email into 3 parts
Joshua Clayton (8):
staging: rtl8712: fix buggy size calculation
staging: rtl8712: simplify size calculation
staging: rtl8712: fix comment
staging: rtl8712: removed unused wrapper structs
staging: rtl8712: remove duplicate struct
staging: rtl8712: rename function
staging: rtl8712: remove typedefs
staging: rtl8712: change SupportedRates to rates
drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
drivers/staging/rtl8712/rtl871x_event.h | 2 +-
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
9 files changed, 64 insertions(+), 139 deletions(-)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
Date: Mon, 27 Jul 2015 21:41:09 -0700
Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
The main goal of this series is to get rid of a needless typedef
in the rtl8712 wlan driver.
In the course of fixing that, I found a bug that can (at least in theory)
lead to a overrun during a memcpy, as well as an identical struct with
a different name, which use the typedef.
Finally after cleaning up the typedef, change the name of the primary
variable that used the typedef from "SupportedRates" to "rates", to
conform to kernel coding style.
Changes since V1:
Do not make other logic changes while Changing the name of SupportedRates
New patch 3/6 fixes a buggy comment that referred to the typedef
Changes sinve V2:
broke former patch 4, which was too big for git-send-email into 3 parts
Joshua Clayton (8):
staging: rtl8712: fix buggy size calculation
staging: rtl8712: simplify size calculation
staging: rtl8712: fix comment
staging: rtl8712: removed unused wrapper structs
staging: rtl8712: remove duplicate struct
staging: rtl8712: rename function
staging: rtl8712: remove typedefs
staging: rtl8712: change SupportedRates to rates
drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
drivers/staging/rtl8712/rtl871x_event.h | 2 +-
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
9 files changed, 64 insertions(+), 139 deletions(-)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
Date: Mon, 27 Jul 2015 21:41:09 -0700
Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
The main goal of this series is to get rid of a needless typedef
in the rtl8712 wlan driver.
In the course of fixing that, I found a bug that can (at least in theory)
lead to a overrun during a memcpy, as well as an identical struct with
a different name, which use the typedef.
Finally after cleaning up the typedef, change the name of the primary
variable that used the typedef from "SupportedRates" to "rates", to
conform to kernel coding style.
Changes since V1:
Do not make other logic changes while Changing the name of SupportedRates
New patch 3/6 fixes a buggy comment that referred to the typedef
Changes sinve V2:
broke former patch 4, which was too big for git-send-email into 3 parts
Joshua Clayton (8):
staging: rtl8712: fix buggy size calculation
staging: rtl8712: simplify size calculation
staging: rtl8712: fix comment
staging: rtl8712: removed unused wrapper structs
staging: rtl8712: remove duplicate struct
staging: rtl8712: rename function
staging: rtl8712: remove typedefs
staging: rtl8712: change SupportedRates to rates
drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
drivers/staging/rtl8712/rtl871x_event.h | 2 +-
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
9 files changed, 64 insertions(+), 139 deletions(-)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
Date: Mon, 27 Jul 2015 21:41:09 -0700
Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
The main goal of this series is to get rid of a needless typedef
in the rtl8712 wlan driver.
In the course of fixing that, I found a bug that can (at least in theory)
lead to a overrun during a memcpy, as well as an identical struct with
a different name, which use the typedef.
Finally after cleaning up the typedef, change the name of the primary
variable that used the typedef from "SupportedRates" to "rates", to
conform to kernel coding style.
Changes since V1:
Do not make other logic changes while Changing the name of SupportedRates
New patch 3/6 fixes a buggy comment that referred to the typedef
Changes sinve V2:
broke former patch 4, which was too big for git-send-email into 3 parts
Joshua Clayton (8):
staging: rtl8712: fix buggy size calculation
staging: rtl8712: simplify size calculation
staging: rtl8712: fix comment
staging: rtl8712: removed unused wrapper structs
staging: rtl8712: remove duplicate struct
staging: rtl8712: rename function
staging: rtl8712: remove typedefs
staging: rtl8712: change SupportedRates to rates
drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
drivers/staging/rtl8712/rtl871x_event.h | 2 +-
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
9 files changed, 64 insertions(+), 139 deletions(-)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
Date: Mon, 27 Jul 2015 21:41:09 -0700
Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
The main goal of this series is to get rid of a needless typedef
in the rtl8712 wlan driver.
In the course of fixing that, I found a bug that can (at least in theory)
lead to a overrun during a memcpy, as well as an identical struct with
a different name, which use the typedef.
Finally after cleaning up the typedef, change the name of the primary
variable that used the typedef from "SupportedRates" to "rates", to
conform to kernel coding style.
Changes since V1:
Do not make other logic changes while Changing the name of SupportedRates
New patch 3/6 fixes a buggy comment that referred to the typedef
Changes sinve V2:
broke former patch 4, which was too big for git-send-email into 3 parts
Joshua Clayton (8):
staging: rtl8712: fix buggy size calculation
staging: rtl8712: simplify size calculation
staging: rtl8712: fix comment
staging: rtl8712: removed unused wrapper structs
staging: rtl8712: remove duplicate struct
staging: rtl8712: rename function
staging: rtl8712: remove typedefs
staging: rtl8712: change SupportedRates to rates
drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
drivers/staging/rtl8712/rtl871x_event.h | 2 +-
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
9 files changed, 64 insertions(+), 139 deletions(-)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
Date: Mon, 27 Jul 2015 21:41:09 -0700
Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
The main goal of this series is to get rid of a needless typedef
in the rtl8712 wlan driver.
In the course of fixing that, I found a bug that can (at least in theory)
lead to a overrun during a memcpy, as well as an identical struct with
a different name, which use the typedef.
Finally after cleaning up the typedef, change the name of the primary
variable that used the typedef from "SupportedRates" to "rates", to
conform to kernel coding style.
Changes since V1:
Do not make other logic changes while Changing the name of SupportedRates
New patch 3/6 fixes a buggy comment that referred to the typedef
Changes sinve V2:
broke former patch 4, which was too big for git-send-email into 3 parts
Joshua Clayton (8):
staging: rtl8712: fix buggy size calculation
staging: rtl8712: simplify size calculation
staging: rtl8712: fix comment
staging: rtl8712: removed unused wrapper structs
staging: rtl8712: remove duplicate struct
staging: rtl8712: rename function
staging: rtl8712: remove typedefs
staging: rtl8712: change SupportedRates to rates
drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
drivers/staging/rtl8712/rtl871x_event.h | 2 +-
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
9 files changed, 64 insertions(+), 139 deletions(-)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
Date: Mon, 27 Jul 2015 21:41:09 -0700
Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
The main goal of this series is to get rid of a needless typedef
in the rtl8712 wlan driver.
In the course of fixing that, I found a bug that can (at least in theory)
lead to a overrun during a memcpy, as well as an identical struct with
a different name, which use the typedef.
Finally after cleaning up the typedef, change the name of the primary
variable that used the typedef from "SupportedRates" to "rates", to
conform to kernel coding style.
Changes since V1:
Do not make other logic changes while Changing the name of SupportedRates
New patch 3/6 fixes a buggy comment that referred to the typedef
Changes sinve V2:
broke former patch 4, which was too big for git-send-email into 3 parts
Joshua Clayton (8):
staging: rtl8712: fix buggy size calculation
staging: rtl8712: simplify size calculation
staging: rtl8712: fix comment
staging: rtl8712: removed unused wrapper structs
staging: rtl8712: remove duplicate struct
staging: rtl8712: rename function
staging: rtl8712: remove typedefs
staging: rtl8712: change SupportedRates to rates
drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
drivers/staging/rtl8712/rtl871x_event.h | 2 +-
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
9 files changed, 64 insertions(+), 139 deletions(-)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
Date: Mon, 27 Jul 2015 21:41:09 -0700
Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
The main goal of this series is to get rid of a needless typedef
in the rtl8712 wlan driver.
In the course of fixing that, I found a bug that can (at least in theory)
lead to a overrun during a memcpy, as well as an identical struct with
a different name, which use the typedef.
Finally after cleaning up the typedef, change the name of the primary
variable that used the typedef from "SupportedRates" to "rates", to
conform to kernel coding style.
Changes since V1:
Do not make other logic changes while Changing the name of SupportedRates
New patch 3/6 fixes a buggy comment that referred to the typedef
Changes sinve V2:
broke former patch 4, which was too big for git-send-email into 3 parts
Joshua Clayton (8):
staging: rtl8712: fix buggy size calculation
staging: rtl8712: simplify size calculation
staging: rtl8712: fix comment
staging: rtl8712: removed unused wrapper structs
staging: rtl8712: remove duplicate struct
staging: rtl8712: rename function
staging: rtl8712: remove typedefs
staging: rtl8712: change SupportedRates to rates
drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
drivers/staging/rtl8712/rtl871x_event.h | 2 +-
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
9 files changed, 64 insertions(+), 139 deletions(-)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
Date: Mon, 27 Jul 2015 21:41:09 -0700
Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
The main goal of this series is to get rid of a needless typedef
in the rtl8712 wlan driver.
In the course of fixing that, I found a bug that can (at least in theory)
lead to a overrun during a memcpy, as well as an identical struct with
a different name, which use the typedef.
Finally after cleaning up the typedef, change the name of the primary
variable that used the typedef from "SupportedRates" to "rates", to
conform to kernel coding style.
Changes since V1:
Do not make other logic changes while Changing the name of SupportedRates
New patch 3/6 fixes a buggy comment that referred to the typedef
Changes sinve V2:
broke former patch 4, which was too big for git-send-email into 3 parts
Joshua Clayton (8):
staging: rtl8712: fix buggy size calculation
staging: rtl8712: simplify size calculation
staging: rtl8712: fix comment
staging: rtl8712: removed unused wrapper structs
staging: rtl8712: remove duplicate struct
staging: rtl8712: rename function
staging: rtl8712: remove typedefs
staging: rtl8712: change SupportedRates to rates
drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
drivers/staging/rtl8712/rtl871x_event.h | 2 +-
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
9 files changed, 64 insertions(+), 139 deletions(-)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
Date: Mon, 27 Jul 2015 21:41:09 -0700
Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
The main goal of this series is to get rid of a needless typedef
in the rtl8712 wlan driver.
In the course of fixing that, I found a bug that can (at least in theory)
lead to a overrun during a memcpy, as well as an identical struct with
a different name, which use the typedef.
Finally after cleaning up the typedef, change the name of the primary
variable that used the typedef from "SupportedRates" to "rates", to
conform to kernel coding style.
Changes since V1:
Do not make other logic changes while Changing the name of SupportedRates
New patch 3/6 fixes a buggy comment that referred to the typedef
Changes sinve V2:
broke former patch 4, which was too big for git-send-email into 3 parts
Joshua Clayton (8):
staging: rtl8712: fix buggy size calculation
staging: rtl8712: simplify size calculation
staging: rtl8712: fix comment
staging: rtl8712: removed unused wrapper structs
staging: rtl8712: remove duplicate struct
staging: rtl8712: rename function
staging: rtl8712: remove typedefs
staging: rtl8712: change SupportedRates to rates
drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
drivers/staging/rtl8712/rtl871x_event.h | 2 +-
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
9 files changed, 64 insertions(+), 139 deletions(-)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
Date: Mon, 27 Jul 2015 21:41:09 -0700
Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
The main goal of this series is to get rid of a needless typedef
in the rtl8712 wlan driver.
In the course of fixing that, I found a bug that can (at least in theory)
lead to a overrun during a memcpy, as well as an identical struct with
a different name, which use the typedef.
Finally after cleaning up the typedef, change the name of the primary
variable that used the typedef from "SupportedRates" to "rates", to
conform to kernel coding style.
Changes since V1:
Do not make other logic changes while Changing the name of SupportedRates
New patch 3/6 fixes a buggy comment that referred to the typedef
Changes sinve V2:
broke former patch 4, which was too big for git-send-email into 3 parts
Joshua Clayton (8):
staging: rtl8712: fix buggy size calculation
staging: rtl8712: simplify size calculation
staging: rtl8712: fix comment
staging: rtl8712: removed unused wrapper structs
staging: rtl8712: remove duplicate struct
staging: rtl8712: rename function
staging: rtl8712: remove typedefs
staging: rtl8712: change SupportedRates to rates
drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
drivers/staging/rtl8712/rtl871x_event.h | 2 +-
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
9 files changed, 64 insertions(+), 139 deletions(-)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
Date: Mon, 27 Jul 2015 21:41:09 -0700
Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
The main goal of this series is to get rid of a needless typedef
in the rtl8712 wlan driver.
In the course of fixing that, I found a bug that can (at least in theory)
lead to a overrun during a memcpy, as well as an identical struct with
a different name, which use the typedef.
Finally after cleaning up the typedef, change the name of the primary
variable that used the typedef from "SupportedRates" to "rates", to
conform to kernel coding style.
Changes since V1:
Do not make other logic changes while Changing the name of SupportedRates
New patch 3/6 fixes a buggy comment that referred to the typedef
Changes sinve V2:
broke former patch 4, which was too big for git-send-email into 3 parts
Joshua Clayton (8):
staging: rtl8712: fix buggy size calculation
staging: rtl8712: simplify size calculation
staging: rtl8712: fix comment
staging: rtl8712: removed unused wrapper structs
staging: rtl8712: remove duplicate struct
staging: rtl8712: rename function
staging: rtl8712: remove typedefs
staging: rtl8712: change SupportedRates to rates
drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
drivers/staging/rtl8712/rtl871x_event.h | 2 +-
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
9 files changed, 64 insertions(+), 139 deletions(-)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
Date: Mon, 27 Jul 2015 21:41:09 -0700
Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
The main goal of this series is to get rid of a needless typedef
in the rtl8712 wlan driver.
In the course of fixing that, I found a bug that can (at least in theory)
lead to a overrun during a memcpy, as well as an identical struct with
a different name, which use the typedef.
Finally after cleaning up the typedef, change the name of the primary
variable that used the typedef from "SupportedRates" to "rates", to
conform to kernel coding style.
Changes since V1:
Do not make other logic changes while Changing the name of SupportedRates
New patch 3/6 fixes a buggy comment that referred to the typedef
Changes sinve V2:
broke former patch 4, which was too big for git-send-email into 3 parts
Joshua Clayton (8):
staging: rtl8712: fix buggy size calculation
staging: rtl8712: simplify size calculation
staging: rtl8712: fix comment
staging: rtl8712: removed unused wrapper structs
staging: rtl8712: remove duplicate struct
staging: rtl8712: rename function
staging: rtl8712: remove typedefs
staging: rtl8712: change SupportedRates to rates
drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
drivers/staging/rtl8712/rtl871x_event.h | 2 +-
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
9 files changed, 64 insertions(+), 139 deletions(-)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
Date: Mon, 27 Jul 2015 21:41:09 -0700
Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
The main goal of this series is to get rid of a needless typedef
in the rtl8712 wlan driver.
In the course of fixing that, I found a bug that can (at least in theory)
lead to a overrun during a memcpy, as well as an identical struct with
a different name, which use the typedef.
Finally after cleaning up the typedef, change the name of the primary
variable that used the typedef from "SupportedRates" to "rates", to
conform to kernel coding style.
Changes since V1:
Do not make other logic changes while Changing the name of SupportedRates
New patch 3/6 fixes a buggy comment that referred to the typedef
Changes sinve V2:
broke former patch 4, which was too big for git-send-email into 3 parts
Joshua Clayton (8):
staging: rtl8712: fix buggy size calculation
staging: rtl8712: simplify size calculation
staging: rtl8712: fix comment
staging: rtl8712: removed unused wrapper structs
staging: rtl8712: remove duplicate struct
staging: rtl8712: rename function
staging: rtl8712: remove typedefs
staging: rtl8712: change SupportedRates to rates
drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
drivers/staging/rtl8712/rtl871x_event.h | 2 +-
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
9 files changed, 64 insertions(+), 139 deletions(-)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
Date: Mon, 27 Jul 2015 21:41:09 -0700
Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
The main goal of this series is to get rid of a needless typedef
in the rtl8712 wlan driver.
In the course of fixing that, I found a bug that can (at least in theory)
lead to a overrun during a memcpy, as well as an identical struct with
a different name, which use the typedef.
Finally after cleaning up the typedef, change the name of the primary
variable that used the typedef from "SupportedRates" to "rates", to
conform to kernel coding style.
Changes since V1:
Do not make other logic changes while Changing the name of SupportedRates
New patch 3/6 fixes a buggy comment that referred to the typedef
Changes sinve V2:
broke former patch 4, which was too big for git-send-email into 3 parts
Joshua Clayton (8):
staging: rtl8712: fix buggy size calculation
staging: rtl8712: simplify size calculation
staging: rtl8712: fix comment
staging: rtl8712: removed unused wrapper structs
staging: rtl8712: remove duplicate struct
staging: rtl8712: rename function
staging: rtl8712: remove typedefs
staging: rtl8712: change SupportedRates to rates
drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
drivers/staging/rtl8712/rtl871x_event.h | 2 +-
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
9 files changed, 64 insertions(+), 139 deletions(-)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
Date: Mon, 27 Jul 2015 21:41:09 -0700
Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
The main goal of this series is to get rid of a needless typedef
in the rtl8712 wlan driver.
In the course of fixing that, I found a bug that can (at least in theory)
lead to a overrun during a memcpy, as well as an identical struct with
a different name, which use the typedef.
Finally after cleaning up the typedef, change the name of the primary
variable that used the typedef from "SupportedRates" to "rates", to
conform to kernel coding style.
Changes since V1:
Do not make other logic changes while Changing the name of SupportedRates
New patch 3/6 fixes a buggy comment that referred to the typedef
Changes sinve V2:
broke former patch 4, which was too big for git-send-email into 3 parts
Joshua Clayton (8):
staging: rtl8712: fix buggy size calculation
staging: rtl8712: simplify size calculation
staging: rtl8712: fix comment
staging: rtl8712: removed unused wrapper structs
staging: rtl8712: remove duplicate struct
staging: rtl8712: rename function
staging: rtl8712: remove typedefs
staging: rtl8712: change SupportedRates to rates
drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
drivers/staging/rtl8712/rtl871x_event.h | 2 +-
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
9 files changed, 64 insertions(+), 139 deletions(-)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
Date: Mon, 27 Jul 2015 21:41:09 -0700
Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
The main goal of this series is to get rid of a needless typedef
in the rtl8712 wlan driver.
In the course of fixing that, I found a bug that can (at least in theory)
lead to a overrun during a memcpy, as well as an identical struct with
a different name, which use the typedef.
Finally after cleaning up the typedef, change the name of the primary
variable that used the typedef from "SupportedRates" to "rates", to
conform to kernel coding style.
Changes since V1:
Do not make other logic changes while Changing the name of SupportedRates
New patch 3/6 fixes a buggy comment that referred to the typedef
Changes sinve V2:
broke former patch 4, which was too big for git-send-email into 3 parts
Joshua Clayton (8):
staging: rtl8712: fix buggy size calculation
staging: rtl8712: simplify size calculation
staging: rtl8712: fix comment
staging: rtl8712: removed unused wrapper structs
staging: rtl8712: remove duplicate struct
staging: rtl8712: rename function
staging: rtl8712: remove typedefs
staging: rtl8712: change SupportedRates to rates
drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
drivers/staging/rtl8712/rtl871x_event.h | 2 +-
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
9 files changed, 64 insertions(+), 139 deletions(-)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
Date: Mon, 27 Jul 2015 21:41:09 -0700
Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
The main goal of this series is to get rid of a needless typedef
in the rtl8712 wlan driver.
In the course of fixing that, I found a bug that can (at least in theory)
lead to a overrun during a memcpy, as well as an identical struct with
a different name, which use the typedef.
Finally after cleaning up the typedef, change the name of the primary
variable that used the typedef from "SupportedRates" to "rates", to
conform to kernel coding style.
Changes since V1:
Do not make other logic changes while Changing the name of SupportedRates
New patch 3/6 fixes a buggy comment that referred to the typedef
Changes sinve V2:
broke former patch 4, which was too big for git-send-email into 3 parts
Joshua Clayton (8):
staging: rtl8712: fix buggy size calculation
staging: rtl8712: simplify size calculation
staging: rtl8712: fix comment
staging: rtl8712: removed unused wrapper structs
staging: rtl8712: remove duplicate struct
staging: rtl8712: rename function
staging: rtl8712: remove typedefs
staging: rtl8712: change SupportedRates to rates
drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
drivers/staging/rtl8712/rtl871x_event.h | 2 +-
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
9 files changed, 64 insertions(+), 139 deletions(-)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
Date: Mon, 27 Jul 2015 21:41:09 -0700
Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
The main goal of this series is to get rid of a needless typedef
in the rtl8712 wlan driver.
In the course of fixing that, I found a bug that can (at least in theory)
lead to a overrun during a memcpy, as well as an identical struct with
a different name, which use the typedef.
Finally after cleaning up the typedef, change the name of the primary
variable that used the typedef from "SupportedRates" to "rates", to
conform to kernel coding style.
Changes since V1:
Do not make other logic changes while Changing the name of SupportedRates
New patch 3/6 fixes a buggy comment that referred to the typedef
Changes sinve V2:
broke former patch 4, which was too big for git-send-email into 3 parts
Joshua Clayton (8):
staging: rtl8712: fix buggy size calculation
staging: rtl8712: simplify size calculation
staging: rtl8712: fix comment
staging: rtl8712: removed unused wrapper structs
staging: rtl8712: remove duplicate struct
staging: rtl8712: rename function
staging: rtl8712: remove typedefs
staging: rtl8712: change SupportedRates to rates
drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
drivers/staging/rtl8712/rtl871x_event.h | 2 +-
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
9 files changed, 64 insertions(+), 139 deletions(-)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
Date: Mon, 27 Jul 2015 21:41:09 -0700
Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
The main goal of this series is to get rid of a needless typedef
in the rtl8712 wlan driver.
In the course of fixing that, I found a bug that can (at least in theory)
lead to a overrun during a memcpy, as well as an identical struct with
a different name, which use the typedef.
Finally after cleaning up the typedef, change the name of the primary
variable that used the typedef from "SupportedRates" to "rates", to
conform to kernel coding style.
Changes since V1:
Do not make other logic changes while Changing the name of SupportedRates
New patch 3/6 fixes a buggy comment that referred to the typedef
Changes sinve V2:
broke former patch 4, which was too big for git-send-email into 3 parts
Joshua Clayton (8):
staging: rtl8712: fix buggy size calculation
staging: rtl8712: simplify size calculation
staging: rtl8712: fix comment
staging: rtl8712: removed unused wrapper structs
staging: rtl8712: remove duplicate struct
staging: rtl8712: rename function
staging: rtl8712: remove typedefs
staging: rtl8712: change SupportedRates to rates
drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
drivers/staging/rtl8712/rtl871x_event.h | 2 +-
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
9 files changed, 64 insertions(+), 139 deletions(-)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
Date: Mon, 27 Jul 2015 21:41:09 -0700
Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
The main goal of this series is to get rid of a needless typedef
in the rtl8712 wlan driver.
In the course of fixing that, I found a bug that can (at least in theory)
lead to a overrun during a memcpy, as well as an identical struct with
a different name, which use the typedef.
Finally after cleaning up the typedef, change the name of the primary
variable that used the typedef from "SupportedRates" to "rates", to
conform to kernel coding style.
Changes since V1:
Do not make other logic changes while Changing the name of SupportedRates
New patch 3/6 fixes a buggy comment that referred to the typedef
Changes sinve V2:
broke former patch 4, which was too big for git-send-email into 3 parts
Joshua Clayton (8):
staging: rtl8712: fix buggy size calculation
staging: rtl8712: simplify size calculation
staging: rtl8712: fix comment
staging: rtl8712: removed unused wrapper structs
staging: rtl8712: remove duplicate struct
staging: rtl8712: rename function
staging: rtl8712: remove typedefs
staging: rtl8712: change SupportedRates to rates
drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
drivers/staging/rtl8712/rtl871x_event.h | 2 +-
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
9 files changed, 64 insertions(+), 139 deletions(-)
--
2.4.6
^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH V3 1/8] staging: rtl8712: fix buggy size calculation
2015-07-28 4:41 [PATCH V3 0/8] clean up wlan_bssdef.h Joshua Clayton
@ 2015-07-28 4:41 ` Joshua Clayton
2015-07-28 11:46 ` Sudip Mukherjee
2015-07-28 4:41 ` [PATCH V3 2/8] staging: rtl8712: simplify " Joshua Clayton
` (15 subsequent siblings)
16 siblings, 1 reply; 27+ messages in thread
From: Joshua Clayton @ 2015-07-28 4:41 UTC (permalink / raw)
To: Larry Finger, Florian Schilhabel, Greg Kroah-Hartman,
Sudip Mukherjee, Nitin Kuppelur, Joshua Clayton,
Vaishali Thakkar, Tapasweni Pathak, Daniel Baluta,
Melike Yurtoglu, Max Perepelitsyn, Aya Mahfouz,
Cristina Opriceana, Dogukan Ergun, Julia Lawall, Dan Carpenter,
Haneen Mohammed, Rickard Strandqvist
Cc: devel, linux-kernel
r8712_get_ndis_wlan_bssid_ex_sz has a "6 * sizeof(unsigned long)"
where the underlying struct has a 6 * unsigned char.
Simplify the calculation by just subtracting the variable part from
the size of the struct.
This also gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_mlme.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c b/drivers/staging/rtl8712/rtl871x_mlme.c
index c044b0e..6b3451f 100644
--- a/drivers/staging/rtl8712/rtl871x_mlme.c
+++ b/drivers/staging/rtl8712/rtl871x_mlme.c
@@ -210,17 +210,7 @@ void r8712_generate_random_ibss(u8 *pibss)
uint r8712_get_ndis_wlan_bssid_ex_sz(struct ndis_wlan_bssid_ex *bss)
{
- uint t_len;
-
- t_len = sizeof(u32) + 6 * sizeof(unsigned long) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + bss->IELength;
- return t_len;
+ return sizeof(*bss) + bss->IELength - MAX_IE_SZ;
}
u8 *r8712_get_capability_from_ie(u8 *ie)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 1/8] staging: rtl8712: fix buggy size calculation
Date: Mon, 27 Jul 2015 21:41:10 -0700
Message-Id: <305999598d7738feabdc8e5df5400b3e7be7f5ed.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
r8712_get_ndis_wlan_bssid_ex_sz has a "6 * sizeof(unsigned long)"
where the underlying struct has a 6 * unsigned char.
Simplify the calculation by just subtracting the variable part from
the size of the struct.
This also gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_mlme.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c b/drivers/staging/rtl8712/rtl871x_mlme.c
index c044b0e..6b3451f 100644
--- a/drivers/staging/rtl8712/rtl871x_mlme.c
+++ b/drivers/staging/rtl8712/rtl871x_mlme.c
@@ -210,17 +210,7 @@ void r8712_generate_random_ibss(u8 *pibss)
uint r8712_get_ndis_wlan_bssid_ex_sz(struct ndis_wlan_bssid_ex *bss)
{
- uint t_len;
-
- t_len = sizeof(u32) + 6 * sizeof(unsigned long) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + bss->IELength;
- return t_len;
+ return sizeof(*bss) + bss->IELength - MAX_IE_SZ;
}
u8 *r8712_get_capability_from_ie(u8 *ie)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 1/8] staging: rtl8712: fix buggy size calculation
Date: Mon, 27 Jul 2015 21:41:10 -0700
Message-Id: <305999598d7738feabdc8e5df5400b3e7be7f5ed.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
r8712_get_ndis_wlan_bssid_ex_sz has a "6 * sizeof(unsigned long)"
where the underlying struct has a 6 * unsigned char.
Simplify the calculation by just subtracting the variable part from
the size of the struct.
This also gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_mlme.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c b/drivers/staging/rtl8712/rtl871x_mlme.c
index c044b0e..6b3451f 100644
--- a/drivers/staging/rtl8712/rtl871x_mlme.c
+++ b/drivers/staging/rtl8712/rtl871x_mlme.c
@@ -210,17 +210,7 @@ void r8712_generate_random_ibss(u8 *pibss)
uint r8712_get_ndis_wlan_bssid_ex_sz(struct ndis_wlan_bssid_ex *bss)
{
- uint t_len;
-
- t_len = sizeof(u32) + 6 * sizeof(unsigned long) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + bss->IELength;
- return t_len;
+ return sizeof(*bss) + bss->IELength - MAX_IE_SZ;
}
u8 *r8712_get_capability_from_ie(u8 *ie)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 1/8] staging: rtl8712: fix buggy size calculation
Date: Mon, 27 Jul 2015 21:41:10 -0700
Message-Id: <305999598d7738feabdc8e5df5400b3e7be7f5ed.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
r8712_get_ndis_wlan_bssid_ex_sz has a "6 * sizeof(unsigned long)"
where the underlying struct has a 6 * unsigned char.
Simplify the calculation by just subtracting the variable part from
the size of the struct.
This also gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_mlme.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c b/drivers/staging/rtl8712/rtl871x_mlme.c
index c044b0e..6b3451f 100644
--- a/drivers/staging/rtl8712/rtl871x_mlme.c
+++ b/drivers/staging/rtl8712/rtl871x_mlme.c
@@ -210,17 +210,7 @@ void r8712_generate_random_ibss(u8 *pibss)
uint r8712_get_ndis_wlan_bssid_ex_sz(struct ndis_wlan_bssid_ex *bss)
{
- uint t_len;
-
- t_len = sizeof(u32) + 6 * sizeof(unsigned long) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + bss->IELength;
- return t_len;
+ return sizeof(*bss) + bss->IELength - MAX_IE_SZ;
}
u8 *r8712_get_capability_from_ie(u8 *ie)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 1/8] staging: rtl8712: fix buggy size calculation
Date: Mon, 27 Jul 2015 21:41:10 -0700
Message-Id: <305999598d7738feabdc8e5df5400b3e7be7f5ed.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
r8712_get_ndis_wlan_bssid_ex_sz has a "6 * sizeof(unsigned long)"
where the underlying struct has a 6 * unsigned char.
Simplify the calculation by just subtracting the variable part from
the size of the struct.
This also gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_mlme.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c b/drivers/staging/rtl8712/rtl871x_mlme.c
index c044b0e..6b3451f 100644
--- a/drivers/staging/rtl8712/rtl871x_mlme.c
+++ b/drivers/staging/rtl8712/rtl871x_mlme.c
@@ -210,17 +210,7 @@ void r8712_generate_random_ibss(u8 *pibss)
uint r8712_get_ndis_wlan_bssid_ex_sz(struct ndis_wlan_bssid_ex *bss)
{
- uint t_len;
-
- t_len = sizeof(u32) + 6 * sizeof(unsigned long) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + bss->IELength;
- return t_len;
+ return sizeof(*bss) + bss->IELength - MAX_IE_SZ;
}
u8 *r8712_get_capability_from_ie(u8 *ie)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 1/8] staging: rtl8712: fix buggy size calculation
Date: Mon, 27 Jul 2015 21:41:10 -0700
Message-Id: <305999598d7738feabdc8e5df5400b3e7be7f5ed.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
r8712_get_ndis_wlan_bssid_ex_sz has a "6 * sizeof(unsigned long)"
where the underlying struct has a 6 * unsigned char.
Simplify the calculation by just subtracting the variable part from
the size of the struct.
This also gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_mlme.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c b/drivers/staging/rtl8712/rtl871x_mlme.c
index c044b0e..6b3451f 100644
--- a/drivers/staging/rtl8712/rtl871x_mlme.c
+++ b/drivers/staging/rtl8712/rtl871x_mlme.c
@@ -210,17 +210,7 @@ void r8712_generate_random_ibss(u8 *pibss)
uint r8712_get_ndis_wlan_bssid_ex_sz(struct ndis_wlan_bssid_ex *bss)
{
- uint t_len;
-
- t_len = sizeof(u32) + 6 * sizeof(unsigned long) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + bss->IELength;
- return t_len;
+ return sizeof(*bss) + bss->IELength - MAX_IE_SZ;
}
u8 *r8712_get_capability_from_ie(u8 *ie)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 1/8] staging: rtl8712: fix buggy size calculation
Date: Mon, 27 Jul 2015 21:41:10 -0700
Message-Id: <305999598d7738feabdc8e5df5400b3e7be7f5ed.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
r8712_get_ndis_wlan_bssid_ex_sz has a "6 * sizeof(unsigned long)"
where the underlying struct has a 6 * unsigned char.
Simplify the calculation by just subtracting the variable part from
the size of the struct.
This also gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_mlme.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c b/drivers/staging/rtl8712/rtl871x_mlme.c
index c044b0e..6b3451f 100644
--- a/drivers/staging/rtl8712/rtl871x_mlme.c
+++ b/drivers/staging/rtl8712/rtl871x_mlme.c
@@ -210,17 +210,7 @@ void r8712_generate_random_ibss(u8 *pibss)
uint r8712_get_ndis_wlan_bssid_ex_sz(struct ndis_wlan_bssid_ex *bss)
{
- uint t_len;
-
- t_len = sizeof(u32) + 6 * sizeof(unsigned long) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + bss->IELength;
- return t_len;
+ return sizeof(*bss) + bss->IELength - MAX_IE_SZ;
}
u8 *r8712_get_capability_from_ie(u8 *ie)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 1/8] staging: rtl8712: fix buggy size calculation
Date: Mon, 27 Jul 2015 21:41:10 -0700
Message-Id: <305999598d7738feabdc8e5df5400b3e7be7f5ed.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
r8712_get_ndis_wlan_bssid_ex_sz has a "6 * sizeof(unsigned long)"
where the underlying struct has a 6 * unsigned char.
Simplify the calculation by just subtracting the variable part from
the size of the struct.
This also gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_mlme.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c b/drivers/staging/rtl8712/rtl871x_mlme.c
index c044b0e..6b3451f 100644
--- a/drivers/staging/rtl8712/rtl871x_mlme.c
+++ b/drivers/staging/rtl8712/rtl871x_mlme.c
@@ -210,17 +210,7 @@ void r8712_generate_random_ibss(u8 *pibss)
uint r8712_get_ndis_wlan_bssid_ex_sz(struct ndis_wlan_bssid_ex *bss)
{
- uint t_len;
-
- t_len = sizeof(u32) + 6 * sizeof(unsigned long) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + bss->IELength;
- return t_len;
+ return sizeof(*bss) + bss->IELength - MAX_IE_SZ;
}
u8 *r8712_get_capability_from_ie(u8 *ie)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 1/8] staging: rtl8712: fix buggy size calculation
Date: Mon, 27 Jul 2015 21:41:10 -0700
Message-Id: <305999598d7738feabdc8e5df5400b3e7be7f5ed.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
r8712_get_ndis_wlan_bssid_ex_sz has a "6 * sizeof(unsigned long)"
where the underlying struct has a 6 * unsigned char.
Simplify the calculation by just subtracting the variable part from
the size of the struct.
This also gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_mlme.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c b/drivers/staging/rtl8712/rtl871x_mlme.c
index c044b0e..6b3451f 100644
--- a/drivers/staging/rtl8712/rtl871x_mlme.c
+++ b/drivers/staging/rtl8712/rtl871x_mlme.c
@@ -210,17 +210,7 @@ void r8712_generate_random_ibss(u8 *pibss)
uint r8712_get_ndis_wlan_bssid_ex_sz(struct ndis_wlan_bssid_ex *bss)
{
- uint t_len;
-
- t_len = sizeof(u32) + 6 * sizeof(unsigned long) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + bss->IELength;
- return t_len;
+ return sizeof(*bss) + bss->IELength - MAX_IE_SZ;
}
u8 *r8712_get_capability_from_ie(u8 *ie)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 1/8] staging: rtl8712: fix buggy size calculation
Date: Mon, 27 Jul 2015 21:41:10 -0700
Message-Id: <305999598d7738feabdc8e5df5400b3e7be7f5ed.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
r8712_get_ndis_wlan_bssid_ex_sz has a "6 * sizeof(unsigned long)"
where the underlying struct has a 6 * unsigned char.
Simplify the calculation by just subtracting the variable part from
the size of the struct.
This also gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_mlme.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c b/drivers/staging/rtl8712/rtl871x_mlme.c
index c044b0e..6b3451f 100644
--- a/drivers/staging/rtl8712/rtl871x_mlme.c
+++ b/drivers/staging/rtl8712/rtl871x_mlme.c
@@ -210,17 +210,7 @@ void r8712_generate_random_ibss(u8 *pibss)
uint r8712_get_ndis_wlan_bssid_ex_sz(struct ndis_wlan_bssid_ex *bss)
{
- uint t_len;
-
- t_len = sizeof(u32) + 6 * sizeof(unsigned long) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + bss->IELength;
- return t_len;
+ return sizeof(*bss) + bss->IELength - MAX_IE_SZ;
}
u8 *r8712_get_capability_from_ie(u8 *ie)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 1/8] staging: rtl8712: fix buggy size calculation
Date: Mon, 27 Jul 2015 21:41:10 -0700
Message-Id: <305999598d7738feabdc8e5df5400b3e7be7f5ed.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
r8712_get_ndis_wlan_bssid_ex_sz has a "6 * sizeof(unsigned long)"
where the underlying struct has a 6 * unsigned char.
Simplify the calculation by just subtracting the variable part from
the size of the struct.
This also gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_mlme.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c b/drivers/staging/rtl8712/rtl871x_mlme.c
index c044b0e..6b3451f 100644
--- a/drivers/staging/rtl8712/rtl871x_mlme.c
+++ b/drivers/staging/rtl8712/rtl871x_mlme.c
@@ -210,17 +210,7 @@ void r8712_generate_random_ibss(u8 *pibss)
uint r8712_get_ndis_wlan_bssid_ex_sz(struct ndis_wlan_bssid_ex *bss)
{
- uint t_len;
-
- t_len = sizeof(u32) + 6 * sizeof(unsigned long) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + bss->IELength;
- return t_len;
+ return sizeof(*bss) + bss->IELength - MAX_IE_SZ;
}
u8 *r8712_get_capability_from_ie(u8 *ie)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 1/8] staging: rtl8712: fix buggy size calculation
Date: Mon, 27 Jul 2015 21:41:10 -0700
Message-Id: <305999598d7738feabdc8e5df5400b3e7be7f5ed.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
r8712_get_ndis_wlan_bssid_ex_sz has a "6 * sizeof(unsigned long)"
where the underlying struct has a 6 * unsigned char.
Simplify the calculation by just subtracting the variable part from
the size of the struct.
This also gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_mlme.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c b/drivers/staging/rtl8712/rtl871x_mlme.c
index c044b0e..6b3451f 100644
--- a/drivers/staging/rtl8712/rtl871x_mlme.c
+++ b/drivers/staging/rtl8712/rtl871x_mlme.c
@@ -210,17 +210,7 @@ void r8712_generate_random_ibss(u8 *pibss)
uint r8712_get_ndis_wlan_bssid_ex_sz(struct ndis_wlan_bssid_ex *bss)
{
- uint t_len;
-
- t_len = sizeof(u32) + 6 * sizeof(unsigned long) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + bss->IELength;
- return t_len;
+ return sizeof(*bss) + bss->IELength - MAX_IE_SZ;
}
u8 *r8712_get_capability_from_ie(u8 *ie)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 1/8] staging: rtl8712: fix buggy size calculation
Date: Mon, 27 Jul 2015 21:41:10 -0700
Message-Id: <305999598d7738feabdc8e5df5400b3e7be7f5ed.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
r8712_get_ndis_wlan_bssid_ex_sz has a "6 * sizeof(unsigned long)"
where the underlying struct has a 6 * unsigned char.
Simplify the calculation by just subtracting the variable part from
the size of the struct.
This also gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_mlme.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c b/drivers/staging/rtl8712/rtl871x_mlme.c
index c044b0e..6b3451f 100644
--- a/drivers/staging/rtl8712/rtl871x_mlme.c
+++ b/drivers/staging/rtl8712/rtl871x_mlme.c
@@ -210,17 +210,7 @@ void r8712_generate_random_ibss(u8 *pibss)
uint r8712_get_ndis_wlan_bssid_ex_sz(struct ndis_wlan_bssid_ex *bss)
{
- uint t_len;
-
- t_len = sizeof(u32) + 6 * sizeof(unsigned long) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + bss->IELength;
- return t_len;
+ return sizeof(*bss) + bss->IELength - MAX_IE_SZ;
}
u8 *r8712_get_capability_from_ie(u8 *ie)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 1/8] staging: rtl8712: fix buggy size calculation
Date: Mon, 27 Jul 2015 21:41:10 -0700
Message-Id: <305999598d7738feabdc8e5df5400b3e7be7f5ed.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
r8712_get_ndis_wlan_bssid_ex_sz has a "6 * sizeof(unsigned long)"
where the underlying struct has a 6 * unsigned char.
Simplify the calculation by just subtracting the variable part from
the size of the struct.
This also gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_mlme.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c b/drivers/staging/rtl8712/rtl871x_mlme.c
index c044b0e..6b3451f 100644
--- a/drivers/staging/rtl8712/rtl871x_mlme.c
+++ b/drivers/staging/rtl8712/rtl871x_mlme.c
@@ -210,17 +210,7 @@ void r8712_generate_random_ibss(u8 *pibss)
uint r8712_get_ndis_wlan_bssid_ex_sz(struct ndis_wlan_bssid_ex *bss)
{
- uint t_len;
-
- t_len = sizeof(u32) + 6 * sizeof(unsigned long) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + bss->IELength;
- return t_len;
+ return sizeof(*bss) + bss->IELength - MAX_IE_SZ;
}
u8 *r8712_get_capability_from_ie(u8 *ie)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 1/8] staging: rtl8712: fix buggy size calculation
Date: Mon, 27 Jul 2015 21:41:10 -0700
Message-Id: <305999598d7738feabdc8e5df5400b3e7be7f5ed.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
r8712_get_ndis_wlan_bssid_ex_sz has a "6 * sizeof(unsigned long)"
where the underlying struct has a 6 * unsigned char.
Simplify the calculation by just subtracting the variable part from
the size of the struct.
This also gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_mlme.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c b/drivers/staging/rtl8712/rtl871x_mlme.c
index c044b0e..6b3451f 100644
--- a/drivers/staging/rtl8712/rtl871x_mlme.c
+++ b/drivers/staging/rtl8712/rtl871x_mlme.c
@@ -210,17 +210,7 @@ void r8712_generate_random_ibss(u8 *pibss)
uint r8712_get_ndis_wlan_bssid_ex_sz(struct ndis_wlan_bssid_ex *bss)
{
- uint t_len;
-
- t_len = sizeof(u32) + 6 * sizeof(unsigned long) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + bss->IELength;
- return t_len;
+ return sizeof(*bss) + bss->IELength - MAX_IE_SZ;
}
u8 *r8712_get_capability_from_ie(u8 *ie)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 1/8] staging: rtl8712: fix buggy size calculation
Date: Mon, 27 Jul 2015 21:41:10 -0700
Message-Id: <305999598d7738feabdc8e5df5400b3e7be7f5ed.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
r8712_get_ndis_wlan_bssid_ex_sz has a "6 * sizeof(unsigned long)"
where the underlying struct has a 6 * unsigned char.
Simplify the calculation by just subtracting the variable part from
the size of the struct.
This also gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_mlme.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c b/drivers/staging/rtl8712/rtl871x_mlme.c
index c044b0e..6b3451f 100644
--- a/drivers/staging/rtl8712/rtl871x_mlme.c
+++ b/drivers/staging/rtl8712/rtl871x_mlme.c
@@ -210,17 +210,7 @@ void r8712_generate_random_ibss(u8 *pibss)
uint r8712_get_ndis_wlan_bssid_ex_sz(struct ndis_wlan_bssid_ex *bss)
{
- uint t_len;
-
- t_len = sizeof(u32) + 6 * sizeof(unsigned long) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + bss->IELength;
- return t_len;
+ return sizeof(*bss) + bss->IELength - MAX_IE_SZ;
}
u8 *r8712_get_capability_from_ie(u8 *ie)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 1/8] staging: rtl8712: fix buggy size calculation
Date: Mon, 27 Jul 2015 21:41:10 -0700
Message-Id: <305999598d7738feabdc8e5df5400b3e7be7f5ed.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
r8712_get_ndis_wlan_bssid_ex_sz has a "6 * sizeof(unsigned long)"
where the underlying struct has a 6 * unsigned char.
Simplify the calculation by just subtracting the variable part from
the size of the struct.
This also gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_mlme.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c b/drivers/staging/rtl8712/rtl871x_mlme.c
index c044b0e..6b3451f 100644
--- a/drivers/staging/rtl8712/rtl871x_mlme.c
+++ b/drivers/staging/rtl8712/rtl871x_mlme.c
@@ -210,17 +210,7 @@ void r8712_generate_random_ibss(u8 *pibss)
uint r8712_get_ndis_wlan_bssid_ex_sz(struct ndis_wlan_bssid_ex *bss)
{
- uint t_len;
-
- t_len = sizeof(u32) + 6 * sizeof(unsigned long) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + bss->IELength;
- return t_len;
+ return sizeof(*bss) + bss->IELength - MAX_IE_SZ;
}
u8 *r8712_get_capability_from_ie(u8 *ie)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 1/8] staging: rtl8712: fix buggy size calculation
Date: Mon, 27 Jul 2015 21:41:10 -0700
Message-Id: <305999598d7738feabdc8e5df5400b3e7be7f5ed.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
r8712_get_ndis_wlan_bssid_ex_sz has a "6 * sizeof(unsigned long)"
where the underlying struct has a 6 * unsigned char.
Simplify the calculation by just subtracting the variable part from
the size of the struct.
This also gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_mlme.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c b/drivers/staging/rtl8712/rtl871x_mlme.c
index c044b0e..6b3451f 100644
--- a/drivers/staging/rtl8712/rtl871x_mlme.c
+++ b/drivers/staging/rtl8712/rtl871x_mlme.c
@@ -210,17 +210,7 @@ void r8712_generate_random_ibss(u8 *pibss)
uint r8712_get_ndis_wlan_bssid_ex_sz(struct ndis_wlan_bssid_ex *bss)
{
- uint t_len;
-
- t_len = sizeof(u32) + 6 * sizeof(unsigned long) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + bss->IELength;
- return t_len;
+ return sizeof(*bss) + bss->IELength - MAX_IE_SZ;
}
u8 *r8712_get_capability_from_ie(u8 *ie)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 1/8] staging: rtl8712: fix buggy size calculation
Date: Mon, 27 Jul 2015 21:41:10 -0700
Message-Id: <305999598d7738feabdc8e5df5400b3e7be7f5ed.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
r8712_get_ndis_wlan_bssid_ex_sz has a "6 * sizeof(unsigned long)"
where the underlying struct has a 6 * unsigned char.
Simplify the calculation by just subtracting the variable part from
the size of the struct.
This also gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_mlme.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c b/drivers/staging/rtl8712/rtl871x_mlme.c
index c044b0e..6b3451f 100644
--- a/drivers/staging/rtl8712/rtl871x_mlme.c
+++ b/drivers/staging/rtl8712/rtl871x_mlme.c
@@ -210,17 +210,7 @@ void r8712_generate_random_ibss(u8 *pibss)
uint r8712_get_ndis_wlan_bssid_ex_sz(struct ndis_wlan_bssid_ex *bss)
{
- uint t_len;
-
- t_len = sizeof(u32) + 6 * sizeof(unsigned long) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + bss->IELength;
- return t_len;
+ return sizeof(*bss) + bss->IELength - MAX_IE_SZ;
}
u8 *r8712_get_capability_from_ie(u8 *ie)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 1/8] staging: rtl8712: fix buggy size calculation
Date: Mon, 27 Jul 2015 21:41:10 -0700
Message-Id: <305999598d7738feabdc8e5df5400b3e7be7f5ed.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
r8712_get_ndis_wlan_bssid_ex_sz has a "6 * sizeof(unsigned long)"
where the underlying struct has a 6 * unsigned char.
Simplify the calculation by just subtracting the variable part from
the size of the struct.
This also gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_mlme.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c b/drivers/staging/rtl8712/rtl871x_mlme.c
index c044b0e..6b3451f 100644
--- a/drivers/staging/rtl8712/rtl871x_mlme.c
+++ b/drivers/staging/rtl8712/rtl871x_mlme.c
@@ -210,17 +210,7 @@ void r8712_generate_random_ibss(u8 *pibss)
uint r8712_get_ndis_wlan_bssid_ex_sz(struct ndis_wlan_bssid_ex *bss)
{
- uint t_len;
-
- t_len = sizeof(u32) + 6 * sizeof(unsigned long) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + bss->IELength;
- return t_len;
+ return sizeof(*bss) + bss->IELength - MAX_IE_SZ;
}
u8 *r8712_get_capability_from_ie(u8 *ie)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 1/8] staging: rtl8712: fix buggy size calculation
Date: Mon, 27 Jul 2015 21:41:10 -0700
Message-Id: <305999598d7738feabdc8e5df5400b3e7be7f5ed.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
r8712_get_ndis_wlan_bssid_ex_sz has a "6 * sizeof(unsigned long)"
where the underlying struct has a 6 * unsigned char.
Simplify the calculation by just subtracting the variable part from
the size of the struct.
This also gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_mlme.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c b/drivers/staging/rtl8712/rtl871x_mlme.c
index c044b0e..6b3451f 100644
--- a/drivers/staging/rtl8712/rtl871x_mlme.c
+++ b/drivers/staging/rtl8712/rtl871x_mlme.c
@@ -210,17 +210,7 @@ void r8712_generate_random_ibss(u8 *pibss)
uint r8712_get_ndis_wlan_bssid_ex_sz(struct ndis_wlan_bssid_ex *bss)
{
- uint t_len;
-
- t_len = sizeof(u32) + 6 * sizeof(unsigned long) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + bss->IELength;
- return t_len;
+ return sizeof(*bss) + bss->IELength - MAX_IE_SZ;
}
u8 *r8712_get_capability_from_ie(u8 *ie)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 1/8] staging: rtl8712: fix buggy size calculation
Date: Mon, 27 Jul 2015 21:41:10 -0700
Message-Id: <305999598d7738feabdc8e5df5400b3e7be7f5ed.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
r8712_get_ndis_wlan_bssid_ex_sz has a "6 * sizeof(unsigned long)"
where the underlying struct has a 6 * unsigned char.
Simplify the calculation by just subtracting the variable part from
the size of the struct.
This also gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_mlme.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c b/drivers/staging/rtl8712/rtl871x_mlme.c
index c044b0e..6b3451f 100644
--- a/drivers/staging/rtl8712/rtl871x_mlme.c
+++ b/drivers/staging/rtl8712/rtl871x_mlme.c
@@ -210,17 +210,7 @@ void r8712_generate_random_ibss(u8 *pibss)
uint r8712_get_ndis_wlan_bssid_ex_sz(struct ndis_wlan_bssid_ex *bss)
{
- uint t_len;
-
- t_len = sizeof(u32) + 6 * sizeof(unsigned long) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + bss->IELength;
- return t_len;
+ return sizeof(*bss) + bss->IELength - MAX_IE_SZ;
}
u8 *r8712_get_capability_from_ie(u8 *ie)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 1/8] staging: rtl8712: fix buggy size calculation
Date: Mon, 27 Jul 2015 21:41:10 -0700
Message-Id: <305999598d7738feabdc8e5df5400b3e7be7f5ed.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
r8712_get_ndis_wlan_bssid_ex_sz has a "6 * sizeof(unsigned long)"
where the underlying struct has a 6 * unsigned char.
Simplify the calculation by just subtracting the variable part from
the size of the struct.
This also gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_mlme.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c b/drivers/staging/rtl8712/rtl871x_mlme.c
index c044b0e..6b3451f 100644
--- a/drivers/staging/rtl8712/rtl871x_mlme.c
+++ b/drivers/staging/rtl8712/rtl871x_mlme.c
@@ -210,17 +210,7 @@ void r8712_generate_random_ibss(u8 *pibss)
uint r8712_get_ndis_wlan_bssid_ex_sz(struct ndis_wlan_bssid_ex *bss)
{
- uint t_len;
-
- t_len = sizeof(u32) + 6 * sizeof(unsigned long) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + bss->IELength;
- return t_len;
+ return sizeof(*bss) + bss->IELength - MAX_IE_SZ;
}
u8 *r8712_get_capability_from_ie(u8 *ie)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 1/8] staging: rtl8712: fix buggy size calculation
Date: Mon, 27 Jul 2015 21:41:10 -0700
Message-Id: <305999598d7738feabdc8e5df5400b3e7be7f5ed.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
r8712_get_ndis_wlan_bssid_ex_sz has a "6 * sizeof(unsigned long)"
where the underlying struct has a 6 * unsigned char.
Simplify the calculation by just subtracting the variable part from
the size of the struct.
This also gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_mlme.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c b/drivers/staging/rtl8712/rtl871x_mlme.c
index c044b0e..6b3451f 100644
--- a/drivers/staging/rtl8712/rtl871x_mlme.c
+++ b/drivers/staging/rtl8712/rtl871x_mlme.c
@@ -210,17 +210,7 @@ void r8712_generate_random_ibss(u8 *pibss)
uint r8712_get_ndis_wlan_bssid_ex_sz(struct ndis_wlan_bssid_ex *bss)
{
- uint t_len;
-
- t_len = sizeof(u32) + 6 * sizeof(unsigned long) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + bss->IELength;
- return t_len;
+ return sizeof(*bss) + bss->IELength - MAX_IE_SZ;
}
u8 *r8712_get_capability_from_ie(u8 *ie)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 1/8] staging: rtl8712: fix buggy size calculation
Date: Mon, 27 Jul 2015 21:41:10 -0700
Message-Id: <305999598d7738feabdc8e5df5400b3e7be7f5ed.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
r8712_get_ndis_wlan_bssid_ex_sz has a "6 * sizeof(unsigned long)"
where the underlying struct has a 6 * unsigned char.
Simplify the calculation by just subtracting the variable part from
the size of the struct.
This also gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_mlme.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c b/drivers/staging/rtl8712/rtl871x_mlme.c
index c044b0e..6b3451f 100644
--- a/drivers/staging/rtl8712/rtl871x_mlme.c
+++ b/drivers/staging/rtl8712/rtl871x_mlme.c
@@ -210,17 +210,7 @@ void r8712_generate_random_ibss(u8 *pibss)
uint r8712_get_ndis_wlan_bssid_ex_sz(struct ndis_wlan_bssid_ex *bss)
{
- uint t_len;
-
- t_len = sizeof(u32) + 6 * sizeof(unsigned long) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + bss->IELength;
- return t_len;
+ return sizeof(*bss) + bss->IELength - MAX_IE_SZ;
}
u8 *r8712_get_capability_from_ie(u8 *ie)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 1/8] staging: rtl8712: fix buggy size calculation
Date: Mon, 27 Jul 2015 21:41:10 -0700
Message-Id: <305999598d7738feabdc8e5df5400b3e7be7f5ed.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
r8712_get_ndis_wlan_bssid_ex_sz has a "6 * sizeof(unsigned long)"
where the underlying struct has a 6 * unsigned char.
Simplify the calculation by just subtracting the variable part from
the size of the struct.
This also gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_mlme.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c b/drivers/staging/rtl8712/rtl871x_mlme.c
index c044b0e..6b3451f 100644
--- a/drivers/staging/rtl8712/rtl871x_mlme.c
+++ b/drivers/staging/rtl8712/rtl871x_mlme.c
@@ -210,17 +210,7 @@ void r8712_generate_random_ibss(u8 *pibss)
uint r8712_get_ndis_wlan_bssid_ex_sz(struct ndis_wlan_bssid_ex *bss)
{
- uint t_len;
-
- t_len = sizeof(u32) + 6 * sizeof(unsigned long) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + bss->IELength;
- return t_len;
+ return sizeof(*bss) + bss->IELength - MAX_IE_SZ;
}
u8 *r8712_get_capability_from_ie(u8 *ie)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 1/8] staging: rtl8712: fix buggy size calculation
Date: Mon, 27 Jul 2015 21:41:10 -0700
Message-Id: <305999598d7738feabdc8e5df5400b3e7be7f5ed.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
r8712_get_ndis_wlan_bssid_ex_sz has a "6 * sizeof(unsigned long)"
where the underlying struct has a 6 * unsigned char.
Simplify the calculation by just subtracting the variable part from
the size of the struct.
This also gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_mlme.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c b/drivers/staging/rtl8712/rtl871x_mlme.c
index c044b0e..6b3451f 100644
--- a/drivers/staging/rtl8712/rtl871x_mlme.c
+++ b/drivers/staging/rtl8712/rtl871x_mlme.c
@@ -210,17 +210,7 @@ void r8712_generate_random_ibss(u8 *pibss)
uint r8712_get_ndis_wlan_bssid_ex_sz(struct ndis_wlan_bssid_ex *bss)
{
- uint t_len;
-
- t_len = sizeof(u32) + 6 * sizeof(unsigned long) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + bss->IELength;
- return t_len;
+ return sizeof(*bss) + bss->IELength - MAX_IE_SZ;
}
u8 *r8712_get_capability_from_ie(u8 *ie)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 1/8] staging: rtl8712: fix buggy size calculation
Date: Mon, 27 Jul 2015 21:41:10 -0700
Message-Id: <305999598d7738feabdc8e5df5400b3e7be7f5ed.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
r8712_get_ndis_wlan_bssid_ex_sz has a "6 * sizeof(unsigned long)"
where the underlying struct has a 6 * unsigned char.
Simplify the calculation by just subtracting the variable part from
the size of the struct.
This also gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_mlme.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c b/drivers/staging/rtl8712/rtl871x_mlme.c
index c044b0e..6b3451f 100644
--- a/drivers/staging/rtl8712/rtl871x_mlme.c
+++ b/drivers/staging/rtl8712/rtl871x_mlme.c
@@ -210,17 +210,7 @@ void r8712_generate_random_ibss(u8 *pibss)
uint r8712_get_ndis_wlan_bssid_ex_sz(struct ndis_wlan_bssid_ex *bss)
{
- uint t_len;
-
- t_len = sizeof(u32) + 6 * sizeof(unsigned long) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + bss->IELength;
- return t_len;
+ return sizeof(*bss) + bss->IELength - MAX_IE_SZ;
}
u8 *r8712_get_capability_from_ie(u8 *ie)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 1/8] staging: rtl8712: fix buggy size calculation
Date: Mon, 27 Jul 2015 21:41:10 -0700
Message-Id: <305999598d7738feabdc8e5df5400b3e7be7f5ed.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
r8712_get_ndis_wlan_bssid_ex_sz has a "6 * sizeof(unsigned long)"
where the underlying struct has a 6 * unsigned char.
Simplify the calculation by just subtracting the variable part from
the size of the struct.
This also gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_mlme.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c b/drivers/staging/rtl8712/rtl871x_mlme.c
index c044b0e..6b3451f 100644
--- a/drivers/staging/rtl8712/rtl871x_mlme.c
+++ b/drivers/staging/rtl8712/rtl871x_mlme.c
@@ -210,17 +210,7 @@ void r8712_generate_random_ibss(u8 *pibss)
uint r8712_get_ndis_wlan_bssid_ex_sz(struct ndis_wlan_bssid_ex *bss)
{
- uint t_len;
-
- t_len = sizeof(u32) + 6 * sizeof(unsigned long) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + bss->IELength;
- return t_len;
+ return sizeof(*bss) + bss->IELength - MAX_IE_SZ;
}
u8 *r8712_get_capability_from_ie(u8 *ie)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 1/8] staging: rtl8712: fix buggy size calculation
Date: Mon, 27 Jul 2015 21:41:10 -0700
Message-Id: <305999598d7738feabdc8e5df5400b3e7be7f5ed.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
r8712_get_ndis_wlan_bssid_ex_sz has a "6 * sizeof(unsigned long)"
where the underlying struct has a 6 * unsigned char.
Simplify the calculation by just subtracting the variable part from
the size of the struct.
This also gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_mlme.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c b/drivers/staging/rtl8712/rtl871x_mlme.c
index c044b0e..6b3451f 100644
--- a/drivers/staging/rtl8712/rtl871x_mlme.c
+++ b/drivers/staging/rtl8712/rtl871x_mlme.c
@@ -210,17 +210,7 @@ void r8712_generate_random_ibss(u8 *pibss)
uint r8712_get_ndis_wlan_bssid_ex_sz(struct ndis_wlan_bssid_ex *bss)
{
- uint t_len;
-
- t_len = sizeof(u32) + 6 * sizeof(unsigned long) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + bss->IELength;
- return t_len;
+ return sizeof(*bss) + bss->IELength - MAX_IE_SZ;
}
u8 *r8712_get_capability_from_ie(u8 *ie)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 1/8] staging: rtl8712: fix buggy size calculation
Date: Mon, 27 Jul 2015 21:41:10 -0700
Message-Id: <305999598d7738feabdc8e5df5400b3e7be7f5ed.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
r8712_get_ndis_wlan_bssid_ex_sz has a "6 * sizeof(unsigned long)"
where the underlying struct has a 6 * unsigned char.
Simplify the calculation by just subtracting the variable part from
the size of the struct.
This also gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_mlme.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c b/drivers/staging/rtl8712/rtl871x_mlme.c
index c044b0e..6b3451f 100644
--- a/drivers/staging/rtl8712/rtl871x_mlme.c
+++ b/drivers/staging/rtl8712/rtl871x_mlme.c
@@ -210,17 +210,7 @@ void r8712_generate_random_ibss(u8 *pibss)
uint r8712_get_ndis_wlan_bssid_ex_sz(struct ndis_wlan_bssid_ex *bss)
{
- uint t_len;
-
- t_len = sizeof(u32) + 6 * sizeof(unsigned long) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + bss->IELength;
- return t_len;
+ return sizeof(*bss) + bss->IELength - MAX_IE_SZ;
}
u8 *r8712_get_capability_from_ie(u8 *ie)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 1/8] staging: rtl8712: fix buggy size calculation
Date: Mon, 27 Jul 2015 21:41:10 -0700
Message-Id: <305999598d7738feabdc8e5df5400b3e7be7f5ed.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
r8712_get_ndis_wlan_bssid_ex_sz has a "6 * sizeof(unsigned long)"
where the underlying struct has a 6 * unsigned char.
Simplify the calculation by just subtracting the variable part from
the size of the struct.
This also gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_mlme.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c b/drivers/staging/rtl8712/rtl871x_mlme.c
index c044b0e..6b3451f 100644
--- a/drivers/staging/rtl8712/rtl871x_mlme.c
+++ b/drivers/staging/rtl8712/rtl871x_mlme.c
@@ -210,17 +210,7 @@ void r8712_generate_random_ibss(u8 *pibss)
uint r8712_get_ndis_wlan_bssid_ex_sz(struct ndis_wlan_bssid_ex *bss)
{
- uint t_len;
-
- t_len = sizeof(u32) + 6 * sizeof(unsigned long) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + bss->IELength;
- return t_len;
+ return sizeof(*bss) + bss->IELength - MAX_IE_SZ;
}
u8 *r8712_get_capability_from_ie(u8 *ie)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 1/8] staging: rtl8712: fix buggy size calculation
Date: Mon, 27 Jul 2015 21:41:10 -0700
Message-Id: <305999598d7738feabdc8e5df5400b3e7be7f5ed.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
r8712_get_ndis_wlan_bssid_ex_sz has a "6 * sizeof(unsigned long)"
where the underlying struct has a 6 * unsigned char.
Simplify the calculation by just subtracting the variable part from
the size of the struct.
This also gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_mlme.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c b/drivers/staging/rtl8712/rtl871x_mlme.c
index c044b0e..6b3451f 100644
--- a/drivers/staging/rtl8712/rtl871x_mlme.c
+++ b/drivers/staging/rtl8712/rtl871x_mlme.c
@@ -210,17 +210,7 @@ void r8712_generate_random_ibss(u8 *pibss)
uint r8712_get_ndis_wlan_bssid_ex_sz(struct ndis_wlan_bssid_ex *bss)
{
- uint t_len;
-
- t_len = sizeof(u32) + 6 * sizeof(unsigned long) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + bss->IELength;
- return t_len;
+ return sizeof(*bss) + bss->IELength - MAX_IE_SZ;
}
u8 *r8712_get_capability_from_ie(u8 *ie)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 1/8] staging: rtl8712: fix buggy size calculation
Date: Mon, 27 Jul 2015 21:41:10 -0700
Message-Id: <305999598d7738feabdc8e5df5400b3e7be7f5ed.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
r8712_get_ndis_wlan_bssid_ex_sz has a "6 * sizeof(unsigned long)"
where the underlying struct has a 6 * unsigned char.
Simplify the calculation by just subtracting the variable part from
the size of the struct.
This also gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_mlme.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c b/drivers/staging/rtl8712/rtl871x_mlme.c
index c044b0e..6b3451f 100644
--- a/drivers/staging/rtl8712/rtl871x_mlme.c
+++ b/drivers/staging/rtl8712/rtl871x_mlme.c
@@ -210,17 +210,7 @@ void r8712_generate_random_ibss(u8 *pibss)
uint r8712_get_ndis_wlan_bssid_ex_sz(struct ndis_wlan_bssid_ex *bss)
{
- uint t_len;
-
- t_len = sizeof(u32) + 6 * sizeof(unsigned long) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + bss->IELength;
- return t_len;
+ return sizeof(*bss) + bss->IELength - MAX_IE_SZ;
}
u8 *r8712_get_capability_from_ie(u8 *ie)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 1/8] staging: rtl8712: fix buggy size calculation
Date: Mon, 27 Jul 2015 21:41:10 -0700
Message-Id: <305999598d7738feabdc8e5df5400b3e7be7f5ed.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
r8712_get_ndis_wlan_bssid_ex_sz has a "6 * sizeof(unsigned long)"
where the underlying struct has a 6 * unsigned char.
Simplify the calculation by just subtracting the variable part from
the size of the struct.
This also gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_mlme.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c b/drivers/staging/rtl8712/rtl871x_mlme.c
index c044b0e..6b3451f 100644
--- a/drivers/staging/rtl8712/rtl871x_mlme.c
+++ b/drivers/staging/rtl8712/rtl871x_mlme.c
@@ -210,17 +210,7 @@ void r8712_generate_random_ibss(u8 *pibss)
uint r8712_get_ndis_wlan_bssid_ex_sz(struct ndis_wlan_bssid_ex *bss)
{
- uint t_len;
-
- t_len = sizeof(u32) + 6 * sizeof(unsigned long) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + bss->IELength;
- return t_len;
+ return sizeof(*bss) + bss->IELength - MAX_IE_SZ;
}
u8 *r8712_get_capability_from_ie(u8 *ie)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 1/8] staging: rtl8712: fix buggy size calculation
Date: Mon, 27 Jul 2015 21:41:10 -0700
Message-Id: <305999598d7738feabdc8e5df5400b3e7be7f5ed.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
r8712_get_ndis_wlan_bssid_ex_sz has a "6 * sizeof(unsigned long)"
where the underlying struct has a 6 * unsigned char.
Simplify the calculation by just subtracting the variable part from
the size of the struct.
This also gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_mlme.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c b/drivers/staging/rtl8712/rtl871x_mlme.c
index c044b0e..6b3451f 100644
--- a/drivers/staging/rtl8712/rtl871x_mlme.c
+++ b/drivers/staging/rtl8712/rtl871x_mlme.c
@@ -210,17 +210,7 @@ void r8712_generate_random_ibss(u8 *pibss)
uint r8712_get_ndis_wlan_bssid_ex_sz(struct ndis_wlan_bssid_ex *bss)
{
- uint t_len;
-
- t_len = sizeof(u32) + 6 * sizeof(unsigned long) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + bss->IELength;
- return t_len;
+ return sizeof(*bss) + bss->IELength - MAX_IE_SZ;
}
u8 *r8712_get_capability_from_ie(u8 *ie)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 1/8] staging: rtl8712: fix buggy size calculation
Date: Mon, 27 Jul 2015 21:41:10 -0700
Message-Id: <305999598d7738feabdc8e5df5400b3e7be7f5ed.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
r8712_get_ndis_wlan_bssid_ex_sz has a "6 * sizeof(unsigned long)"
where the underlying struct has a 6 * unsigned char.
Simplify the calculation by just subtracting the variable part from
the size of the struct.
This also gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_mlme.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c b/drivers/staging/rtl8712/rtl871x_mlme.c
index c044b0e..6b3451f 100644
--- a/drivers/staging/rtl8712/rtl871x_mlme.c
+++ b/drivers/staging/rtl8712/rtl871x_mlme.c
@@ -210,17 +210,7 @@ void r8712_generate_random_ibss(u8 *pibss)
uint r8712_get_ndis_wlan_bssid_ex_sz(struct ndis_wlan_bssid_ex *bss)
{
- uint t_len;
-
- t_len = sizeof(u32) + 6 * sizeof(unsigned long) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + bss->IELength;
- return t_len;
+ return sizeof(*bss) + bss->IELength - MAX_IE_SZ;
}
u8 *r8712_get_capability_from_ie(u8 *ie)
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 1/8] staging: rtl8712: fix buggy size calculation
Date: Mon, 27 Jul 2015 21:41:10 -0700
Message-Id: <305999598d7738feabdc8e5df5400b3e7be7f5ed.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
r8712_get_ndis_wlan_bssid_ex_sz has a "6 * sizeof(unsigned long)"
where the underlying struct has a 6 * unsigned char.
Simplify the calculation by just subtracting the variable part from
the size of the struct.
This also gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_mlme.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c b/drivers/staging/rtl8712/rtl871x_mlme.c
index c044b0e..6b3451f 100644
--- a/drivers/staging/rtl8712/rtl871x_mlme.c
+++ b/drivers/staging/rtl8712/rtl871x_mlme.c
@@ -210,17 +210,7 @@ void r8712_generate_random_ibss(u8 *pibss)
uint r8712_get_ndis_wlan_bssid_ex_sz(struct ndis_wlan_bssid_ex *bss)
{
- uint t_len;
-
- t_len = sizeof(u32) + 6 * sizeof(unsigned long) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + bss->IELength;
- return t_len;
+ return sizeof(*bss) + bss->IELength - MAX_IE_SZ;
}
u8 *r8712_get_capability_from_ie(u8 *ie)
--
2.4.6
^ permalink raw reply related [flat|nested] 27+ messages in thread
* [PATCH V3 2/8] staging: rtl8712: simplify size calculation
2015-07-28 4:41 [PATCH V3 0/8] clean up wlan_bssdef.h Joshua Clayton
2015-07-28 4:41 ` [PATCH V3 1/8] staging: rtl8712: fix buggy size calculation Joshua Clayton
@ 2015-07-28 4:41 ` Joshua Clayton
2015-07-28 4:41 ` [PATCH V3 3/8] staging: rtl8712: fix comment Joshua Clayton
` (14 subsequent siblings)
16 siblings, 0 replies; 27+ messages in thread
From: Joshua Clayton @ 2015-07-28 4:41 UTC (permalink / raw)
To: Larry Finger, Florian Schilhabel, Greg Kroah-Hartman,
Sudip Mukherjee, Nitin Kuppelur, Joshua Clayton,
Vaishali Thakkar, Tapasweni Pathak, Daniel Baluta,
Melike Yurtoglu, Max Perepelitsyn, Aya Mahfouz,
Cristina Opriceana, Dogukan Ergun, Julia Lawall, Dan Carpenter,
Haneen Mohammed, Rickard Strandqvist
Cc: devel, linux-kernel
replace item-by-item size calculation of a struct
with the size of the struct.
This gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c
index e35854d..f07050d 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.c
+++ b/drivers/staging/rtl8712/rtl871x_cmd.c
@@ -471,7 +471,6 @@ u8 r8712_createbss_cmd(struct _adapter *padapter)
u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
{
- uint t_len = 0;
struct ndis_wlan_bssid_ex *psecnetwork;
struct cmd_obj *pcmd;
struct cmd_priv *pcmdpriv = &padapter->cmdpriv;
@@ -486,14 +485,6 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
pcmd = kmalloc(sizeof(*pcmd), GFP_ATOMIC);
if (pcmd == NULL)
return _FAIL;
- t_len = sizeof(u32) + 6 * sizeof(unsigned char) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + MAX_IE_SZ;
/* for hidden ap to set fw_state here */
if (check_fwstate(pmlmepriv, WIFI_STATION_STATE|WIFI_ADHOC_STATE) !=
@@ -516,7 +507,7 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
kfree(pcmd);
return _FAIL;
}
- memcpy(psecnetwork, &pnetwork->network, t_len);
+ memcpy(psecnetwork, &pnetwork->network, sizeof(*psecnetwork));
psecuritypriv->authenticator_ie[0] = (unsigned char)
psecnetwork->IELength;
if ((psecnetwork->IELength-12) < (256 - 1))
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 2/8] staging: rtl8712: simplify size calculation
Date: Mon, 27 Jul 2015 21:41:11 -0700
Message-Id: <f6e35adbb97dfcedbc6a99efbca0d27fb04a7a50.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
replace item-by-item size calculation of a struct
with the size of the struct.
This gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c
index e35854d..f07050d 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.c
+++ b/drivers/staging/rtl8712/rtl871x_cmd.c
@@ -471,7 +471,6 @@ u8 r8712_createbss_cmd(struct _adapter *padapter)
u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
{
- uint t_len = 0;
struct ndis_wlan_bssid_ex *psecnetwork;
struct cmd_obj *pcmd;
struct cmd_priv *pcmdpriv = &padapter->cmdpriv;
@@ -486,14 +485,6 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
pcmd = kmalloc(sizeof(*pcmd), GFP_ATOMIC);
if (pcmd == NULL)
return _FAIL;
- t_len = sizeof(u32) + 6 * sizeof(unsigned char) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + MAX_IE_SZ;
/* for hidden ap to set fw_state here */
if (check_fwstate(pmlmepriv, WIFI_STATION_STATE|WIFI_ADHOC_STATE) !=
@@ -516,7 +507,7 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
kfree(pcmd);
return _FAIL;
}
- memcpy(psecnetwork, &pnetwork->network, t_len);
+ memcpy(psecnetwork, &pnetwork->network, sizeof(*psecnetwork));
psecuritypriv->authenticator_ie[0] = (unsigned char)
psecnetwork->IELength;
if ((psecnetwork->IELength-12) < (256 - 1))
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 2/8] staging: rtl8712: simplify size calculation
Date: Mon, 27 Jul 2015 21:41:11 -0700
Message-Id: <f6e35adbb97dfcedbc6a99efbca0d27fb04a7a50.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
replace item-by-item size calculation of a struct
with the size of the struct.
This gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c
index e35854d..f07050d 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.c
+++ b/drivers/staging/rtl8712/rtl871x_cmd.c
@@ -471,7 +471,6 @@ u8 r8712_createbss_cmd(struct _adapter *padapter)
u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
{
- uint t_len = 0;
struct ndis_wlan_bssid_ex *psecnetwork;
struct cmd_obj *pcmd;
struct cmd_priv *pcmdpriv = &padapter->cmdpriv;
@@ -486,14 +485,6 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
pcmd = kmalloc(sizeof(*pcmd), GFP_ATOMIC);
if (pcmd == NULL)
return _FAIL;
- t_len = sizeof(u32) + 6 * sizeof(unsigned char) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + MAX_IE_SZ;
/* for hidden ap to set fw_state here */
if (check_fwstate(pmlmepriv, WIFI_STATION_STATE|WIFI_ADHOC_STATE) !=
@@ -516,7 +507,7 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
kfree(pcmd);
return _FAIL;
}
- memcpy(psecnetwork, &pnetwork->network, t_len);
+ memcpy(psecnetwork, &pnetwork->network, sizeof(*psecnetwork));
psecuritypriv->authenticator_ie[0] = (unsigned char)
psecnetwork->IELength;
if ((psecnetwork->IELength-12) < (256 - 1))
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 2/8] staging: rtl8712: simplify size calculation
Date: Mon, 27 Jul 2015 21:41:11 -0700
Message-Id: <f6e35adbb97dfcedbc6a99efbca0d27fb04a7a50.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
replace item-by-item size calculation of a struct
with the size of the struct.
This gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c
index e35854d..f07050d 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.c
+++ b/drivers/staging/rtl8712/rtl871x_cmd.c
@@ -471,7 +471,6 @@ u8 r8712_createbss_cmd(struct _adapter *padapter)
u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
{
- uint t_len = 0;
struct ndis_wlan_bssid_ex *psecnetwork;
struct cmd_obj *pcmd;
struct cmd_priv *pcmdpriv = &padapter->cmdpriv;
@@ -486,14 +485,6 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
pcmd = kmalloc(sizeof(*pcmd), GFP_ATOMIC);
if (pcmd == NULL)
return _FAIL;
- t_len = sizeof(u32) + 6 * sizeof(unsigned char) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + MAX_IE_SZ;
/* for hidden ap to set fw_state here */
if (check_fwstate(pmlmepriv, WIFI_STATION_STATE|WIFI_ADHOC_STATE) !=
@@ -516,7 +507,7 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
kfree(pcmd);
return _FAIL;
}
- memcpy(psecnetwork, &pnetwork->network, t_len);
+ memcpy(psecnetwork, &pnetwork->network, sizeof(*psecnetwork));
psecuritypriv->authenticator_ie[0] = (unsigned char)
psecnetwork->IELength;
if ((psecnetwork->IELength-12) < (256 - 1))
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 2/8] staging: rtl8712: simplify size calculation
Date: Mon, 27 Jul 2015 21:41:11 -0700
Message-Id: <f6e35adbb97dfcedbc6a99efbca0d27fb04a7a50.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
replace item-by-item size calculation of a struct
with the size of the struct.
This gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c
index e35854d..f07050d 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.c
+++ b/drivers/staging/rtl8712/rtl871x_cmd.c
@@ -471,7 +471,6 @@ u8 r8712_createbss_cmd(struct _adapter *padapter)
u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
{
- uint t_len = 0;
struct ndis_wlan_bssid_ex *psecnetwork;
struct cmd_obj *pcmd;
struct cmd_priv *pcmdpriv = &padapter->cmdpriv;
@@ -486,14 +485,6 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
pcmd = kmalloc(sizeof(*pcmd), GFP_ATOMIC);
if (pcmd == NULL)
return _FAIL;
- t_len = sizeof(u32) + 6 * sizeof(unsigned char) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + MAX_IE_SZ;
/* for hidden ap to set fw_state here */
if (check_fwstate(pmlmepriv, WIFI_STATION_STATE|WIFI_ADHOC_STATE) !=
@@ -516,7 +507,7 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
kfree(pcmd);
return _FAIL;
}
- memcpy(psecnetwork, &pnetwork->network, t_len);
+ memcpy(psecnetwork, &pnetwork->network, sizeof(*psecnetwork));
psecuritypriv->authenticator_ie[0] = (unsigned char)
psecnetwork->IELength;
if ((psecnetwork->IELength-12) < (256 - 1))
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 2/8] staging: rtl8712: simplify size calculation
Date: Mon, 27 Jul 2015 21:41:11 -0700
Message-Id: <f6e35adbb97dfcedbc6a99efbca0d27fb04a7a50.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
replace item-by-item size calculation of a struct
with the size of the struct.
This gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c
index e35854d..f07050d 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.c
+++ b/drivers/staging/rtl8712/rtl871x_cmd.c
@@ -471,7 +471,6 @@ u8 r8712_createbss_cmd(struct _adapter *padapter)
u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
{
- uint t_len = 0;
struct ndis_wlan_bssid_ex *psecnetwork;
struct cmd_obj *pcmd;
struct cmd_priv *pcmdpriv = &padapter->cmdpriv;
@@ -486,14 +485,6 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
pcmd = kmalloc(sizeof(*pcmd), GFP_ATOMIC);
if (pcmd == NULL)
return _FAIL;
- t_len = sizeof(u32) + 6 * sizeof(unsigned char) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + MAX_IE_SZ;
/* for hidden ap to set fw_state here */
if (check_fwstate(pmlmepriv, WIFI_STATION_STATE|WIFI_ADHOC_STATE) !=
@@ -516,7 +507,7 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
kfree(pcmd);
return _FAIL;
}
- memcpy(psecnetwork, &pnetwork->network, t_len);
+ memcpy(psecnetwork, &pnetwork->network, sizeof(*psecnetwork));
psecuritypriv->authenticator_ie[0] = (unsigned char)
psecnetwork->IELength;
if ((psecnetwork->IELength-12) < (256 - 1))
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 2/8] staging: rtl8712: simplify size calculation
Date: Mon, 27 Jul 2015 21:41:11 -0700
Message-Id: <f6e35adbb97dfcedbc6a99efbca0d27fb04a7a50.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
replace item-by-item size calculation of a struct
with the size of the struct.
This gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c
index e35854d..f07050d 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.c
+++ b/drivers/staging/rtl8712/rtl871x_cmd.c
@@ -471,7 +471,6 @@ u8 r8712_createbss_cmd(struct _adapter *padapter)
u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
{
- uint t_len = 0;
struct ndis_wlan_bssid_ex *psecnetwork;
struct cmd_obj *pcmd;
struct cmd_priv *pcmdpriv = &padapter->cmdpriv;
@@ -486,14 +485,6 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
pcmd = kmalloc(sizeof(*pcmd), GFP_ATOMIC);
if (pcmd == NULL)
return _FAIL;
- t_len = sizeof(u32) + 6 * sizeof(unsigned char) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + MAX_IE_SZ;
/* for hidden ap to set fw_state here */
if (check_fwstate(pmlmepriv, WIFI_STATION_STATE|WIFI_ADHOC_STATE) !=
@@ -516,7 +507,7 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
kfree(pcmd);
return _FAIL;
}
- memcpy(psecnetwork, &pnetwork->network, t_len);
+ memcpy(psecnetwork, &pnetwork->network, sizeof(*psecnetwork));
psecuritypriv->authenticator_ie[0] = (unsigned char)
psecnetwork->IELength;
if ((psecnetwork->IELength-12) < (256 - 1))
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 2/8] staging: rtl8712: simplify size calculation
Date: Mon, 27 Jul 2015 21:41:11 -0700
Message-Id: <f6e35adbb97dfcedbc6a99efbca0d27fb04a7a50.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
replace item-by-item size calculation of a struct
with the size of the struct.
This gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c
index e35854d..f07050d 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.c
+++ b/drivers/staging/rtl8712/rtl871x_cmd.c
@@ -471,7 +471,6 @@ u8 r8712_createbss_cmd(struct _adapter *padapter)
u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
{
- uint t_len = 0;
struct ndis_wlan_bssid_ex *psecnetwork;
struct cmd_obj *pcmd;
struct cmd_priv *pcmdpriv = &padapter->cmdpriv;
@@ -486,14 +485,6 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
pcmd = kmalloc(sizeof(*pcmd), GFP_ATOMIC);
if (pcmd == NULL)
return _FAIL;
- t_len = sizeof(u32) + 6 * sizeof(unsigned char) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + MAX_IE_SZ;
/* for hidden ap to set fw_state here */
if (check_fwstate(pmlmepriv, WIFI_STATION_STATE|WIFI_ADHOC_STATE) !=
@@ -516,7 +507,7 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
kfree(pcmd);
return _FAIL;
}
- memcpy(psecnetwork, &pnetwork->network, t_len);
+ memcpy(psecnetwork, &pnetwork->network, sizeof(*psecnetwork));
psecuritypriv->authenticator_ie[0] = (unsigned char)
psecnetwork->IELength;
if ((psecnetwork->IELength-12) < (256 - 1))
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 2/8] staging: rtl8712: simplify size calculation
Date: Mon, 27 Jul 2015 21:41:11 -0700
Message-Id: <f6e35adbb97dfcedbc6a99efbca0d27fb04a7a50.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
replace item-by-item size calculation of a struct
with the size of the struct.
This gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c
index e35854d..f07050d 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.c
+++ b/drivers/staging/rtl8712/rtl871x_cmd.c
@@ -471,7 +471,6 @@ u8 r8712_createbss_cmd(struct _adapter *padapter)
u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
{
- uint t_len = 0;
struct ndis_wlan_bssid_ex *psecnetwork;
struct cmd_obj *pcmd;
struct cmd_priv *pcmdpriv = &padapter->cmdpriv;
@@ -486,14 +485,6 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
pcmd = kmalloc(sizeof(*pcmd), GFP_ATOMIC);
if (pcmd == NULL)
return _FAIL;
- t_len = sizeof(u32) + 6 * sizeof(unsigned char) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + MAX_IE_SZ;
/* for hidden ap to set fw_state here */
if (check_fwstate(pmlmepriv, WIFI_STATION_STATE|WIFI_ADHOC_STATE) !=
@@ -516,7 +507,7 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
kfree(pcmd);
return _FAIL;
}
- memcpy(psecnetwork, &pnetwork->network, t_len);
+ memcpy(psecnetwork, &pnetwork->network, sizeof(*psecnetwork));
psecuritypriv->authenticator_ie[0] = (unsigned char)
psecnetwork->IELength;
if ((psecnetwork->IELength-12) < (256 - 1))
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 2/8] staging: rtl8712: simplify size calculation
Date: Mon, 27 Jul 2015 21:41:11 -0700
Message-Id: <f6e35adbb97dfcedbc6a99efbca0d27fb04a7a50.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
replace item-by-item size calculation of a struct
with the size of the struct.
This gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c
index e35854d..f07050d 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.c
+++ b/drivers/staging/rtl8712/rtl871x_cmd.c
@@ -471,7 +471,6 @@ u8 r8712_createbss_cmd(struct _adapter *padapter)
u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
{
- uint t_len = 0;
struct ndis_wlan_bssid_ex *psecnetwork;
struct cmd_obj *pcmd;
struct cmd_priv *pcmdpriv = &padapter->cmdpriv;
@@ -486,14 +485,6 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
pcmd = kmalloc(sizeof(*pcmd), GFP_ATOMIC);
if (pcmd == NULL)
return _FAIL;
- t_len = sizeof(u32) + 6 * sizeof(unsigned char) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + MAX_IE_SZ;
/* for hidden ap to set fw_state here */
if (check_fwstate(pmlmepriv, WIFI_STATION_STATE|WIFI_ADHOC_STATE) !=
@@ -516,7 +507,7 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
kfree(pcmd);
return _FAIL;
}
- memcpy(psecnetwork, &pnetwork->network, t_len);
+ memcpy(psecnetwork, &pnetwork->network, sizeof(*psecnetwork));
psecuritypriv->authenticator_ie[0] = (unsigned char)
psecnetwork->IELength;
if ((psecnetwork->IELength-12) < (256 - 1))
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 2/8] staging: rtl8712: simplify size calculation
Date: Mon, 27 Jul 2015 21:41:11 -0700
Message-Id: <f6e35adbb97dfcedbc6a99efbca0d27fb04a7a50.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
replace item-by-item size calculation of a struct
with the size of the struct.
This gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c
index e35854d..f07050d 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.c
+++ b/drivers/staging/rtl8712/rtl871x_cmd.c
@@ -471,7 +471,6 @@ u8 r8712_createbss_cmd(struct _adapter *padapter)
u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
{
- uint t_len = 0;
struct ndis_wlan_bssid_ex *psecnetwork;
struct cmd_obj *pcmd;
struct cmd_priv *pcmdpriv = &padapter->cmdpriv;
@@ -486,14 +485,6 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
pcmd = kmalloc(sizeof(*pcmd), GFP_ATOMIC);
if (pcmd == NULL)
return _FAIL;
- t_len = sizeof(u32) + 6 * sizeof(unsigned char) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + MAX_IE_SZ;
/* for hidden ap to set fw_state here */
if (check_fwstate(pmlmepriv, WIFI_STATION_STATE|WIFI_ADHOC_STATE) !=
@@ -516,7 +507,7 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
kfree(pcmd);
return _FAIL;
}
- memcpy(psecnetwork, &pnetwork->network, t_len);
+ memcpy(psecnetwork, &pnetwork->network, sizeof(*psecnetwork));
psecuritypriv->authenticator_ie[0] = (unsigned char)
psecnetwork->IELength;
if ((psecnetwork->IELength-12) < (256 - 1))
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 2/8] staging: rtl8712: simplify size calculation
Date: Mon, 27 Jul 2015 21:41:11 -0700
Message-Id: <f6e35adbb97dfcedbc6a99efbca0d27fb04a7a50.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
replace item-by-item size calculation of a struct
with the size of the struct.
This gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c
index e35854d..f07050d 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.c
+++ b/drivers/staging/rtl8712/rtl871x_cmd.c
@@ -471,7 +471,6 @@ u8 r8712_createbss_cmd(struct _adapter *padapter)
u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
{
- uint t_len = 0;
struct ndis_wlan_bssid_ex *psecnetwork;
struct cmd_obj *pcmd;
struct cmd_priv *pcmdpriv = &padapter->cmdpriv;
@@ -486,14 +485,6 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
pcmd = kmalloc(sizeof(*pcmd), GFP_ATOMIC);
if (pcmd == NULL)
return _FAIL;
- t_len = sizeof(u32) + 6 * sizeof(unsigned char) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + MAX_IE_SZ;
/* for hidden ap to set fw_state here */
if (check_fwstate(pmlmepriv, WIFI_STATION_STATE|WIFI_ADHOC_STATE) !=
@@ -516,7 +507,7 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
kfree(pcmd);
return _FAIL;
}
- memcpy(psecnetwork, &pnetwork->network, t_len);
+ memcpy(psecnetwork, &pnetwork->network, sizeof(*psecnetwork));
psecuritypriv->authenticator_ie[0] = (unsigned char)
psecnetwork->IELength;
if ((psecnetwork->IELength-12) < (256 - 1))
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 2/8] staging: rtl8712: simplify size calculation
Date: Mon, 27 Jul 2015 21:41:11 -0700
Message-Id: <f6e35adbb97dfcedbc6a99efbca0d27fb04a7a50.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
replace item-by-item size calculation of a struct
with the size of the struct.
This gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c
index e35854d..f07050d 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.c
+++ b/drivers/staging/rtl8712/rtl871x_cmd.c
@@ -471,7 +471,6 @@ u8 r8712_createbss_cmd(struct _adapter *padapter)
u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
{
- uint t_len = 0;
struct ndis_wlan_bssid_ex *psecnetwork;
struct cmd_obj *pcmd;
struct cmd_priv *pcmdpriv = &padapter->cmdpriv;
@@ -486,14 +485,6 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
pcmd = kmalloc(sizeof(*pcmd), GFP_ATOMIC);
if (pcmd == NULL)
return _FAIL;
- t_len = sizeof(u32) + 6 * sizeof(unsigned char) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + MAX_IE_SZ;
/* for hidden ap to set fw_state here */
if (check_fwstate(pmlmepriv, WIFI_STATION_STATE|WIFI_ADHOC_STATE) !=
@@ -516,7 +507,7 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
kfree(pcmd);
return _FAIL;
}
- memcpy(psecnetwork, &pnetwork->network, t_len);
+ memcpy(psecnetwork, &pnetwork->network, sizeof(*psecnetwork));
psecuritypriv->authenticator_ie[0] = (unsigned char)
psecnetwork->IELength;
if ((psecnetwork->IELength-12) < (256 - 1))
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 2/8] staging: rtl8712: simplify size calculation
Date: Mon, 27 Jul 2015 21:41:11 -0700
Message-Id: <f6e35adbb97dfcedbc6a99efbca0d27fb04a7a50.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
replace item-by-item size calculation of a struct
with the size of the struct.
This gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c
index e35854d..f07050d 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.c
+++ b/drivers/staging/rtl8712/rtl871x_cmd.c
@@ -471,7 +471,6 @@ u8 r8712_createbss_cmd(struct _adapter *padapter)
u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
{
- uint t_len = 0;
struct ndis_wlan_bssid_ex *psecnetwork;
struct cmd_obj *pcmd;
struct cmd_priv *pcmdpriv = &padapter->cmdpriv;
@@ -486,14 +485,6 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
pcmd = kmalloc(sizeof(*pcmd), GFP_ATOMIC);
if (pcmd == NULL)
return _FAIL;
- t_len = sizeof(u32) + 6 * sizeof(unsigned char) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + MAX_IE_SZ;
/* for hidden ap to set fw_state here */
if (check_fwstate(pmlmepriv, WIFI_STATION_STATE|WIFI_ADHOC_STATE) !=
@@ -516,7 +507,7 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
kfree(pcmd);
return _FAIL;
}
- memcpy(psecnetwork, &pnetwork->network, t_len);
+ memcpy(psecnetwork, &pnetwork->network, sizeof(*psecnetwork));
psecuritypriv->authenticator_ie[0] = (unsigned char)
psecnetwork->IELength;
if ((psecnetwork->IELength-12) < (256 - 1))
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 2/8] staging: rtl8712: simplify size calculation
Date: Mon, 27 Jul 2015 21:41:11 -0700
Message-Id: <f6e35adbb97dfcedbc6a99efbca0d27fb04a7a50.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
replace item-by-item size calculation of a struct
with the size of the struct.
This gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c
index e35854d..f07050d 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.c
+++ b/drivers/staging/rtl8712/rtl871x_cmd.c
@@ -471,7 +471,6 @@ u8 r8712_createbss_cmd(struct _adapter *padapter)
u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
{
- uint t_len = 0;
struct ndis_wlan_bssid_ex *psecnetwork;
struct cmd_obj *pcmd;
struct cmd_priv *pcmdpriv = &padapter->cmdpriv;
@@ -486,14 +485,6 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
pcmd = kmalloc(sizeof(*pcmd), GFP_ATOMIC);
if (pcmd == NULL)
return _FAIL;
- t_len = sizeof(u32) + 6 * sizeof(unsigned char) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + MAX_IE_SZ;
/* for hidden ap to set fw_state here */
if (check_fwstate(pmlmepriv, WIFI_STATION_STATE|WIFI_ADHOC_STATE) !=
@@ -516,7 +507,7 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
kfree(pcmd);
return _FAIL;
}
- memcpy(psecnetwork, &pnetwork->network, t_len);
+ memcpy(psecnetwork, &pnetwork->network, sizeof(*psecnetwork));
psecuritypriv->authenticator_ie[0] = (unsigned char)
psecnetwork->IELength;
if ((psecnetwork->IELength-12) < (256 - 1))
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 2/8] staging: rtl8712: simplify size calculation
Date: Mon, 27 Jul 2015 21:41:11 -0700
Message-Id: <f6e35adbb97dfcedbc6a99efbca0d27fb04a7a50.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
replace item-by-item size calculation of a struct
with the size of the struct.
This gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c
index e35854d..f07050d 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.c
+++ b/drivers/staging/rtl8712/rtl871x_cmd.c
@@ -471,7 +471,6 @@ u8 r8712_createbss_cmd(struct _adapter *padapter)
u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
{
- uint t_len = 0;
struct ndis_wlan_bssid_ex *psecnetwork;
struct cmd_obj *pcmd;
struct cmd_priv *pcmdpriv = &padapter->cmdpriv;
@@ -486,14 +485,6 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
pcmd = kmalloc(sizeof(*pcmd), GFP_ATOMIC);
if (pcmd == NULL)
return _FAIL;
- t_len = sizeof(u32) + 6 * sizeof(unsigned char) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + MAX_IE_SZ;
/* for hidden ap to set fw_state here */
if (check_fwstate(pmlmepriv, WIFI_STATION_STATE|WIFI_ADHOC_STATE) !=
@@ -516,7 +507,7 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
kfree(pcmd);
return _FAIL;
}
- memcpy(psecnetwork, &pnetwork->network, t_len);
+ memcpy(psecnetwork, &pnetwork->network, sizeof(*psecnetwork));
psecuritypriv->authenticator_ie[0] = (unsigned char)
psecnetwork->IELength;
if ((psecnetwork->IELength-12) < (256 - 1))
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 2/8] staging: rtl8712: simplify size calculation
Date: Mon, 27 Jul 2015 21:41:11 -0700
Message-Id: <f6e35adbb97dfcedbc6a99efbca0d27fb04a7a50.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
replace item-by-item size calculation of a struct
with the size of the struct.
This gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c
index e35854d..f07050d 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.c
+++ b/drivers/staging/rtl8712/rtl871x_cmd.c
@@ -471,7 +471,6 @@ u8 r8712_createbss_cmd(struct _adapter *padapter)
u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
{
- uint t_len = 0;
struct ndis_wlan_bssid_ex *psecnetwork;
struct cmd_obj *pcmd;
struct cmd_priv *pcmdpriv = &padapter->cmdpriv;
@@ -486,14 +485,6 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
pcmd = kmalloc(sizeof(*pcmd), GFP_ATOMIC);
if (pcmd == NULL)
return _FAIL;
- t_len = sizeof(u32) + 6 * sizeof(unsigned char) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + MAX_IE_SZ;
/* for hidden ap to set fw_state here */
if (check_fwstate(pmlmepriv, WIFI_STATION_STATE|WIFI_ADHOC_STATE) !=
@@ -516,7 +507,7 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
kfree(pcmd);
return _FAIL;
}
- memcpy(psecnetwork, &pnetwork->network, t_len);
+ memcpy(psecnetwork, &pnetwork->network, sizeof(*psecnetwork));
psecuritypriv->authenticator_ie[0] = (unsigned char)
psecnetwork->IELength;
if ((psecnetwork->IELength-12) < (256 - 1))
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 2/8] staging: rtl8712: simplify size calculation
Date: Mon, 27 Jul 2015 21:41:11 -0700
Message-Id: <f6e35adbb97dfcedbc6a99efbca0d27fb04a7a50.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
replace item-by-item size calculation of a struct
with the size of the struct.
This gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c
index e35854d..f07050d 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.c
+++ b/drivers/staging/rtl8712/rtl871x_cmd.c
@@ -471,7 +471,6 @@ u8 r8712_createbss_cmd(struct _adapter *padapter)
u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
{
- uint t_len = 0;
struct ndis_wlan_bssid_ex *psecnetwork;
struct cmd_obj *pcmd;
struct cmd_priv *pcmdpriv = &padapter->cmdpriv;
@@ -486,14 +485,6 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
pcmd = kmalloc(sizeof(*pcmd), GFP_ATOMIC);
if (pcmd == NULL)
return _FAIL;
- t_len = sizeof(u32) + 6 * sizeof(unsigned char) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + MAX_IE_SZ;
/* for hidden ap to set fw_state here */
if (check_fwstate(pmlmepriv, WIFI_STATION_STATE|WIFI_ADHOC_STATE) !=
@@ -516,7 +507,7 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
kfree(pcmd);
return _FAIL;
}
- memcpy(psecnetwork, &pnetwork->network, t_len);
+ memcpy(psecnetwork, &pnetwork->network, sizeof(*psecnetwork));
psecuritypriv->authenticator_ie[0] = (unsigned char)
psecnetwork->IELength;
if ((psecnetwork->IELength-12) < (256 - 1))
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 2/8] staging: rtl8712: simplify size calculation
Date: Mon, 27 Jul 2015 21:41:11 -0700
Message-Id: <f6e35adbb97dfcedbc6a99efbca0d27fb04a7a50.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
replace item-by-item size calculation of a struct
with the size of the struct.
This gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c
index e35854d..f07050d 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.c
+++ b/drivers/staging/rtl8712/rtl871x_cmd.c
@@ -471,7 +471,6 @@ u8 r8712_createbss_cmd(struct _adapter *padapter)
u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
{
- uint t_len = 0;
struct ndis_wlan_bssid_ex *psecnetwork;
struct cmd_obj *pcmd;
struct cmd_priv *pcmdpriv = &padapter->cmdpriv;
@@ -486,14 +485,6 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
pcmd = kmalloc(sizeof(*pcmd), GFP_ATOMIC);
if (pcmd == NULL)
return _FAIL;
- t_len = sizeof(u32) + 6 * sizeof(unsigned char) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + MAX_IE_SZ;
/* for hidden ap to set fw_state here */
if (check_fwstate(pmlmepriv, WIFI_STATION_STATE|WIFI_ADHOC_STATE) !=
@@ -516,7 +507,7 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
kfree(pcmd);
return _FAIL;
}
- memcpy(psecnetwork, &pnetwork->network, t_len);
+ memcpy(psecnetwork, &pnetwork->network, sizeof(*psecnetwork));
psecuritypriv->authenticator_ie[0] = (unsigned char)
psecnetwork->IELength;
if ((psecnetwork->IELength-12) < (256 - 1))
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 2/8] staging: rtl8712: simplify size calculation
Date: Mon, 27 Jul 2015 21:41:11 -0700
Message-Id: <f6e35adbb97dfcedbc6a99efbca0d27fb04a7a50.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
replace item-by-item size calculation of a struct
with the size of the struct.
This gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c
index e35854d..f07050d 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.c
+++ b/drivers/staging/rtl8712/rtl871x_cmd.c
@@ -471,7 +471,6 @@ u8 r8712_createbss_cmd(struct _adapter *padapter)
u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
{
- uint t_len = 0;
struct ndis_wlan_bssid_ex *psecnetwork;
struct cmd_obj *pcmd;
struct cmd_priv *pcmdpriv = &padapter->cmdpriv;
@@ -486,14 +485,6 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
pcmd = kmalloc(sizeof(*pcmd), GFP_ATOMIC);
if (pcmd == NULL)
return _FAIL;
- t_len = sizeof(u32) + 6 * sizeof(unsigned char) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + MAX_IE_SZ;
/* for hidden ap to set fw_state here */
if (check_fwstate(pmlmepriv, WIFI_STATION_STATE|WIFI_ADHOC_STATE) !=
@@ -516,7 +507,7 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
kfree(pcmd);
return _FAIL;
}
- memcpy(psecnetwork, &pnetwork->network, t_len);
+ memcpy(psecnetwork, &pnetwork->network, sizeof(*psecnetwork));
psecuritypriv->authenticator_ie[0] = (unsigned char)
psecnetwork->IELength;
if ((psecnetwork->IELength-12) < (256 - 1))
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 2/8] staging: rtl8712: simplify size calculation
Date: Mon, 27 Jul 2015 21:41:11 -0700
Message-Id: <f6e35adbb97dfcedbc6a99efbca0d27fb04a7a50.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
replace item-by-item size calculation of a struct
with the size of the struct.
This gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c
index e35854d..f07050d 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.c
+++ b/drivers/staging/rtl8712/rtl871x_cmd.c
@@ -471,7 +471,6 @@ u8 r8712_createbss_cmd(struct _adapter *padapter)
u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
{
- uint t_len = 0;
struct ndis_wlan_bssid_ex *psecnetwork;
struct cmd_obj *pcmd;
struct cmd_priv *pcmdpriv = &padapter->cmdpriv;
@@ -486,14 +485,6 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
pcmd = kmalloc(sizeof(*pcmd), GFP_ATOMIC);
if (pcmd == NULL)
return _FAIL;
- t_len = sizeof(u32) + 6 * sizeof(unsigned char) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + MAX_IE_SZ;
/* for hidden ap to set fw_state here */
if (check_fwstate(pmlmepriv, WIFI_STATION_STATE|WIFI_ADHOC_STATE) !=
@@ -516,7 +507,7 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
kfree(pcmd);
return _FAIL;
}
- memcpy(psecnetwork, &pnetwork->network, t_len);
+ memcpy(psecnetwork, &pnetwork->network, sizeof(*psecnetwork));
psecuritypriv->authenticator_ie[0] = (unsigned char)
psecnetwork->IELength;
if ((psecnetwork->IELength-12) < (256 - 1))
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 2/8] staging: rtl8712: simplify size calculation
Date: Mon, 27 Jul 2015 21:41:11 -0700
Message-Id: <f6e35adbb97dfcedbc6a99efbca0d27fb04a7a50.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
replace item-by-item size calculation of a struct
with the size of the struct.
This gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c
index e35854d..f07050d 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.c
+++ b/drivers/staging/rtl8712/rtl871x_cmd.c
@@ -471,7 +471,6 @@ u8 r8712_createbss_cmd(struct _adapter *padapter)
u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
{
- uint t_len = 0;
struct ndis_wlan_bssid_ex *psecnetwork;
struct cmd_obj *pcmd;
struct cmd_priv *pcmdpriv = &padapter->cmdpriv;
@@ -486,14 +485,6 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
pcmd = kmalloc(sizeof(*pcmd), GFP_ATOMIC);
if (pcmd == NULL)
return _FAIL;
- t_len = sizeof(u32) + 6 * sizeof(unsigned char) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + MAX_IE_SZ;
/* for hidden ap to set fw_state here */
if (check_fwstate(pmlmepriv, WIFI_STATION_STATE|WIFI_ADHOC_STATE) !=
@@ -516,7 +507,7 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
kfree(pcmd);
return _FAIL;
}
- memcpy(psecnetwork, &pnetwork->network, t_len);
+ memcpy(psecnetwork, &pnetwork->network, sizeof(*psecnetwork));
psecuritypriv->authenticator_ie[0] = (unsigned char)
psecnetwork->IELength;
if ((psecnetwork->IELength-12) < (256 - 1))
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 2/8] staging: rtl8712: simplify size calculation
Date: Mon, 27 Jul 2015 21:41:11 -0700
Message-Id: <f6e35adbb97dfcedbc6a99efbca0d27fb04a7a50.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
replace item-by-item size calculation of a struct
with the size of the struct.
This gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c
index e35854d..f07050d 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.c
+++ b/drivers/staging/rtl8712/rtl871x_cmd.c
@@ -471,7 +471,6 @@ u8 r8712_createbss_cmd(struct _adapter *padapter)
u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
{
- uint t_len = 0;
struct ndis_wlan_bssid_ex *psecnetwork;
struct cmd_obj *pcmd;
struct cmd_priv *pcmdpriv = &padapter->cmdpriv;
@@ -486,14 +485,6 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
pcmd = kmalloc(sizeof(*pcmd), GFP_ATOMIC);
if (pcmd == NULL)
return _FAIL;
- t_len = sizeof(u32) + 6 * sizeof(unsigned char) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + MAX_IE_SZ;
/* for hidden ap to set fw_state here */
if (check_fwstate(pmlmepriv, WIFI_STATION_STATE|WIFI_ADHOC_STATE) !=
@@ -516,7 +507,7 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
kfree(pcmd);
return _FAIL;
}
- memcpy(psecnetwork, &pnetwork->network, t_len);
+ memcpy(psecnetwork, &pnetwork->network, sizeof(*psecnetwork));
psecuritypriv->authenticator_ie[0] = (unsigned char)
psecnetwork->IELength;
if ((psecnetwork->IELength-12) < (256 - 1))
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 2/8] staging: rtl8712: simplify size calculation
Date: Mon, 27 Jul 2015 21:41:11 -0700
Message-Id: <f6e35adbb97dfcedbc6a99efbca0d27fb04a7a50.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
replace item-by-item size calculation of a struct
with the size of the struct.
This gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c
index e35854d..f07050d 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.c
+++ b/drivers/staging/rtl8712/rtl871x_cmd.c
@@ -471,7 +471,6 @@ u8 r8712_createbss_cmd(struct _adapter *padapter)
u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
{
- uint t_len = 0;
struct ndis_wlan_bssid_ex *psecnetwork;
struct cmd_obj *pcmd;
struct cmd_priv *pcmdpriv = &padapter->cmdpriv;
@@ -486,14 +485,6 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
pcmd = kmalloc(sizeof(*pcmd), GFP_ATOMIC);
if (pcmd == NULL)
return _FAIL;
- t_len = sizeof(u32) + 6 * sizeof(unsigned char) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + MAX_IE_SZ;
/* for hidden ap to set fw_state here */
if (check_fwstate(pmlmepriv, WIFI_STATION_STATE|WIFI_ADHOC_STATE) !=
@@ -516,7 +507,7 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
kfree(pcmd);
return _FAIL;
}
- memcpy(psecnetwork, &pnetwork->network, t_len);
+ memcpy(psecnetwork, &pnetwork->network, sizeof(*psecnetwork));
psecuritypriv->authenticator_ie[0] = (unsigned char)
psecnetwork->IELength;
if ((psecnetwork->IELength-12) < (256 - 1))
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 2/8] staging: rtl8712: simplify size calculation
Date: Mon, 27 Jul 2015 21:41:11 -0700
Message-Id: <f6e35adbb97dfcedbc6a99efbca0d27fb04a7a50.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
replace item-by-item size calculation of a struct
with the size of the struct.
This gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c
index e35854d..f07050d 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.c
+++ b/drivers/staging/rtl8712/rtl871x_cmd.c
@@ -471,7 +471,6 @@ u8 r8712_createbss_cmd(struct _adapter *padapter)
u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
{
- uint t_len = 0;
struct ndis_wlan_bssid_ex *psecnetwork;
struct cmd_obj *pcmd;
struct cmd_priv *pcmdpriv = &padapter->cmdpriv;
@@ -486,14 +485,6 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
pcmd = kmalloc(sizeof(*pcmd), GFP_ATOMIC);
if (pcmd == NULL)
return _FAIL;
- t_len = sizeof(u32) + 6 * sizeof(unsigned char) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + MAX_IE_SZ;
/* for hidden ap to set fw_state here */
if (check_fwstate(pmlmepriv, WIFI_STATION_STATE|WIFI_ADHOC_STATE) !=
@@ -516,7 +507,7 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
kfree(pcmd);
return _FAIL;
}
- memcpy(psecnetwork, &pnetwork->network, t_len);
+ memcpy(psecnetwork, &pnetwork->network, sizeof(*psecnetwork));
psecuritypriv->authenticator_ie[0] = (unsigned char)
psecnetwork->IELength;
if ((psecnetwork->IELength-12) < (256 - 1))
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 2/8] staging: rtl8712: simplify size calculation
Date: Mon, 27 Jul 2015 21:41:11 -0700
Message-Id: <f6e35adbb97dfcedbc6a99efbca0d27fb04a7a50.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
replace item-by-item size calculation of a struct
with the size of the struct.
This gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c
index e35854d..f07050d 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.c
+++ b/drivers/staging/rtl8712/rtl871x_cmd.c
@@ -471,7 +471,6 @@ u8 r8712_createbss_cmd(struct _adapter *padapter)
u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
{
- uint t_len = 0;
struct ndis_wlan_bssid_ex *psecnetwork;
struct cmd_obj *pcmd;
struct cmd_priv *pcmdpriv = &padapter->cmdpriv;
@@ -486,14 +485,6 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
pcmd = kmalloc(sizeof(*pcmd), GFP_ATOMIC);
if (pcmd == NULL)
return _FAIL;
- t_len = sizeof(u32) + 6 * sizeof(unsigned char) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + MAX_IE_SZ;
/* for hidden ap to set fw_state here */
if (check_fwstate(pmlmepriv, WIFI_STATION_STATE|WIFI_ADHOC_STATE) !=
@@ -516,7 +507,7 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
kfree(pcmd);
return _FAIL;
}
- memcpy(psecnetwork, &pnetwork->network, t_len);
+ memcpy(psecnetwork, &pnetwork->network, sizeof(*psecnetwork));
psecuritypriv->authenticator_ie[0] = (unsigned char)
psecnetwork->IELength;
if ((psecnetwork->IELength-12) < (256 - 1))
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 2/8] staging: rtl8712: simplify size calculation
Date: Mon, 27 Jul 2015 21:41:11 -0700
Message-Id: <f6e35adbb97dfcedbc6a99efbca0d27fb04a7a50.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
replace item-by-item size calculation of a struct
with the size of the struct.
This gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c
index e35854d..f07050d 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.c
+++ b/drivers/staging/rtl8712/rtl871x_cmd.c
@@ -471,7 +471,6 @@ u8 r8712_createbss_cmd(struct _adapter *padapter)
u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
{
- uint t_len = 0;
struct ndis_wlan_bssid_ex *psecnetwork;
struct cmd_obj *pcmd;
struct cmd_priv *pcmdpriv = &padapter->cmdpriv;
@@ -486,14 +485,6 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
pcmd = kmalloc(sizeof(*pcmd), GFP_ATOMIC);
if (pcmd == NULL)
return _FAIL;
- t_len = sizeof(u32) + 6 * sizeof(unsigned char) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + MAX_IE_SZ;
/* for hidden ap to set fw_state here */
if (check_fwstate(pmlmepriv, WIFI_STATION_STATE|WIFI_ADHOC_STATE) !=
@@ -516,7 +507,7 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
kfree(pcmd);
return _FAIL;
}
- memcpy(psecnetwork, &pnetwork->network, t_len);
+ memcpy(psecnetwork, &pnetwork->network, sizeof(*psecnetwork));
psecuritypriv->authenticator_ie[0] = (unsigned char)
psecnetwork->IELength;
if ((psecnetwork->IELength-12) < (256 - 1))
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 2/8] staging: rtl8712: simplify size calculation
Date: Mon, 27 Jul 2015 21:41:11 -0700
Message-Id: <f6e35adbb97dfcedbc6a99efbca0d27fb04a7a50.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
replace item-by-item size calculation of a struct
with the size of the struct.
This gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c
index e35854d..f07050d 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.c
+++ b/drivers/staging/rtl8712/rtl871x_cmd.c
@@ -471,7 +471,6 @@ u8 r8712_createbss_cmd(struct _adapter *padapter)
u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
{
- uint t_len = 0;
struct ndis_wlan_bssid_ex *psecnetwork;
struct cmd_obj *pcmd;
struct cmd_priv *pcmdpriv = &padapter->cmdpriv;
@@ -486,14 +485,6 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
pcmd = kmalloc(sizeof(*pcmd), GFP_ATOMIC);
if (pcmd == NULL)
return _FAIL;
- t_len = sizeof(u32) + 6 * sizeof(unsigned char) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + MAX_IE_SZ;
/* for hidden ap to set fw_state here */
if (check_fwstate(pmlmepriv, WIFI_STATION_STATE|WIFI_ADHOC_STATE) !=
@@ -516,7 +507,7 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
kfree(pcmd);
return _FAIL;
}
- memcpy(psecnetwork, &pnetwork->network, t_len);
+ memcpy(psecnetwork, &pnetwork->network, sizeof(*psecnetwork));
psecuritypriv->authenticator_ie[0] = (unsigned char)
psecnetwork->IELength;
if ((psecnetwork->IELength-12) < (256 - 1))
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 2/8] staging: rtl8712: simplify size calculation
Date: Mon, 27 Jul 2015 21:41:11 -0700
Message-Id: <f6e35adbb97dfcedbc6a99efbca0d27fb04a7a50.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
replace item-by-item size calculation of a struct
with the size of the struct.
This gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c
index e35854d..f07050d 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.c
+++ b/drivers/staging/rtl8712/rtl871x_cmd.c
@@ -471,7 +471,6 @@ u8 r8712_createbss_cmd(struct _adapter *padapter)
u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
{
- uint t_len = 0;
struct ndis_wlan_bssid_ex *psecnetwork;
struct cmd_obj *pcmd;
struct cmd_priv *pcmdpriv = &padapter->cmdpriv;
@@ -486,14 +485,6 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
pcmd = kmalloc(sizeof(*pcmd), GFP_ATOMIC);
if (pcmd == NULL)
return _FAIL;
- t_len = sizeof(u32) + 6 * sizeof(unsigned char) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + MAX_IE_SZ;
/* for hidden ap to set fw_state here */
if (check_fwstate(pmlmepriv, WIFI_STATION_STATE|WIFI_ADHOC_STATE) !=
@@ -516,7 +507,7 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
kfree(pcmd);
return _FAIL;
}
- memcpy(psecnetwork, &pnetwork->network, t_len);
+ memcpy(psecnetwork, &pnetwork->network, sizeof(*psecnetwork));
psecuritypriv->authenticator_ie[0] = (unsigned char)
psecnetwork->IELength;
if ((psecnetwork->IELength-12) < (256 - 1))
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 2/8] staging: rtl8712: simplify size calculation
Date: Mon, 27 Jul 2015 21:41:11 -0700
Message-Id: <f6e35adbb97dfcedbc6a99efbca0d27fb04a7a50.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
replace item-by-item size calculation of a struct
with the size of the struct.
This gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c
index e35854d..f07050d 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.c
+++ b/drivers/staging/rtl8712/rtl871x_cmd.c
@@ -471,7 +471,6 @@ u8 r8712_createbss_cmd(struct _adapter *padapter)
u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
{
- uint t_len = 0;
struct ndis_wlan_bssid_ex *psecnetwork;
struct cmd_obj *pcmd;
struct cmd_priv *pcmdpriv = &padapter->cmdpriv;
@@ -486,14 +485,6 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
pcmd = kmalloc(sizeof(*pcmd), GFP_ATOMIC);
if (pcmd == NULL)
return _FAIL;
- t_len = sizeof(u32) + 6 * sizeof(unsigned char) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + MAX_IE_SZ;
/* for hidden ap to set fw_state here */
if (check_fwstate(pmlmepriv, WIFI_STATION_STATE|WIFI_ADHOC_STATE) !=
@@ -516,7 +507,7 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
kfree(pcmd);
return _FAIL;
}
- memcpy(psecnetwork, &pnetwork->network, t_len);
+ memcpy(psecnetwork, &pnetwork->network, sizeof(*psecnetwork));
psecuritypriv->authenticator_ie[0] = (unsigned char)
psecnetwork->IELength;
if ((psecnetwork->IELength-12) < (256 - 1))
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 2/8] staging: rtl8712: simplify size calculation
Date: Mon, 27 Jul 2015 21:41:11 -0700
Message-Id: <f6e35adbb97dfcedbc6a99efbca0d27fb04a7a50.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
replace item-by-item size calculation of a struct
with the size of the struct.
This gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c
index e35854d..f07050d 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.c
+++ b/drivers/staging/rtl8712/rtl871x_cmd.c
@@ -471,7 +471,6 @@ u8 r8712_createbss_cmd(struct _adapter *padapter)
u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
{
- uint t_len = 0;
struct ndis_wlan_bssid_ex *psecnetwork;
struct cmd_obj *pcmd;
struct cmd_priv *pcmdpriv = &padapter->cmdpriv;
@@ -486,14 +485,6 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
pcmd = kmalloc(sizeof(*pcmd), GFP_ATOMIC);
if (pcmd == NULL)
return _FAIL;
- t_len = sizeof(u32) + 6 * sizeof(unsigned char) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + MAX_IE_SZ;
/* for hidden ap to set fw_state here */
if (check_fwstate(pmlmepriv, WIFI_STATION_STATE|WIFI_ADHOC_STATE) !=
@@ -516,7 +507,7 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
kfree(pcmd);
return _FAIL;
}
- memcpy(psecnetwork, &pnetwork->network, t_len);
+ memcpy(psecnetwork, &pnetwork->network, sizeof(*psecnetwork));
psecuritypriv->authenticator_ie[0] = (unsigned char)
psecnetwork->IELength;
if ((psecnetwork->IELength-12) < (256 - 1))
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 2/8] staging: rtl8712: simplify size calculation
Date: Mon, 27 Jul 2015 21:41:11 -0700
Message-Id: <f6e35adbb97dfcedbc6a99efbca0d27fb04a7a50.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
replace item-by-item size calculation of a struct
with the size of the struct.
This gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c
index e35854d..f07050d 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.c
+++ b/drivers/staging/rtl8712/rtl871x_cmd.c
@@ -471,7 +471,6 @@ u8 r8712_createbss_cmd(struct _adapter *padapter)
u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
{
- uint t_len = 0;
struct ndis_wlan_bssid_ex *psecnetwork;
struct cmd_obj *pcmd;
struct cmd_priv *pcmdpriv = &padapter->cmdpriv;
@@ -486,14 +485,6 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
pcmd = kmalloc(sizeof(*pcmd), GFP_ATOMIC);
if (pcmd == NULL)
return _FAIL;
- t_len = sizeof(u32) + 6 * sizeof(unsigned char) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + MAX_IE_SZ;
/* for hidden ap to set fw_state here */
if (check_fwstate(pmlmepriv, WIFI_STATION_STATE|WIFI_ADHOC_STATE) !=
@@ -516,7 +507,7 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
kfree(pcmd);
return _FAIL;
}
- memcpy(psecnetwork, &pnetwork->network, t_len);
+ memcpy(psecnetwork, &pnetwork->network, sizeof(*psecnetwork));
psecuritypriv->authenticator_ie[0] = (unsigned char)
psecnetwork->IELength;
if ((psecnetwork->IELength-12) < (256 - 1))
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 2/8] staging: rtl8712: simplify size calculation
Date: Mon, 27 Jul 2015 21:41:11 -0700
Message-Id: <f6e35adbb97dfcedbc6a99efbca0d27fb04a7a50.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
replace item-by-item size calculation of a struct
with the size of the struct.
This gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c
index e35854d..f07050d 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.c
+++ b/drivers/staging/rtl8712/rtl871x_cmd.c
@@ -471,7 +471,6 @@ u8 r8712_createbss_cmd(struct _adapter *padapter)
u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
{
- uint t_len = 0;
struct ndis_wlan_bssid_ex *psecnetwork;
struct cmd_obj *pcmd;
struct cmd_priv *pcmdpriv = &padapter->cmdpriv;
@@ -486,14 +485,6 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
pcmd = kmalloc(sizeof(*pcmd), GFP_ATOMIC);
if (pcmd == NULL)
return _FAIL;
- t_len = sizeof(u32) + 6 * sizeof(unsigned char) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + MAX_IE_SZ;
/* for hidden ap to set fw_state here */
if (check_fwstate(pmlmepriv, WIFI_STATION_STATE|WIFI_ADHOC_STATE) !=
@@ -516,7 +507,7 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
kfree(pcmd);
return _FAIL;
}
- memcpy(psecnetwork, &pnetwork->network, t_len);
+ memcpy(psecnetwork, &pnetwork->network, sizeof(*psecnetwork));
psecuritypriv->authenticator_ie[0] = (unsigned char)
psecnetwork->IELength;
if ((psecnetwork->IELength-12) < (256 - 1))
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 2/8] staging: rtl8712: simplify size calculation
Date: Mon, 27 Jul 2015 21:41:11 -0700
Message-Id: <f6e35adbb97dfcedbc6a99efbca0d27fb04a7a50.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
replace item-by-item size calculation of a struct
with the size of the struct.
This gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c
index e35854d..f07050d 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.c
+++ b/drivers/staging/rtl8712/rtl871x_cmd.c
@@ -471,7 +471,6 @@ u8 r8712_createbss_cmd(struct _adapter *padapter)
u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
{
- uint t_len = 0;
struct ndis_wlan_bssid_ex *psecnetwork;
struct cmd_obj *pcmd;
struct cmd_priv *pcmdpriv = &padapter->cmdpriv;
@@ -486,14 +485,6 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
pcmd = kmalloc(sizeof(*pcmd), GFP_ATOMIC);
if (pcmd == NULL)
return _FAIL;
- t_len = sizeof(u32) + 6 * sizeof(unsigned char) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + MAX_IE_SZ;
/* for hidden ap to set fw_state here */
if (check_fwstate(pmlmepriv, WIFI_STATION_STATE|WIFI_ADHOC_STATE) !=
@@ -516,7 +507,7 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
kfree(pcmd);
return _FAIL;
}
- memcpy(psecnetwork, &pnetwork->network, t_len);
+ memcpy(psecnetwork, &pnetwork->network, sizeof(*psecnetwork));
psecuritypriv->authenticator_ie[0] = (unsigned char)
psecnetwork->IELength;
if ((psecnetwork->IELength-12) < (256 - 1))
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 2/8] staging: rtl8712: simplify size calculation
Date: Mon, 27 Jul 2015 21:41:11 -0700
Message-Id: <f6e35adbb97dfcedbc6a99efbca0d27fb04a7a50.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
replace item-by-item size calculation of a struct
with the size of the struct.
This gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c
index e35854d..f07050d 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.c
+++ b/drivers/staging/rtl8712/rtl871x_cmd.c
@@ -471,7 +471,6 @@ u8 r8712_createbss_cmd(struct _adapter *padapter)
u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
{
- uint t_len = 0;
struct ndis_wlan_bssid_ex *psecnetwork;
struct cmd_obj *pcmd;
struct cmd_priv *pcmdpriv = &padapter->cmdpriv;
@@ -486,14 +485,6 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
pcmd = kmalloc(sizeof(*pcmd), GFP_ATOMIC);
if (pcmd == NULL)
return _FAIL;
- t_len = sizeof(u32) + 6 * sizeof(unsigned char) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + MAX_IE_SZ;
/* for hidden ap to set fw_state here */
if (check_fwstate(pmlmepriv, WIFI_STATION_STATE|WIFI_ADHOC_STATE) !=
@@ -516,7 +507,7 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
kfree(pcmd);
return _FAIL;
}
- memcpy(psecnetwork, &pnetwork->network, t_len);
+ memcpy(psecnetwork, &pnetwork->network, sizeof(*psecnetwork));
psecuritypriv->authenticator_ie[0] = (unsigned char)
psecnetwork->IELength;
if ((psecnetwork->IELength-12) < (256 - 1))
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 2/8] staging: rtl8712: simplify size calculation
Date: Mon, 27 Jul 2015 21:41:11 -0700
Message-Id: <f6e35adbb97dfcedbc6a99efbca0d27fb04a7a50.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
replace item-by-item size calculation of a struct
with the size of the struct.
This gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c
index e35854d..f07050d 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.c
+++ b/drivers/staging/rtl8712/rtl871x_cmd.c
@@ -471,7 +471,6 @@ u8 r8712_createbss_cmd(struct _adapter *padapter)
u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
{
- uint t_len = 0;
struct ndis_wlan_bssid_ex *psecnetwork;
struct cmd_obj *pcmd;
struct cmd_priv *pcmdpriv = &padapter->cmdpriv;
@@ -486,14 +485,6 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
pcmd = kmalloc(sizeof(*pcmd), GFP_ATOMIC);
if (pcmd == NULL)
return _FAIL;
- t_len = sizeof(u32) + 6 * sizeof(unsigned char) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + MAX_IE_SZ;
/* for hidden ap to set fw_state here */
if (check_fwstate(pmlmepriv, WIFI_STATION_STATE|WIFI_ADHOC_STATE) !=
@@ -516,7 +507,7 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
kfree(pcmd);
return _FAIL;
}
- memcpy(psecnetwork, &pnetwork->network, t_len);
+ memcpy(psecnetwork, &pnetwork->network, sizeof(*psecnetwork));
psecuritypriv->authenticator_ie[0] = (unsigned char)
psecnetwork->IELength;
if ((psecnetwork->IELength-12) < (256 - 1))
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 2/8] staging: rtl8712: simplify size calculation
Date: Mon, 27 Jul 2015 21:41:11 -0700
Message-Id: <f6e35adbb97dfcedbc6a99efbca0d27fb04a7a50.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
replace item-by-item size calculation of a struct
with the size of the struct.
This gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c
index e35854d..f07050d 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.c
+++ b/drivers/staging/rtl8712/rtl871x_cmd.c
@@ -471,7 +471,6 @@ u8 r8712_createbss_cmd(struct _adapter *padapter)
u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
{
- uint t_len = 0;
struct ndis_wlan_bssid_ex *psecnetwork;
struct cmd_obj *pcmd;
struct cmd_priv *pcmdpriv = &padapter->cmdpriv;
@@ -486,14 +485,6 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
pcmd = kmalloc(sizeof(*pcmd), GFP_ATOMIC);
if (pcmd == NULL)
return _FAIL;
- t_len = sizeof(u32) + 6 * sizeof(unsigned char) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + MAX_IE_SZ;
/* for hidden ap to set fw_state here */
if (check_fwstate(pmlmepriv, WIFI_STATION_STATE|WIFI_ADHOC_STATE) !=
@@ -516,7 +507,7 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
kfree(pcmd);
return _FAIL;
}
- memcpy(psecnetwork, &pnetwork->network, t_len);
+ memcpy(psecnetwork, &pnetwork->network, sizeof(*psecnetwork));
psecuritypriv->authenticator_ie[0] = (unsigned char)
psecnetwork->IELength;
if ((psecnetwork->IELength-12) < (256 - 1))
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 2/8] staging: rtl8712: simplify size calculation
Date: Mon, 27 Jul 2015 21:41:11 -0700
Message-Id: <f6e35adbb97dfcedbc6a99efbca0d27fb04a7a50.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
replace item-by-item size calculation of a struct
with the size of the struct.
This gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c
index e35854d..f07050d 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.c
+++ b/drivers/staging/rtl8712/rtl871x_cmd.c
@@ -471,7 +471,6 @@ u8 r8712_createbss_cmd(struct _adapter *padapter)
u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
{
- uint t_len = 0;
struct ndis_wlan_bssid_ex *psecnetwork;
struct cmd_obj *pcmd;
struct cmd_priv *pcmdpriv = &padapter->cmdpriv;
@@ -486,14 +485,6 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
pcmd = kmalloc(sizeof(*pcmd), GFP_ATOMIC);
if (pcmd == NULL)
return _FAIL;
- t_len = sizeof(u32) + 6 * sizeof(unsigned char) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + MAX_IE_SZ;
/* for hidden ap to set fw_state here */
if (check_fwstate(pmlmepriv, WIFI_STATION_STATE|WIFI_ADHOC_STATE) !=
@@ -516,7 +507,7 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
kfree(pcmd);
return _FAIL;
}
- memcpy(psecnetwork, &pnetwork->network, t_len);
+ memcpy(psecnetwork, &pnetwork->network, sizeof(*psecnetwork));
psecuritypriv->authenticator_ie[0] = (unsigned char)
psecnetwork->IELength;
if ((psecnetwork->IELength-12) < (256 - 1))
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 2/8] staging: rtl8712: simplify size calculation
Date: Mon, 27 Jul 2015 21:41:11 -0700
Message-Id: <f6e35adbb97dfcedbc6a99efbca0d27fb04a7a50.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
replace item-by-item size calculation of a struct
with the size of the struct.
This gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c
index e35854d..f07050d 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.c
+++ b/drivers/staging/rtl8712/rtl871x_cmd.c
@@ -471,7 +471,6 @@ u8 r8712_createbss_cmd(struct _adapter *padapter)
u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
{
- uint t_len = 0;
struct ndis_wlan_bssid_ex *psecnetwork;
struct cmd_obj *pcmd;
struct cmd_priv *pcmdpriv = &padapter->cmdpriv;
@@ -486,14 +485,6 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
pcmd = kmalloc(sizeof(*pcmd), GFP_ATOMIC);
if (pcmd == NULL)
return _FAIL;
- t_len = sizeof(u32) + 6 * sizeof(unsigned char) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + MAX_IE_SZ;
/* for hidden ap to set fw_state here */
if (check_fwstate(pmlmepriv, WIFI_STATION_STATE|WIFI_ADHOC_STATE) !=
@@ -516,7 +507,7 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
kfree(pcmd);
return _FAIL;
}
- memcpy(psecnetwork, &pnetwork->network, t_len);
+ memcpy(psecnetwork, &pnetwork->network, sizeof(*psecnetwork));
psecuritypriv->authenticator_ie[0] = (unsigned char)
psecnetwork->IELength;
if ((psecnetwork->IELength-12) < (256 - 1))
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 2/8] staging: rtl8712: simplify size calculation
Date: Mon, 27 Jul 2015 21:41:11 -0700
Message-Id: <f6e35adbb97dfcedbc6a99efbca0d27fb04a7a50.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
replace item-by-item size calculation of a struct
with the size of the struct.
This gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c
index e35854d..f07050d 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.c
+++ b/drivers/staging/rtl8712/rtl871x_cmd.c
@@ -471,7 +471,6 @@ u8 r8712_createbss_cmd(struct _adapter *padapter)
u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
{
- uint t_len = 0;
struct ndis_wlan_bssid_ex *psecnetwork;
struct cmd_obj *pcmd;
struct cmd_priv *pcmdpriv = &padapter->cmdpriv;
@@ -486,14 +485,6 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
pcmd = kmalloc(sizeof(*pcmd), GFP_ATOMIC);
if (pcmd == NULL)
return _FAIL;
- t_len = sizeof(u32) + 6 * sizeof(unsigned char) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + MAX_IE_SZ;
/* for hidden ap to set fw_state here */
if (check_fwstate(pmlmepriv, WIFI_STATION_STATE|WIFI_ADHOC_STATE) !=
@@ -516,7 +507,7 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
kfree(pcmd);
return _FAIL;
}
- memcpy(psecnetwork, &pnetwork->network, t_len);
+ memcpy(psecnetwork, &pnetwork->network, sizeof(*psecnetwork));
psecuritypriv->authenticator_ie[0] = (unsigned char)
psecnetwork->IELength;
if ((psecnetwork->IELength-12) < (256 - 1))
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 2/8] staging: rtl8712: simplify size calculation
Date: Mon, 27 Jul 2015 21:41:11 -0700
Message-Id: <f6e35adbb97dfcedbc6a99efbca0d27fb04a7a50.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
replace item-by-item size calculation of a struct
with the size of the struct.
This gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c
index e35854d..f07050d 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.c
+++ b/drivers/staging/rtl8712/rtl871x_cmd.c
@@ -471,7 +471,6 @@ u8 r8712_createbss_cmd(struct _adapter *padapter)
u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
{
- uint t_len = 0;
struct ndis_wlan_bssid_ex *psecnetwork;
struct cmd_obj *pcmd;
struct cmd_priv *pcmdpriv = &padapter->cmdpriv;
@@ -486,14 +485,6 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
pcmd = kmalloc(sizeof(*pcmd), GFP_ATOMIC);
if (pcmd == NULL)
return _FAIL;
- t_len = sizeof(u32) + 6 * sizeof(unsigned char) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + MAX_IE_SZ;
/* for hidden ap to set fw_state here */
if (check_fwstate(pmlmepriv, WIFI_STATION_STATE|WIFI_ADHOC_STATE) !=
@@ -516,7 +507,7 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
kfree(pcmd);
return _FAIL;
}
- memcpy(psecnetwork, &pnetwork->network, t_len);
+ memcpy(psecnetwork, &pnetwork->network, sizeof(*psecnetwork));
psecuritypriv->authenticator_ie[0] = (unsigned char)
psecnetwork->IELength;
if ((psecnetwork->IELength-12) < (256 - 1))
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 2/8] staging: rtl8712: simplify size calculation
Date: Mon, 27 Jul 2015 21:41:11 -0700
Message-Id: <f6e35adbb97dfcedbc6a99efbca0d27fb04a7a50.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
replace item-by-item size calculation of a struct
with the size of the struct.
This gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c
index e35854d..f07050d 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.c
+++ b/drivers/staging/rtl8712/rtl871x_cmd.c
@@ -471,7 +471,6 @@ u8 r8712_createbss_cmd(struct _adapter *padapter)
u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
{
- uint t_len = 0;
struct ndis_wlan_bssid_ex *psecnetwork;
struct cmd_obj *pcmd;
struct cmd_priv *pcmdpriv = &padapter->cmdpriv;
@@ -486,14 +485,6 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
pcmd = kmalloc(sizeof(*pcmd), GFP_ATOMIC);
if (pcmd == NULL)
return _FAIL;
- t_len = sizeof(u32) + 6 * sizeof(unsigned char) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + MAX_IE_SZ;
/* for hidden ap to set fw_state here */
if (check_fwstate(pmlmepriv, WIFI_STATION_STATE|WIFI_ADHOC_STATE) !=
@@ -516,7 +507,7 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
kfree(pcmd);
return _FAIL;
}
- memcpy(psecnetwork, &pnetwork->network, t_len);
+ memcpy(psecnetwork, &pnetwork->network, sizeof(*psecnetwork));
psecuritypriv->authenticator_ie[0] = (unsigned char)
psecnetwork->IELength;
if ((psecnetwork->IELength-12) < (256 - 1))
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 2/8] staging: rtl8712: simplify size calculation
Date: Mon, 27 Jul 2015 21:41:11 -0700
Message-Id: <f6e35adbb97dfcedbc6a99efbca0d27fb04a7a50.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
replace item-by-item size calculation of a struct
with the size of the struct.
This gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c
index e35854d..f07050d 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.c
+++ b/drivers/staging/rtl8712/rtl871x_cmd.c
@@ -471,7 +471,6 @@ u8 r8712_createbss_cmd(struct _adapter *padapter)
u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
{
- uint t_len = 0;
struct ndis_wlan_bssid_ex *psecnetwork;
struct cmd_obj *pcmd;
struct cmd_priv *pcmdpriv = &padapter->cmdpriv;
@@ -486,14 +485,6 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
pcmd = kmalloc(sizeof(*pcmd), GFP_ATOMIC);
if (pcmd == NULL)
return _FAIL;
- t_len = sizeof(u32) + 6 * sizeof(unsigned char) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + MAX_IE_SZ;
/* for hidden ap to set fw_state here */
if (check_fwstate(pmlmepriv, WIFI_STATION_STATE|WIFI_ADHOC_STATE) !=
@@ -516,7 +507,7 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
kfree(pcmd);
return _FAIL;
}
- memcpy(psecnetwork, &pnetwork->network, t_len);
+ memcpy(psecnetwork, &pnetwork->network, sizeof(*psecnetwork));
psecuritypriv->authenticator_ie[0] = (unsigned char)
psecnetwork->IELength;
if ((psecnetwork->IELength-12) < (256 - 1))
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 2/8] staging: rtl8712: simplify size calculation
Date: Mon, 27 Jul 2015 21:41:11 -0700
Message-Id: <f6e35adbb97dfcedbc6a99efbca0d27fb04a7a50.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
replace item-by-item size calculation of a struct
with the size of the struct.
This gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c
index e35854d..f07050d 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.c
+++ b/drivers/staging/rtl8712/rtl871x_cmd.c
@@ -471,7 +471,6 @@ u8 r8712_createbss_cmd(struct _adapter *padapter)
u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
{
- uint t_len = 0;
struct ndis_wlan_bssid_ex *psecnetwork;
struct cmd_obj *pcmd;
struct cmd_priv *pcmdpriv = &padapter->cmdpriv;
@@ -486,14 +485,6 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
pcmd = kmalloc(sizeof(*pcmd), GFP_ATOMIC);
if (pcmd == NULL)
return _FAIL;
- t_len = sizeof(u32) + 6 * sizeof(unsigned char) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + MAX_IE_SZ;
/* for hidden ap to set fw_state here */
if (check_fwstate(pmlmepriv, WIFI_STATION_STATE|WIFI_ADHOC_STATE) !=
@@ -516,7 +507,7 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
kfree(pcmd);
return _FAIL;
}
- memcpy(psecnetwork, &pnetwork->network, t_len);
+ memcpy(psecnetwork, &pnetwork->network, sizeof(*psecnetwork));
psecuritypriv->authenticator_ie[0] = (unsigned char)
psecnetwork->IELength;
if ((psecnetwork->IELength-12) < (256 - 1))
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 2/8] staging: rtl8712: simplify size calculation
Date: Mon, 27 Jul 2015 21:41:11 -0700
Message-Id: <f6e35adbb97dfcedbc6a99efbca0d27fb04a7a50.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
replace item-by-item size calculation of a struct
with the size of the struct.
This gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c
index e35854d..f07050d 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.c
+++ b/drivers/staging/rtl8712/rtl871x_cmd.c
@@ -471,7 +471,6 @@ u8 r8712_createbss_cmd(struct _adapter *padapter)
u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
{
- uint t_len = 0;
struct ndis_wlan_bssid_ex *psecnetwork;
struct cmd_obj *pcmd;
struct cmd_priv *pcmdpriv = &padapter->cmdpriv;
@@ -486,14 +485,6 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
pcmd = kmalloc(sizeof(*pcmd), GFP_ATOMIC);
if (pcmd == NULL)
return _FAIL;
- t_len = sizeof(u32) + 6 * sizeof(unsigned char) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + MAX_IE_SZ;
/* for hidden ap to set fw_state here */
if (check_fwstate(pmlmepriv, WIFI_STATION_STATE|WIFI_ADHOC_STATE) !=
@@ -516,7 +507,7 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
kfree(pcmd);
return _FAIL;
}
- memcpy(psecnetwork, &pnetwork->network, t_len);
+ memcpy(psecnetwork, &pnetwork->network, sizeof(*psecnetwork));
psecuritypriv->authenticator_ie[0] = (unsigned char)
psecnetwork->IELength;
if ((psecnetwork->IELength-12) < (256 - 1))
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 2/8] staging: rtl8712: simplify size calculation
Date: Mon, 27 Jul 2015 21:41:11 -0700
Message-Id: <f6e35adbb97dfcedbc6a99efbca0d27fb04a7a50.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
replace item-by-item size calculation of a struct
with the size of the struct.
This gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c
index e35854d..f07050d 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.c
+++ b/drivers/staging/rtl8712/rtl871x_cmd.c
@@ -471,7 +471,6 @@ u8 r8712_createbss_cmd(struct _adapter *padapter)
u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
{
- uint t_len = 0;
struct ndis_wlan_bssid_ex *psecnetwork;
struct cmd_obj *pcmd;
struct cmd_priv *pcmdpriv = &padapter->cmdpriv;
@@ -486,14 +485,6 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
pcmd = kmalloc(sizeof(*pcmd), GFP_ATOMIC);
if (pcmd == NULL)
return _FAIL;
- t_len = sizeof(u32) + 6 * sizeof(unsigned char) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + MAX_IE_SZ;
/* for hidden ap to set fw_state here */
if (check_fwstate(pmlmepriv, WIFI_STATION_STATE|WIFI_ADHOC_STATE) !=
@@ -516,7 +507,7 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
kfree(pcmd);
return _FAIL;
}
- memcpy(psecnetwork, &pnetwork->network, t_len);
+ memcpy(psecnetwork, &pnetwork->network, sizeof(*psecnetwork));
psecuritypriv->authenticator_ie[0] = (unsigned char)
psecnetwork->IELength;
if ((psecnetwork->IELength-12) < (256 - 1))
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 2/8] staging: rtl8712: simplify size calculation
Date: Mon, 27 Jul 2015 21:41:11 -0700
Message-Id: <f6e35adbb97dfcedbc6a99efbca0d27fb04a7a50.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
replace item-by-item size calculation of a struct
with the size of the struct.
This gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c
index e35854d..f07050d 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.c
+++ b/drivers/staging/rtl8712/rtl871x_cmd.c
@@ -471,7 +471,6 @@ u8 r8712_createbss_cmd(struct _adapter *padapter)
u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
{
- uint t_len = 0;
struct ndis_wlan_bssid_ex *psecnetwork;
struct cmd_obj *pcmd;
struct cmd_priv *pcmdpriv = &padapter->cmdpriv;
@@ -486,14 +485,6 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
pcmd = kmalloc(sizeof(*pcmd), GFP_ATOMIC);
if (pcmd == NULL)
return _FAIL;
- t_len = sizeof(u32) + 6 * sizeof(unsigned char) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + MAX_IE_SZ;
/* for hidden ap to set fw_state here */
if (check_fwstate(pmlmepriv, WIFI_STATION_STATE|WIFI_ADHOC_STATE) !=
@@ -516,7 +507,7 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
kfree(pcmd);
return _FAIL;
}
- memcpy(psecnetwork, &pnetwork->network, t_len);
+ memcpy(psecnetwork, &pnetwork->network, sizeof(*psecnetwork));
psecuritypriv->authenticator_ie[0] = (unsigned char)
psecnetwork->IELength;
if ((psecnetwork->IELength-12) < (256 - 1))
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 2/8] staging: rtl8712: simplify size calculation
Date: Mon, 27 Jul 2015 21:41:11 -0700
Message-Id: <f6e35adbb97dfcedbc6a99efbca0d27fb04a7a50.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
replace item-by-item size calculation of a struct
with the size of the struct.
This gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c
index e35854d..f07050d 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.c
+++ b/drivers/staging/rtl8712/rtl871x_cmd.c
@@ -471,7 +471,6 @@ u8 r8712_createbss_cmd(struct _adapter *padapter)
u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
{
- uint t_len = 0;
struct ndis_wlan_bssid_ex *psecnetwork;
struct cmd_obj *pcmd;
struct cmd_priv *pcmdpriv = &padapter->cmdpriv;
@@ -486,14 +485,6 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
pcmd = kmalloc(sizeof(*pcmd), GFP_ATOMIC);
if (pcmd == NULL)
return _FAIL;
- t_len = sizeof(u32) + 6 * sizeof(unsigned char) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + MAX_IE_SZ;
/* for hidden ap to set fw_state here */
if (check_fwstate(pmlmepriv, WIFI_STATION_STATE|WIFI_ADHOC_STATE) !=
@@ -516,7 +507,7 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
kfree(pcmd);
return _FAIL;
}
- memcpy(psecnetwork, &pnetwork->network, t_len);
+ memcpy(psecnetwork, &pnetwork->network, sizeof(*psecnetwork));
psecuritypriv->authenticator_ie[0] = (unsigned char)
psecnetwork->IELength;
if ((psecnetwork->IELength-12) < (256 - 1))
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 2/8] staging: rtl8712: simplify size calculation
Date: Mon, 27 Jul 2015 21:41:11 -0700
Message-Id: <f6e35adbb97dfcedbc6a99efbca0d27fb04a7a50.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
replace item-by-item size calculation of a struct
with the size of the struct.
This gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c
index e35854d..f07050d 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.c
+++ b/drivers/staging/rtl8712/rtl871x_cmd.c
@@ -471,7 +471,6 @@ u8 r8712_createbss_cmd(struct _adapter *padapter)
u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
{
- uint t_len = 0;
struct ndis_wlan_bssid_ex *psecnetwork;
struct cmd_obj *pcmd;
struct cmd_priv *pcmdpriv = &padapter->cmdpriv;
@@ -486,14 +485,6 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
pcmd = kmalloc(sizeof(*pcmd), GFP_ATOMIC);
if (pcmd == NULL)
return _FAIL;
- t_len = sizeof(u32) + 6 * sizeof(unsigned char) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + MAX_IE_SZ;
/* for hidden ap to set fw_state here */
if (check_fwstate(pmlmepriv, WIFI_STATION_STATE|WIFI_ADHOC_STATE) !=
@@ -516,7 +507,7 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
kfree(pcmd);
return _FAIL;
}
- memcpy(psecnetwork, &pnetwork->network, t_len);
+ memcpy(psecnetwork, &pnetwork->network, sizeof(*psecnetwork));
psecuritypriv->authenticator_ie[0] = (unsigned char)
psecnetwork->IELength;
if ((psecnetwork->IELength-12) < (256 - 1))
--
2.4.6
^ permalink raw reply related [flat|nested] 27+ messages in thread
* [PATCH V3 3/8] staging: rtl8712: fix comment
2015-07-28 4:41 [PATCH V3 0/8] clean up wlan_bssdef.h Joshua Clayton
2015-07-28 4:41 ` [PATCH V3 1/8] staging: rtl8712: fix buggy size calculation Joshua Clayton
2015-07-28 4:41 ` [PATCH V3 2/8] staging: rtl8712: simplify " Joshua Clayton
@ 2015-07-28 4:41 ` Joshua Clayton
2015-07-28 4:41 ` [PATCH V3 4/8] staging: rtl8712: removed unused wrapper structs Joshua Clayton
` (13 subsequent siblings)
16 siblings, 0 replies; 27+ messages in thread
From: Joshua Clayton @ 2015-07-28 4:41 UTC (permalink / raw)
To: Larry Finger, Florian Schilhabel, Greg Kroah-Hartman,
Sudip Mukherjee, Nitin Kuppelur, Joshua Clayton,
Vaishali Thakkar, Tapasweni Pathak, Daniel Baluta,
Melike Yurtoglu, Max Perepelitsyn, Aya Mahfouz,
Cristina Opriceana, Dogukan Ergun, Julia Lawall, Dan Carpenter,
Haneen Mohammed, Rickard Strandqvist
Cc: devel, linux-kernel
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
^ permalink raw reply related [flat|nested] 27+ messages in thread
* [PATCH V3 4/8] staging: rtl8712: removed unused wrapper structs
2015-07-28 4:41 [PATCH V3 0/8] clean up wlan_bssdef.h Joshua Clayton
` (2 preceding siblings ...)
2015-07-28 4:41 ` [PATCH V3 3/8] staging: rtl8712: fix comment Joshua Clayton
@ 2015-07-28 4:41 ` Joshua Clayton
2015-07-28 4:41 ` [PATCH V3 7/8] staging: rtl8712: remove typedefs Joshua Clayton
` (12 subsequent siblings)
16 siblings, 0 replies; 27+ messages in thread
From: Joshua Clayton @ 2015-07-28 4:41 UTC (permalink / raw)
To: Larry Finger, Florian Schilhabel, Greg Kroah-Hartman,
Sudip Mukherjee, Nitin Kuppelur, Joshua Clayton,
Vaishali Thakkar, Tapasweni Pathak, Daniel Baluta,
Melike Yurtoglu, Max Perepelitsyn, Aya Mahfouz,
Cristina Opriceana, Dogukan Ergun, Julia Lawall, Dan Carpenter,
Haneen Mohammed, Rickard Strandqvist
Cc: devel, linux-kernel
Remove wrapper structs that just wrap struct ndis_wlan_bssid_ex,
and are unused.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.h b/drivers/staging/rtl8712/rtl871x_cmd.h
index cb8225b..818cd88 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.h
+++ b/drivers/staging/rtl8712/rtl871x_cmd.h
@@ -123,15 +123,6 @@ struct usb_suspend_parm {
};
/*
- * Caller Mode: Infra, Ad-Hoc
- * Notes: To join the specified bss
- * Command Event Mode
- */
-struct joinbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: Infra, Ad-HoC(C)
* Notes: To disconnect the current associated BSS
* Command Mode
@@ -141,15 +132,6 @@ struct disconnect_parm {
};
/*
- * Caller Mode: AP, Ad-HoC(M)
- * Notes: To create a BSS
- * Command Mode
- */
-struct createbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: AP, Ad-HoC, Infra
* Notes: To set the NIC mode of RTL8711
* Command Mode
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 4/8] staging: rtl8712: removed unused wrapper structs
Date: Mon, 27 Jul 2015 21:41:13 -0700
Message-Id: <75dcdd4644344c7c4f0ccabf8a0e28bce7974349.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Remove wrapper structs that just wrap struct ndis_wlan_bssid_ex,
and are unused.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.h b/drivers/staging/rtl8712/rtl871x_cmd.h
index cb8225b..818cd88 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.h
+++ b/drivers/staging/rtl8712/rtl871x_cmd.h
@@ -123,15 +123,6 @@ struct usb_suspend_parm {
};
/*
- * Caller Mode: Infra, Ad-Hoc
- * Notes: To join the specified bss
- * Command Event Mode
- */
-struct joinbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: Infra, Ad-HoC(C)
* Notes: To disconnect the current associated BSS
* Command Mode
@@ -141,15 +132,6 @@ struct disconnect_parm {
};
/*
- * Caller Mode: AP, Ad-HoC(M)
- * Notes: To create a BSS
- * Command Mode
- */
-struct createbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: AP, Ad-HoC, Infra
* Notes: To set the NIC mode of RTL8711
* Command Mode
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 4/8] staging: rtl8712: removed unused wrapper structs
Date: Mon, 27 Jul 2015 21:41:13 -0700
Message-Id: <75dcdd4644344c7c4f0ccabf8a0e28bce7974349.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Remove wrapper structs that just wrap struct ndis_wlan_bssid_ex,
and are unused.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.h b/drivers/staging/rtl8712/rtl871x_cmd.h
index cb8225b..818cd88 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.h
+++ b/drivers/staging/rtl8712/rtl871x_cmd.h
@@ -123,15 +123,6 @@ struct usb_suspend_parm {
};
/*
- * Caller Mode: Infra, Ad-Hoc
- * Notes: To join the specified bss
- * Command Event Mode
- */
-struct joinbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: Infra, Ad-HoC(C)
* Notes: To disconnect the current associated BSS
* Command Mode
@@ -141,15 +132,6 @@ struct disconnect_parm {
};
/*
- * Caller Mode: AP, Ad-HoC(M)
- * Notes: To create a BSS
- * Command Mode
- */
-struct createbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: AP, Ad-HoC, Infra
* Notes: To set the NIC mode of RTL8711
* Command Mode
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 4/8] staging: rtl8712: removed unused wrapper structs
Date: Mon, 27 Jul 2015 21:41:13 -0700
Message-Id: <75dcdd4644344c7c4f0ccabf8a0e28bce7974349.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Remove wrapper structs that just wrap struct ndis_wlan_bssid_ex,
and are unused.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.h b/drivers/staging/rtl8712/rtl871x_cmd.h
index cb8225b..818cd88 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.h
+++ b/drivers/staging/rtl8712/rtl871x_cmd.h
@@ -123,15 +123,6 @@ struct usb_suspend_parm {
};
/*
- * Caller Mode: Infra, Ad-Hoc
- * Notes: To join the specified bss
- * Command Event Mode
- */
-struct joinbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: Infra, Ad-HoC(C)
* Notes: To disconnect the current associated BSS
* Command Mode
@@ -141,15 +132,6 @@ struct disconnect_parm {
};
/*
- * Caller Mode: AP, Ad-HoC(M)
- * Notes: To create a BSS
- * Command Mode
- */
-struct createbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: AP, Ad-HoC, Infra
* Notes: To set the NIC mode of RTL8711
* Command Mode
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 4/8] staging: rtl8712: removed unused wrapper structs
Date: Mon, 27 Jul 2015 21:41:13 -0700
Message-Id: <75dcdd4644344c7c4f0ccabf8a0e28bce7974349.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Remove wrapper structs that just wrap struct ndis_wlan_bssid_ex,
and are unused.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.h b/drivers/staging/rtl8712/rtl871x_cmd.h
index cb8225b..818cd88 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.h
+++ b/drivers/staging/rtl8712/rtl871x_cmd.h
@@ -123,15 +123,6 @@ struct usb_suspend_parm {
};
/*
- * Caller Mode: Infra, Ad-Hoc
- * Notes: To join the specified bss
- * Command Event Mode
- */
-struct joinbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: Infra, Ad-HoC(C)
* Notes: To disconnect the current associated BSS
* Command Mode
@@ -141,15 +132,6 @@ struct disconnect_parm {
};
/*
- * Caller Mode: AP, Ad-HoC(M)
- * Notes: To create a BSS
- * Command Mode
- */
-struct createbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: AP, Ad-HoC, Infra
* Notes: To set the NIC mode of RTL8711
* Command Mode
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 4/8] staging: rtl8712: removed unused wrapper structs
Date: Mon, 27 Jul 2015 21:41:13 -0700
Message-Id: <75dcdd4644344c7c4f0ccabf8a0e28bce7974349.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Remove wrapper structs that just wrap struct ndis_wlan_bssid_ex,
and are unused.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.h b/drivers/staging/rtl8712/rtl871x_cmd.h
index cb8225b..818cd88 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.h
+++ b/drivers/staging/rtl8712/rtl871x_cmd.h
@@ -123,15 +123,6 @@ struct usb_suspend_parm {
};
/*
- * Caller Mode: Infra, Ad-Hoc
- * Notes: To join the specified bss
- * Command Event Mode
- */
-struct joinbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: Infra, Ad-HoC(C)
* Notes: To disconnect the current associated BSS
* Command Mode
@@ -141,15 +132,6 @@ struct disconnect_parm {
};
/*
- * Caller Mode: AP, Ad-HoC(M)
- * Notes: To create a BSS
- * Command Mode
- */
-struct createbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: AP, Ad-HoC, Infra
* Notes: To set the NIC mode of RTL8711
* Command Mode
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 4/8] staging: rtl8712: removed unused wrapper structs
Date: Mon, 27 Jul 2015 21:41:13 -0700
Message-Id: <75dcdd4644344c7c4f0ccabf8a0e28bce7974349.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Remove wrapper structs that just wrap struct ndis_wlan_bssid_ex,
and are unused.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.h b/drivers/staging/rtl8712/rtl871x_cmd.h
index cb8225b..818cd88 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.h
+++ b/drivers/staging/rtl8712/rtl871x_cmd.h
@@ -123,15 +123,6 @@ struct usb_suspend_parm {
};
/*
- * Caller Mode: Infra, Ad-Hoc
- * Notes: To join the specified bss
- * Command Event Mode
- */
-struct joinbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: Infra, Ad-HoC(C)
* Notes: To disconnect the current associated BSS
* Command Mode
@@ -141,15 +132,6 @@ struct disconnect_parm {
};
/*
- * Caller Mode: AP, Ad-HoC(M)
- * Notes: To create a BSS
- * Command Mode
- */
-struct createbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: AP, Ad-HoC, Infra
* Notes: To set the NIC mode of RTL8711
* Command Mode
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 4/8] staging: rtl8712: removed unused wrapper structs
Date: Mon, 27 Jul 2015 21:41:13 -0700
Message-Id: <75dcdd4644344c7c4f0ccabf8a0e28bce7974349.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Remove wrapper structs that just wrap struct ndis_wlan_bssid_ex,
and are unused.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.h b/drivers/staging/rtl8712/rtl871x_cmd.h
index cb8225b..818cd88 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.h
+++ b/drivers/staging/rtl8712/rtl871x_cmd.h
@@ -123,15 +123,6 @@ struct usb_suspend_parm {
};
/*
- * Caller Mode: Infra, Ad-Hoc
- * Notes: To join the specified bss
- * Command Event Mode
- */
-struct joinbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: Infra, Ad-HoC(C)
* Notes: To disconnect the current associated BSS
* Command Mode
@@ -141,15 +132,6 @@ struct disconnect_parm {
};
/*
- * Caller Mode: AP, Ad-HoC(M)
- * Notes: To create a BSS
- * Command Mode
- */
-struct createbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: AP, Ad-HoC, Infra
* Notes: To set the NIC mode of RTL8711
* Command Mode
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 4/8] staging: rtl8712: removed unused wrapper structs
Date: Mon, 27 Jul 2015 21:41:13 -0700
Message-Id: <75dcdd4644344c7c4f0ccabf8a0e28bce7974349.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Remove wrapper structs that just wrap struct ndis_wlan_bssid_ex,
and are unused.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.h b/drivers/staging/rtl8712/rtl871x_cmd.h
index cb8225b..818cd88 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.h
+++ b/drivers/staging/rtl8712/rtl871x_cmd.h
@@ -123,15 +123,6 @@ struct usb_suspend_parm {
};
/*
- * Caller Mode: Infra, Ad-Hoc
- * Notes: To join the specified bss
- * Command Event Mode
- */
-struct joinbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: Infra, Ad-HoC(C)
* Notes: To disconnect the current associated BSS
* Command Mode
@@ -141,15 +132,6 @@ struct disconnect_parm {
};
/*
- * Caller Mode: AP, Ad-HoC(M)
- * Notes: To create a BSS
- * Command Mode
- */
-struct createbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: AP, Ad-HoC, Infra
* Notes: To set the NIC mode of RTL8711
* Command Mode
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 4/8] staging: rtl8712: removed unused wrapper structs
Date: Mon, 27 Jul 2015 21:41:13 -0700
Message-Id: <75dcdd4644344c7c4f0ccabf8a0e28bce7974349.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Remove wrapper structs that just wrap struct ndis_wlan_bssid_ex,
and are unused.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.h b/drivers/staging/rtl8712/rtl871x_cmd.h
index cb8225b..818cd88 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.h
+++ b/drivers/staging/rtl8712/rtl871x_cmd.h
@@ -123,15 +123,6 @@ struct usb_suspend_parm {
};
/*
- * Caller Mode: Infra, Ad-Hoc
- * Notes: To join the specified bss
- * Command Event Mode
- */
-struct joinbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: Infra, Ad-HoC(C)
* Notes: To disconnect the current associated BSS
* Command Mode
@@ -141,15 +132,6 @@ struct disconnect_parm {
};
/*
- * Caller Mode: AP, Ad-HoC(M)
- * Notes: To create a BSS
- * Command Mode
- */
-struct createbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: AP, Ad-HoC, Infra
* Notes: To set the NIC mode of RTL8711
* Command Mode
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 4/8] staging: rtl8712: removed unused wrapper structs
Date: Mon, 27 Jul 2015 21:41:13 -0700
Message-Id: <75dcdd4644344c7c4f0ccabf8a0e28bce7974349.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Remove wrapper structs that just wrap struct ndis_wlan_bssid_ex,
and are unused.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.h b/drivers/staging/rtl8712/rtl871x_cmd.h
index cb8225b..818cd88 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.h
+++ b/drivers/staging/rtl8712/rtl871x_cmd.h
@@ -123,15 +123,6 @@ struct usb_suspend_parm {
};
/*
- * Caller Mode: Infra, Ad-Hoc
- * Notes: To join the specified bss
- * Command Event Mode
- */
-struct joinbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: Infra, Ad-HoC(C)
* Notes: To disconnect the current associated BSS
* Command Mode
@@ -141,15 +132,6 @@ struct disconnect_parm {
};
/*
- * Caller Mode: AP, Ad-HoC(M)
- * Notes: To create a BSS
- * Command Mode
- */
-struct createbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: AP, Ad-HoC, Infra
* Notes: To set the NIC mode of RTL8711
* Command Mode
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 4/8] staging: rtl8712: removed unused wrapper structs
Date: Mon, 27 Jul 2015 21:41:13 -0700
Message-Id: <75dcdd4644344c7c4f0ccabf8a0e28bce7974349.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Remove wrapper structs that just wrap struct ndis_wlan_bssid_ex,
and are unused.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.h b/drivers/staging/rtl8712/rtl871x_cmd.h
index cb8225b..818cd88 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.h
+++ b/drivers/staging/rtl8712/rtl871x_cmd.h
@@ -123,15 +123,6 @@ struct usb_suspend_parm {
};
/*
- * Caller Mode: Infra, Ad-Hoc
- * Notes: To join the specified bss
- * Command Event Mode
- */
-struct joinbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: Infra, Ad-HoC(C)
* Notes: To disconnect the current associated BSS
* Command Mode
@@ -141,15 +132,6 @@ struct disconnect_parm {
};
/*
- * Caller Mode: AP, Ad-HoC(M)
- * Notes: To create a BSS
- * Command Mode
- */
-struct createbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: AP, Ad-HoC, Infra
* Notes: To set the NIC mode of RTL8711
* Command Mode
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 4/8] staging: rtl8712: removed unused wrapper structs
Date: Mon, 27 Jul 2015 21:41:13 -0700
Message-Id: <75dcdd4644344c7c4f0ccabf8a0e28bce7974349.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Remove wrapper structs that just wrap struct ndis_wlan_bssid_ex,
and are unused.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.h b/drivers/staging/rtl8712/rtl871x_cmd.h
index cb8225b..818cd88 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.h
+++ b/drivers/staging/rtl8712/rtl871x_cmd.h
@@ -123,15 +123,6 @@ struct usb_suspend_parm {
};
/*
- * Caller Mode: Infra, Ad-Hoc
- * Notes: To join the specified bss
- * Command Event Mode
- */
-struct joinbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: Infra, Ad-HoC(C)
* Notes: To disconnect the current associated BSS
* Command Mode
@@ -141,15 +132,6 @@ struct disconnect_parm {
};
/*
- * Caller Mode: AP, Ad-HoC(M)
- * Notes: To create a BSS
- * Command Mode
- */
-struct createbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: AP, Ad-HoC, Infra
* Notes: To set the NIC mode of RTL8711
* Command Mode
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 4/8] staging: rtl8712: removed unused wrapper structs
Date: Mon, 27 Jul 2015 21:41:13 -0700
Message-Id: <75dcdd4644344c7c4f0ccabf8a0e28bce7974349.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Remove wrapper structs that just wrap struct ndis_wlan_bssid_ex,
and are unused.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.h b/drivers/staging/rtl8712/rtl871x_cmd.h
index cb8225b..818cd88 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.h
+++ b/drivers/staging/rtl8712/rtl871x_cmd.h
@@ -123,15 +123,6 @@ struct usb_suspend_parm {
};
/*
- * Caller Mode: Infra, Ad-Hoc
- * Notes: To join the specified bss
- * Command Event Mode
- */
-struct joinbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: Infra, Ad-HoC(C)
* Notes: To disconnect the current associated BSS
* Command Mode
@@ -141,15 +132,6 @@ struct disconnect_parm {
};
/*
- * Caller Mode: AP, Ad-HoC(M)
- * Notes: To create a BSS
- * Command Mode
- */
-struct createbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: AP, Ad-HoC, Infra
* Notes: To set the NIC mode of RTL8711
* Command Mode
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 4/8] staging: rtl8712: removed unused wrapper structs
Date: Mon, 27 Jul 2015 21:41:13 -0700
Message-Id: <75dcdd4644344c7c4f0ccabf8a0e28bce7974349.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Remove wrapper structs that just wrap struct ndis_wlan_bssid_ex,
and are unused.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.h b/drivers/staging/rtl8712/rtl871x_cmd.h
index cb8225b..818cd88 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.h
+++ b/drivers/staging/rtl8712/rtl871x_cmd.h
@@ -123,15 +123,6 @@ struct usb_suspend_parm {
};
/*
- * Caller Mode: Infra, Ad-Hoc
- * Notes: To join the specified bss
- * Command Event Mode
- */
-struct joinbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: Infra, Ad-HoC(C)
* Notes: To disconnect the current associated BSS
* Command Mode
@@ -141,15 +132,6 @@ struct disconnect_parm {
};
/*
- * Caller Mode: AP, Ad-HoC(M)
- * Notes: To create a BSS
- * Command Mode
- */
-struct createbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: AP, Ad-HoC, Infra
* Notes: To set the NIC mode of RTL8711
* Command Mode
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 4/8] staging: rtl8712: removed unused wrapper structs
Date: Mon, 27 Jul 2015 21:41:13 -0700
Message-Id: <75dcdd4644344c7c4f0ccabf8a0e28bce7974349.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Remove wrapper structs that just wrap struct ndis_wlan_bssid_ex,
and are unused.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.h b/drivers/staging/rtl8712/rtl871x_cmd.h
index cb8225b..818cd88 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.h
+++ b/drivers/staging/rtl8712/rtl871x_cmd.h
@@ -123,15 +123,6 @@ struct usb_suspend_parm {
};
/*
- * Caller Mode: Infra, Ad-Hoc
- * Notes: To join the specified bss
- * Command Event Mode
- */
-struct joinbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: Infra, Ad-HoC(C)
* Notes: To disconnect the current associated BSS
* Command Mode
@@ -141,15 +132,6 @@ struct disconnect_parm {
};
/*
- * Caller Mode: AP, Ad-HoC(M)
- * Notes: To create a BSS
- * Command Mode
- */
-struct createbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: AP, Ad-HoC, Infra
* Notes: To set the NIC mode of RTL8711
* Command Mode
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 4/8] staging: rtl8712: removed unused wrapper structs
Date: Mon, 27 Jul 2015 21:41:13 -0700
Message-Id: <75dcdd4644344c7c4f0ccabf8a0e28bce7974349.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Remove wrapper structs that just wrap struct ndis_wlan_bssid_ex,
and are unused.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.h b/drivers/staging/rtl8712/rtl871x_cmd.h
index cb8225b..818cd88 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.h
+++ b/drivers/staging/rtl8712/rtl871x_cmd.h
@@ -123,15 +123,6 @@ struct usb_suspend_parm {
};
/*
- * Caller Mode: Infra, Ad-Hoc
- * Notes: To join the specified bss
- * Command Event Mode
- */
-struct joinbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: Infra, Ad-HoC(C)
* Notes: To disconnect the current associated BSS
* Command Mode
@@ -141,15 +132,6 @@ struct disconnect_parm {
};
/*
- * Caller Mode: AP, Ad-HoC(M)
- * Notes: To create a BSS
- * Command Mode
- */
-struct createbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: AP, Ad-HoC, Infra
* Notes: To set the NIC mode of RTL8711
* Command Mode
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 4/8] staging: rtl8712: removed unused wrapper structs
Date: Mon, 27 Jul 2015 21:41:13 -0700
Message-Id: <75dcdd4644344c7c4f0ccabf8a0e28bce7974349.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Remove wrapper structs that just wrap struct ndis_wlan_bssid_ex,
and are unused.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.h b/drivers/staging/rtl8712/rtl871x_cmd.h
index cb8225b..818cd88 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.h
+++ b/drivers/staging/rtl8712/rtl871x_cmd.h
@@ -123,15 +123,6 @@ struct usb_suspend_parm {
};
/*
- * Caller Mode: Infra, Ad-Hoc
- * Notes: To join the specified bss
- * Command Event Mode
- */
-struct joinbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: Infra, Ad-HoC(C)
* Notes: To disconnect the current associated BSS
* Command Mode
@@ -141,15 +132,6 @@ struct disconnect_parm {
};
/*
- * Caller Mode: AP, Ad-HoC(M)
- * Notes: To create a BSS
- * Command Mode
- */
-struct createbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: AP, Ad-HoC, Infra
* Notes: To set the NIC mode of RTL8711
* Command Mode
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 4/8] staging: rtl8712: removed unused wrapper structs
Date: Mon, 27 Jul 2015 21:41:13 -0700
Message-Id: <75dcdd4644344c7c4f0ccabf8a0e28bce7974349.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Remove wrapper structs that just wrap struct ndis_wlan_bssid_ex,
and are unused.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.h b/drivers/staging/rtl8712/rtl871x_cmd.h
index cb8225b..818cd88 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.h
+++ b/drivers/staging/rtl8712/rtl871x_cmd.h
@@ -123,15 +123,6 @@ struct usb_suspend_parm {
};
/*
- * Caller Mode: Infra, Ad-Hoc
- * Notes: To join the specified bss
- * Command Event Mode
- */
-struct joinbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: Infra, Ad-HoC(C)
* Notes: To disconnect the current associated BSS
* Command Mode
@@ -141,15 +132,6 @@ struct disconnect_parm {
};
/*
- * Caller Mode: AP, Ad-HoC(M)
- * Notes: To create a BSS
- * Command Mode
- */
-struct createbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: AP, Ad-HoC, Infra
* Notes: To set the NIC mode of RTL8711
* Command Mode
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 4/8] staging: rtl8712: removed unused wrapper structs
Date: Mon, 27 Jul 2015 21:41:13 -0700
Message-Id: <75dcdd4644344c7c4f0ccabf8a0e28bce7974349.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Remove wrapper structs that just wrap struct ndis_wlan_bssid_ex,
and are unused.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.h b/drivers/staging/rtl8712/rtl871x_cmd.h
index cb8225b..818cd88 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.h
+++ b/drivers/staging/rtl8712/rtl871x_cmd.h
@@ -123,15 +123,6 @@ struct usb_suspend_parm {
};
/*
- * Caller Mode: Infra, Ad-Hoc
- * Notes: To join the specified bss
- * Command Event Mode
- */
-struct joinbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: Infra, Ad-HoC(C)
* Notes: To disconnect the current associated BSS
* Command Mode
@@ -141,15 +132,6 @@ struct disconnect_parm {
};
/*
- * Caller Mode: AP, Ad-HoC(M)
- * Notes: To create a BSS
- * Command Mode
- */
-struct createbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: AP, Ad-HoC, Infra
* Notes: To set the NIC mode of RTL8711
* Command Mode
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 4/8] staging: rtl8712: removed unused wrapper structs
Date: Mon, 27 Jul 2015 21:41:13 -0700
Message-Id: <75dcdd4644344c7c4f0ccabf8a0e28bce7974349.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Remove wrapper structs that just wrap struct ndis_wlan_bssid_ex,
and are unused.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.h b/drivers/staging/rtl8712/rtl871x_cmd.h
index cb8225b..818cd88 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.h
+++ b/drivers/staging/rtl8712/rtl871x_cmd.h
@@ -123,15 +123,6 @@ struct usb_suspend_parm {
};
/*
- * Caller Mode: Infra, Ad-Hoc
- * Notes: To join the specified bss
- * Command Event Mode
- */
-struct joinbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: Infra, Ad-HoC(C)
* Notes: To disconnect the current associated BSS
* Command Mode
@@ -141,15 +132,6 @@ struct disconnect_parm {
};
/*
- * Caller Mode: AP, Ad-HoC(M)
- * Notes: To create a BSS
- * Command Mode
- */
-struct createbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: AP, Ad-HoC, Infra
* Notes: To set the NIC mode of RTL8711
* Command Mode
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 4/8] staging: rtl8712: removed unused wrapper structs
Date: Mon, 27 Jul 2015 21:41:13 -0700
Message-Id: <75dcdd4644344c7c4f0ccabf8a0e28bce7974349.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Remove wrapper structs that just wrap struct ndis_wlan_bssid_ex,
and are unused.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.h b/drivers/staging/rtl8712/rtl871x_cmd.h
index cb8225b..818cd88 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.h
+++ b/drivers/staging/rtl8712/rtl871x_cmd.h
@@ -123,15 +123,6 @@ struct usb_suspend_parm {
};
/*
- * Caller Mode: Infra, Ad-Hoc
- * Notes: To join the specified bss
- * Command Event Mode
- */
-struct joinbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: Infra, Ad-HoC(C)
* Notes: To disconnect the current associated BSS
* Command Mode
@@ -141,15 +132,6 @@ struct disconnect_parm {
};
/*
- * Caller Mode: AP, Ad-HoC(M)
- * Notes: To create a BSS
- * Command Mode
- */
-struct createbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: AP, Ad-HoC, Infra
* Notes: To set the NIC mode of RTL8711
* Command Mode
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 4/8] staging: rtl8712: removed unused wrapper structs
Date: Mon, 27 Jul 2015 21:41:13 -0700
Message-Id: <75dcdd4644344c7c4f0ccabf8a0e28bce7974349.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Remove wrapper structs that just wrap struct ndis_wlan_bssid_ex,
and are unused.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.h b/drivers/staging/rtl8712/rtl871x_cmd.h
index cb8225b..818cd88 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.h
+++ b/drivers/staging/rtl8712/rtl871x_cmd.h
@@ -123,15 +123,6 @@ struct usb_suspend_parm {
};
/*
- * Caller Mode: Infra, Ad-Hoc
- * Notes: To join the specified bss
- * Command Event Mode
- */
-struct joinbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: Infra, Ad-HoC(C)
* Notes: To disconnect the current associated BSS
* Command Mode
@@ -141,15 +132,6 @@ struct disconnect_parm {
};
/*
- * Caller Mode: AP, Ad-HoC(M)
- * Notes: To create a BSS
- * Command Mode
- */
-struct createbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: AP, Ad-HoC, Infra
* Notes: To set the NIC mode of RTL8711
* Command Mode
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 4/8] staging: rtl8712: removed unused wrapper structs
Date: Mon, 27 Jul 2015 21:41:13 -0700
Message-Id: <75dcdd4644344c7c4f0ccabf8a0e28bce7974349.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Remove wrapper structs that just wrap struct ndis_wlan_bssid_ex,
and are unused.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.h b/drivers/staging/rtl8712/rtl871x_cmd.h
index cb8225b..818cd88 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.h
+++ b/drivers/staging/rtl8712/rtl871x_cmd.h
@@ -123,15 +123,6 @@ struct usb_suspend_parm {
};
/*
- * Caller Mode: Infra, Ad-Hoc
- * Notes: To join the specified bss
- * Command Event Mode
- */
-struct joinbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: Infra, Ad-HoC(C)
* Notes: To disconnect the current associated BSS
* Command Mode
@@ -141,15 +132,6 @@ struct disconnect_parm {
};
/*
- * Caller Mode: AP, Ad-HoC(M)
- * Notes: To create a BSS
- * Command Mode
- */
-struct createbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: AP, Ad-HoC, Infra
* Notes: To set the NIC mode of RTL8711
* Command Mode
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 4/8] staging: rtl8712: removed unused wrapper structs
Date: Mon, 27 Jul 2015 21:41:13 -0700
Message-Id: <75dcdd4644344c7c4f0ccabf8a0e28bce7974349.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Remove wrapper structs that just wrap struct ndis_wlan_bssid_ex,
and are unused.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.h b/drivers/staging/rtl8712/rtl871x_cmd.h
index cb8225b..818cd88 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.h
+++ b/drivers/staging/rtl8712/rtl871x_cmd.h
@@ -123,15 +123,6 @@ struct usb_suspend_parm {
};
/*
- * Caller Mode: Infra, Ad-Hoc
- * Notes: To join the specified bss
- * Command Event Mode
- */
-struct joinbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: Infra, Ad-HoC(C)
* Notes: To disconnect the current associated BSS
* Command Mode
@@ -141,15 +132,6 @@ struct disconnect_parm {
};
/*
- * Caller Mode: AP, Ad-HoC(M)
- * Notes: To create a BSS
- * Command Mode
- */
-struct createbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: AP, Ad-HoC, Infra
* Notes: To set the NIC mode of RTL8711
* Command Mode
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 4/8] staging: rtl8712: removed unused wrapper structs
Date: Mon, 27 Jul 2015 21:41:13 -0700
Message-Id: <75dcdd4644344c7c4f0ccabf8a0e28bce7974349.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Remove wrapper structs that just wrap struct ndis_wlan_bssid_ex,
and are unused.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.h b/drivers/staging/rtl8712/rtl871x_cmd.h
index cb8225b..818cd88 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.h
+++ b/drivers/staging/rtl8712/rtl871x_cmd.h
@@ -123,15 +123,6 @@ struct usb_suspend_parm {
};
/*
- * Caller Mode: Infra, Ad-Hoc
- * Notes: To join the specified bss
- * Command Event Mode
- */
-struct joinbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: Infra, Ad-HoC(C)
* Notes: To disconnect the current associated BSS
* Command Mode
@@ -141,15 +132,6 @@ struct disconnect_parm {
};
/*
- * Caller Mode: AP, Ad-HoC(M)
- * Notes: To create a BSS
- * Command Mode
- */
-struct createbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: AP, Ad-HoC, Infra
* Notes: To set the NIC mode of RTL8711
* Command Mode
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 4/8] staging: rtl8712: removed unused wrapper structs
Date: Mon, 27 Jul 2015 21:41:13 -0700
Message-Id: <75dcdd4644344c7c4f0ccabf8a0e28bce7974349.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Remove wrapper structs that just wrap struct ndis_wlan_bssid_ex,
and are unused.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.h b/drivers/staging/rtl8712/rtl871x_cmd.h
index cb8225b..818cd88 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.h
+++ b/drivers/staging/rtl8712/rtl871x_cmd.h
@@ -123,15 +123,6 @@ struct usb_suspend_parm {
};
/*
- * Caller Mode: Infra, Ad-Hoc
- * Notes: To join the specified bss
- * Command Event Mode
- */
-struct joinbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: Infra, Ad-HoC(C)
* Notes: To disconnect the current associated BSS
* Command Mode
@@ -141,15 +132,6 @@ struct disconnect_parm {
};
/*
- * Caller Mode: AP, Ad-HoC(M)
- * Notes: To create a BSS
- * Command Mode
- */
-struct createbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: AP, Ad-HoC, Infra
* Notes: To set the NIC mode of RTL8711
* Command Mode
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 4/8] staging: rtl8712: removed unused wrapper structs
Date: Mon, 27 Jul 2015 21:41:13 -0700
Message-Id: <75dcdd4644344c7c4f0ccabf8a0e28bce7974349.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Remove wrapper structs that just wrap struct ndis_wlan_bssid_ex,
and are unused.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.h b/drivers/staging/rtl8712/rtl871x_cmd.h
index cb8225b..818cd88 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.h
+++ b/drivers/staging/rtl8712/rtl871x_cmd.h
@@ -123,15 +123,6 @@ struct usb_suspend_parm {
};
/*
- * Caller Mode: Infra, Ad-Hoc
- * Notes: To join the specified bss
- * Command Event Mode
- */
-struct joinbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: Infra, Ad-HoC(C)
* Notes: To disconnect the current associated BSS
* Command Mode
@@ -141,15 +132,6 @@ struct disconnect_parm {
};
/*
- * Caller Mode: AP, Ad-HoC(M)
- * Notes: To create a BSS
- * Command Mode
- */
-struct createbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: AP, Ad-HoC, Infra
* Notes: To set the NIC mode of RTL8711
* Command Mode
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 4/8] staging: rtl8712: removed unused wrapper structs
Date: Mon, 27 Jul 2015 21:41:13 -0700
Message-Id: <75dcdd4644344c7c4f0ccabf8a0e28bce7974349.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Remove wrapper structs that just wrap struct ndis_wlan_bssid_ex,
and are unused.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.h b/drivers/staging/rtl8712/rtl871x_cmd.h
index cb8225b..818cd88 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.h
+++ b/drivers/staging/rtl8712/rtl871x_cmd.h
@@ -123,15 +123,6 @@ struct usb_suspend_parm {
};
/*
- * Caller Mode: Infra, Ad-Hoc
- * Notes: To join the specified bss
- * Command Event Mode
- */
-struct joinbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: Infra, Ad-HoC(C)
* Notes: To disconnect the current associated BSS
* Command Mode
@@ -141,15 +132,6 @@ struct disconnect_parm {
};
/*
- * Caller Mode: AP, Ad-HoC(M)
- * Notes: To create a BSS
- * Command Mode
- */
-struct createbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: AP, Ad-HoC, Infra
* Notes: To set the NIC mode of RTL8711
* Command Mode
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 4/8] staging: rtl8712: removed unused wrapper structs
Date: Mon, 27 Jul 2015 21:41:13 -0700
Message-Id: <75dcdd4644344c7c4f0ccabf8a0e28bce7974349.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Remove wrapper structs that just wrap struct ndis_wlan_bssid_ex,
and are unused.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.h b/drivers/staging/rtl8712/rtl871x_cmd.h
index cb8225b..818cd88 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.h
+++ b/drivers/staging/rtl8712/rtl871x_cmd.h
@@ -123,15 +123,6 @@ struct usb_suspend_parm {
};
/*
- * Caller Mode: Infra, Ad-Hoc
- * Notes: To join the specified bss
- * Command Event Mode
- */
-struct joinbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: Infra, Ad-HoC(C)
* Notes: To disconnect the current associated BSS
* Command Mode
@@ -141,15 +132,6 @@ struct disconnect_parm {
};
/*
- * Caller Mode: AP, Ad-HoC(M)
- * Notes: To create a BSS
- * Command Mode
- */
-struct createbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: AP, Ad-HoC, Infra
* Notes: To set the NIC mode of RTL8711
* Command Mode
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 4/8] staging: rtl8712: removed unused wrapper structs
Date: Mon, 27 Jul 2015 21:41:13 -0700
Message-Id: <75dcdd4644344c7c4f0ccabf8a0e28bce7974349.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Remove wrapper structs that just wrap struct ndis_wlan_bssid_ex,
and are unused.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.h b/drivers/staging/rtl8712/rtl871x_cmd.h
index cb8225b..818cd88 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.h
+++ b/drivers/staging/rtl8712/rtl871x_cmd.h
@@ -123,15 +123,6 @@ struct usb_suspend_parm {
};
/*
- * Caller Mode: Infra, Ad-Hoc
- * Notes: To join the specified bss
- * Command Event Mode
- */
-struct joinbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: Infra, Ad-HoC(C)
* Notes: To disconnect the current associated BSS
* Command Mode
@@ -141,15 +132,6 @@ struct disconnect_parm {
};
/*
- * Caller Mode: AP, Ad-HoC(M)
- * Notes: To create a BSS
- * Command Mode
- */
-struct createbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: AP, Ad-HoC, Infra
* Notes: To set the NIC mode of RTL8711
* Command Mode
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 4/8] staging: rtl8712: removed unused wrapper structs
Date: Mon, 27 Jul 2015 21:41:13 -0700
Message-Id: <75dcdd4644344c7c4f0ccabf8a0e28bce7974349.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Remove wrapper structs that just wrap struct ndis_wlan_bssid_ex,
and are unused.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.h b/drivers/staging/rtl8712/rtl871x_cmd.h
index cb8225b..818cd88 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.h
+++ b/drivers/staging/rtl8712/rtl871x_cmd.h
@@ -123,15 +123,6 @@ struct usb_suspend_parm {
};
/*
- * Caller Mode: Infra, Ad-Hoc
- * Notes: To join the specified bss
- * Command Event Mode
- */
-struct joinbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: Infra, Ad-HoC(C)
* Notes: To disconnect the current associated BSS
* Command Mode
@@ -141,15 +132,6 @@ struct disconnect_parm {
};
/*
- * Caller Mode: AP, Ad-HoC(M)
- * Notes: To create a BSS
- * Command Mode
- */
-struct createbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: AP, Ad-HoC, Infra
* Notes: To set the NIC mode of RTL8711
* Command Mode
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 4/8] staging: rtl8712: removed unused wrapper structs
Date: Mon, 27 Jul 2015 21:41:13 -0700
Message-Id: <75dcdd4644344c7c4f0ccabf8a0e28bce7974349.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Remove wrapper structs that just wrap struct ndis_wlan_bssid_ex,
and are unused.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.h b/drivers/staging/rtl8712/rtl871x_cmd.h
index cb8225b..818cd88 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.h
+++ b/drivers/staging/rtl8712/rtl871x_cmd.h
@@ -123,15 +123,6 @@ struct usb_suspend_parm {
};
/*
- * Caller Mode: Infra, Ad-Hoc
- * Notes: To join the specified bss
- * Command Event Mode
- */
-struct joinbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: Infra, Ad-HoC(C)
* Notes: To disconnect the current associated BSS
* Command Mode
@@ -141,15 +132,6 @@ struct disconnect_parm {
};
/*
- * Caller Mode: AP, Ad-HoC(M)
- * Notes: To create a BSS
- * Command Mode
- */
-struct createbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: AP, Ad-HoC, Infra
* Notes: To set the NIC mode of RTL8711
* Command Mode
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 4/8] staging: rtl8712: removed unused wrapper structs
Date: Mon, 27 Jul 2015 21:41:13 -0700
Message-Id: <75dcdd4644344c7c4f0ccabf8a0e28bce7974349.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Remove wrapper structs that just wrap struct ndis_wlan_bssid_ex,
and are unused.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.h b/drivers/staging/rtl8712/rtl871x_cmd.h
index cb8225b..818cd88 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.h
+++ b/drivers/staging/rtl8712/rtl871x_cmd.h
@@ -123,15 +123,6 @@ struct usb_suspend_parm {
};
/*
- * Caller Mode: Infra, Ad-Hoc
- * Notes: To join the specified bss
- * Command Event Mode
- */
-struct joinbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: Infra, Ad-HoC(C)
* Notes: To disconnect the current associated BSS
* Command Mode
@@ -141,15 +132,6 @@ struct disconnect_parm {
};
/*
- * Caller Mode: AP, Ad-HoC(M)
- * Notes: To create a BSS
- * Command Mode
- */
-struct createbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: AP, Ad-HoC, Infra
* Notes: To set the NIC mode of RTL8711
* Command Mode
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 4/8] staging: rtl8712: removed unused wrapper structs
Date: Mon, 27 Jul 2015 21:41:13 -0700
Message-Id: <75dcdd4644344c7c4f0ccabf8a0e28bce7974349.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Remove wrapper structs that just wrap struct ndis_wlan_bssid_ex,
and are unused.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.h b/drivers/staging/rtl8712/rtl871x_cmd.h
index cb8225b..818cd88 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.h
+++ b/drivers/staging/rtl8712/rtl871x_cmd.h
@@ -123,15 +123,6 @@ struct usb_suspend_parm {
};
/*
- * Caller Mode: Infra, Ad-Hoc
- * Notes: To join the specified bss
- * Command Event Mode
- */
-struct joinbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: Infra, Ad-HoC(C)
* Notes: To disconnect the current associated BSS
* Command Mode
@@ -141,15 +132,6 @@ struct disconnect_parm {
};
/*
- * Caller Mode: AP, Ad-HoC(M)
- * Notes: To create a BSS
- * Command Mode
- */
-struct createbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: AP, Ad-HoC, Infra
* Notes: To set the NIC mode of RTL8711
* Command Mode
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 4/8] staging: rtl8712: removed unused wrapper structs
Date: Mon, 27 Jul 2015 21:41:13 -0700
Message-Id: <75dcdd4644344c7c4f0ccabf8a0e28bce7974349.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Remove wrapper structs that just wrap struct ndis_wlan_bssid_ex,
and are unused.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.h b/drivers/staging/rtl8712/rtl871x_cmd.h
index cb8225b..818cd88 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.h
+++ b/drivers/staging/rtl8712/rtl871x_cmd.h
@@ -123,15 +123,6 @@ struct usb_suspend_parm {
};
/*
- * Caller Mode: Infra, Ad-Hoc
- * Notes: To join the specified bss
- * Command Event Mode
- */
-struct joinbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: Infra, Ad-HoC(C)
* Notes: To disconnect the current associated BSS
* Command Mode
@@ -141,15 +132,6 @@ struct disconnect_parm {
};
/*
- * Caller Mode: AP, Ad-HoC(M)
- * Notes: To create a BSS
- * Command Mode
- */
-struct createbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: AP, Ad-HoC, Infra
* Notes: To set the NIC mode of RTL8711
* Command Mode
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 4/8] staging: rtl8712: removed unused wrapper structs
Date: Mon, 27 Jul 2015 21:41:13 -0700
Message-Id: <75dcdd4644344c7c4f0ccabf8a0e28bce7974349.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Remove wrapper structs that just wrap struct ndis_wlan_bssid_ex,
and are unused.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.h b/drivers/staging/rtl8712/rtl871x_cmd.h
index cb8225b..818cd88 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.h
+++ b/drivers/staging/rtl8712/rtl871x_cmd.h
@@ -123,15 +123,6 @@ struct usb_suspend_parm {
};
/*
- * Caller Mode: Infra, Ad-Hoc
- * Notes: To join the specified bss
- * Command Event Mode
- */
-struct joinbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: Infra, Ad-HoC(C)
* Notes: To disconnect the current associated BSS
* Command Mode
@@ -141,15 +132,6 @@ struct disconnect_parm {
};
/*
- * Caller Mode: AP, Ad-HoC(M)
- * Notes: To create a BSS
- * Command Mode
- */
-struct createbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: AP, Ad-HoC, Infra
* Notes: To set the NIC mode of RTL8711
* Command Mode
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 4/8] staging: rtl8712: removed unused wrapper structs
Date: Mon, 27 Jul 2015 21:41:13 -0700
Message-Id: <75dcdd4644344c7c4f0ccabf8a0e28bce7974349.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Remove wrapper structs that just wrap struct ndis_wlan_bssid_ex,
and are unused.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.h b/drivers/staging/rtl8712/rtl871x_cmd.h
index cb8225b..818cd88 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.h
+++ b/drivers/staging/rtl8712/rtl871x_cmd.h
@@ -123,15 +123,6 @@ struct usb_suspend_parm {
};
/*
- * Caller Mode: Infra, Ad-Hoc
- * Notes: To join the specified bss
- * Command Event Mode
- */
-struct joinbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: Infra, Ad-HoC(C)
* Notes: To disconnect the current associated BSS
* Command Mode
@@ -141,15 +132,6 @@ struct disconnect_parm {
};
/*
- * Caller Mode: AP, Ad-HoC(M)
- * Notes: To create a BSS
- * Command Mode
- */
-struct createbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: AP, Ad-HoC, Infra
* Notes: To set the NIC mode of RTL8711
* Command Mode
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 4/8] staging: rtl8712: removed unused wrapper structs
Date: Mon, 27 Jul 2015 21:41:13 -0700
Message-Id: <75dcdd4644344c7c4f0ccabf8a0e28bce7974349.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Remove wrapper structs that just wrap struct ndis_wlan_bssid_ex,
and are unused.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.h b/drivers/staging/rtl8712/rtl871x_cmd.h
index cb8225b..818cd88 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.h
+++ b/drivers/staging/rtl8712/rtl871x_cmd.h
@@ -123,15 +123,6 @@ struct usb_suspend_parm {
};
/*
- * Caller Mode: Infra, Ad-Hoc
- * Notes: To join the specified bss
- * Command Event Mode
- */
-struct joinbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: Infra, Ad-HoC(C)
* Notes: To disconnect the current associated BSS
* Command Mode
@@ -141,15 +132,6 @@ struct disconnect_parm {
};
/*
- * Caller Mode: AP, Ad-HoC(M)
- * Notes: To create a BSS
- * Command Mode
- */
-struct createbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: AP, Ad-HoC, Infra
* Notes: To set the NIC mode of RTL8711
* Command Mode
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 4/8] staging: rtl8712: removed unused wrapper structs
Date: Mon, 27 Jul 2015 21:41:13 -0700
Message-Id: <75dcdd4644344c7c4f0ccabf8a0e28bce7974349.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Remove wrapper structs that just wrap struct ndis_wlan_bssid_ex,
and are unused.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.h b/drivers/staging/rtl8712/rtl871x_cmd.h
index cb8225b..818cd88 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.h
+++ b/drivers/staging/rtl8712/rtl871x_cmd.h
@@ -123,15 +123,6 @@ struct usb_suspend_parm {
};
/*
- * Caller Mode: Infra, Ad-Hoc
- * Notes: To join the specified bss
- * Command Event Mode
- */
-struct joinbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: Infra, Ad-HoC(C)
* Notes: To disconnect the current associated BSS
* Command Mode
@@ -141,15 +132,6 @@ struct disconnect_parm {
};
/*
- * Caller Mode: AP, Ad-HoC(M)
- * Notes: To create a BSS
- * Command Mode
- */
-struct createbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: AP, Ad-HoC, Infra
* Notes: To set the NIC mode of RTL8711
* Command Mode
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 4/8] staging: rtl8712: removed unused wrapper structs
Date: Mon, 27 Jul 2015 21:41:13 -0700
Message-Id: <75dcdd4644344c7c4f0ccabf8a0e28bce7974349.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Remove wrapper structs that just wrap struct ndis_wlan_bssid_ex,
and are unused.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.h b/drivers/staging/rtl8712/rtl871x_cmd.h
index cb8225b..818cd88 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.h
+++ b/drivers/staging/rtl8712/rtl871x_cmd.h
@@ -123,15 +123,6 @@ struct usb_suspend_parm {
};
/*
- * Caller Mode: Infra, Ad-Hoc
- * Notes: To join the specified bss
- * Command Event Mode
- */
-struct joinbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: Infra, Ad-HoC(C)
* Notes: To disconnect the current associated BSS
* Command Mode
@@ -141,15 +132,6 @@ struct disconnect_parm {
};
/*
- * Caller Mode: AP, Ad-HoC(M)
- * Notes: To create a BSS
- * Command Mode
- */
-struct createbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: AP, Ad-HoC, Infra
* Notes: To set the NIC mode of RTL8711
* Command Mode
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 4/8] staging: rtl8712: removed unused wrapper structs
Date: Mon, 27 Jul 2015 21:41:13 -0700
Message-Id: <75dcdd4644344c7c4f0ccabf8a0e28bce7974349.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Remove wrapper structs that just wrap struct ndis_wlan_bssid_ex,
and are unused.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.h b/drivers/staging/rtl8712/rtl871x_cmd.h
index cb8225b..818cd88 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.h
+++ b/drivers/staging/rtl8712/rtl871x_cmd.h
@@ -123,15 +123,6 @@ struct usb_suspend_parm {
};
/*
- * Caller Mode: Infra, Ad-Hoc
- * Notes: To join the specified bss
- * Command Event Mode
- */
-struct joinbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: Infra, Ad-HoC(C)
* Notes: To disconnect the current associated BSS
* Command Mode
@@ -141,15 +132,6 @@ struct disconnect_parm {
};
/*
- * Caller Mode: AP, Ad-HoC(M)
- * Notes: To create a BSS
- * Command Mode
- */
-struct createbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: AP, Ad-HoC, Infra
* Notes: To set the NIC mode of RTL8711
* Command Mode
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 4/8] staging: rtl8712: removed unused wrapper structs
Date: Mon, 27 Jul 2015 21:41:13 -0700
Message-Id: <75dcdd4644344c7c4f0ccabf8a0e28bce7974349.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Remove wrapper structs that just wrap struct ndis_wlan_bssid_ex,
and are unused.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.h b/drivers/staging/rtl8712/rtl871x_cmd.h
index cb8225b..818cd88 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.h
+++ b/drivers/staging/rtl8712/rtl871x_cmd.h
@@ -123,15 +123,6 @@ struct usb_suspend_parm {
};
/*
- * Caller Mode: Infra, Ad-Hoc
- * Notes: To join the specified bss
- * Command Event Mode
- */
-struct joinbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: Infra, Ad-HoC(C)
* Notes: To disconnect the current associated BSS
* Command Mode
@@ -141,15 +132,6 @@ struct disconnect_parm {
};
/*
- * Caller Mode: AP, Ad-HoC(M)
- * Notes: To create a BSS
- * Command Mode
- */
-struct createbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: AP, Ad-HoC, Infra
* Notes: To set the NIC mode of RTL8711
* Command Mode
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 4/8] staging: rtl8712: removed unused wrapper structs
Date: Mon, 27 Jul 2015 21:41:13 -0700
Message-Id: <75dcdd4644344c7c4f0ccabf8a0e28bce7974349.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Remove wrapper structs that just wrap struct ndis_wlan_bssid_ex,
and are unused.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.h b/drivers/staging/rtl8712/rtl871x_cmd.h
index cb8225b..818cd88 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.h
+++ b/drivers/staging/rtl8712/rtl871x_cmd.h
@@ -123,15 +123,6 @@ struct usb_suspend_parm {
};
/*
- * Caller Mode: Infra, Ad-Hoc
- * Notes: To join the specified bss
- * Command Event Mode
- */
-struct joinbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: Infra, Ad-HoC(C)
* Notes: To disconnect the current associated BSS
* Command Mode
@@ -141,15 +132,6 @@ struct disconnect_parm {
};
/*
- * Caller Mode: AP, Ad-HoC(M)
- * Notes: To create a BSS
- * Command Mode
- */
-struct createbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: AP, Ad-HoC, Infra
* Notes: To set the NIC mode of RTL8711
* Command Mode
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 4/8] staging: rtl8712: removed unused wrapper structs
Date: Mon, 27 Jul 2015 21:41:13 -0700
Message-Id: <75dcdd4644344c7c4f0ccabf8a0e28bce7974349.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Remove wrapper structs that just wrap struct ndis_wlan_bssid_ex,
and are unused.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.h b/drivers/staging/rtl8712/rtl871x_cmd.h
index cb8225b..818cd88 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.h
+++ b/drivers/staging/rtl8712/rtl871x_cmd.h
@@ -123,15 +123,6 @@ struct usb_suspend_parm {
};
/*
- * Caller Mode: Infra, Ad-Hoc
- * Notes: To join the specified bss
- * Command Event Mode
- */
-struct joinbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: Infra, Ad-HoC(C)
* Notes: To disconnect the current associated BSS
* Command Mode
@@ -141,15 +132,6 @@ struct disconnect_parm {
};
/*
- * Caller Mode: AP, Ad-HoC(M)
- * Notes: To create a BSS
- * Command Mode
- */
-struct createbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: AP, Ad-HoC, Infra
* Notes: To set the NIC mode of RTL8711
* Command Mode
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 4/8] staging: rtl8712: removed unused wrapper structs
Date: Mon, 27 Jul 2015 21:41:13 -0700
Message-Id: <75dcdd4644344c7c4f0ccabf8a0e28bce7974349.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Remove wrapper structs that just wrap struct ndis_wlan_bssid_ex,
and are unused.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.h b/drivers/staging/rtl8712/rtl871x_cmd.h
index cb8225b..818cd88 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.h
+++ b/drivers/staging/rtl8712/rtl871x_cmd.h
@@ -123,15 +123,6 @@ struct usb_suspend_parm {
};
/*
- * Caller Mode: Infra, Ad-Hoc
- * Notes: To join the specified bss
- * Command Event Mode
- */
-struct joinbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: Infra, Ad-HoC(C)
* Notes: To disconnect the current associated BSS
* Command Mode
@@ -141,15 +132,6 @@ struct disconnect_parm {
};
/*
- * Caller Mode: AP, Ad-HoC(M)
- * Notes: To create a BSS
- * Command Mode
- */
-struct createbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: AP, Ad-HoC, Infra
* Notes: To set the NIC mode of RTL8711
* Command Mode
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 4/8] staging: rtl8712: removed unused wrapper structs
Date: Mon, 27 Jul 2015 21:41:13 -0700
Message-Id: <75dcdd4644344c7c4f0ccabf8a0e28bce7974349.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Remove wrapper structs that just wrap struct ndis_wlan_bssid_ex,
and are unused.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.h b/drivers/staging/rtl8712/rtl871x_cmd.h
index cb8225b..818cd88 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.h
+++ b/drivers/staging/rtl8712/rtl871x_cmd.h
@@ -123,15 +123,6 @@ struct usb_suspend_parm {
};
/*
- * Caller Mode: Infra, Ad-Hoc
- * Notes: To join the specified bss
- * Command Event Mode
- */
-struct joinbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: Infra, Ad-HoC(C)
* Notes: To disconnect the current associated BSS
* Command Mode
@@ -141,15 +132,6 @@ struct disconnect_parm {
};
/*
- * Caller Mode: AP, Ad-HoC(M)
- * Notes: To create a BSS
- * Command Mode
- */
-struct createbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: AP, Ad-HoC, Infra
* Notes: To set the NIC mode of RTL8711
* Command Mode
--
2.4.6
^ permalink raw reply related [flat|nested] 27+ messages in thread
* [PATCH V3 7/8] staging: rtl8712: remove typedefs
2015-07-28 4:41 [PATCH V3 0/8] clean up wlan_bssdef.h Joshua Clayton
` (3 preceding siblings ...)
2015-07-28 4:41 ` [PATCH V3 4/8] staging: rtl8712: removed unused wrapper structs Joshua Clayton
@ 2015-07-28 4:41 ` Joshua Clayton
2015-07-28 5:27 ` [PATCH V3 0/8] clean up wlan_bssdef.h Julia Lawall
` (11 subsequent siblings)
16 siblings, 0 replies; 27+ messages in thread
From: Joshua Clayton @ 2015-07-28 4:41 UTC (permalink / raw)
To: Larry Finger, Florian Schilhabel, Greg Kroah-Hartman,
Sudip Mukherjee, Nitin Kuppelur, Joshua Clayton,
Vaishali Thakkar, Tapasweni Pathak, Daniel Baluta,
Melike Yurtoglu, Max Perepelitsyn, Aya Mahfouz,
Cristina Opriceana, Dogukan Ergun, Julia Lawall, Dan Carpenter,
Haneen Mohammed, Rickard Strandqvist
Cc: devel, linux-kernel
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Daniel Baluta <daniel.baluta@intel.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Max Perepelitsyn <mperepelitsyn@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Dogukan Ergun <dogukan.ergun@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 7/8] staging: rtl8712: remove typedefs
Date: Mon, 27 Jul 2015 21:41:16 -0700
Message-Id: <cab9d5de1a7dada159f3bf2e1044ccc3fc831977.1438057939.git.stillcompiling@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
References: <cover.1438057939.git.stillcompiling@gmail.com>
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
^ permalink raw reply related [flat|nested] 27+ messages in thread
* Re: [PATCH V3 0/8] clean up wlan_bssdef.h
2015-07-28 4:41 [PATCH V3 0/8] clean up wlan_bssdef.h Joshua Clayton
` (4 preceding siblings ...)
2015-07-28 4:41 ` [PATCH V3 7/8] staging: rtl8712: remove typedefs Joshua Clayton
@ 2015-07-28 5:27 ` Julia Lawall
2015-07-28 12:38 ` Joshua Clayton
2015-07-28 14:15 ` [PATCH V3 RESEND 5/8] staging: rtl8712: remove duplicate struct Joshua Clayton
` (10 subsequent siblings)
16 siblings, 1 reply; 27+ messages in thread
From: Julia Lawall @ 2015-07-28 5:27 UTC (permalink / raw)
To: Joshua Clayton
Cc: Larry Finger, Florian Schilhabel, Greg Kroah-Hartman,
Sudip Mukherjee, Nitin Kuppelur, Vaishali Thakkar,
Tapasweni Pathak, Daniel Baluta, Melike Yurtoglu,
Max Perepelitsyn, Aya Mahfouz, Cristina Opriceana, Dogukan Ergun,
Julia Lawall, Dan Carpenter, Haneen Mohammed,
Rickard Strandqvist, devel, linux-kernel
Something horrible seems to have happened in your patch sending process,
and you have the same message over and over.
Also, you don't really need to seen the patch to everyone who has ever
touched the file. The following arguments can be useful:
--nokeywords --nogit --nogit-fallback --norolestats
julia
On Mon, 27 Jul 2015, Joshua Clayton wrote:
> The main goal of this series is to get rid of a needless typedef
> in the rtl8712 wlan driver.
>
> In the course of fixing that, I found a bug that can (at least in theory)
> lead to a overrun during a memcpy, as well as an identical struct with
> a different name, which use the typedef.
> Finally after cleaning up the typedef, change the name of the primary
> variable that used the typedef from "SupportedRates" to "rates", to
> conform to kernel coding style.
>
> Changes since V1:
> Do not make other logic changes while Changing the name of SupportedRates
> New patch 3/6 fixes a buggy comment that referred to the typedef
>
> Changes sinve V2:
> broke former patch 4, which was too big for git-send-email into 3 parts
>
> Joshua Clayton (8):
> staging: rtl8712: fix buggy size calculation
> staging: rtl8712: simplify size calculation
> staging: rtl8712: fix comment
> staging: rtl8712: removed unused wrapper structs
> staging: rtl8712: remove duplicate struct
> staging: rtl8712: rename function
> staging: rtl8712: remove typedefs
> staging: rtl8712: change SupportedRates to rates
>
> drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
> drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
> drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
> drivers/staging/rtl8712/rtl871x_event.h | 2 +-
> drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
> drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
> drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
> drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
> drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
> 9 files changed, 64 insertions(+), 139 deletions(-)
>
> --
> 2.4.6
>
> From: Joshua Clayton <stillcompiling@gmail.com>
> To: Larry Finger <Larry.Finger@lwfinger.net>,
> Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
> Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
> Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
> Nitin Kuppelur <nitinkuppelur@gmail.com>,
> Joshua Clayton <stillcompiling@gmail.com>,
> Vaishali Thakkar <vthakkar1994@gmail.com>,
> Tapasweni Pathak <tapaswenipathak@gmail.com>,
> Daniel Baluta <daniel.baluta@intel.com>,
> Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
> Max Perepelitsyn <mperepelitsyn@gmail.com>,
> Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
> Cristina Opriceana <cristina.opriceana@gmail.com>,
> Dogukan Ergun <dogukan.ergun@gmail.com>,
> Julia Lawall <Julia.Lawall@lip6.fr>,
> Dan Carpenter <dan.carpenter@oracle.com>,
> Haneen Mohammed <hamohammed.sa@gmail.com>,
> Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> Cc: devel@driverdev.osuosl.org,
> linux-kernel@vger.kernel.org
> Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
> Date: Mon, 27 Jul 2015 21:41:09 -0700
> Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
> X-Mailer: git-send-email 2.4.6
>
> The main goal of this series is to get rid of a needless typedef
> in the rtl8712 wlan driver.
>
> In the course of fixing that, I found a bug that can (at least in theory)
> lead to a overrun during a memcpy, as well as an identical struct with
> a different name, which use the typedef.
> Finally after cleaning up the typedef, change the name of the primary
> variable that used the typedef from "SupportedRates" to "rates", to
> conform to kernel coding style.
>
> Changes since V1:
> Do not make other logic changes while Changing the name of SupportedRates
> New patch 3/6 fixes a buggy comment that referred to the typedef
>
> Changes sinve V2:
> broke former patch 4, which was too big for git-send-email into 3 parts
>
> Joshua Clayton (8):
> staging: rtl8712: fix buggy size calculation
> staging: rtl8712: simplify size calculation
> staging: rtl8712: fix comment
> staging: rtl8712: removed unused wrapper structs
> staging: rtl8712: remove duplicate struct
> staging: rtl8712: rename function
> staging: rtl8712: remove typedefs
> staging: rtl8712: change SupportedRates to rates
>
> drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
> drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
> drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
> drivers/staging/rtl8712/rtl871x_event.h | 2 +-
> drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
> drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
> drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
> drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
> drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
> 9 files changed, 64 insertions(+), 139 deletions(-)
>
> --
> 2.4.6
>
> From: Joshua Clayton <stillcompiling@gmail.com>
> To: Larry Finger <Larry.Finger@lwfinger.net>,
> Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
> Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
> Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
> Nitin Kuppelur <nitinkuppelur@gmail.com>,
> Joshua Clayton <stillcompiling@gmail.com>,
> Vaishali Thakkar <vthakkar1994@gmail.com>,
> Tapasweni Pathak <tapaswenipathak@gmail.com>,
> Daniel Baluta <daniel.baluta@intel.com>,
> Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
> Max Perepelitsyn <mperepelitsyn@gmail.com>,
> Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
> Cristina Opriceana <cristina.opriceana@gmail.com>,
> Dogukan Ergun <dogukan.ergun@gmail.com>,
> Julia Lawall <Julia.Lawall@lip6.fr>,
> Dan Carpenter <dan.carpenter@oracle.com>,
> Haneen Mohammed <hamohammed.sa@gmail.com>,
> Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> Cc: devel@driverdev.osuosl.org,
> linux-kernel@vger.kernel.org
> Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
> Date: Mon, 27 Jul 2015 21:41:09 -0700
> Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
> X-Mailer: git-send-email 2.4.6
>
> The main goal of this series is to get rid of a needless typedef
> in the rtl8712 wlan driver.
>
> In the course of fixing that, I found a bug that can (at least in theory)
> lead to a overrun during a memcpy, as well as an identical struct with
> a different name, which use the typedef.
> Finally after cleaning up the typedef, change the name of the primary
> variable that used the typedef from "SupportedRates" to "rates", to
> conform to kernel coding style.
>
> Changes since V1:
> Do not make other logic changes while Changing the name of SupportedRates
> New patch 3/6 fixes a buggy comment that referred to the typedef
>
> Changes sinve V2:
> broke former patch 4, which was too big for git-send-email into 3 parts
>
> Joshua Clayton (8):
> staging: rtl8712: fix buggy size calculation
> staging: rtl8712: simplify size calculation
> staging: rtl8712: fix comment
> staging: rtl8712: removed unused wrapper structs
> staging: rtl8712: remove duplicate struct
> staging: rtl8712: rename function
> staging: rtl8712: remove typedefs
> staging: rtl8712: change SupportedRates to rates
>
> drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
> drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
> drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
> drivers/staging/rtl8712/rtl871x_event.h | 2 +-
> drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
> drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
> drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
> drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
> drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
> 9 files changed, 64 insertions(+), 139 deletions(-)
>
> --
> 2.4.6
>
> From: Joshua Clayton <stillcompiling@gmail.com>
> To: Larry Finger <Larry.Finger@lwfinger.net>,
> Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
> Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
> Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
> Nitin Kuppelur <nitinkuppelur@gmail.com>,
> Joshua Clayton <stillcompiling@gmail.com>,
> Vaishali Thakkar <vthakkar1994@gmail.com>,
> Tapasweni Pathak <tapaswenipathak@gmail.com>,
> Daniel Baluta <daniel.baluta@intel.com>,
> Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
> Max Perepelitsyn <mperepelitsyn@gmail.com>,
> Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
> Cristina Opriceana <cristina.opriceana@gmail.com>,
> Dogukan Ergun <dogukan.ergun@gmail.com>,
> Julia Lawall <Julia.Lawall@lip6.fr>,
> Dan Carpenter <dan.carpenter@oracle.com>,
> Haneen Mohammed <hamohammed.sa@gmail.com>,
> Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> Cc: devel@driverdev.osuosl.org,
> linux-kernel@vger.kernel.org
> Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
> Date: Mon, 27 Jul 2015 21:41:09 -0700
> Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
> X-Mailer: git-send-email 2.4.6
>
> The main goal of this series is to get rid of a needless typedef
> in the rtl8712 wlan driver.
>
> In the course of fixing that, I found a bug that can (at least in theory)
> lead to a overrun during a memcpy, as well as an identical struct with
> a different name, which use the typedef.
> Finally after cleaning up the typedef, change the name of the primary
> variable that used the typedef from "SupportedRates" to "rates", to
> conform to kernel coding style.
>
> Changes since V1:
> Do not make other logic changes while Changing the name of SupportedRates
> New patch 3/6 fixes a buggy comment that referred to the typedef
>
> Changes sinve V2:
> broke former patch 4, which was too big for git-send-email into 3 parts
>
> Joshua Clayton (8):
> staging: rtl8712: fix buggy size calculation
> staging: rtl8712: simplify size calculation
> staging: rtl8712: fix comment
> staging: rtl8712: removed unused wrapper structs
> staging: rtl8712: remove duplicate struct
> staging: rtl8712: rename function
> staging: rtl8712: remove typedefs
> staging: rtl8712: change SupportedRates to rates
>
> drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
> drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
> drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
> drivers/staging/rtl8712/rtl871x_event.h | 2 +-
> drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
> drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
> drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
> drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
> drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
> 9 files changed, 64 insertions(+), 139 deletions(-)
>
> --
> 2.4.6
>
> From: Joshua Clayton <stillcompiling@gmail.com>
> To: Larry Finger <Larry.Finger@lwfinger.net>,
> Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
> Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
> Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
> Nitin Kuppelur <nitinkuppelur@gmail.com>,
> Joshua Clayton <stillcompiling@gmail.com>,
> Vaishali Thakkar <vthakkar1994@gmail.com>,
> Tapasweni Pathak <tapaswenipathak@gmail.com>,
> Daniel Baluta <daniel.baluta@intel.com>,
> Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
> Max Perepelitsyn <mperepelitsyn@gmail.com>,
> Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
> Cristina Opriceana <cristina.opriceana@gmail.com>,
> Dogukan Ergun <dogukan.ergun@gmail.com>,
> Julia Lawall <Julia.Lawall@lip6.fr>,
> Dan Carpenter <dan.carpenter@oracle.com>,
> Haneen Mohammed <hamohammed.sa@gmail.com>,
> Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> Cc: devel@driverdev.osuosl.org,
> linux-kernel@vger.kernel.org
> Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
> Date: Mon, 27 Jul 2015 21:41:09 -0700
> Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
> X-Mailer: git-send-email 2.4.6
>
> The main goal of this series is to get rid of a needless typedef
> in the rtl8712 wlan driver.
>
> In the course of fixing that, I found a bug that can (at least in theory)
> lead to a overrun during a memcpy, as well as an identical struct with
> a different name, which use the typedef.
> Finally after cleaning up the typedef, change the name of the primary
> variable that used the typedef from "SupportedRates" to "rates", to
> conform to kernel coding style.
>
> Changes since V1:
> Do not make other logic changes while Changing the name of SupportedRates
> New patch 3/6 fixes a buggy comment that referred to the typedef
>
> Changes sinve V2:
> broke former patch 4, which was too big for git-send-email into 3 parts
>
> Joshua Clayton (8):
> staging: rtl8712: fix buggy size calculation
> staging: rtl8712: simplify size calculation
> staging: rtl8712: fix comment
> staging: rtl8712: removed unused wrapper structs
> staging: rtl8712: remove duplicate struct
> staging: rtl8712: rename function
> staging: rtl8712: remove typedefs
> staging: rtl8712: change SupportedRates to rates
>
> drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
> drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
> drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
> drivers/staging/rtl8712/rtl871x_event.h | 2 +-
> drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
> drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
> drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
> drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
> drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
> 9 files changed, 64 insertions(+), 139 deletions(-)
>
> --
> 2.4.6
>
> From: Joshua Clayton <stillcompiling@gmail.com>
> To: Larry Finger <Larry.Finger@lwfinger.net>,
> Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
> Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
> Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
> Nitin Kuppelur <nitinkuppelur@gmail.com>,
> Joshua Clayton <stillcompiling@gmail.com>,
> Vaishali Thakkar <vthakkar1994@gmail.com>,
> Tapasweni Pathak <tapaswenipathak@gmail.com>,
> Daniel Baluta <daniel.baluta@intel.com>,
> Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
> Max Perepelitsyn <mperepelitsyn@gmail.com>,
> Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
> Cristina Opriceana <cristina.opriceana@gmail.com>,
> Dogukan Ergun <dogukan.ergun@gmail.com>,
> Julia Lawall <Julia.Lawall@lip6.fr>,
> Dan Carpenter <dan.carpenter@oracle.com>,
> Haneen Mohammed <hamohammed.sa@gmail.com>,
> Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> Cc: devel@driverdev.osuosl.org,
> linux-kernel@vger.kernel.org
> Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
> Date: Mon, 27 Jul 2015 21:41:09 -0700
> Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
> X-Mailer: git-send-email 2.4.6
>
> The main goal of this series is to get rid of a needless typedef
> in the rtl8712 wlan driver.
>
> In the course of fixing that, I found a bug that can (at least in theory)
> lead to a overrun during a memcpy, as well as an identical struct with
> a different name, which use the typedef.
> Finally after cleaning up the typedef, change the name of the primary
> variable that used the typedef from "SupportedRates" to "rates", to
> conform to kernel coding style.
>
> Changes since V1:
> Do not make other logic changes while Changing the name of SupportedRates
> New patch 3/6 fixes a buggy comment that referred to the typedef
>
> Changes sinve V2:
> broke former patch 4, which was too big for git-send-email into 3 parts
>
> Joshua Clayton (8):
> staging: rtl8712: fix buggy size calculation
> staging: rtl8712: simplify size calculation
> staging: rtl8712: fix comment
> staging: rtl8712: removed unused wrapper structs
> staging: rtl8712: remove duplicate struct
> staging: rtl8712: rename function
> staging: rtl8712: remove typedefs
> staging: rtl8712: change SupportedRates to rates
>
> drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
> drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
> drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
> drivers/staging/rtl8712/rtl871x_event.h | 2 +-
> drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
> drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
> drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
> drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
> drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
> 9 files changed, 64 insertions(+), 139 deletions(-)
>
> --
> 2.4.6
>
> From: Joshua Clayton <stillcompiling@gmail.com>
> To: Larry Finger <Larry.Finger@lwfinger.net>,
> Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
> Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
> Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
> Nitin Kuppelur <nitinkuppelur@gmail.com>,
> Joshua Clayton <stillcompiling@gmail.com>,
> Vaishali Thakkar <vthakkar1994@gmail.com>,
> Tapasweni Pathak <tapaswenipathak@gmail.com>,
> Daniel Baluta <daniel.baluta@intel.com>,
> Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
> Max Perepelitsyn <mperepelitsyn@gmail.com>,
> Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
> Cristina Opriceana <cristina.opriceana@gmail.com>,
> Dogukan Ergun <dogukan.ergun@gmail.com>,
> Julia Lawall <Julia.Lawall@lip6.fr>,
> Dan Carpenter <dan.carpenter@oracle.com>,
> Haneen Mohammed <hamohammed.sa@gmail.com>,
> Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> Cc: devel@driverdev.osuosl.org,
> linux-kernel@vger.kernel.org
> Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
> Date: Mon, 27 Jul 2015 21:41:09 -0700
> Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
> X-Mailer: git-send-email 2.4.6
>
> The main goal of this series is to get rid of a needless typedef
> in the rtl8712 wlan driver.
>
> In the course of fixing that, I found a bug that can (at least in theory)
> lead to a overrun during a memcpy, as well as an identical struct with
> a different name, which use the typedef.
> Finally after cleaning up the typedef, change the name of the primary
> variable that used the typedef from "SupportedRates" to "rates", to
> conform to kernel coding style.
>
> Changes since V1:
> Do not make other logic changes while Changing the name of SupportedRates
> New patch 3/6 fixes a buggy comment that referred to the typedef
>
> Changes sinve V2:
> broke former patch 4, which was too big for git-send-email into 3 parts
>
> Joshua Clayton (8):
> staging: rtl8712: fix buggy size calculation
> staging: rtl8712: simplify size calculation
> staging: rtl8712: fix comment
> staging: rtl8712: removed unused wrapper structs
> staging: rtl8712: remove duplicate struct
> staging: rtl8712: rename function
> staging: rtl8712: remove typedefs
> staging: rtl8712: change SupportedRates to rates
>
> drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
> drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
> drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
> drivers/staging/rtl8712/rtl871x_event.h | 2 +-
> drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
> drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
> drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
> drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
> drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
> 9 files changed, 64 insertions(+), 139 deletions(-)
>
> --
> 2.4.6
>
> From: Joshua Clayton <stillcompiling@gmail.com>
> To: Larry Finger <Larry.Finger@lwfinger.net>,
> Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
> Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
> Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
> Nitin Kuppelur <nitinkuppelur@gmail.com>,
> Joshua Clayton <stillcompiling@gmail.com>,
> Vaishali Thakkar <vthakkar1994@gmail.com>,
> Tapasweni Pathak <tapaswenipathak@gmail.com>,
> Daniel Baluta <daniel.baluta@intel.com>,
> Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
> Max Perepelitsyn <mperepelitsyn@gmail.com>,
> Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
> Cristina Opriceana <cristina.opriceana@gmail.com>,
> Dogukan Ergun <dogukan.ergun@gmail.com>,
> Julia Lawall <Julia.Lawall@lip6.fr>,
> Dan Carpenter <dan.carpenter@oracle.com>,
> Haneen Mohammed <hamohammed.sa@gmail.com>,
> Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> Cc: devel@driverdev.osuosl.org,
> linux-kernel@vger.kernel.org
> Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
> Date: Mon, 27 Jul 2015 21:41:09 -0700
> Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
> X-Mailer: git-send-email 2.4.6
>
> The main goal of this series is to get rid of a needless typedef
> in the rtl8712 wlan driver.
>
> In the course of fixing that, I found a bug that can (at least in theory)
> lead to a overrun during a memcpy, as well as an identical struct with
> a different name, which use the typedef.
> Finally after cleaning up the typedef, change the name of the primary
> variable that used the typedef from "SupportedRates" to "rates", to
> conform to kernel coding style.
>
> Changes since V1:
> Do not make other logic changes while Changing the name of SupportedRates
> New patch 3/6 fixes a buggy comment that referred to the typedef
>
> Changes sinve V2:
> broke former patch 4, which was too big for git-send-email into 3 parts
>
> Joshua Clayton (8):
> staging: rtl8712: fix buggy size calculation
> staging: rtl8712: simplify size calculation
> staging: rtl8712: fix comment
> staging: rtl8712: removed unused wrapper structs
> staging: rtl8712: remove duplicate struct
> staging: rtl8712: rename function
> staging: rtl8712: remove typedefs
> staging: rtl8712: change SupportedRates to rates
>
> drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
> drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
> drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
> drivers/staging/rtl8712/rtl871x_event.h | 2 +-
> drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
> drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
> drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
> drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
> drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
> 9 files changed, 64 insertions(+), 139 deletions(-)
>
> --
> 2.4.6
>
> From: Joshua Clayton <stillcompiling@gmail.com>
> To: Larry Finger <Larry.Finger@lwfinger.net>,
> Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
> Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
> Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
> Nitin Kuppelur <nitinkuppelur@gmail.com>,
> Joshua Clayton <stillcompiling@gmail.com>,
> Vaishali Thakkar <vthakkar1994@gmail.com>,
> Tapasweni Pathak <tapaswenipathak@gmail.com>,
> Daniel Baluta <daniel.baluta@intel.com>,
> Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
> Max Perepelitsyn <mperepelitsyn@gmail.com>,
> Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
> Cristina Opriceana <cristina.opriceana@gmail.com>,
> Dogukan Ergun <dogukan.ergun@gmail.com>,
> Julia Lawall <Julia.Lawall@lip6.fr>,
> Dan Carpenter <dan.carpenter@oracle.com>,
> Haneen Mohammed <hamohammed.sa@gmail.com>,
> Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> Cc: devel@driverdev.osuosl.org,
> linux-kernel@vger.kernel.org
> Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
> Date: Mon, 27 Jul 2015 21:41:09 -0700
> Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
> X-Mailer: git-send-email 2.4.6
>
> The main goal of this series is to get rid of a needless typedef
> in the rtl8712 wlan driver.
>
> In the course of fixing that, I found a bug that can (at least in theory)
> lead to a overrun during a memcpy, as well as an identical struct with
> a different name, which use the typedef.
> Finally after cleaning up the typedef, change the name of the primary
> variable that used the typedef from "SupportedRates" to "rates", to
> conform to kernel coding style.
>
> Changes since V1:
> Do not make other logic changes while Changing the name of SupportedRates
> New patch 3/6 fixes a buggy comment that referred to the typedef
>
> Changes sinve V2:
> broke former patch 4, which was too big for git-send-email into 3 parts
>
> Joshua Clayton (8):
> staging: rtl8712: fix buggy size calculation
> staging: rtl8712: simplify size calculation
> staging: rtl8712: fix comment
> staging: rtl8712: removed unused wrapper structs
> staging: rtl8712: remove duplicate struct
> staging: rtl8712: rename function
> staging: rtl8712: remove typedefs
> staging: rtl8712: change SupportedRates to rates
>
> drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
> drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
> drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
> drivers/staging/rtl8712/rtl871x_event.h | 2 +-
> drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
> drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
> drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
> drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
> drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
> 9 files changed, 64 insertions(+), 139 deletions(-)
>
> --
> 2.4.6
>
> From: Joshua Clayton <stillcompiling@gmail.com>
> To: Larry Finger <Larry.Finger@lwfinger.net>,
> Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
> Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
> Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
> Nitin Kuppelur <nitinkuppelur@gmail.com>,
> Joshua Clayton <stillcompiling@gmail.com>,
> Vaishali Thakkar <vthakkar1994@gmail.com>,
> Tapasweni Pathak <tapaswenipathak@gmail.com>,
> Daniel Baluta <daniel.baluta@intel.com>,
> Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
> Max Perepelitsyn <mperepelitsyn@gmail.com>,
> Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
> Cristina Opriceana <cristina.opriceana@gmail.com>,
> Dogukan Ergun <dogukan.ergun@gmail.com>,
> Julia Lawall <Julia.Lawall@lip6.fr>,
> Dan Carpenter <dan.carpenter@oracle.com>,
> Haneen Mohammed <hamohammed.sa@gmail.com>,
> Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> Cc: devel@driverdev.osuosl.org,
> linux-kernel@vger.kernel.org
> Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
> Date: Mon, 27 Jul 2015 21:41:09 -0700
> Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
> X-Mailer: git-send-email 2.4.6
>
> The main goal of this series is to get rid of a needless typedef
> in the rtl8712 wlan driver.
>
> In the course of fixing that, I found a bug that can (at least in theory)
> lead to a overrun during a memcpy, as well as an identical struct with
> a different name, which use the typedef.
> Finally after cleaning up the typedef, change the name of the primary
> variable that used the typedef from "SupportedRates" to "rates", to
> conform to kernel coding style.
>
> Changes since V1:
> Do not make other logic changes while Changing the name of SupportedRates
> New patch 3/6 fixes a buggy comment that referred to the typedef
>
> Changes sinve V2:
> broke former patch 4, which was too big for git-send-email into 3 parts
>
> Joshua Clayton (8):
> staging: rtl8712: fix buggy size calculation
> staging: rtl8712: simplify size calculation
> staging: rtl8712: fix comment
> staging: rtl8712: removed unused wrapper structs
> staging: rtl8712: remove duplicate struct
> staging: rtl8712: rename function
> staging: rtl8712: remove typedefs
> staging: rtl8712: change SupportedRates to rates
>
> drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
> drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
> drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
> drivers/staging/rtl8712/rtl871x_event.h | 2 +-
> drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
> drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
> drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
> drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
> drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
> 9 files changed, 64 insertions(+), 139 deletions(-)
>
> --
> 2.4.6
>
> From: Joshua Clayton <stillcompiling@gmail.com>
> To: Larry Finger <Larry.Finger@lwfinger.net>,
> Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
> Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
> Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
> Nitin Kuppelur <nitinkuppelur@gmail.com>,
> Joshua Clayton <stillcompiling@gmail.com>,
> Vaishali Thakkar <vthakkar1994@gmail.com>,
> Tapasweni Pathak <tapaswenipathak@gmail.com>,
> Daniel Baluta <daniel.baluta@intel.com>,
> Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
> Max Perepelitsyn <mperepelitsyn@gmail.com>,
> Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
> Cristina Opriceana <cristina.opriceana@gmail.com>,
> Dogukan Ergun <dogukan.ergun@gmail.com>,
> Julia Lawall <Julia.Lawall@lip6.fr>,
> Dan Carpenter <dan.carpenter@oracle.com>,
> Haneen Mohammed <hamohammed.sa@gmail.com>,
> Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> Cc: devel@driverdev.osuosl.org,
> linux-kernel@vger.kernel.org
> Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
> Date: Mon, 27 Jul 2015 21:41:09 -0700
> Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
> X-Mailer: git-send-email 2.4.6
>
> The main goal of this series is to get rid of a needless typedef
> in the rtl8712 wlan driver.
>
> In the course of fixing that, I found a bug that can (at least in theory)
> lead to a overrun during a memcpy, as well as an identical struct with
> a different name, which use the typedef.
> Finally after cleaning up the typedef, change the name of the primary
> variable that used the typedef from "SupportedRates" to "rates", to
> conform to kernel coding style.
>
> Changes since V1:
> Do not make other logic changes while Changing the name of SupportedRates
> New patch 3/6 fixes a buggy comment that referred to the typedef
>
> Changes sinve V2:
> broke former patch 4, which was too big for git-send-email into 3 parts
>
> Joshua Clayton (8):
> staging: rtl8712: fix buggy size calculation
> staging: rtl8712: simplify size calculation
> staging: rtl8712: fix comment
> staging: rtl8712: removed unused wrapper structs
> staging: rtl8712: remove duplicate struct
> staging: rtl8712: rename function
> staging: rtl8712: remove typedefs
> staging: rtl8712: change SupportedRates to rates
>
> drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
> drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
> drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
> drivers/staging/rtl8712/rtl871x_event.h | 2 +-
> drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
> drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
> drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
> drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
> drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
> 9 files changed, 64 insertions(+), 139 deletions(-)
>
> --
> 2.4.6
>
> From: Joshua Clayton <stillcompiling@gmail.com>
> To: Larry Finger <Larry.Finger@lwfinger.net>,
> Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
> Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
> Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
> Nitin Kuppelur <nitinkuppelur@gmail.com>,
> Joshua Clayton <stillcompiling@gmail.com>,
> Vaishali Thakkar <vthakkar1994@gmail.com>,
> Tapasweni Pathak <tapaswenipathak@gmail.com>,
> Daniel Baluta <daniel.baluta@intel.com>,
> Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
> Max Perepelitsyn <mperepelitsyn@gmail.com>,
> Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
> Cristina Opriceana <cristina.opriceana@gmail.com>,
> Dogukan Ergun <dogukan.ergun@gmail.com>,
> Julia Lawall <Julia.Lawall@lip6.fr>,
> Dan Carpenter <dan.carpenter@oracle.com>,
> Haneen Mohammed <hamohammed.sa@gmail.com>,
> Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> Cc: devel@driverdev.osuosl.org,
> linux-kernel@vger.kernel.org
> Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
> Date: Mon, 27 Jul 2015 21:41:09 -0700
> Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
> X-Mailer: git-send-email 2.4.6
>
> The main goal of this series is to get rid of a needless typedef
> in the rtl8712 wlan driver.
>
> In the course of fixing that, I found a bug that can (at least in theory)
> lead to a overrun during a memcpy, as well as an identical struct with
> a different name, which use the typedef.
> Finally after cleaning up the typedef, change the name of the primary
> variable that used the typedef from "SupportedRates" to "rates", to
> conform to kernel coding style.
>
> Changes since V1:
> Do not make other logic changes while Changing the name of SupportedRates
> New patch 3/6 fixes a buggy comment that referred to the typedef
>
> Changes sinve V2:
> broke former patch 4, which was too big for git-send-email into 3 parts
>
> Joshua Clayton (8):
> staging: rtl8712: fix buggy size calculation
> staging: rtl8712: simplify size calculation
> staging: rtl8712: fix comment
> staging: rtl8712: removed unused wrapper structs
> staging: rtl8712: remove duplicate struct
> staging: rtl8712: rename function
> staging: rtl8712: remove typedefs
> staging: rtl8712: change SupportedRates to rates
>
> drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
> drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
> drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
> drivers/staging/rtl8712/rtl871x_event.h | 2 +-
> drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
> drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
> drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
> drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
> drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
> 9 files changed, 64 insertions(+), 139 deletions(-)
>
> --
> 2.4.6
>
> From: Joshua Clayton <stillcompiling@gmail.com>
> To: Larry Finger <Larry.Finger@lwfinger.net>,
> Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
> Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
> Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
> Nitin Kuppelur <nitinkuppelur@gmail.com>,
> Joshua Clayton <stillcompiling@gmail.com>,
> Vaishali Thakkar <vthakkar1994@gmail.com>,
> Tapasweni Pathak <tapaswenipathak@gmail.com>,
> Daniel Baluta <daniel.baluta@intel.com>,
> Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
> Max Perepelitsyn <mperepelitsyn@gmail.com>,
> Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
> Cristina Opriceana <cristina.opriceana@gmail.com>,
> Dogukan Ergun <dogukan.ergun@gmail.com>,
> Julia Lawall <Julia.Lawall@lip6.fr>,
> Dan Carpenter <dan.carpenter@oracle.com>,
> Haneen Mohammed <hamohammed.sa@gmail.com>,
> Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> Cc: devel@driverdev.osuosl.org,
> linux-kernel@vger.kernel.org
> Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
> Date: Mon, 27 Jul 2015 21:41:09 -0700
> Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
> X-Mailer: git-send-email 2.4.6
>
> The main goal of this series is to get rid of a needless typedef
> in the rtl8712 wlan driver.
>
> In the course of fixing that, I found a bug that can (at least in theory)
> lead to a overrun during a memcpy, as well as an identical struct with
> a different name, which use the typedef.
> Finally after cleaning up the typedef, change the name of the primary
> variable that used the typedef from "SupportedRates" to "rates", to
> conform to kernel coding style.
>
> Changes since V1:
> Do not make other logic changes while Changing the name of SupportedRates
> New patch 3/6 fixes a buggy comment that referred to the typedef
>
> Changes sinve V2:
> broke former patch 4, which was too big for git-send-email into 3 parts
>
> Joshua Clayton (8):
> staging: rtl8712: fix buggy size calculation
> staging: rtl8712: simplify size calculation
> staging: rtl8712: fix comment
> staging: rtl8712: removed unused wrapper structs
> staging: rtl8712: remove duplicate struct
> staging: rtl8712: rename function
> staging: rtl8712: remove typedefs
> staging: rtl8712: change SupportedRates to rates
>
> drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
> drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
> drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
> drivers/staging/rtl8712/rtl871x_event.h | 2 +-
> drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
> drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
> drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
> drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
> drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
> 9 files changed, 64 insertions(+), 139 deletions(-)
>
> --
> 2.4.6
>
> From: Joshua Clayton <stillcompiling@gmail.com>
> To: Larry Finger <Larry.Finger@lwfinger.net>,
> Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
> Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
> Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
> Nitin Kuppelur <nitinkuppelur@gmail.com>,
> Joshua Clayton <stillcompiling@gmail.com>,
> Vaishali Thakkar <vthakkar1994@gmail.com>,
> Tapasweni Pathak <tapaswenipathak@gmail.com>,
> Daniel Baluta <daniel.baluta@intel.com>,
> Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
> Max Perepelitsyn <mperepelitsyn@gmail.com>,
> Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
> Cristina Opriceana <cristina.opriceana@gmail.com>,
> Dogukan Ergun <dogukan.ergun@gmail.com>,
> Julia Lawall <Julia.Lawall@lip6.fr>,
> Dan Carpenter <dan.carpenter@oracle.com>,
> Haneen Mohammed <hamohammed.sa@gmail.com>,
> Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> Cc: devel@driverdev.osuosl.org,
> linux-kernel@vger.kernel.org
> Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
> Date: Mon, 27 Jul 2015 21:41:09 -0700
> Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
> X-Mailer: git-send-email 2.4.6
>
> The main goal of this series is to get rid of a needless typedef
> in the rtl8712 wlan driver.
>
> In the course of fixing that, I found a bug that can (at least in theory)
> lead to a overrun during a memcpy, as well as an identical struct with
> a different name, which use the typedef.
> Finally after cleaning up the typedef, change the name of the primary
> variable that used the typedef from "SupportedRates" to "rates", to
> conform to kernel coding style.
>
> Changes since V1:
> Do not make other logic changes while Changing the name of SupportedRates
> New patch 3/6 fixes a buggy comment that referred to the typedef
>
> Changes sinve V2:
> broke former patch 4, which was too big for git-send-email into 3 parts
>
> Joshua Clayton (8):
> staging: rtl8712: fix buggy size calculation
> staging: rtl8712: simplify size calculation
> staging: rtl8712: fix comment
> staging: rtl8712: removed unused wrapper structs
> staging: rtl8712: remove duplicate struct
> staging: rtl8712: rename function
> staging: rtl8712: remove typedefs
> staging: rtl8712: change SupportedRates to rates
>
> drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
> drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
> drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
> drivers/staging/rtl8712/rtl871x_event.h | 2 +-
> drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
> drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
> drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
> drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
> drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
> 9 files changed, 64 insertions(+), 139 deletions(-)
>
> --
> 2.4.6
>
> From: Joshua Clayton <stillcompiling@gmail.com>
> To: Larry Finger <Larry.Finger@lwfinger.net>,
> Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
> Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
> Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
> Nitin Kuppelur <nitinkuppelur@gmail.com>,
> Joshua Clayton <stillcompiling@gmail.com>,
> Vaishali Thakkar <vthakkar1994@gmail.com>,
> Tapasweni Pathak <tapaswenipathak@gmail.com>,
> Daniel Baluta <daniel.baluta@intel.com>,
> Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
> Max Perepelitsyn <mperepelitsyn@gmail.com>,
> Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
> Cristina Opriceana <cristina.opriceana@gmail.com>,
> Dogukan Ergun <dogukan.ergun@gmail.com>,
> Julia Lawall <Julia.Lawall@lip6.fr>,
> Dan Carpenter <dan.carpenter@oracle.com>,
> Haneen Mohammed <hamohammed.sa@gmail.com>,
> Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> Cc: devel@driverdev.osuosl.org,
> linux-kernel@vger.kernel.org
> Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
> Date: Mon, 27 Jul 2015 21:41:09 -0700
> Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
> X-Mailer: git-send-email 2.4.6
>
> The main goal of this series is to get rid of a needless typedef
> in the rtl8712 wlan driver.
>
> In the course of fixing that, I found a bug that can (at least in theory)
> lead to a overrun during a memcpy, as well as an identical struct with
> a different name, which use the typedef.
> Finally after cleaning up the typedef, change the name of the primary
> variable that used the typedef from "SupportedRates" to "rates", to
> conform to kernel coding style.
>
> Changes since V1:
> Do not make other logic changes while Changing the name of SupportedRates
> New patch 3/6 fixes a buggy comment that referred to the typedef
>
> Changes sinve V2:
> broke former patch 4, which was too big for git-send-email into 3 parts
>
> Joshua Clayton (8):
> staging: rtl8712: fix buggy size calculation
> staging: rtl8712: simplify size calculation
> staging: rtl8712: fix comment
> staging: rtl8712: removed unused wrapper structs
> staging: rtl8712: remove duplicate struct
> staging: rtl8712: rename function
> staging: rtl8712: remove typedefs
> staging: rtl8712: change SupportedRates to rates
>
> drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
> drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
> drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
> drivers/staging/rtl8712/rtl871x_event.h | 2 +-
> drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
> drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
> drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
> drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
> drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
> 9 files changed, 64 insertions(+), 139 deletions(-)
>
> --
> 2.4.6
>
> From: Joshua Clayton <stillcompiling@gmail.com>
> To: Larry Finger <Larry.Finger@lwfinger.net>,
> Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
> Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
> Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
> Nitin Kuppelur <nitinkuppelur@gmail.com>,
> Joshua Clayton <stillcompiling@gmail.com>,
> Vaishali Thakkar <vthakkar1994@gmail.com>,
> Tapasweni Pathak <tapaswenipathak@gmail.com>,
> Daniel Baluta <daniel.baluta@intel.com>,
> Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
> Max Perepelitsyn <mperepelitsyn@gmail.com>,
> Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
> Cristina Opriceana <cristina.opriceana@gmail.com>,
> Dogukan Ergun <dogukan.ergun@gmail.com>,
> Julia Lawall <Julia.Lawall@lip6.fr>,
> Dan Carpenter <dan.carpenter@oracle.com>,
> Haneen Mohammed <hamohammed.sa@gmail.com>,
> Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> Cc: devel@driverdev.osuosl.org,
> linux-kernel@vger.kernel.org
> Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
> Date: Mon, 27 Jul 2015 21:41:09 -0700
> Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
> X-Mailer: git-send-email 2.4.6
>
> The main goal of this series is to get rid of a needless typedef
> in the rtl8712 wlan driver.
>
> In the course of fixing that, I found a bug that can (at least in theory)
> lead to a overrun during a memcpy, as well as an identical struct with
> a different name, which use the typedef.
> Finally after cleaning up the typedef, change the name of the primary
> variable that used the typedef from "SupportedRates" to "rates", to
> conform to kernel coding style.
>
> Changes since V1:
> Do not make other logic changes while Changing the name of SupportedRates
> New patch 3/6 fixes a buggy comment that referred to the typedef
>
> Changes sinve V2:
> broke former patch 4, which was too big for git-send-email into 3 parts
>
> Joshua Clayton (8):
> staging: rtl8712: fix buggy size calculation
> staging: rtl8712: simplify size calculation
> staging: rtl8712: fix comment
> staging: rtl8712: removed unused wrapper structs
> staging: rtl8712: remove duplicate struct
> staging: rtl8712: rename function
> staging: rtl8712: remove typedefs
> staging: rtl8712: change SupportedRates to rates
>
> drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
> drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
> drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
> drivers/staging/rtl8712/rtl871x_event.h | 2 +-
> drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
> drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
> drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
> drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
> drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
> 9 files changed, 64 insertions(+), 139 deletions(-)
>
> --
> 2.4.6
>
> From: Joshua Clayton <stillcompiling@gmail.com>
> To: Larry Finger <Larry.Finger@lwfinger.net>,
> Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
> Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
> Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
> Nitin Kuppelur <nitinkuppelur@gmail.com>,
> Joshua Clayton <stillcompiling@gmail.com>,
> Vaishali Thakkar <vthakkar1994@gmail.com>,
> Tapasweni Pathak <tapaswenipathak@gmail.com>,
> Daniel Baluta <daniel.baluta@intel.com>,
> Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
> Max Perepelitsyn <mperepelitsyn@gmail.com>,
> Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
> Cristina Opriceana <cristina.opriceana@gmail.com>,
> Dogukan Ergun <dogukan.ergun@gmail.com>,
> Julia Lawall <Julia.Lawall@lip6.fr>,
> Dan Carpenter <dan.carpenter@oracle.com>,
> Haneen Mohammed <hamohammed.sa@gmail.com>,
> Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> Cc: devel@driverdev.osuosl.org,
> linux-kernel@vger.kernel.org
> Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
> Date: Mon, 27 Jul 2015 21:41:09 -0700
> Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
> X-Mailer: git-send-email 2.4.6
>
> The main goal of this series is to get rid of a needless typedef
> in the rtl8712 wlan driver.
>
> In the course of fixing that, I found a bug that can (at least in theory)
> lead to a overrun during a memcpy, as well as an identical struct with
> a different name, which use the typedef.
> Finally after cleaning up the typedef, change the name of the primary
> variable that used the typedef from "SupportedRates" to "rates", to
> conform to kernel coding style.
>
> Changes since V1:
> Do not make other logic changes while Changing the name of SupportedRates
> New patch 3/6 fixes a buggy comment that referred to the typedef
>
> Changes sinve V2:
> broke former patch 4, which was too big for git-send-email into 3 parts
>
> Joshua Clayton (8):
> staging: rtl8712: fix buggy size calculation
> staging: rtl8712: simplify size calculation
> staging: rtl8712: fix comment
> staging: rtl8712: removed unused wrapper structs
> staging: rtl8712: remove duplicate struct
> staging: rtl8712: rename function
> staging: rtl8712: remove typedefs
> staging: rtl8712: change SupportedRates to rates
>
> drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
> drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
> drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
> drivers/staging/rtl8712/rtl871x_event.h | 2 +-
> drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
> drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
> drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
> drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
> drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
> 9 files changed, 64 insertions(+), 139 deletions(-)
>
> --
> 2.4.6
>
> From: Joshua Clayton <stillcompiling@gmail.com>
> To: Larry Finger <Larry.Finger@lwfinger.net>,
> Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
> Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
> Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
> Nitin Kuppelur <nitinkuppelur@gmail.com>,
> Joshua Clayton <stillcompiling@gmail.com>,
> Vaishali Thakkar <vthakkar1994@gmail.com>,
> Tapasweni Pathak <tapaswenipathak@gmail.com>,
> Daniel Baluta <daniel.baluta@intel.com>,
> Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
> Max Perepelitsyn <mperepelitsyn@gmail.com>,
> Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
> Cristina Opriceana <cristina.opriceana@gmail.com>,
> Dogukan Ergun <dogukan.ergun@gmail.com>,
> Julia Lawall <Julia.Lawall@lip6.fr>,
> Dan Carpenter <dan.carpenter@oracle.com>,
> Haneen Mohammed <hamohammed.sa@gmail.com>,
> Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> Cc: devel@driverdev.osuosl.org,
> linux-kernel@vger.kernel.org
> Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
> Date: Mon, 27 Jul 2015 21:41:09 -0700
> Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
> X-Mailer: git-send-email 2.4.6
>
> The main goal of this series is to get rid of a needless typedef
> in the rtl8712 wlan driver.
>
> In the course of fixing that, I found a bug that can (at least in theory)
> lead to a overrun during a memcpy, as well as an identical struct with
> a different name, which use the typedef.
> Finally after cleaning up the typedef, change the name of the primary
> variable that used the typedef from "SupportedRates" to "rates", to
> conform to kernel coding style.
>
> Changes since V1:
> Do not make other logic changes while Changing the name of SupportedRates
> New patch 3/6 fixes a buggy comment that referred to the typedef
>
> Changes sinve V2:
> broke former patch 4, which was too big for git-send-email into 3 parts
>
> Joshua Clayton (8):
> staging: rtl8712: fix buggy size calculation
> staging: rtl8712: simplify size calculation
> staging: rtl8712: fix comment
> staging: rtl8712: removed unused wrapper structs
> staging: rtl8712: remove duplicate struct
> staging: rtl8712: rename function
> staging: rtl8712: remove typedefs
> staging: rtl8712: change SupportedRates to rates
>
> drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
> drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
> drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
> drivers/staging/rtl8712/rtl871x_event.h | 2 +-
> drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
> drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
> drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
> drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
> drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
> 9 files changed, 64 insertions(+), 139 deletions(-)
>
> --
> 2.4.6
>
> From: Joshua Clayton <stillcompiling@gmail.com>
> To: Larry Finger <Larry.Finger@lwfinger.net>,
> Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
> Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
> Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
> Nitin Kuppelur <nitinkuppelur@gmail.com>,
> Joshua Clayton <stillcompiling@gmail.com>,
> Vaishali Thakkar <vthakkar1994@gmail.com>,
> Tapasweni Pathak <tapaswenipathak@gmail.com>,
> Daniel Baluta <daniel.baluta@intel.com>,
> Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
> Max Perepelitsyn <mperepelitsyn@gmail.com>,
> Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
> Cristina Opriceana <cristina.opriceana@gmail.com>,
> Dogukan Ergun <dogukan.ergun@gmail.com>,
> Julia Lawall <Julia.Lawall@lip6.fr>,
> Dan Carpenter <dan.carpenter@oracle.com>,
> Haneen Mohammed <hamohammed.sa@gmail.com>,
> Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> Cc: devel@driverdev.osuosl.org,
> linux-kernel@vger.kernel.org
> Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
> Date: Mon, 27 Jul 2015 21:41:09 -0700
> Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
> X-Mailer: git-send-email 2.4.6
>
> The main goal of this series is to get rid of a needless typedef
> in the rtl8712 wlan driver.
>
> In the course of fixing that, I found a bug that can (at least in theory)
> lead to a overrun during a memcpy, as well as an identical struct with
> a different name, which use the typedef.
> Finally after cleaning up the typedef, change the name of the primary
> variable that used the typedef from "SupportedRates" to "rates", to
> conform to kernel coding style.
>
> Changes since V1:
> Do not make other logic changes while Changing the name of SupportedRates
> New patch 3/6 fixes a buggy comment that referred to the typedef
>
> Changes sinve V2:
> broke former patch 4, which was too big for git-send-email into 3 parts
>
> Joshua Clayton (8):
> staging: rtl8712: fix buggy size calculation
> staging: rtl8712: simplify size calculation
> staging: rtl8712: fix comment
> staging: rtl8712: removed unused wrapper structs
> staging: rtl8712: remove duplicate struct
> staging: rtl8712: rename function
> staging: rtl8712: remove typedefs
> staging: rtl8712: change SupportedRates to rates
>
> drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
> drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
> drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
> drivers/staging/rtl8712/rtl871x_event.h | 2 +-
> drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
> drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
> drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
> drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
> drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
> 9 files changed, 64 insertions(+), 139 deletions(-)
>
> --
> 2.4.6
>
> From: Joshua Clayton <stillcompiling@gmail.com>
> To: Larry Finger <Larry.Finger@lwfinger.net>,
> Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
> Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
> Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
> Nitin Kuppelur <nitinkuppelur@gmail.com>,
> Joshua Clayton <stillcompiling@gmail.com>,
> Vaishali Thakkar <vthakkar1994@gmail.com>,
> Tapasweni Pathak <tapaswenipathak@gmail.com>,
> Daniel Baluta <daniel.baluta@intel.com>,
> Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
> Max Perepelitsyn <mperepelitsyn@gmail.com>,
> Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
> Cristina Opriceana <cristina.opriceana@gmail.com>,
> Dogukan Ergun <dogukan.ergun@gmail.com>,
> Julia Lawall <Julia.Lawall@lip6.fr>,
> Dan Carpenter <dan.carpenter@oracle.com>,
> Haneen Mohammed <hamohammed.sa@gmail.com>,
> Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> Cc: devel@driverdev.osuosl.org,
> linux-kernel@vger.kernel.org
> Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
> Date: Mon, 27 Jul 2015 21:41:09 -0700
> Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
> X-Mailer: git-send-email 2.4.6
>
> The main goal of this series is to get rid of a needless typedef
> in the rtl8712 wlan driver.
>
> In the course of fixing that, I found a bug that can (at least in theory)
> lead to a overrun during a memcpy, as well as an identical struct with
> a different name, which use the typedef.
> Finally after cleaning up the typedef, change the name of the primary
> variable that used the typedef from "SupportedRates" to "rates", to
> conform to kernel coding style.
>
> Changes since V1:
> Do not make other logic changes while Changing the name of SupportedRates
> New patch 3/6 fixes a buggy comment that referred to the typedef
>
> Changes sinve V2:
> broke former patch 4, which was too big for git-send-email into 3 parts
>
> Joshua Clayton (8):
> staging: rtl8712: fix buggy size calculation
> staging: rtl8712: simplify size calculation
> staging: rtl8712: fix comment
> staging: rtl8712: removed unused wrapper structs
> staging: rtl8712: remove duplicate struct
> staging: rtl8712: rename function
> staging: rtl8712: remove typedefs
> staging: rtl8712: change SupportedRates to rates
>
> drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
> drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
> drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
> drivers/staging/rtl8712/rtl871x_event.h | 2 +-
> drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
> drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
> drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
> drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
> drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
> 9 files changed, 64 insertions(+), 139 deletions(-)
>
> --
> 2.4.6
>
> From: Joshua Clayton <stillcompiling@gmail.com>
> To: Larry Finger <Larry.Finger@lwfinger.net>,
> Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
> Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
> Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
> Nitin Kuppelur <nitinkuppelur@gmail.com>,
> Joshua Clayton <stillcompiling@gmail.com>,
> Vaishali Thakkar <vthakkar1994@gmail.com>,
> Tapasweni Pathak <tapaswenipathak@gmail.com>,
> Daniel Baluta <daniel.baluta@intel.com>,
> Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
> Max Perepelitsyn <mperepelitsyn@gmail.com>,
> Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
> Cristina Opriceana <cristina.opriceana@gmail.com>,
> Dogukan Ergun <dogukan.ergun@gmail.com>,
> Julia Lawall <Julia.Lawall@lip6.fr>,
> Dan Carpenter <dan.carpenter@oracle.com>,
> Haneen Mohammed <hamohammed.sa@gmail.com>,
> Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> Cc: devel@driverdev.osuosl.org,
> linux-kernel@vger.kernel.org
> Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
> Date: Mon, 27 Jul 2015 21:41:09 -0700
> Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
> X-Mailer: git-send-email 2.4.6
>
> The main goal of this series is to get rid of a needless typedef
> in the rtl8712 wlan driver.
>
> In the course of fixing that, I found a bug that can (at least in theory)
> lead to a overrun during a memcpy, as well as an identical struct with
> a different name, which use the typedef.
> Finally after cleaning up the typedef, change the name of the primary
> variable that used the typedef from "SupportedRates" to "rates", to
> conform to kernel coding style.
>
> Changes since V1:
> Do not make other logic changes while Changing the name of SupportedRates
> New patch 3/6 fixes a buggy comment that referred to the typedef
>
> Changes sinve V2:
> broke former patch 4, which was too big for git-send-email into 3 parts
>
> Joshua Clayton (8):
> staging: rtl8712: fix buggy size calculation
> staging: rtl8712: simplify size calculation
> staging: rtl8712: fix comment
> staging: rtl8712: removed unused wrapper structs
> staging: rtl8712: remove duplicate struct
> staging: rtl8712: rename function
> staging: rtl8712: remove typedefs
> staging: rtl8712: change SupportedRates to rates
>
> drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
> drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
> drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
> drivers/staging/rtl8712/rtl871x_event.h | 2 +-
> drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
> drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
> drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
> drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
> drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
> 9 files changed, 64 insertions(+), 139 deletions(-)
>
> --
> 2.4.6
>
> From: Joshua Clayton <stillcompiling@gmail.com>
> To: Larry Finger <Larry.Finger@lwfinger.net>,
> Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
> Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
> Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
> Nitin Kuppelur <nitinkuppelur@gmail.com>,
> Joshua Clayton <stillcompiling@gmail.com>,
> Vaishali Thakkar <vthakkar1994@gmail.com>,
> Tapasweni Pathak <tapaswenipathak@gmail.com>,
> Daniel Baluta <daniel.baluta@intel.com>,
> Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
> Max Perepelitsyn <mperepelitsyn@gmail.com>,
> Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
> Cristina Opriceana <cristina.opriceana@gmail.com>,
> Dogukan Ergun <dogukan.ergun@gmail.com>,
> Julia Lawall <Julia.Lawall@lip6.fr>,
> Dan Carpenter <dan.carpenter@oracle.com>,
> Haneen Mohammed <hamohammed.sa@gmail.com>,
> Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> Cc: devel@driverdev.osuosl.org,
> linux-kernel@vger.kernel.org
> Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
> Date: Mon, 27 Jul 2015 21:41:09 -0700
> Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
> X-Mailer: git-send-email 2.4.6
>
> The main goal of this series is to get rid of a needless typedef
> in the rtl8712 wlan driver.
>
> In the course of fixing that, I found a bug that can (at least in theory)
> lead to a overrun during a memcpy, as well as an identical struct with
> a different name, which use the typedef.
> Finally after cleaning up the typedef, change the name of the primary
> variable that used the typedef from "SupportedRates" to "rates", to
> conform to kernel coding style.
>
> Changes since V1:
> Do not make other logic changes while Changing the name of SupportedRates
> New patch 3/6 fixes a buggy comment that referred to the typedef
>
> Changes sinve V2:
> broke former patch 4, which was too big for git-send-email into 3 parts
>
> Joshua Clayton (8):
> staging: rtl8712: fix buggy size calculation
> staging: rtl8712: simplify size calculation
> staging: rtl8712: fix comment
> staging: rtl8712: removed unused wrapper structs
> staging: rtl8712: remove duplicate struct
> staging: rtl8712: rename function
> staging: rtl8712: remove typedefs
> staging: rtl8712: change SupportedRates to rates
>
> drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
> drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
> drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
> drivers/staging/rtl8712/rtl871x_event.h | 2 +-
> drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
> drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
> drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
> drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
> drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
> 9 files changed, 64 insertions(+), 139 deletions(-)
>
> --
> 2.4.6
>
> From: Joshua Clayton <stillcompiling@gmail.com>
> To: Larry Finger <Larry.Finger@lwfinger.net>,
> Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
> Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
> Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
> Nitin Kuppelur <nitinkuppelur@gmail.com>,
> Joshua Clayton <stillcompiling@gmail.com>,
> Vaishali Thakkar <vthakkar1994@gmail.com>,
> Tapasweni Pathak <tapaswenipathak@gmail.com>,
> Daniel Baluta <daniel.baluta@intel.com>,
> Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
> Max Perepelitsyn <mperepelitsyn@gmail.com>,
> Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
> Cristina Opriceana <cristina.opriceana@gmail.com>,
> Dogukan Ergun <dogukan.ergun@gmail.com>,
> Julia Lawall <Julia.Lawall@lip6.fr>,
> Dan Carpenter <dan.carpenter@oracle.com>,
> Haneen Mohammed <hamohammed.sa@gmail.com>,
> Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> Cc: devel@driverdev.osuosl.org,
> linux-kernel@vger.kernel.org
> Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
> Date: Mon, 27 Jul 2015 21:41:09 -0700
> Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
> X-Mailer: git-send-email 2.4.6
>
> The main goal of this series is to get rid of a needless typedef
> in the rtl8712 wlan driver.
>
> In the course of fixing that, I found a bug that can (at least in theory)
> lead to a overrun during a memcpy, as well as an identical struct with
> a different name, which use the typedef.
> Finally after cleaning up the typedef, change the name of the primary
> variable that used the typedef from "SupportedRates" to "rates", to
> conform to kernel coding style.
>
> Changes since V1:
> Do not make other logic changes while Changing the name of SupportedRates
> New patch 3/6 fixes a buggy comment that referred to the typedef
>
> Changes sinve V2:
> broke former patch 4, which was too big for git-send-email into 3 parts
>
> Joshua Clayton (8):
> staging: rtl8712: fix buggy size calculation
> staging: rtl8712: simplify size calculation
> staging: rtl8712: fix comment
> staging: rtl8712: removed unused wrapper structs
> staging: rtl8712: remove duplicate struct
> staging: rtl8712: rename function
> staging: rtl8712: remove typedefs
> staging: rtl8712: change SupportedRates to rates
>
> drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
> drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
> drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
> drivers/staging/rtl8712/rtl871x_event.h | 2 +-
> drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
> drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
> drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
> drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
> drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
> 9 files changed, 64 insertions(+), 139 deletions(-)
>
> --
> 2.4.6
>
> From: Joshua Clayton <stillcompiling@gmail.com>
> To: Larry Finger <Larry.Finger@lwfinger.net>,
> Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
> Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
> Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
> Nitin Kuppelur <nitinkuppelur@gmail.com>,
> Joshua Clayton <stillcompiling@gmail.com>,
> Vaishali Thakkar <vthakkar1994@gmail.com>,
> Tapasweni Pathak <tapaswenipathak@gmail.com>,
> Daniel Baluta <daniel.baluta@intel.com>,
> Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
> Max Perepelitsyn <mperepelitsyn@gmail.com>,
> Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
> Cristina Opriceana <cristina.opriceana@gmail.com>,
> Dogukan Ergun <dogukan.ergun@gmail.com>,
> Julia Lawall <Julia.Lawall@lip6.fr>,
> Dan Carpenter <dan.carpenter@oracle.com>,
> Haneen Mohammed <hamohammed.sa@gmail.com>,
> Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> Cc: devel@driverdev.osuosl.org,
> linux-kernel@vger.kernel.org
> Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
> Date: Mon, 27 Jul 2015 21:41:09 -0700
> Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
> X-Mailer: git-send-email 2.4.6
>
> The main goal of this series is to get rid of a needless typedef
> in the rtl8712 wlan driver.
>
> In the course of fixing that, I found a bug that can (at least in theory)
> lead to a overrun during a memcpy, as well as an identical struct with
> a different name, which use the typedef.
> Finally after cleaning up the typedef, change the name of the primary
> variable that used the typedef from "SupportedRates" to "rates", to
> conform to kernel coding style.
>
> Changes since V1:
> Do not make other logic changes while Changing the name of SupportedRates
> New patch 3/6 fixes a buggy comment that referred to the typedef
>
> Changes sinve V2:
> broke former patch 4, which was too big for git-send-email into 3 parts
>
> Joshua Clayton (8):
> staging: rtl8712: fix buggy size calculation
> staging: rtl8712: simplify size calculation
> staging: rtl8712: fix comment
> staging: rtl8712: removed unused wrapper structs
> staging: rtl8712: remove duplicate struct
> staging: rtl8712: rename function
> staging: rtl8712: remove typedefs
> staging: rtl8712: change SupportedRates to rates
>
> drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
> drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
> drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
> drivers/staging/rtl8712/rtl871x_event.h | 2 +-
> drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
> drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
> drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
> drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
> drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
> 9 files changed, 64 insertions(+), 139 deletions(-)
>
> --
> 2.4.6
>
> From: Joshua Clayton <stillcompiling@gmail.com>
> To: Larry Finger <Larry.Finger@lwfinger.net>,
> Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
> Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
> Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
> Nitin Kuppelur <nitinkuppelur@gmail.com>,
> Joshua Clayton <stillcompiling@gmail.com>,
> Vaishali Thakkar <vthakkar1994@gmail.com>,
> Tapasweni Pathak <tapaswenipathak@gmail.com>,
> Daniel Baluta <daniel.baluta@intel.com>,
> Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
> Max Perepelitsyn <mperepelitsyn@gmail.com>,
> Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
> Cristina Opriceana <cristina.opriceana@gmail.com>,
> Dogukan Ergun <dogukan.ergun@gmail.com>,
> Julia Lawall <Julia.Lawall@lip6.fr>,
> Dan Carpenter <dan.carpenter@oracle.com>,
> Haneen Mohammed <hamohammed.sa@gmail.com>,
> Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> Cc: devel@driverdev.osuosl.org,
> linux-kernel@vger.kernel.org
> Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
> Date: Mon, 27 Jul 2015 21:41:09 -0700
> Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
> X-Mailer: git-send-email 2.4.6
>
> The main goal of this series is to get rid of a needless typedef
> in the rtl8712 wlan driver.
>
> In the course of fixing that, I found a bug that can (at least in theory)
> lead to a overrun during a memcpy, as well as an identical struct with
> a different name, which use the typedef.
> Finally after cleaning up the typedef, change the name of the primary
> variable that used the typedef from "SupportedRates" to "rates", to
> conform to kernel coding style.
>
> Changes since V1:
> Do not make other logic changes while Changing the name of SupportedRates
> New patch 3/6 fixes a buggy comment that referred to the typedef
>
> Changes sinve V2:
> broke former patch 4, which was too big for git-send-email into 3 parts
>
> Joshua Clayton (8):
> staging: rtl8712: fix buggy size calculation
> staging: rtl8712: simplify size calculation
> staging: rtl8712: fix comment
> staging: rtl8712: removed unused wrapper structs
> staging: rtl8712: remove duplicate struct
> staging: rtl8712: rename function
> staging: rtl8712: remove typedefs
> staging: rtl8712: change SupportedRates to rates
>
> drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
> drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
> drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
> drivers/staging/rtl8712/rtl871x_event.h | 2 +-
> drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
> drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
> drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
> drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
> drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
> 9 files changed, 64 insertions(+), 139 deletions(-)
>
> --
> 2.4.6
>
> From: Joshua Clayton <stillcompiling@gmail.com>
> To: Larry Finger <Larry.Finger@lwfinger.net>,
> Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
> Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
> Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
> Nitin Kuppelur <nitinkuppelur@gmail.com>,
> Joshua Clayton <stillcompiling@gmail.com>,
> Vaishali Thakkar <vthakkar1994@gmail.com>,
> Tapasweni Pathak <tapaswenipathak@gmail.com>,
> Daniel Baluta <daniel.baluta@intel.com>,
> Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
> Max Perepelitsyn <mperepelitsyn@gmail.com>,
> Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
> Cristina Opriceana <cristina.opriceana@gmail.com>,
> Dogukan Ergun <dogukan.ergun@gmail.com>,
> Julia Lawall <Julia.Lawall@lip6.fr>,
> Dan Carpenter <dan.carpenter@oracle.com>,
> Haneen Mohammed <hamohammed.sa@gmail.com>,
> Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> Cc: devel@driverdev.osuosl.org,
> linux-kernel@vger.kernel.org
> Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
> Date: Mon, 27 Jul 2015 21:41:09 -0700
> Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
> X-Mailer: git-send-email 2.4.6
>
> The main goal of this series is to get rid of a needless typedef
> in the rtl8712 wlan driver.
>
> In the course of fixing that, I found a bug that can (at least in theory)
> lead to a overrun during a memcpy, as well as an identical struct with
> a different name, which use the typedef.
> Finally after cleaning up the typedef, change the name of the primary
> variable that used the typedef from "SupportedRates" to "rates", to
> conform to kernel coding style.
>
> Changes since V1:
> Do not make other logic changes while Changing the name of SupportedRates
> New patch 3/6 fixes a buggy comment that referred to the typedef
>
> Changes sinve V2:
> broke former patch 4, which was too big for git-send-email into 3 parts
>
> Joshua Clayton (8):
> staging: rtl8712: fix buggy size calculation
> staging: rtl8712: simplify size calculation
> staging: rtl8712: fix comment
> staging: rtl8712: removed unused wrapper structs
> staging: rtl8712: remove duplicate struct
> staging: rtl8712: rename function
> staging: rtl8712: remove typedefs
> staging: rtl8712: change SupportedRates to rates
>
> drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
> drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
> drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
> drivers/staging/rtl8712/rtl871x_event.h | 2 +-
> drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
> drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
> drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
> drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
> drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
> 9 files changed, 64 insertions(+), 139 deletions(-)
>
> --
> 2.4.6
>
> From: Joshua Clayton <stillcompiling@gmail.com>
> To: Larry Finger <Larry.Finger@lwfinger.net>,
> Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
> Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
> Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
> Nitin Kuppelur <nitinkuppelur@gmail.com>,
> Joshua Clayton <stillcompiling@gmail.com>,
> Vaishali Thakkar <vthakkar1994@gmail.com>,
> Tapasweni Pathak <tapaswenipathak@gmail.com>,
> Daniel Baluta <daniel.baluta@intel.com>,
> Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
> Max Perepelitsyn <mperepelitsyn@gmail.com>,
> Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
> Cristina Opriceana <cristina.opriceana@gmail.com>,
> Dogukan Ergun <dogukan.ergun@gmail.com>,
> Julia Lawall <Julia.Lawall@lip6.fr>,
> Dan Carpenter <dan.carpenter@oracle.com>,
> Haneen Mohammed <hamohammed.sa@gmail.com>,
> Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> Cc: devel@driverdev.osuosl.org,
> linux-kernel@vger.kernel.org
> Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
> Date: Mon, 27 Jul 2015 21:41:09 -0700
> Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
> X-Mailer: git-send-email 2.4.6
>
> The main goal of this series is to get rid of a needless typedef
> in the rtl8712 wlan driver.
>
> In the course of fixing that, I found a bug that can (at least in theory)
> lead to a overrun during a memcpy, as well as an identical struct with
> a different name, which use the typedef.
> Finally after cleaning up the typedef, change the name of the primary
> variable that used the typedef from "SupportedRates" to "rates", to
> conform to kernel coding style.
>
> Changes since V1:
> Do not make other logic changes while Changing the name of SupportedRates
> New patch 3/6 fixes a buggy comment that referred to the typedef
>
> Changes sinve V2:
> broke former patch 4, which was too big for git-send-email into 3 parts
>
> Joshua Clayton (8):
> staging: rtl8712: fix buggy size calculation
> staging: rtl8712: simplify size calculation
> staging: rtl8712: fix comment
> staging: rtl8712: removed unused wrapper structs
> staging: rtl8712: remove duplicate struct
> staging: rtl8712: rename function
> staging: rtl8712: remove typedefs
> staging: rtl8712: change SupportedRates to rates
>
> drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
> drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
> drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
> drivers/staging/rtl8712/rtl871x_event.h | 2 +-
> drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
> drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
> drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
> drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
> drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
> 9 files changed, 64 insertions(+), 139 deletions(-)
>
> --
> 2.4.6
>
> From: Joshua Clayton <stillcompiling@gmail.com>
> To: Larry Finger <Larry.Finger@lwfinger.net>,
> Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
> Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
> Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
> Nitin Kuppelur <nitinkuppelur@gmail.com>,
> Joshua Clayton <stillcompiling@gmail.com>,
> Vaishali Thakkar <vthakkar1994@gmail.com>,
> Tapasweni Pathak <tapaswenipathak@gmail.com>,
> Daniel Baluta <daniel.baluta@intel.com>,
> Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
> Max Perepelitsyn <mperepelitsyn@gmail.com>,
> Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
> Cristina Opriceana <cristina.opriceana@gmail.com>,
> Dogukan Ergun <dogukan.ergun@gmail.com>,
> Julia Lawall <Julia.Lawall@lip6.fr>,
> Dan Carpenter <dan.carpenter@oracle.com>,
> Haneen Mohammed <hamohammed.sa@gmail.com>,
> Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> Cc: devel@driverdev.osuosl.org,
> linux-kernel@vger.kernel.org
> Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
> Date: Mon, 27 Jul 2015 21:41:09 -0700
> Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
> X-Mailer: git-send-email 2.4.6
>
> The main goal of this series is to get rid of a needless typedef
> in the rtl8712 wlan driver.
>
> In the course of fixing that, I found a bug that can (at least in theory)
> lead to a overrun during a memcpy, as well as an identical struct with
> a different name, which use the typedef.
> Finally after cleaning up the typedef, change the name of the primary
> variable that used the typedef from "SupportedRates" to "rates", to
> conform to kernel coding style.
>
> Changes since V1:
> Do not make other logic changes while Changing the name of SupportedRates
> New patch 3/6 fixes a buggy comment that referred to the typedef
>
> Changes sinve V2:
> broke former patch 4, which was too big for git-send-email into 3 parts
>
> Joshua Clayton (8):
> staging: rtl8712: fix buggy size calculation
> staging: rtl8712: simplify size calculation
> staging: rtl8712: fix comment
> staging: rtl8712: removed unused wrapper structs
> staging: rtl8712: remove duplicate struct
> staging: rtl8712: rename function
> staging: rtl8712: remove typedefs
> staging: rtl8712: change SupportedRates to rates
>
> drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
> drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
> drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
> drivers/staging/rtl8712/rtl871x_event.h | 2 +-
> drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
> drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
> drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
> drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
> drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
> 9 files changed, 64 insertions(+), 139 deletions(-)
>
> --
> 2.4.6
>
> From: Joshua Clayton <stillcompiling@gmail.com>
> To: Larry Finger <Larry.Finger@lwfinger.net>,
> Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
> Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
> Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
> Nitin Kuppelur <nitinkuppelur@gmail.com>,
> Joshua Clayton <stillcompiling@gmail.com>,
> Vaishali Thakkar <vthakkar1994@gmail.com>,
> Tapasweni Pathak <tapaswenipathak@gmail.com>,
> Daniel Baluta <daniel.baluta@intel.com>,
> Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
> Max Perepelitsyn <mperepelitsyn@gmail.com>,
> Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
> Cristina Opriceana <cristina.opriceana@gmail.com>,
> Dogukan Ergun <dogukan.ergun@gmail.com>,
> Julia Lawall <Julia.Lawall@lip6.fr>,
> Dan Carpenter <dan.carpenter@oracle.com>,
> Haneen Mohammed <hamohammed.sa@gmail.com>,
> Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> Cc: devel@driverdev.osuosl.org,
> linux-kernel@vger.kernel.org
> Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
> Date: Mon, 27 Jul 2015 21:41:09 -0700
> Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
> X-Mailer: git-send-email 2.4.6
>
> The main goal of this series is to get rid of a needless typedef
> in the rtl8712 wlan driver.
>
> In the course of fixing that, I found a bug that can (at least in theory)
> lead to a overrun during a memcpy, as well as an identical struct with
> a different name, which use the typedef.
> Finally after cleaning up the typedef, change the name of the primary
> variable that used the typedef from "SupportedRates" to "rates", to
> conform to kernel coding style.
>
> Changes since V1:
> Do not make other logic changes while Changing the name of SupportedRates
> New patch 3/6 fixes a buggy comment that referred to the typedef
>
> Changes sinve V2:
> broke former patch 4, which was too big for git-send-email into 3 parts
>
> Joshua Clayton (8):
> staging: rtl8712: fix buggy size calculation
> staging: rtl8712: simplify size calculation
> staging: rtl8712: fix comment
> staging: rtl8712: removed unused wrapper structs
> staging: rtl8712: remove duplicate struct
> staging: rtl8712: rename function
> staging: rtl8712: remove typedefs
> staging: rtl8712: change SupportedRates to rates
>
> drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
> drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
> drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
> drivers/staging/rtl8712/rtl871x_event.h | 2 +-
> drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
> drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
> drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
> drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
> drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
> 9 files changed, 64 insertions(+), 139 deletions(-)
>
> --
> 2.4.6
>
> From: Joshua Clayton <stillcompiling@gmail.com>
> To: Larry Finger <Larry.Finger@lwfinger.net>,
> Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
> Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
> Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
> Nitin Kuppelur <nitinkuppelur@gmail.com>,
> Joshua Clayton <stillcompiling@gmail.com>,
> Vaishali Thakkar <vthakkar1994@gmail.com>,
> Tapasweni Pathak <tapaswenipathak@gmail.com>,
> Daniel Baluta <daniel.baluta@intel.com>,
> Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
> Max Perepelitsyn <mperepelitsyn@gmail.com>,
> Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
> Cristina Opriceana <cristina.opriceana@gmail.com>,
> Dogukan Ergun <dogukan.ergun@gmail.com>,
> Julia Lawall <Julia.Lawall@lip6.fr>,
> Dan Carpenter <dan.carpenter@oracle.com>,
> Haneen Mohammed <hamohammed.sa@gmail.com>,
> Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> Cc: devel@driverdev.osuosl.org,
> linux-kernel@vger.kernel.org
> Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
> Date: Mon, 27 Jul 2015 21:41:09 -0700
> Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
> X-Mailer: git-send-email 2.4.6
>
> The main goal of this series is to get rid of a needless typedef
> in the rtl8712 wlan driver.
>
> In the course of fixing that, I found a bug that can (at least in theory)
> lead to a overrun during a memcpy, as well as an identical struct with
> a different name, which use the typedef.
> Finally after cleaning up the typedef, change the name of the primary
> variable that used the typedef from "SupportedRates" to "rates", to
> conform to kernel coding style.
>
> Changes since V1:
> Do not make other logic changes while Changing the name of SupportedRates
> New patch 3/6 fixes a buggy comment that referred to the typedef
>
> Changes sinve V2:
> broke former patch 4, which was too big for git-send-email into 3 parts
>
> Joshua Clayton (8):
> staging: rtl8712: fix buggy size calculation
> staging: rtl8712: simplify size calculation
> staging: rtl8712: fix comment
> staging: rtl8712: removed unused wrapper structs
> staging: rtl8712: remove duplicate struct
> staging: rtl8712: rename function
> staging: rtl8712: remove typedefs
> staging: rtl8712: change SupportedRates to rates
>
> drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
> drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
> drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
> drivers/staging/rtl8712/rtl871x_event.h | 2 +-
> drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
> drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
> drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
> drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
> drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
> 9 files changed, 64 insertions(+), 139 deletions(-)
>
> --
> 2.4.6
>
> From: Joshua Clayton <stillcompiling@gmail.com>
> To: Larry Finger <Larry.Finger@lwfinger.net>,
> Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
> Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
> Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
> Nitin Kuppelur <nitinkuppelur@gmail.com>,
> Joshua Clayton <stillcompiling@gmail.com>,
> Vaishali Thakkar <vthakkar1994@gmail.com>,
> Tapasweni Pathak <tapaswenipathak@gmail.com>,
> Daniel Baluta <daniel.baluta@intel.com>,
> Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
> Max Perepelitsyn <mperepelitsyn@gmail.com>,
> Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
> Cristina Opriceana <cristina.opriceana@gmail.com>,
> Dogukan Ergun <dogukan.ergun@gmail.com>,
> Julia Lawall <Julia.Lawall@lip6.fr>,
> Dan Carpenter <dan.carpenter@oracle.com>,
> Haneen Mohammed <hamohammed.sa@gmail.com>,
> Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> Cc: devel@driverdev.osuosl.org,
> linux-kernel@vger.kernel.org
> Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
> Date: Mon, 27 Jul 2015 21:41:09 -0700
> Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
> X-Mailer: git-send-email 2.4.6
>
> The main goal of this series is to get rid of a needless typedef
> in the rtl8712 wlan driver.
>
> In the course of fixing that, I found a bug that can (at least in theory)
> lead to a overrun during a memcpy, as well as an identical struct with
> a different name, which use the typedef.
> Finally after cleaning up the typedef, change the name of the primary
> variable that used the typedef from "SupportedRates" to "rates", to
> conform to kernel coding style.
>
> Changes since V1:
> Do not make other logic changes while Changing the name of SupportedRates
> New patch 3/6 fixes a buggy comment that referred to the typedef
>
> Changes sinve V2:
> broke former patch 4, which was too big for git-send-email into 3 parts
>
> Joshua Clayton (8):
> staging: rtl8712: fix buggy size calculation
> staging: rtl8712: simplify size calculation
> staging: rtl8712: fix comment
> staging: rtl8712: removed unused wrapper structs
> staging: rtl8712: remove duplicate struct
> staging: rtl8712: rename function
> staging: rtl8712: remove typedefs
> staging: rtl8712: change SupportedRates to rates
>
> drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
> drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
> drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
> drivers/staging/rtl8712/rtl871x_event.h | 2 +-
> drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
> drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
> drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
> drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
> drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
> 9 files changed, 64 insertions(+), 139 deletions(-)
>
> --
> 2.4.6
>
> From: Joshua Clayton <stillcompiling@gmail.com>
> To: Larry Finger <Larry.Finger@lwfinger.net>,
> Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
> Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
> Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
> Nitin Kuppelur <nitinkuppelur@gmail.com>,
> Joshua Clayton <stillcompiling@gmail.com>,
> Vaishali Thakkar <vthakkar1994@gmail.com>,
> Tapasweni Pathak <tapaswenipathak@gmail.com>,
> Daniel Baluta <daniel.baluta@intel.com>,
> Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
> Max Perepelitsyn <mperepelitsyn@gmail.com>,
> Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
> Cristina Opriceana <cristina.opriceana@gmail.com>,
> Dogukan Ergun <dogukan.ergun@gmail.com>,
> Julia Lawall <Julia.Lawall@lip6.fr>,
> Dan Carpenter <dan.carpenter@oracle.com>,
> Haneen Mohammed <hamohammed.sa@gmail.com>,
> Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> Cc: devel@driverdev.osuosl.org,
> linux-kernel@vger.kernel.org
> Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
> Date: Mon, 27 Jul 2015 21:41:09 -0700
> Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
> X-Mailer: git-send-email 2.4.6
>
> The main goal of this series is to get rid of a needless typedef
> in the rtl8712 wlan driver.
>
> In the course of fixing that, I found a bug that can (at least in theory)
> lead to a overrun during a memcpy, as well as an identical struct with
> a different name, which use the typedef.
> Finally after cleaning up the typedef, change the name of the primary
> variable that used the typedef from "SupportedRates" to "rates", to
> conform to kernel coding style.
>
> Changes since V1:
> Do not make other logic changes while Changing the name of SupportedRates
> New patch 3/6 fixes a buggy comment that referred to the typedef
>
> Changes sinve V2:
> broke former patch 4, which was too big for git-send-email into 3 parts
>
> Joshua Clayton (8):
> staging: rtl8712: fix buggy size calculation
> staging: rtl8712: simplify size calculation
> staging: rtl8712: fix comment
> staging: rtl8712: removed unused wrapper structs
> staging: rtl8712: remove duplicate struct
> staging: rtl8712: rename function
> staging: rtl8712: remove typedefs
> staging: rtl8712: change SupportedRates to rates
>
> drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
> drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
> drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
> drivers/staging/rtl8712/rtl871x_event.h | 2 +-
> drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
> drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
> drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
> drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
> drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
> 9 files changed, 64 insertions(+), 139 deletions(-)
>
> --
> 2.4.6
>
> From: Joshua Clayton <stillcompiling@gmail.com>
> To: Larry Finger <Larry.Finger@lwfinger.net>,
> Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
> Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
> Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
> Nitin Kuppelur <nitinkuppelur@gmail.com>,
> Joshua Clayton <stillcompiling@gmail.com>,
> Vaishali Thakkar <vthakkar1994@gmail.com>,
> Tapasweni Pathak <tapaswenipathak@gmail.com>,
> Daniel Baluta <daniel.baluta@intel.com>,
> Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
> Max Perepelitsyn <mperepelitsyn@gmail.com>,
> Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
> Cristina Opriceana <cristina.opriceana@gmail.com>,
> Dogukan Ergun <dogukan.ergun@gmail.com>,
> Julia Lawall <Julia.Lawall@lip6.fr>,
> Dan Carpenter <dan.carpenter@oracle.com>,
> Haneen Mohammed <hamohammed.sa@gmail.com>,
> Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> Cc: devel@driverdev.osuosl.org,
> linux-kernel@vger.kernel.org
> Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
> Date: Mon, 27 Jul 2015 21:41:09 -0700
> Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
> X-Mailer: git-send-email 2.4.6
>
> The main goal of this series is to get rid of a needless typedef
> in the rtl8712 wlan driver.
>
> In the course of fixing that, I found a bug that can (at least in theory)
> lead to a overrun during a memcpy, as well as an identical struct with
> a different name, which use the typedef.
> Finally after cleaning up the typedef, change the name of the primary
> variable that used the typedef from "SupportedRates" to "rates", to
> conform to kernel coding style.
>
> Changes since V1:
> Do not make other logic changes while Changing the name of SupportedRates
> New patch 3/6 fixes a buggy comment that referred to the typedef
>
> Changes sinve V2:
> broke former patch 4, which was too big for git-send-email into 3 parts
>
> Joshua Clayton (8):
> staging: rtl8712: fix buggy size calculation
> staging: rtl8712: simplify size calculation
> staging: rtl8712: fix comment
> staging: rtl8712: removed unused wrapper structs
> staging: rtl8712: remove duplicate struct
> staging: rtl8712: rename function
> staging: rtl8712: remove typedefs
> staging: rtl8712: change SupportedRates to rates
>
> drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
> drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
> drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
> drivers/staging/rtl8712/rtl871x_event.h | 2 +-
> drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
> drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
> drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
> drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
> drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
> 9 files changed, 64 insertions(+), 139 deletions(-)
>
> --
> 2.4.6
>
> From: Joshua Clayton <stillcompiling@gmail.com>
> To: Larry Finger <Larry.Finger@lwfinger.net>,
> Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
> Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
> Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
> Nitin Kuppelur <nitinkuppelur@gmail.com>,
> Joshua Clayton <stillcompiling@gmail.com>,
> Vaishali Thakkar <vthakkar1994@gmail.com>,
> Tapasweni Pathak <tapaswenipathak@gmail.com>,
> Daniel Baluta <daniel.baluta@intel.com>,
> Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
> Max Perepelitsyn <mperepelitsyn@gmail.com>,
> Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
> Cristina Opriceana <cristina.opriceana@gmail.com>,
> Dogukan Ergun <dogukan.ergun@gmail.com>,
> Julia Lawall <Julia.Lawall@lip6.fr>,
> Dan Carpenter <dan.carpenter@oracle.com>,
> Haneen Mohammed <hamohammed.sa@gmail.com>,
> Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> Cc: devel@driverdev.osuosl.org,
> linux-kernel@vger.kernel.org
> Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
> Date: Mon, 27 Jul 2015 21:41:09 -0700
> Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
> X-Mailer: git-send-email 2.4.6
>
> The main goal of this series is to get rid of a needless typedef
> in the rtl8712 wlan driver.
>
> In the course of fixing that, I found a bug that can (at least in theory)
> lead to a overrun during a memcpy, as well as an identical struct with
> a different name, which use the typedef.
> Finally after cleaning up the typedef, change the name of the primary
> variable that used the typedef from "SupportedRates" to "rates", to
> conform to kernel coding style.
>
> Changes since V1:
> Do not make other logic changes while Changing the name of SupportedRates
> New patch 3/6 fixes a buggy comment that referred to the typedef
>
> Changes sinve V2:
> broke former patch 4, which was too big for git-send-email into 3 parts
>
> Joshua Clayton (8):
> staging: rtl8712: fix buggy size calculation
> staging: rtl8712: simplify size calculation
> staging: rtl8712: fix comment
> staging: rtl8712: removed unused wrapper structs
> staging: rtl8712: remove duplicate struct
> staging: rtl8712: rename function
> staging: rtl8712: remove typedefs
> staging: rtl8712: change SupportedRates to rates
>
> drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
> drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
> drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
> drivers/staging/rtl8712/rtl871x_event.h | 2 +-
> drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
> drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
> drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
> drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
> drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
> 9 files changed, 64 insertions(+), 139 deletions(-)
>
> --
> 2.4.6
>
> From: Joshua Clayton <stillcompiling@gmail.com>
> To: Larry Finger <Larry.Finger@lwfinger.net>,
> Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
> Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
> Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
> Nitin Kuppelur <nitinkuppelur@gmail.com>,
> Joshua Clayton <stillcompiling@gmail.com>,
> Vaishali Thakkar <vthakkar1994@gmail.com>,
> Tapasweni Pathak <tapaswenipathak@gmail.com>,
> Daniel Baluta <daniel.baluta@intel.com>,
> Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
> Max Perepelitsyn <mperepelitsyn@gmail.com>,
> Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
> Cristina Opriceana <cristina.opriceana@gmail.com>,
> Dogukan Ergun <dogukan.ergun@gmail.com>,
> Julia Lawall <Julia.Lawall@lip6.fr>,
> Dan Carpenter <dan.carpenter@oracle.com>,
> Haneen Mohammed <hamohammed.sa@gmail.com>,
> Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> Cc: devel@driverdev.osuosl.org,
> linux-kernel@vger.kernel.org
> Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
> Date: Mon, 27 Jul 2015 21:41:09 -0700
> Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
> X-Mailer: git-send-email 2.4.6
>
> The main goal of this series is to get rid of a needless typedef
> in the rtl8712 wlan driver.
>
> In the course of fixing that, I found a bug that can (at least in theory)
> lead to a overrun during a memcpy, as well as an identical struct with
> a different name, which use the typedef.
> Finally after cleaning up the typedef, change the name of the primary
> variable that used the typedef from "SupportedRates" to "rates", to
> conform to kernel coding style.
>
> Changes since V1:
> Do not make other logic changes while Changing the name of SupportedRates
> New patch 3/6 fixes a buggy comment that referred to the typedef
>
> Changes sinve V2:
> broke former patch 4, which was too big for git-send-email into 3 parts
>
> Joshua Clayton (8):
> staging: rtl8712: fix buggy size calculation
> staging: rtl8712: simplify size calculation
> staging: rtl8712: fix comment
> staging: rtl8712: removed unused wrapper structs
> staging: rtl8712: remove duplicate struct
> staging: rtl8712: rename function
> staging: rtl8712: remove typedefs
> staging: rtl8712: change SupportedRates to rates
>
> drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
> drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
> drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
> drivers/staging/rtl8712/rtl871x_event.h | 2 +-
> drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
> drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
> drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
> drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
> drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
> 9 files changed, 64 insertions(+), 139 deletions(-)
>
> --
> 2.4.6
>
> From: Joshua Clayton <stillcompiling@gmail.com>
> To: Larry Finger <Larry.Finger@lwfinger.net>,
> Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
> Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
> Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
> Nitin Kuppelur <nitinkuppelur@gmail.com>,
> Joshua Clayton <stillcompiling@gmail.com>,
> Vaishali Thakkar <vthakkar1994@gmail.com>,
> Tapasweni Pathak <tapaswenipathak@gmail.com>,
> Daniel Baluta <daniel.baluta@intel.com>,
> Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
> Max Perepelitsyn <mperepelitsyn@gmail.com>,
> Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
> Cristina Opriceana <cristina.opriceana@gmail.com>,
> Dogukan Ergun <dogukan.ergun@gmail.com>,
> Julia Lawall <Julia.Lawall@lip6.fr>,
> Dan Carpenter <dan.carpenter@oracle.com>,
> Haneen Mohammed <hamohammed.sa@gmail.com>,
> Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> Cc: devel@driverdev.osuosl.org,
> linux-kernel@vger.kernel.org
> Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
> Date: Mon, 27 Jul 2015 21:41:09 -0700
> Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
> X-Mailer: git-send-email 2.4.6
>
> The main goal of this series is to get rid of a needless typedef
> in the rtl8712 wlan driver.
>
> In the course of fixing that, I found a bug that can (at least in theory)
> lead to a overrun during a memcpy, as well as an identical struct with
> a different name, which use the typedef.
> Finally after cleaning up the typedef, change the name of the primary
> variable that used the typedef from "SupportedRates" to "rates", to
> conform to kernel coding style.
>
> Changes since V1:
> Do not make other logic changes while Changing the name of SupportedRates
> New patch 3/6 fixes a buggy comment that referred to the typedef
>
> Changes sinve V2:
> broke former patch 4, which was too big for git-send-email into 3 parts
>
> Joshua Clayton (8):
> staging: rtl8712: fix buggy size calculation
> staging: rtl8712: simplify size calculation
> staging: rtl8712: fix comment
> staging: rtl8712: removed unused wrapper structs
> staging: rtl8712: remove duplicate struct
> staging: rtl8712: rename function
> staging: rtl8712: remove typedefs
> staging: rtl8712: change SupportedRates to rates
>
> drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
> drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
> drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
> drivers/staging/rtl8712/rtl871x_event.h | 2 +-
> drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
> drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
> drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
> drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
> drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
> 9 files changed, 64 insertions(+), 139 deletions(-)
>
> --
> 2.4.6
>
> From: Joshua Clayton <stillcompiling@gmail.com>
> To: Larry Finger <Larry.Finger@lwfinger.net>,
> Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
> Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
> Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
> Nitin Kuppelur <nitinkuppelur@gmail.com>,
> Joshua Clayton <stillcompiling@gmail.com>,
> Vaishali Thakkar <vthakkar1994@gmail.com>,
> Tapasweni Pathak <tapaswenipathak@gmail.com>,
> Daniel Baluta <daniel.baluta@intel.com>,
> Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
> Max Perepelitsyn <mperepelitsyn@gmail.com>,
> Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
> Cristina Opriceana <cristina.opriceana@gmail.com>,
> Dogukan Ergun <dogukan.ergun@gmail.com>,
> Julia Lawall <Julia.Lawall@lip6.fr>,
> Dan Carpenter <dan.carpenter@oracle.com>,
> Haneen Mohammed <hamohammed.sa@gmail.com>,
> Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> Cc: devel@driverdev.osuosl.org,
> linux-kernel@vger.kernel.org
> Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
> Date: Mon, 27 Jul 2015 21:41:09 -0700
> Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
> X-Mailer: git-send-email 2.4.6
>
> The main goal of this series is to get rid of a needless typedef
> in the rtl8712 wlan driver.
>
> In the course of fixing that, I found a bug that can (at least in theory)
> lead to a overrun during a memcpy, as well as an identical struct with
> a different name, which use the typedef.
> Finally after cleaning up the typedef, change the name of the primary
> variable that used the typedef from "SupportedRates" to "rates", to
> conform to kernel coding style.
>
> Changes since V1:
> Do not make other logic changes while Changing the name of SupportedRates
> New patch 3/6 fixes a buggy comment that referred to the typedef
>
> Changes sinve V2:
> broke former patch 4, which was too big for git-send-email into 3 parts
>
> Joshua Clayton (8):
> staging: rtl8712: fix buggy size calculation
> staging: rtl8712: simplify size calculation
> staging: rtl8712: fix comment
> staging: rtl8712: removed unused wrapper structs
> staging: rtl8712: remove duplicate struct
> staging: rtl8712: rename function
> staging: rtl8712: remove typedefs
> staging: rtl8712: change SupportedRates to rates
>
> drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
> drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
> drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
> drivers/staging/rtl8712/rtl871x_event.h | 2 +-
> drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
> drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
> drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
> drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
> drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
> 9 files changed, 64 insertions(+), 139 deletions(-)
>
> --
> 2.4.6
>
> From: Joshua Clayton <stillcompiling@gmail.com>
> To: Larry Finger <Larry.Finger@lwfinger.net>,
> Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
> Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
> Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
> Nitin Kuppelur <nitinkuppelur@gmail.com>,
> Joshua Clayton <stillcompiling@gmail.com>,
> Vaishali Thakkar <vthakkar1994@gmail.com>,
> Tapasweni Pathak <tapaswenipathak@gmail.com>,
> Daniel Baluta <daniel.baluta@intel.com>,
> Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
> Max Perepelitsyn <mperepelitsyn@gmail.com>,
> Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
> Cristina Opriceana <cristina.opriceana@gmail.com>,
> Dogukan Ergun <dogukan.ergun@gmail.com>,
> Julia Lawall <Julia.Lawall@lip6.fr>,
> Dan Carpenter <dan.carpenter@oracle.com>,
> Haneen Mohammed <hamohammed.sa@gmail.com>,
> Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> Cc: devel@driverdev.osuosl.org,
> linux-kernel@vger.kernel.org
> Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
> Date: Mon, 27 Jul 2015 21:41:09 -0700
> Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
> X-Mailer: git-send-email 2.4.6
>
> The main goal of this series is to get rid of a needless typedef
> in the rtl8712 wlan driver.
>
> In the course of fixing that, I found a bug that can (at least in theory)
> lead to a overrun during a memcpy, as well as an identical struct with
> a different name, which use the typedef.
> Finally after cleaning up the typedef, change the name of the primary
> variable that used the typedef from "SupportedRates" to "rates", to
> conform to kernel coding style.
>
> Changes since V1:
> Do not make other logic changes while Changing the name of SupportedRates
> New patch 3/6 fixes a buggy comment that referred to the typedef
>
> Changes sinve V2:
> broke former patch 4, which was too big for git-send-email into 3 parts
>
> Joshua Clayton (8):
> staging: rtl8712: fix buggy size calculation
> staging: rtl8712: simplify size calculation
> staging: rtl8712: fix comment
> staging: rtl8712: removed unused wrapper structs
> staging: rtl8712: remove duplicate struct
> staging: rtl8712: rename function
> staging: rtl8712: remove typedefs
> staging: rtl8712: change SupportedRates to rates
>
> drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
> drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
> drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
> drivers/staging/rtl8712/rtl871x_event.h | 2 +-
> drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
> drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
> drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
> drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
> drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
> 9 files changed, 64 insertions(+), 139 deletions(-)
>
> --
> 2.4.6
>
> From: Joshua Clayton <stillcompiling@gmail.com>
> To: Larry Finger <Larry.Finger@lwfinger.net>,
> Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
> Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
> Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
> Nitin Kuppelur <nitinkuppelur@gmail.com>,
> Joshua Clayton <stillcompiling@gmail.com>,
> Vaishali Thakkar <vthakkar1994@gmail.com>,
> Tapasweni Pathak <tapaswenipathak@gmail.com>,
> Daniel Baluta <daniel.baluta@intel.com>,
> Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
> Max Perepelitsyn <mperepelitsyn@gmail.com>,
> Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
> Cristina Opriceana <cristina.opriceana@gmail.com>,
> Dogukan Ergun <dogukan.ergun@gmail.com>,
> Julia Lawall <Julia.Lawall@lip6.fr>,
> Dan Carpenter <dan.carpenter@oracle.com>,
> Haneen Mohammed <hamohammed.sa@gmail.com>,
> Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> Cc: devel@driverdev.osuosl.org,
> linux-kernel@vger.kernel.org
> Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
> Date: Mon, 27 Jul 2015 21:41:09 -0700
> Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
> X-Mailer: git-send-email 2.4.6
>
> The main goal of this series is to get rid of a needless typedef
> in the rtl8712 wlan driver.
>
> In the course of fixing that, I found a bug that can (at least in theory)
> lead to a overrun during a memcpy, as well as an identical struct with
> a different name, which use the typedef.
> Finally after cleaning up the typedef, change the name of the primary
> variable that used the typedef from "SupportedRates" to "rates", to
> conform to kernel coding style.
>
> Changes since V1:
> Do not make other logic changes while Changing the name of SupportedRates
> New patch 3/6 fixes a buggy comment that referred to the typedef
>
> Changes sinve V2:
> broke former patch 4, which was too big for git-send-email into 3 parts
>
> Joshua Clayton (8):
> staging: rtl8712: fix buggy size calculation
> staging: rtl8712: simplify size calculation
> staging: rtl8712: fix comment
> staging: rtl8712: removed unused wrapper structs
> staging: rtl8712: remove duplicate struct
> staging: rtl8712: rename function
> staging: rtl8712: remove typedefs
> staging: rtl8712: change SupportedRates to rates
>
> drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
> drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
> drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
> drivers/staging/rtl8712/rtl871x_event.h | 2 +-
> drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
> drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
> drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
> drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
> drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
> 9 files changed, 64 insertions(+), 139 deletions(-)
>
> --
> 2.4.6
>
> From: Joshua Clayton <stillcompiling@gmail.com>
> To: Larry Finger <Larry.Finger@lwfinger.net>,
> Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
> Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
> Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
> Nitin Kuppelur <nitinkuppelur@gmail.com>,
> Joshua Clayton <stillcompiling@gmail.com>,
> Vaishali Thakkar <vthakkar1994@gmail.com>,
> Tapasweni Pathak <tapaswenipathak@gmail.com>,
> Daniel Baluta <daniel.baluta@intel.com>,
> Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
> Max Perepelitsyn <mperepelitsyn@gmail.com>,
> Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
> Cristina Opriceana <cristina.opriceana@gmail.com>,
> Dogukan Ergun <dogukan.ergun@gmail.com>,
> Julia Lawall <Julia.Lawall@lip6.fr>,
> Dan Carpenter <dan.carpenter@oracle.com>,
> Haneen Mohammed <hamohammed.sa@gmail.com>,
> Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> Cc: devel@driverdev.osuosl.org,
> linux-kernel@vger.kernel.org
> Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
> Date: Mon, 27 Jul 2015 21:41:09 -0700
> Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
> X-Mailer: git-send-email 2.4.6
>
> The main goal of this series is to get rid of a needless typedef
> in the rtl8712 wlan driver.
>
> In the course of fixing that, I found a bug that can (at least in theory)
> lead to a overrun during a memcpy, as well as an identical struct with
> a different name, which use the typedef.
> Finally after cleaning up the typedef, change the name of the primary
> variable that used the typedef from "SupportedRates" to "rates", to
> conform to kernel coding style.
>
> Changes since V1:
> Do not make other logic changes while Changing the name of SupportedRates
> New patch 3/6 fixes a buggy comment that referred to the typedef
>
> Changes sinve V2:
> broke former patch 4, which was too big for git-send-email into 3 parts
>
> Joshua Clayton (8):
> staging: rtl8712: fix buggy size calculation
> staging: rtl8712: simplify size calculation
> staging: rtl8712: fix comment
> staging: rtl8712: removed unused wrapper structs
> staging: rtl8712: remove duplicate struct
> staging: rtl8712: rename function
> staging: rtl8712: remove typedefs
> staging: rtl8712: change SupportedRates to rates
>
> drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
> drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
> drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
> drivers/staging/rtl8712/rtl871x_event.h | 2 +-
> drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
> drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
> drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
> drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
> drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
> 9 files changed, 64 insertions(+), 139 deletions(-)
>
> --
> 2.4.6
>
> From: Joshua Clayton <stillcompiling@gmail.com>
> To: Larry Finger <Larry.Finger@lwfinger.net>,
> Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
> Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
> Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
> Nitin Kuppelur <nitinkuppelur@gmail.com>,
> Joshua Clayton <stillcompiling@gmail.com>,
> Vaishali Thakkar <vthakkar1994@gmail.com>,
> Tapasweni Pathak <tapaswenipathak@gmail.com>,
> Daniel Baluta <daniel.baluta@intel.com>,
> Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
> Max Perepelitsyn <mperepelitsyn@gmail.com>,
> Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
> Cristina Opriceana <cristina.opriceana@gmail.com>,
> Dogukan Ergun <dogukan.ergun@gmail.com>,
> Julia Lawall <Julia.Lawall@lip6.fr>,
> Dan Carpenter <dan.carpenter@oracle.com>,
> Haneen Mohammed <hamohammed.sa@gmail.com>,
> Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> Cc: devel@driverdev.osuosl.org,
> linux-kernel@vger.kernel.org
> Subject: [PATCH V3 0/8] clean up wlan_bssdef.h
> Date: Mon, 27 Jul 2015 21:41:09 -0700
> Message-Id: <cover.1438057939.git.stillcompiling@gmail.com>
> X-Mailer: git-send-email 2.4.6
>
> The main goal of this series is to get rid of a needless typedef
> in the rtl8712 wlan driver.
>
> In the course of fixing that, I found a bug that can (at least in theory)
> lead to a overrun during a memcpy, as well as an identical struct with
> a different name, which use the typedef.
> Finally after cleaning up the typedef, change the name of the primary
> variable that used the typedef from "SupportedRates" to "rates", to
> conform to kernel coding style.
>
> Changes since V1:
> Do not make other logic changes while Changing the name of SupportedRates
> New patch 3/6 fixes a buggy comment that referred to the typedef
>
> Changes sinve V2:
> broke former patch 4, which was too big for git-send-email into 3 parts
>
> Joshua Clayton (8):
> staging: rtl8712: fix buggy size calculation
> staging: rtl8712: simplify size calculation
> staging: rtl8712: fix comment
> staging: rtl8712: removed unused wrapper structs
> staging: rtl8712: remove duplicate struct
> staging: rtl8712: rename function
> staging: rtl8712: remove typedefs
> staging: rtl8712: change SupportedRates to rates
>
> drivers/staging/rtl8712/ieee80211.c | 22 ++++++-------
> drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
> drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
> drivers/staging/rtl8712/rtl871x_event.h | 2 +-
> drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++----------
> drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
> drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
> drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
> drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
> 9 files changed, 64 insertions(+), 139 deletions(-)
>
> --
> 2.4.6
>
>
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH V3 1/8] staging: rtl8712: fix buggy size calculation
2015-07-28 4:41 ` [PATCH V3 1/8] staging: rtl8712: fix buggy size calculation Joshua Clayton
@ 2015-07-28 11:46 ` Sudip Mukherjee
2015-07-28 12:27 ` Joshua Clayton
0 siblings, 1 reply; 27+ messages in thread
From: Sudip Mukherjee @ 2015-07-28 11:46 UTC (permalink / raw)
To: Joshua Clayton
Cc: Larry Finger, Florian Schilhabel, Greg Kroah-Hartman,
Nitin Kuppelur, Vaishali Thakkar, Tapasweni Pathak,
Daniel Baluta, Melike Yurtoglu, Max Perepelitsyn, Aya Mahfouz,
Cristina Opriceana, Dogukan Ergun, Julia Lawall, Dan Carpenter,
Haneen Mohammed, Rickard Strandqvist, devel, linux-kernel
On Mon, Jul 27, 2015 at 09:41:10PM -0700, Joshua Clayton wrote:
> r8712_get_ndis_wlan_bssid_ex_sz has a "6 * sizeof(unsigned long)"
> where the underlying struct has a 6 * unsigned char.
> Simplify the calculation by just subtracting the variable part from
> the size of the struct.
>
> This also gets rid of a use of typedef NDIS_802_11_RATES_EX
>
> Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
> ---
<snip>
>
> u8 *r8712_get_capability_from_ie(u8 *ie)
> --
> 2.4.6
>
> From: Joshua Clayton <stillcompiling@gmail.com>
> To: Larry Finger <Larry.Finger@lwfinger.net>,
> Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
> Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
> Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
> Nitin Kuppelur <nitinkuppelur@gmail.com>,
> Joshua Clayton <stillcompiling@gmail.com>,
> Vaishali Thakkar <vthakkar1994@gmail.com>,
> Tapasweni Pathak <tapaswenipathak@gmail.com>,
> Daniel Baluta <daniel.baluta@intel.com>,
> Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
> Max Perepelitsyn <mperepelitsyn@gmail.com>,
> Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
> Cristina Opriceana <cristina.opriceana@gmail.com>,
> Dogukan Ergun <dogukan.ergun@gmail.com>,
> Julia Lawall <Julia.Lawall@lip6.fr>,
> Dan Carpenter <dan.carpenter@oracle.com>,
> Haneen Mohammed <hamohammed.sa@gmail.com>,
> Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> Cc: devel@driverdev.osuosl.org,
> linux-kernel@vger.kernel.org
> Subject: [PATCH V3 1/8] staging: rtl8712: fix buggy size calculation
> Date: Mon, 27 Jul 2015 21:41:10 -0700
> Message-Id: <305999598d7738feabdc8e5df5400b3e7be7f5ed.1438057939.git.stillcompiling@gmail.com>
> X-Mailer: git-send-email 2.4.6
> In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
> References: <cover.1438057939.git.stillcompiling@gmail.com>
> In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
> References: <cover.1438057939.git.stillcompiling@gmail.com>
Something is wrong. The same patch is getting repeated in the same mail
multiple times. I deleted almost 2500 lines after this before sending
this reply. See how your patch is looking like:
http://www.gossamer-threads.com/lists/linux/kernel/2224869
regards
sudip
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH V3 1/8] staging: rtl8712: fix buggy size calculation
2015-07-28 11:46 ` Sudip Mukherjee
@ 2015-07-28 12:27 ` Joshua Clayton
0 siblings, 0 replies; 27+ messages in thread
From: Joshua Clayton @ 2015-07-28 12:27 UTC (permalink / raw)
To: Sudip Mukherjee
Cc: Larry Finger, Florian Schilhabel, Greg Kroah-Hartman,
Nitin Kuppelur, Vaishali Thakkar, Tapasweni Pathak,
Daniel Baluta, Melike Yurtoglu, Max Perepelitsyn, Aya Mahfouz,
Cristina Opriceana, Dogukan Ergun, Julia Lawall, Dan Carpenter,
Haneen Mohammed, Rickard Strandqvist, devel, linux-kernel
On Tuesday, July 28, 2015 05:16:56 PM Sudip Mukherjee wrote:
> On Mon, Jul 27, 2015 at 09:41:10PM -0700, Joshua Clayton wrote:
> > r8712_get_ndis_wlan_bssid_ex_sz has a "6 * sizeof(unsigned long)"
> > where the underlying struct has a 6 * unsigned char.
> > Simplify the calculation by just subtracting the variable part from
> > the size of the struct.
> >
> > This also gets rid of a use of typedef NDIS_802_11_RATES_EX
> >
> > Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
> > ---
> <snip>
> >
> > u8 *r8712_get_capability_from_ie(u8 *ie)
>
> Something is wrong. The same patch is getting repeated in the same mail
> multiple times. I deleted almost 2500 lines after this before sending
> this reply. See how your patch is looking like:
> http://www.gossamer-threads.com/lists/linux/kernel/2224869
>
> regards
> sudip
>
Oh No!
I made a tweak to git-send-email to try to get past the problem with perl 5.22
That was causing git-send-email to crash.
The whole series, including the cover letter is like this.
I will resubmit when I have fixed this problem.
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH V3 0/8] clean up wlan_bssdef.h
2015-07-28 5:27 ` [PATCH V3 0/8] clean up wlan_bssdef.h Julia Lawall
@ 2015-07-28 12:38 ` Joshua Clayton
0 siblings, 0 replies; 27+ messages in thread
From: Joshua Clayton @ 2015-07-28 12:38 UTC (permalink / raw)
To: Julia Lawall
Cc: Larry Finger, Florian Schilhabel, Greg Kroah-Hartman,
Sudip Mukherjee, Nitin Kuppelur, Vaishali Thakkar,
Tapasweni Pathak, Daniel Baluta, Melike Yurtoglu,
Max Perepelitsyn, Aya Mahfouz, Cristina Opriceana, Dogukan Ergun,
Julia Lawall, Dan Carpenter, Haneen Mohammed,
Rickard Strandqvist, devel, linux-kernel
On Tuesday, July 28, 2015 07:27:53 AM Julia Lawall wrote:
> Something horrible seems to have happened in your patch sending process,
> and you have the same message over and over.
>
I see that now. :(
This was a failed work-around to git-send-email I forgot I had done early in the day.
I'll fix it and resubmit, after I have emailed myself
> Also, you don't really need to seen the patch to everyone who has ever
> touched the file. The following arguments can be useful:
>
> --nokeywords --nogit --nogit-fallback --norolestats
>
> julia
>
Thanks.
I was finding the output of get_maintainer rather confusing.
^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH V3 RESEND 5/8] staging: rtl8712: remove duplicate struct
2015-07-28 4:41 [PATCH V3 0/8] clean up wlan_bssdef.h Joshua Clayton
` (5 preceding siblings ...)
2015-07-28 5:27 ` [PATCH V3 0/8] clean up wlan_bssdef.h Julia Lawall
@ 2015-07-28 14:15 ` Joshua Clayton
2015-07-28 14:15 ` [PATCH V3 RESEND 6/8] staging: rtl8712: rename function Joshua Clayton
` (9 subsequent siblings)
16 siblings, 0 replies; 27+ messages in thread
From: Joshua Clayton @ 2015-07-28 14:15 UTC (permalink / raw)
To: Larry Finger, Florian Schilhabel, Greg Kroah-Hartman
Cc: Sudip Mukherjee, Nitin Kuppelur, Joshua Clayton, Julia Lawall,
Dan Carpenter, devel, linux-kernel
struct ndis_wlan_bssid_ex is a doppelganger of struct wlan_bssid_ex,
and is used about a third as often.
Switch all instances to wlan_bssid_ex, and remove ndis_wlan_bssid_ex
This also gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.c | 11 ++++-------
drivers/staging/rtl8712/rtl871x_event.h | 2 +-
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 10 +++++-----
drivers/staging/rtl8712/rtl871x_mlme.c | 23 +++++++++++------------
drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 4 ++--
drivers/staging/rtl8712/wlan_bssdef.h | 23 ++---------------------
7 files changed, 26 insertions(+), 49 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c
index f07050d..06d9844 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.c
+++ b/drivers/staging/rtl8712/rtl871x_cmd.c
@@ -456,9 +456,7 @@ u8 r8712_createbss_cmd(struct _adapter *padapter)
INIT_LIST_HEAD(&pcmd->list);
pcmd->cmdcode = _CreateBss_CMD_;
pcmd->parmbuf = (unsigned char *)pdev_network;
- pcmd->cmdsz = r8712_get_ndis_wlan_bssid_ex_sz((
- struct ndis_wlan_bssid_ex *)
- pdev_network);
+ pcmd->cmdsz = r8712_get_ndis_wlan_bssid_ex_sz(pdev_network);
pcmd->rsp = NULL;
pcmd->rspsz = 0;
/* notes: translate IELength & Length after assign to cmdsz; */
@@ -471,7 +469,7 @@ u8 r8712_createbss_cmd(struct _adapter *padapter)
u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
{
- struct ndis_wlan_bssid_ex *psecnetwork;
+ struct wlan_bssid_ex *psecnetwork;
struct cmd_obj *pcmd;
struct cmd_priv *pcmdpriv = &padapter->cmdpriv;
struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
@@ -502,7 +500,7 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
break;
}
}
- psecnetwork = (struct ndis_wlan_bssid_ex *)&psecuritypriv->sec_bss;
+ psecnetwork = &psecuritypriv->sec_bss;
if (psecnetwork == NULL) {
kfree(pcmd);
return _FAIL;
@@ -894,8 +892,7 @@ void r8712_createbss_cmd_callback(struct _adapter *padapter,
struct sta_info *psta = NULL;
struct wlan_network *pwlan = NULL;
struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
- struct ndis_wlan_bssid_ex *pnetwork = (struct ndis_wlan_bssid_ex *)
- pcmd->parmbuf;
+ struct wlan_bssid_ex *pnetwork = (struct wlan_bssid_ex *)pcmd->parmbuf;
struct wlan_network *tgt_network = &(pmlmepriv->cur_network);
if (pcmd->res != H2C_SUCCESS)
diff --git a/drivers/staging/rtl8712/rtl871x_event.h b/drivers/staging/rtl8712/rtl871x_event.h
index e03ee90..697c8d7 100644
--- a/drivers/staging/rtl8712/rtl871x_event.h
+++ b/drivers/staging/rtl8712/rtl871x_event.h
@@ -36,7 +36,7 @@
* Used to report a bss has been scanned
*/
struct survey_event {
- struct ndis_wlan_bssid_ex bss;
+ struct wlan_bssid_ex bss;
};
/*
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 3388f97..4f5f69c 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -634,7 +634,7 @@ static int r8711_wx_get_name(struct net_device *dev,
char *p;
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
- struct ndis_wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
+ struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
NDIS_802_11_RATES_EX *prates = NULL;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
@@ -723,7 +723,7 @@ static int r8711_wx_get_freq(struct net_device *dev,
{
struct _adapter *padapter = netdev_priv(dev);
struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
- struct ndis_wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
+ struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
if (check_fwstate(pmlmepriv, _FW_LINKED) == true) {
wrqu->freq.m = ieee80211_wlan_frequencies[
@@ -1111,7 +1111,7 @@ static int r8711_wx_get_wap(struct net_device *dev,
{
struct _adapter *padapter = netdev_priv(dev);
struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
- struct ndis_wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
+ struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
wrqu->ap_addr.sa_family = ARPHRD_ETHER;
if (check_fwstate(pmlmepriv, _FW_LINKED | WIFI_ADHOC_MASTER_STATE |
@@ -1327,7 +1327,7 @@ static int r8711_wx_get_essid(struct net_device *dev,
{
struct _adapter *padapter = netdev_priv(dev);
struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
- struct ndis_wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
+ struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
u32 len, ret = 0;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE)) {
@@ -1419,7 +1419,7 @@ static int r8711_wx_get_rate(struct net_device *dev,
{
struct _adapter *padapter = netdev_priv(dev);
struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
- struct ndis_wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
+ struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
struct ieee80211_ht_cap *pht_capie;
unsigned char rf_type = padapter->registrypriv.rf_config;
int i;
diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c b/drivers/staging/rtl8712/rtl871x_mlme.c
index 6b3451f..7af9699 100644
--- a/drivers/staging/rtl8712/rtl871x_mlme.c
+++ b/drivers/staging/rtl8712/rtl871x_mlme.c
@@ -208,7 +208,7 @@ void r8712_generate_random_ibss(u8 *pibss)
pibss[5] = (u8)((curtime>>16) & 0xff);
}
-uint r8712_get_ndis_wlan_bssid_ex_sz(struct ndis_wlan_bssid_ex *bss)
+uint r8712_get_ndis_wlan_bssid_ex_sz(struct wlan_bssid_ex *bss)
{
return sizeof(*bss) + bss->IELength - MAX_IE_SZ;
}
@@ -276,8 +276,8 @@ int r8712_is_same_ibss(struct _adapter *adapter, struct wlan_network *pnetwork)
}
-static int is_same_network(struct ndis_wlan_bssid_ex *src,
- struct ndis_wlan_bssid_ex *dst)
+static int is_same_network(struct wlan_bssid_ex *src,
+ struct wlan_bssid_ex *dst)
{
u16 s_cap, d_cap;
@@ -322,8 +322,8 @@ struct wlan_network *r8712_get_oldest_wlan_network(
return oldest;
}
-static void update_network(struct ndis_wlan_bssid_ex *dst,
- struct ndis_wlan_bssid_ex *src,
+static void update_network(struct wlan_bssid_ex *dst,
+ struct wlan_bssid_ex *src,
struct _adapter *padapter)
{
u32 last_evm = 0, tmpVal;
@@ -360,7 +360,7 @@ static void update_network(struct ndis_wlan_bssid_ex *dst,
}
static void update_current_network(struct _adapter *adapter,
- struct ndis_wlan_bssid_ex *pnetwork)
+ struct wlan_bssid_ex *pnetwork)
{
struct mlme_priv *pmlmepriv = &adapter->mlmepriv;
@@ -378,7 +378,7 @@ static void update_current_network(struct _adapter *adapter,
Caller must hold pmlmepriv->lock first.
*/
static void update_scanned_network(struct _adapter *adapter,
- struct ndis_wlan_bssid_ex *target)
+ struct wlan_bssid_ex *target)
{
struct list_head *plist, *phead;
@@ -441,7 +441,7 @@ static void update_scanned_network(struct _adapter *adapter,
}
static void rtl8711_add_network(struct _adapter *adapter,
- struct ndis_wlan_bssid_ex *pnetwork)
+ struct wlan_bssid_ex *pnetwork)
{
unsigned long irqL;
struct mlme_priv *pmlmepriv = &(((struct _adapter *)adapter)->mlmepriv);
@@ -497,10 +497,10 @@ void r8712_survey_event_callback(struct _adapter *adapter, u8 *pbuf)
{
unsigned long flags;
u32 len;
- struct ndis_wlan_bssid_ex *pnetwork;
+ struct wlan_bssid_ex *pnetwork;
struct mlme_priv *pmlmepriv = &adapter->mlmepriv;
- pnetwork = (struct ndis_wlan_bssid_ex *)pbuf;
+ pnetwork = (struct wlan_bssid_ex *)pbuf;
#ifdef __BIG_ENDIAN
/* endian_convert */
pnetwork->Length = le32_to_cpu(pnetwork->Length);
@@ -1658,8 +1658,7 @@ void r8712_update_registrypriv_dev_network(struct _adapter *adapter)
*/
sz = r8712_generate_ie(pregistrypriv);
pdev_network->IELength = sz;
- pdev_network->Length = r8712_get_ndis_wlan_bssid_ex_sz(
- (struct ndis_wlan_bssid_ex *)pdev_network);
+ pdev_network->Length = r8712_get_ndis_wlan_bssid_ex_sz(pdev_network);
}
/*the function is at passive_level*/
diff --git a/drivers/staging/rtl8712/rtl871x_mlme.h b/drivers/staging/rtl8712/rtl871x_mlme.h
index 42bd0bf..47bb9c5 100644
--- a/drivers/staging/rtl8712/rtl871x_mlme.h
+++ b/drivers/staging/rtl8712/rtl871x_mlme.h
@@ -202,7 +202,7 @@ sint r8712_set_key(struct _adapter *adapter,
struct security_priv *psecuritypriv, sint keyid);
sint r8712_set_auth(struct _adapter *adapter,
struct security_priv *psecuritypriv);
-uint r8712_get_ndis_wlan_bssid_ex_sz(struct ndis_wlan_bssid_ex *bss);
+uint r8712_get_ndis_wlan_bssid_ex_sz(struct wlan_bssid_ex *bss);
void r8712_generate_random_ibss(u8 *pibss);
u8 *r8712_get_capability_from_ie(u8 *ie);
struct wlan_network *r8712_get_oldest_wlan_network(
diff --git a/drivers/staging/rtl8712/rtl871x_mp_ioctl.c b/drivers/staging/rtl8712/rtl871x_mp_ioctl.c
index 0b54612..c77b63a 100644
--- a/drivers/staging/rtl8712/rtl871x_mp_ioctl.c
+++ b/drivers/staging/rtl8712/rtl871x_mp_ioctl.c
@@ -160,13 +160,13 @@ static int mp_start_test(struct _adapter *padapter)
struct mp_priv *pmppriv = &padapter->mppriv;
struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
struct wlan_network *tgt_network = &pmlmepriv->cur_network;
- struct ndis_wlan_bssid_ex bssid;
+ struct wlan_bssid_ex bssid;
struct sta_info *psta;
unsigned long length;
unsigned long irqL;
int res = _SUCCESS;
- /* 3 1. initialize a new struct ndis_wlan_bssid_ex */
+ /* 3 1. initialize a new struct wlan_bssid_ex */
memcpy(bssid.MacAddress, pmppriv->network_macaddr, ETH_ALEN);
bssid.Ssid.SsidLength = 16;
memcpy(bssid.Ssid.Ssid, (unsigned char *)"mp_pseudo_adhoc",
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 8c5d6e7..cd3e62a 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,7 +83,7 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-struct ndis_wlan_bssid_ex {
+struct wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
u8 Reserved[2];
@@ -203,7 +203,7 @@ struct wlan_network {
unsigned int last_scanned; /*timestamp for the network */
int aid; /*will only be valid when a BSS is joined. */
int join_res;
- struct ndis_wlan_bssid_ex network; /*must be the last item */
+ struct wlan_bssid_ex network; /*must be the last item */
};
enum VRTL_CARRIER_SENSE {
@@ -234,24 +234,5 @@ enum UAPSD_MAX_SP {
#define NUM_PRE_AUTH_KEY 16
#define NUM_PMKID_CACHE NUM_PRE_AUTH_KEY
-/*
- * WPA2
- */
-struct wlan_bssid_ex {
- u32 Length;
- unsigned char MacAddress[6];
- u8 Reserved[2];
- struct ndis_802_11_ssid Ssid;
- u32 Privacy;
- s32 Rssi;
- enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
- struct NDIS_802_11_CONFIGURATION Configuration;
- enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
- u32 IELength;
- u8 IEs[MAX_IE_SZ]; /* (timestamp, beacon interval, and capability
- * information) */
-};
-
#endif /* #ifndef WLAN_BSSDEF_H_ */
--
2.4.6
^ permalink raw reply related [flat|nested] 27+ messages in thread
* [PATCH V3 RESEND 6/8] staging: rtl8712: rename function
2015-07-28 4:41 [PATCH V3 0/8] clean up wlan_bssdef.h Joshua Clayton
` (6 preceding siblings ...)
2015-07-28 14:15 ` [PATCH V3 RESEND 5/8] staging: rtl8712: remove duplicate struct Joshua Clayton
@ 2015-07-28 14:15 ` Joshua Clayton
2015-07-28 14:16 ` [PATCH V3 RESEND 8/8] staging: rtl8712: change SupportedRates to rates Joshua Clayton
` (8 subsequent siblings)
16 siblings, 0 replies; 27+ messages in thread
From: Joshua Clayton @ 2015-07-28 14:15 UTC (permalink / raw)
To: Larry Finger, Florian Schilhabel, Greg Kroah-Hartman
Cc: Sudip Mukherjee, Nitin Kuppelur, Joshua Clayton, Julia Lawall,
Dan Carpenter, devel, linux-kernel
Rename r8712_get_ndis_wlan_bssid_ex_sz() to r8712_get_wlan_bssid_ex_sz(),
which corresponds to the struct whose size it measures.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.c | 8 ++++----
drivers/staging/rtl8712/rtl871x_mlme.c | 16 ++++++++--------
drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 2 +-
4 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c
index 06d9844..ef71829 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.c
+++ b/drivers/staging/rtl8712/rtl871x_cmd.c
@@ -456,7 +456,7 @@ u8 r8712_createbss_cmd(struct _adapter *padapter)
INIT_LIST_HEAD(&pcmd->list);
pcmd->cmdcode = _CreateBss_CMD_;
pcmd->parmbuf = (unsigned char *)pdev_network;
- pcmd->cmdsz = r8712_get_ndis_wlan_bssid_ex_sz(pdev_network);
+ pcmd->cmdsz = r8712_get_wlan_bssid_ex_sz(pdev_network);
pcmd->rsp = NULL;
pcmd->rspsz = 0;
/* notes: translate IELength & Length after assign to cmdsz; */
@@ -564,7 +564,7 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
memcpy(&psecuritypriv->supplicant_ie[1], &psecnetwork->IEs[0],
255);
/* get cmdsz before endian conversion */
- pcmd->cmdsz = r8712_get_ndis_wlan_bssid_ex_sz(psecnetwork);
+ pcmd->cmdsz = r8712_get_wlan_bssid_ex_sz(psecnetwork);
#ifdef __BIG_ENDIAN
/* wlan_network endian conversion */
psecnetwork->Length = cpu_to_le32(psecnetwork->Length);
@@ -946,11 +946,11 @@ void r8712_createbss_cmd_callback(struct _adapter *padapter,
} else
list_add_tail(&(pwlan->list),
&pmlmepriv->scanned_queue.queue);
- pnetwork->Length = r8712_get_ndis_wlan_bssid_ex_sz(pnetwork);
+ pnetwork->Length = r8712_get_wlan_bssid_ex_sz(pnetwork);
memcpy(&(pwlan->network), pnetwork, pnetwork->Length);
pwlan->fixed = true;
memcpy(&tgt_network->network, pnetwork,
- (r8712_get_ndis_wlan_bssid_ex_sz(pnetwork)));
+ (r8712_get_wlan_bssid_ex_sz(pnetwork)));
if (pmlmepriv->fw_state & _FW_UNDER_LINKING)
pmlmepriv->fw_state ^= _FW_UNDER_LINKING;
/* we will set _FW_LINKED when there is one more sat to
diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c b/drivers/staging/rtl8712/rtl871x_mlme.c
index 7af9699..fc5dbea 100644
--- a/drivers/staging/rtl8712/rtl871x_mlme.c
+++ b/drivers/staging/rtl8712/rtl871x_mlme.c
@@ -208,7 +208,7 @@ void r8712_generate_random_ibss(u8 *pibss)
pibss[5] = (u8)((curtime>>16) & 0xff);
}
-uint r8712_get_ndis_wlan_bssid_ex_sz(struct wlan_bssid_ex *bss)
+uint r8712_get_wlan_bssid_ex_sz(struct wlan_bssid_ex *bss)
{
return sizeof(*bss) + bss->IELength - MAX_IE_SZ;
}
@@ -356,7 +356,7 @@ static void update_network(struct wlan_bssid_ex *dst,
src->Rssi = padapter->recvpriv.signal;
} else
src->Rssi = (src->Rssi + dst->Rssi) / 2;
- memcpy((u8 *)dst, (u8 *)src, r8712_get_ndis_wlan_bssid_ex_sz(src));
+ memcpy((u8 *)dst, (u8 *)src, r8712_get_wlan_bssid_ex_sz(src));
}
static void update_current_network(struct _adapter *adapter,
@@ -416,7 +416,7 @@ static void update_scanned_network(struct _adapter *adapter,
target->Rssi = (pnetwork->network.Rssi +
target->Rssi) / 2;
memcpy(&pnetwork->network, target,
- r8712_get_ndis_wlan_bssid_ex_sz(target));
+ r8712_get_wlan_bssid_ex_sz(target));
pnetwork->last_scanned = jiffies;
} else {
/* Otherwise just pull from the free list */
@@ -424,7 +424,7 @@ static void update_scanned_network(struct _adapter *adapter,
pnetwork = alloc_network(pmlmepriv);
if (pnetwork == NULL)
return;
- bssid_ex_sz = r8712_get_ndis_wlan_bssid_ex_sz(target);
+ bssid_ex_sz = r8712_get_wlan_bssid_ex_sz(target);
target->Length = bssid_ex_sz;
memcpy(&pnetwork->network, target, bssid_ex_sz);
list_add_tail(&pnetwork->list, &queue->queue);
@@ -528,7 +528,7 @@ void r8712_survey_event_callback(struct _adapter *adapter, u8 *pbuf)
le32_to_cpu(pnetwork->InfrastructureMode);
pnetwork->IELength = le32_to_cpu(pnetwork->IELength);
#endif
- len = r8712_get_ndis_wlan_bssid_ex_sz(pnetwork);
+ len = r8712_get_wlan_bssid_ex_sz(pnetwork);
if (len > sizeof(struct wlan_bssid_ex))
return;
spin_lock_irqsave(&pmlmepriv->lock2, flags);
@@ -759,7 +759,7 @@ void r8712_joinbss_event_callback(struct _adapter *adapter, u8 *pbuf)
the_same_macaddr = !memcmp(pnetwork->network.MacAddress,
cur_network->network.MacAddress, ETH_ALEN);
pnetwork->network.Length =
- r8712_get_ndis_wlan_bssid_ex_sz(&pnetwork->network);
+ r8712_get_wlan_bssid_ex_sz(&pnetwork->network);
spin_lock_irqsave(&pmlmepriv->lock, irqL);
if (pnetwork->network.Length > sizeof(struct wlan_bssid_ex))
goto ignore_joinbss_callback;
@@ -991,7 +991,7 @@ void r8712_stadel_event_callback(struct _adapter *adapter, u8 *pbuf)
pdev_network = &(adapter->registrypriv.dev_network);
pibss = adapter->registrypriv.dev_network.MacAddress;
memcpy(pdev_network, &tgt_network->network,
- r8712_get_ndis_wlan_bssid_ex_sz(&tgt_network->
+ r8712_get_wlan_bssid_ex_sz(&tgt_network->
network));
memcpy(&pdev_network->Ssid,
&pmlmepriv->assoc_ssid,
@@ -1658,7 +1658,7 @@ void r8712_update_registrypriv_dev_network(struct _adapter *adapter)
*/
sz = r8712_generate_ie(pregistrypriv);
pdev_network->IELength = sz;
- pdev_network->Length = r8712_get_ndis_wlan_bssid_ex_sz(pdev_network);
+ pdev_network->Length = r8712_get_wlan_bssid_ex_sz(pdev_network);
}
/*the function is at passive_level*/
diff --git a/drivers/staging/rtl8712/rtl871x_mlme.h b/drivers/staging/rtl8712/rtl871x_mlme.h
index 47bb9c5..08d6c98 100644
--- a/drivers/staging/rtl8712/rtl871x_mlme.h
+++ b/drivers/staging/rtl8712/rtl871x_mlme.h
@@ -202,7 +202,7 @@ sint r8712_set_key(struct _adapter *adapter,
struct security_priv *psecuritypriv, sint keyid);
sint r8712_set_auth(struct _adapter *adapter,
struct security_priv *psecuritypriv);
-uint r8712_get_ndis_wlan_bssid_ex_sz(struct wlan_bssid_ex *bss);
+uint r8712_get_wlan_bssid_ex_sz(struct wlan_bssid_ex *bss);
void r8712_generate_random_ibss(u8 *pibss);
u8 *r8712_get_capability_from_ie(u8 *ie);
struct wlan_network *r8712_get_oldest_wlan_network(
diff --git a/drivers/staging/rtl8712/rtl871x_mp_ioctl.c b/drivers/staging/rtl8712/rtl871x_mp_ioctl.c
index c77b63a..77f01bf 100644
--- a/drivers/staging/rtl8712/rtl871x_mp_ioctl.c
+++ b/drivers/staging/rtl8712/rtl871x_mp_ioctl.c
@@ -174,7 +174,7 @@ static int mp_start_test(struct _adapter *padapter)
bssid.InfrastructureMode = Ndis802_11IBSS;
bssid.NetworkTypeInUse = Ndis802_11DS;
bssid.IELength = 0;
- length = r8712_get_ndis_wlan_bssid_ex_sz(&bssid);
+ length = r8712_get_wlan_bssid_ex_sz(&bssid);
if (length % 4) {
/*round up to multiple of 4 bytes.*/
bssid.Length = ((length >> 2) + 1) << 2;
--
2.4.6
^ permalink raw reply related [flat|nested] 27+ messages in thread
* [PATCH V3 RESEND 8/8] staging: rtl8712: change SupportedRates to rates
2015-07-28 4:41 [PATCH V3 0/8] clean up wlan_bssdef.h Joshua Clayton
` (7 preceding siblings ...)
2015-07-28 14:15 ` [PATCH V3 RESEND 6/8] staging: rtl8712: rename function Joshua Clayton
@ 2015-07-28 14:16 ` Joshua Clayton
2015-07-28 15:37 ` Julia Lawall
2015-07-29 13:49 ` [PATCH V4 1/8] staging: rtl8712: fix buggy size calculation Joshua Clayton
` (7 subsequent siblings)
16 siblings, 1 reply; 27+ messages in thread
From: Joshua Clayton @ 2015-07-28 14:16 UTC (permalink / raw)
To: Larry Finger, Florian Schilhabel, Greg Kroah-Hartman
Cc: Sudip Mukherjee, Nitin Kuppelur, Joshua Clayton, Julia Lawall,
Dan Carpenter, devel, linux-kernel
Change the value to a name that conforms to Linux coding style.
"rates" is equally expressive in this context, and I have left alone
a comment and function name that describe the rates as supported rates.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/ieee80211.c | 22 +++++++++++-----------
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 16 ++++++++--------
drivers/staging/rtl8712/wlan_bssdef.h | 2 +-
3 files changed, 20 insertions(+), 20 deletions(-)
diff --git a/drivers/staging/rtl8712/ieee80211.c b/drivers/staging/rtl8712/ieee80211.c
index 5786808..ca9dcaf 100644
--- a/drivers/staging/rtl8712/ieee80211.c
+++ b/drivers/staging/rtl8712/ieee80211.c
@@ -134,22 +134,22 @@ u8 *r8712_get_ie(u8 *pbuf, sint index, sint *len, sint limit)
return NULL;
}
-static void set_supported_rate(u8 *SupportedRates, uint mode)
+static void set_supported_rate(u8 *rates, uint mode)
{
- memset(SupportedRates, 0, NDIS_802_11_LENGTH_RATES_EX);
+ memset(rates, 0, NDIS_802_11_LENGTH_RATES_EX);
switch (mode) {
case WIRELESS_11B:
- memcpy(SupportedRates, WIFI_CCKRATES,
+ memcpy(rates, WIFI_CCKRATES,
IEEE80211_CCK_RATE_LEN);
break;
case WIRELESS_11G:
case WIRELESS_11A:
- memcpy(SupportedRates, WIFI_OFDMRATES,
+ memcpy(rates, WIFI_OFDMRATES,
IEEE80211_NUM_OFDM_RATESLEN);
break;
case WIRELESS_11BG:
- memcpy(SupportedRates, WIFI_CCKRATES, IEEE80211_CCK_RATE_LEN);
- memcpy(SupportedRates + IEEE80211_CCK_RATE_LEN, WIFI_OFDMRATES,
+ memcpy(rates, WIFI_CCKRATES, IEEE80211_CCK_RATE_LEN);
+ memcpy(rates + IEEE80211_CCK_RATE_LEN, WIFI_OFDMRATES,
IEEE80211_NUM_OFDM_RATESLEN);
break;
}
@@ -195,17 +195,17 @@ int r8712_generate_ie(struct registry_priv *pregistrypriv)
ie = r8712_set_ie(ie, _SSID_IE_, pdev_network->Ssid.SsidLength,
pdev_network->Ssid.Ssid, &sz);
/*supported rates*/
- set_supported_rate(pdev_network->SupportedRates,
+ set_supported_rate(pdev_network->rates,
pregistrypriv->wireless_mode);
- rateLen = r8712_get_rateset_len(pdev_network->SupportedRates);
+ rateLen = r8712_get_rateset_len(pdev_network->rates);
if (rateLen > 8) {
ie = r8712_set_ie(ie, _SUPPORTEDRATES_IE_, 8,
- pdev_network->SupportedRates, &sz);
+ pdev_network->rates, &sz);
ie = r8712_set_ie(ie, _EXT_SUPPORTEDRATES_IE_, (rateLen - 8),
- (pdev_network->SupportedRates + 8), &sz);
+ (pdev_network->rates + 8), &sz);
} else
ie = r8712_set_ie(ie, _SUPPORTEDRATES_IE_,
- rateLen, pdev_network->SupportedRates, &sz);
+ rateLen, pdev_network->rates, &sz);
/*DS parameter set*/
ie = r8712_set_ie(ie, _DSSET_IE_, 1,
(u8 *)&(pdev_network->Configuration.DSConfig), &sz);
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 83d4bca..1ded691 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -204,13 +204,13 @@ static inline char *translate_scan(struct _adapter *padapter,
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
if ((r8712_is_cckratesonly_included(pnetwork->network.
- SupportedRates)) == true) {
+ rates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
} else if ((r8712_is_cckrates_included(pnetwork->network.
- SupportedRates)) == true) {
+ rates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
else
@@ -270,9 +270,9 @@ static inline char *translate_scan(struct _adapter *padapter,
iwe.u.bitrate.disabled = 0;
iwe.u.bitrate.value = 0;
i = 0;
- while (pnetwork->network.SupportedRates[i] != 0) {
+ while (pnetwork->network.rates[i] != 0) {
/* Bit rate given in 500 kb/s units */
- iwe.u.bitrate.value = (pnetwork->network.SupportedRates[i++] &
+ iwe.u.bitrate.value = (pnetwork->network.rates[i++] &
0x7F) * 500000;
current_val = iwe_stream_add_value(info, start, current_val,
stop, &iwe, IW_EV_PARAM_LEN);
@@ -644,7 +644,7 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = pcur_bss->SupportedRates;
+ prates = pcur_bss->rates;
if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
@@ -1444,9 +1444,9 @@ static int r8711_wx_get_rate(struct net_device *dev,
(IEEE80211_HT_CAP_SGI_20 |
IEEE80211_HT_CAP_SGI_40)) ? 1 : 0;
}
- while ((pcur_bss->SupportedRates[i] != 0) &&
- (pcur_bss->SupportedRates[i] != 0xFF)) {
- rate = pcur_bss->SupportedRates[i] & 0x7F;
+ while ((pcur_bss->rates[i] != 0) &&
+ (pcur_bss->rates[i] != 0xFF)) {
+ rate = pcur_bss->rates[i] & 0x7F;
if (rate > max_rate)
max_rate = rate;
wrqu->bitrate.fixed = 0; /* no auto select */
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index ff86fbd..fda5707 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -88,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
+ u8 rates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
^ permalink raw reply related [flat|nested] 27+ messages in thread
* Re: [PATCH V3 RESEND 8/8] staging: rtl8712: change SupportedRates to rates
2015-07-28 14:16 ` [PATCH V3 RESEND 8/8] staging: rtl8712: change SupportedRates to rates Joshua Clayton
@ 2015-07-28 15:37 ` Julia Lawall
2015-07-28 15:50 ` Joshua Clayton
0 siblings, 1 reply; 27+ messages in thread
From: Julia Lawall @ 2015-07-28 15:37 UTC (permalink / raw)
To: Joshua Clayton
Cc: Larry Finger, Florian Schilhabel, Greg Kroah-Hartman,
Sudip Mukherjee, Nitin Kuppelur, Dan Carpenter, devel,
linux-kernel
> diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> index 83d4bca..1ded691 100644
> --- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> +++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> @@ -204,13 +204,13 @@ static inline char *translate_scan(struct _adapter *padapter,
> /* Add the protocol name */
> iwe.cmd = SIOCGIWNAME;
> if ((r8712_is_cckratesonly_included(pnetwork->network.
> - SupportedRates)) == true) {
> + rates)) == true) {
> if (ht_cap == true)
> snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
> else
> snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
> } else if ((r8712_is_cckrates_included(pnetwork->network.
> - SupportedRates)) == true) {
> + rates)) == true) {
> if (ht_cap == true)
> snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
> else
The placement of the line breaks here is partucularly unpleasant. Perhaps
that could be adjusted now that the field name is shorter. Theer may be
some other cases in the patch where the line breaks could be adjusted to
improve readability.
julia
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH V3 RESEND 8/8] staging: rtl8712: change SupportedRates to rates
2015-07-28 15:37 ` Julia Lawall
@ 2015-07-28 15:50 ` Joshua Clayton
2015-07-28 15:53 ` Julia Lawall
2015-07-28 15:56 ` Dan Carpenter
0 siblings, 2 replies; 27+ messages in thread
From: Joshua Clayton @ 2015-07-28 15:50 UTC (permalink / raw)
To: Julia Lawall
Cc: Larry Finger, Florian Schilhabel, Greg Kroah-Hartman,
Sudip Mukherjee, Nitin Kuppelur, Dan Carpenter, devel,
linux-kernel
On Tuesday, July 28, 2015 05:37:16 PM Julia Lawall wrote:
> > diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> > index 83d4bca..1ded691 100644
> > --- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> > +++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> > @@ -204,13 +204,13 @@ static inline char *translate_scan(struct _adapter *padapter,
> > /* Add the protocol name */
> > iwe.cmd = SIOCGIWNAME;
> > if ((r8712_is_cckratesonly_included(pnetwork->network.
> > - SupportedRates)) == true) {
> > + rates)) == true) {
> > if (ht_cap == true)
> > snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
> > else
> > snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
> > } else if ((r8712_is_cckrates_included(pnetwork->network.
> > - SupportedRates)) == true) {
> > + rates)) == true) {
> > if (ht_cap == true)
> > snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
> > else
>
> The placement of the line breaks here is partucularly unpleasant. Perhaps
> that could be adjusted now that the field name is shorter. Theer may be
> some other cases in the patch where the line breaks could be adjusted to
> improve readability.
>
> julia
I agree. Dan Carpenter earlier complained about me fixing up the lines
while changing the variable name. Should that be a separate patch?
--
~Joshua Clayton
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH V3 RESEND 8/8] staging: rtl8712: change SupportedRates to rates
2015-07-28 15:50 ` Joshua Clayton
@ 2015-07-28 15:53 ` Julia Lawall
2015-07-28 15:56 ` Dan Carpenter
1 sibling, 0 replies; 27+ messages in thread
From: Julia Lawall @ 2015-07-28 15:53 UTC (permalink / raw)
To: Joshua Clayton
Cc: Larry Finger, Florian Schilhabel, Greg Kroah-Hartman,
Sudip Mukherjee, Nitin Kuppelur, Dan Carpenter, devel,
linux-kernel
On Tue, 28 Jul 2015, Joshua Clayton wrote:
> On Tuesday, July 28, 2015 05:37:16 PM Julia Lawall wrote:
> > > diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> > > index 83d4bca..1ded691 100644
> > > --- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> > > +++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> > > @@ -204,13 +204,13 @@ static inline char *translate_scan(struct _adapter *padapter,
> > > /* Add the protocol name */
> > > iwe.cmd = SIOCGIWNAME;
> > > if ((r8712_is_cckratesonly_included(pnetwork->network.
> > > - SupportedRates)) == true) {
> > > + rates)) == true) {
> > > if (ht_cap == true)
> > > snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
> > > else
> > > snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
> > > } else if ((r8712_is_cckrates_included(pnetwork->network.
> > > - SupportedRates)) == true) {
> > > + rates)) == true) {
> > > if (ht_cap == true)
> > > snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
> > > else
> >
> > The placement of the line breaks here is partucularly unpleasant. Perhaps
> > that could be adjusted now that the field name is shorter. Theer may be
> > some other cases in the patch where the line breaks could be adjusted to
> > improve readability.
> >
> > julia
> I agree. Dan Carpenter earlier complained about me fixing up the lines
> while changing the variable name. Should that be a separate patch?
I would have done it at once, but you can take Dan's advice.
julia
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH V3 RESEND 8/8] staging: rtl8712: change SupportedRates to rates
2015-07-28 15:50 ` Joshua Clayton
2015-07-28 15:53 ` Julia Lawall
@ 2015-07-28 15:56 ` Dan Carpenter
2015-07-28 17:49 ` Joshua Clayton
1 sibling, 1 reply; 27+ messages in thread
From: Dan Carpenter @ 2015-07-28 15:56 UTC (permalink / raw)
To: Joshua Clayton
Cc: Julia Lawall, devel, Florian Schilhabel, Greg Kroah-Hartman,
Nitin Kuppelur, linux-kernel, Sudip Mukherjee, Larry Finger
On Tue, Jul 28, 2015 at 08:50:04AM -0700, Joshua Clayton wrote:
> On Tuesday, July 28, 2015 05:37:16 PM Julia Lawall wrote:
> > > diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> > > index 83d4bca..1ded691 100644
> > > --- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> > > +++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> > > @@ -204,13 +204,13 @@ static inline char *translate_scan(struct _adapter *padapter,
> > > /* Add the protocol name */
> > > iwe.cmd = SIOCGIWNAME;
> > > if ((r8712_is_cckratesonly_included(pnetwork->network.
> > > - SupportedRates)) == true) {
> > > + rates)) == true) {
> > > if (ht_cap == true)
> > > snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
> > > else
> > > snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
> > > } else if ((r8712_is_cckrates_included(pnetwork->network.
> > > - SupportedRates)) == true) {
> > > + rates)) == true) {
> > > if (ht_cap == true)
> > > snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
> > > else
> >
> > The placement of the line breaks here is partucularly unpleasant. Perhaps
> > that could be adjusted now that the field name is shorter. Theer may be
> > some other cases in the patch where the line breaks could be adjusted to
> > improve readability.
> >
> > julia
> I agree. Dan Carpenter earlier complained about me fixing up the lines
> while changing the variable name. Should that be a separate patch?
>
Changing the line breaks here is a tiny change on the same line and so
it's fine. It fits into the one thing per patch rule.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH V3 RESEND 8/8] staging: rtl8712: change SupportedRates to rates
2015-07-28 15:56 ` Dan Carpenter
@ 2015-07-28 17:49 ` Joshua Clayton
2015-07-28 22:07 ` Dan Carpenter
0 siblings, 1 reply; 27+ messages in thread
From: Joshua Clayton @ 2015-07-28 17:49 UTC (permalink / raw)
To: Dan Carpenter
Cc: Julia Lawall, devel, Florian Schilhabel, Greg Kroah-Hartman,
Nitin Kuppelur, linux-kernel, Sudip Mukherjee, Larry Finger
On Tuesday, July 28, 2015 06:56:38 PM Dan Carpenter wrote:
> On Tue, Jul 28, 2015 at 08:50:04AM -0700, Joshua Clayton wrote:
> > On Tuesday, July 28, 2015 05:37:16 PM Julia Lawall wrote:
> > > > diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> > > > index 83d4bca..1ded691 100644
> > > > --- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> > > > +++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> > > > @@ -204,13 +204,13 @@ static inline char *translate_scan(struct _adapter *padapter,
> > > > /* Add the protocol name */
> > > > iwe.cmd = SIOCGIWNAME;
> > > > if ((r8712_is_cckratesonly_included(pnetwork->network.
> > > > - SupportedRates)) == true) {
> > > > + rates)) == true) {
> > > > if (ht_cap == true)
> > > > snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
> > > > else
> > > > snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
> > > > } else if ((r8712_is_cckrates_included(pnetwork->network.
> > > > - SupportedRates)) == true) {
> > > > + rates)) == true) {
> > > > if (ht_cap == true)
> > > > snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
> > > > else
> > >
> > > The placement of the line breaks here is partucularly unpleasant. Perhaps
> > > that could be adjusted now that the field name is shorter. Theer may be
> > > some other cases in the patch where the line breaks could be adjusted to
> > > improve readability.
> > >
> > > julia
> > I agree. Dan Carpenter earlier complained about me fixing up the lines
> > while changing the variable name. Should that be a separate patch?
> >
>
> Changing the line breaks here is a tiny change on the same line and so
> it's fine. It fits into the one thing per patch rule.
This is the style I prefer (getting rid of the explicit == true)
- if ((r8712_is_cckratesonly_included(pnetwork->network.
- SupportedRates)) == true) {
+ if (r8712_is_cckratesonly_included(pnetwork->network.rates)) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included(pnetwork->network.
- SupportedRates)) == true) {
+ } else if (r8712_is_cckrates_included(pnetwork->network.rates)) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
Does that look ok?
If we keep the "== true" and the extra set of parentheses, the "else if" case goes over 80 lines.
I will happily submit the change as follow up patch if that is too much to change at once.
>
> regards,
> dan carpenter
>
--
~Joshua Clayton
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH V3 RESEND 8/8] staging: rtl8712: change SupportedRates to rates
2015-07-28 17:49 ` Joshua Clayton
@ 2015-07-28 22:07 ` Dan Carpenter
0 siblings, 0 replies; 27+ messages in thread
From: Dan Carpenter @ 2015-07-28 22:07 UTC (permalink / raw)
To: Joshua Clayton
Cc: Julia Lawall, devel, Florian Schilhabel, Greg Kroah-Hartman,
Nitin Kuppelur, linux-kernel, Sudip Mukherjee, Larry Finger
On Tue, Jul 28, 2015 at 10:49:52AM -0700, Joshua Clayton wrote:
> > Changing the line breaks here is a tiny change on the same line and so
> > it's fine. It fits into the one thing per patch rule.
>
> This is the style I prefer (getting rid of the explicit == true)
>
> - if ((r8712_is_cckratesonly_included(pnetwork->network.
> - SupportedRates)) == true) {
> + if (r8712_is_cckratesonly_included(pnetwork->network.rates)) {
> if (ht_cap == true)
> snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
> else
> snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
> - } else if ((r8712_is_cckrates_included(pnetwork->network.
> - SupportedRates)) == true) {
> + } else if (r8712_is_cckrates_included(pnetwork->network.rates)) {
> if (ht_cap == true)
> snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
>
> Does that look ok?
Yes. It looks better.
> If we keep the "== true" and the extra set of parentheses, the "else if" case goes over 80 lines.
> I will happily submit the change as follow up patch if that is too much to change at once.
The "one thing per patch" rule is a fuzzy line. My scripts don't care
about white space very much so moving the .rates to the other line is
not a big deal. Also the line break was really bad and the == true is
only mildly untidy at worst. If it's a massive patch then removing the
== true makes things more difficult, yes, but if it's small then it's
probably fine to do it at once since it's on the same line and makes the
80 character rule work.
What I'm saying is that just use your best judgement what is easy to
review and we try to be reasonable as well.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH V4 1/8] staging: rtl8712: fix buggy size calculation
2015-07-28 4:41 [PATCH V3 0/8] clean up wlan_bssdef.h Joshua Clayton
` (8 preceding siblings ...)
2015-07-28 14:16 ` [PATCH V3 RESEND 8/8] staging: rtl8712: change SupportedRates to rates Joshua Clayton
@ 2015-07-29 13:49 ` Joshua Clayton
2015-07-29 13:49 ` [PATCH V4 2/8] staging: rtl8712: simplify " Joshua Clayton
` (6 subsequent siblings)
16 siblings, 0 replies; 27+ messages in thread
From: Joshua Clayton @ 2015-07-29 13:49 UTC (permalink / raw)
To: Larry Finger, Florian Schilhabel, Greg Kroah-Hartman
Cc: Sudip Mukherjee, Nitin Kuppelur, Joshua Clayton, Julia Lawall,
Dan Carpenter, devel, linux-kernel
r8712_get_ndis_wlan_bssid_ex_sz has a "6 * sizeof(unsigned long)"
where the underlying struct has a 6 * unsigned char.
Simplify the calculation by just subtracting the variable part from
the size of the struct.
This also gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_mlme.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c b/drivers/staging/rtl8712/rtl871x_mlme.c
index c044b0e..6b3451f 100644
--- a/drivers/staging/rtl8712/rtl871x_mlme.c
+++ b/drivers/staging/rtl8712/rtl871x_mlme.c
@@ -210,17 +210,7 @@ void r8712_generate_random_ibss(u8 *pibss)
uint r8712_get_ndis_wlan_bssid_ex_sz(struct ndis_wlan_bssid_ex *bss)
{
- uint t_len;
-
- t_len = sizeof(u32) + 6 * sizeof(unsigned long) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + bss->IELength;
- return t_len;
+ return sizeof(*bss) + bss->IELength - MAX_IE_SZ;
}
u8 *r8712_get_capability_from_ie(u8 *ie)
--
2.4.6
^ permalink raw reply related [flat|nested] 27+ messages in thread
* [PATCH V4 2/8] staging: rtl8712: simplify size calculation
2015-07-28 4:41 [PATCH V3 0/8] clean up wlan_bssdef.h Joshua Clayton
` (9 preceding siblings ...)
2015-07-29 13:49 ` [PATCH V4 1/8] staging: rtl8712: fix buggy size calculation Joshua Clayton
@ 2015-07-29 13:49 ` Joshua Clayton
2015-07-29 13:50 ` [PATCH V4 3/8] staging: rtl8712: fix comment Joshua Clayton
` (5 subsequent siblings)
16 siblings, 0 replies; 27+ messages in thread
From: Joshua Clayton @ 2015-07-29 13:49 UTC (permalink / raw)
To: Larry Finger, Florian Schilhabel, Greg Kroah-Hartman
Cc: Sudip Mukherjee, Nitin Kuppelur, Joshua Clayton, Julia Lawall,
Dan Carpenter, devel, linux-kernel
replace item-by-item size calculation of a struct
with the size of the struct.
This gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c
index e35854d..f07050d 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.c
+++ b/drivers/staging/rtl8712/rtl871x_cmd.c
@@ -471,7 +471,6 @@ u8 r8712_createbss_cmd(struct _adapter *padapter)
u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
{
- uint t_len = 0;
struct ndis_wlan_bssid_ex *psecnetwork;
struct cmd_obj *pcmd;
struct cmd_priv *pcmdpriv = &padapter->cmdpriv;
@@ -486,14 +485,6 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
pcmd = kmalloc(sizeof(*pcmd), GFP_ATOMIC);
if (pcmd == NULL)
return _FAIL;
- t_len = sizeof(u32) + 6 * sizeof(unsigned char) + 2 +
- sizeof(struct ndis_802_11_ssid) + sizeof(u32) +
- sizeof(s32) +
- sizeof(enum NDIS_802_11_NETWORK_TYPE) +
- sizeof(struct NDIS_802_11_CONFIGURATION) +
- sizeof(enum NDIS_802_11_NETWORK_INFRASTRUCTURE) +
- sizeof(NDIS_802_11_RATES_EX) +
- sizeof(u32) + MAX_IE_SZ;
/* for hidden ap to set fw_state here */
if (check_fwstate(pmlmepriv, WIFI_STATION_STATE|WIFI_ADHOC_STATE) !=
@@ -516,7 +507,7 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
kfree(pcmd);
return _FAIL;
}
- memcpy(psecnetwork, &pnetwork->network, t_len);
+ memcpy(psecnetwork, &pnetwork->network, sizeof(*psecnetwork));
psecuritypriv->authenticator_ie[0] = (unsigned char)
psecnetwork->IELength;
if ((psecnetwork->IELength-12) < (256 - 1))
--
2.4.6
^ permalink raw reply related [flat|nested] 27+ messages in thread
* [PATCH V4 3/8] staging: rtl8712: fix comment
2015-07-28 4:41 [PATCH V3 0/8] clean up wlan_bssdef.h Joshua Clayton
` (10 preceding siblings ...)
2015-07-29 13:49 ` [PATCH V4 2/8] staging: rtl8712: simplify " Joshua Clayton
@ 2015-07-29 13:50 ` Joshua Clayton
2015-07-29 13:50 ` [PATCH V4 4/8] staging: rtl8712: removed unused wrapper structs Joshua Clayton
` (4 subsequent siblings)
16 siblings, 0 replies; 27+ messages in thread
From: Joshua Clayton @ 2015-07-29 13:50 UTC (permalink / raw)
To: Larry Finger, Florian Schilhabel, Greg Kroah-Hartman
Cc: Sudip Mukherjee, Nitin Kuppelur, Joshua Clayton, Julia Lawall,
Dan Carpenter, devel, linux-kernel
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
^ permalink raw reply related [flat|nested] 27+ messages in thread
* [PATCH V4 4/8] staging: rtl8712: removed unused wrapper structs
2015-07-28 4:41 [PATCH V3 0/8] clean up wlan_bssdef.h Joshua Clayton
` (11 preceding siblings ...)
2015-07-29 13:50 ` [PATCH V4 3/8] staging: rtl8712: fix comment Joshua Clayton
@ 2015-07-29 13:50 ` Joshua Clayton
2015-07-29 13:50 ` [PATCH V4 5/8] staging: rtl8712: remove duplicate struct Joshua Clayton
` (3 subsequent siblings)
16 siblings, 0 replies; 27+ messages in thread
From: Joshua Clayton @ 2015-07-29 13:50 UTC (permalink / raw)
To: Larry Finger, Florian Schilhabel, Greg Kroah-Hartman
Cc: Sudip Mukherjee, Nitin Kuppelur, Joshua Clayton, Julia Lawall,
Dan Carpenter, devel, linux-kernel
Remove wrapper structs that just wrap struct ndis_wlan_bssid_ex,
and are unused.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.h b/drivers/staging/rtl8712/rtl871x_cmd.h
index cb8225b..818cd88 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.h
+++ b/drivers/staging/rtl8712/rtl871x_cmd.h
@@ -123,15 +123,6 @@ struct usb_suspend_parm {
};
/*
- * Caller Mode: Infra, Ad-Hoc
- * Notes: To join the specified bss
- * Command Event Mode
- */
-struct joinbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: Infra, Ad-HoC(C)
* Notes: To disconnect the current associated BSS
* Command Mode
@@ -141,15 +132,6 @@ struct disconnect_parm {
};
/*
- * Caller Mode: AP, Ad-HoC(M)
- * Notes: To create a BSS
- * Command Mode
- */
-struct createbss_parm {
- struct ndis_wlan_bssid_ex network;
-};
-
-/*
* Caller Mode: AP, Ad-HoC, Infra
* Notes: To set the NIC mode of RTL8711
* Command Mode
--
2.4.6
^ permalink raw reply related [flat|nested] 27+ messages in thread
* [PATCH V4 5/8] staging: rtl8712: remove duplicate struct
2015-07-28 4:41 [PATCH V3 0/8] clean up wlan_bssdef.h Joshua Clayton
` (12 preceding siblings ...)
2015-07-29 13:50 ` [PATCH V4 4/8] staging: rtl8712: removed unused wrapper structs Joshua Clayton
@ 2015-07-29 13:50 ` Joshua Clayton
2015-07-29 13:50 ` [PATCH V4 6/8] staging: rtl8712: rename function Joshua Clayton
` (2 subsequent siblings)
16 siblings, 0 replies; 27+ messages in thread
From: Joshua Clayton @ 2015-07-29 13:50 UTC (permalink / raw)
To: Larry Finger, Florian Schilhabel, Greg Kroah-Hartman
Cc: Sudip Mukherjee, Nitin Kuppelur, Joshua Clayton, Julia Lawall,
Dan Carpenter, devel, linux-kernel
struct ndis_wlan_bssid_ex is a doppelganger of struct wlan_bssid_ex,
and is used about a third as often.
Switch all instances to wlan_bssid_ex, and remove ndis_wlan_bssid_ex
This also gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.c | 11 ++++-------
drivers/staging/rtl8712/rtl871x_event.h | 2 +-
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 10 +++++-----
drivers/staging/rtl8712/rtl871x_mlme.c | 23 +++++++++++------------
drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 4 ++--
drivers/staging/rtl8712/wlan_bssdef.h | 23 ++---------------------
7 files changed, 26 insertions(+), 49 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c
index f07050d..06d9844 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.c
+++ b/drivers/staging/rtl8712/rtl871x_cmd.c
@@ -456,9 +456,7 @@ u8 r8712_createbss_cmd(struct _adapter *padapter)
INIT_LIST_HEAD(&pcmd->list);
pcmd->cmdcode = _CreateBss_CMD_;
pcmd->parmbuf = (unsigned char *)pdev_network;
- pcmd->cmdsz = r8712_get_ndis_wlan_bssid_ex_sz((
- struct ndis_wlan_bssid_ex *)
- pdev_network);
+ pcmd->cmdsz = r8712_get_ndis_wlan_bssid_ex_sz(pdev_network);
pcmd->rsp = NULL;
pcmd->rspsz = 0;
/* notes: translate IELength & Length after assign to cmdsz; */
@@ -471,7 +469,7 @@ u8 r8712_createbss_cmd(struct _adapter *padapter)
u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
{
- struct ndis_wlan_bssid_ex *psecnetwork;
+ struct wlan_bssid_ex *psecnetwork;
struct cmd_obj *pcmd;
struct cmd_priv *pcmdpriv = &padapter->cmdpriv;
struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
@@ -502,7 +500,7 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
break;
}
}
- psecnetwork = (struct ndis_wlan_bssid_ex *)&psecuritypriv->sec_bss;
+ psecnetwork = &psecuritypriv->sec_bss;
if (psecnetwork == NULL) {
kfree(pcmd);
return _FAIL;
@@ -894,8 +892,7 @@ void r8712_createbss_cmd_callback(struct _adapter *padapter,
struct sta_info *psta = NULL;
struct wlan_network *pwlan = NULL;
struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
- struct ndis_wlan_bssid_ex *pnetwork = (struct ndis_wlan_bssid_ex *)
- pcmd->parmbuf;
+ struct wlan_bssid_ex *pnetwork = (struct wlan_bssid_ex *)pcmd->parmbuf;
struct wlan_network *tgt_network = &(pmlmepriv->cur_network);
if (pcmd->res != H2C_SUCCESS)
diff --git a/drivers/staging/rtl8712/rtl871x_event.h b/drivers/staging/rtl8712/rtl871x_event.h
index e03ee90..697c8d7 100644
--- a/drivers/staging/rtl8712/rtl871x_event.h
+++ b/drivers/staging/rtl8712/rtl871x_event.h
@@ -36,7 +36,7 @@
* Used to report a bss has been scanned
*/
struct survey_event {
- struct ndis_wlan_bssid_ex bss;
+ struct wlan_bssid_ex bss;
};
/*
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 3388f97..4f5f69c 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -634,7 +634,7 @@ static int r8711_wx_get_name(struct net_device *dev,
char *p;
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
- struct ndis_wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
+ struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
NDIS_802_11_RATES_EX *prates = NULL;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
@@ -723,7 +723,7 @@ static int r8711_wx_get_freq(struct net_device *dev,
{
struct _adapter *padapter = netdev_priv(dev);
struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
- struct ndis_wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
+ struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
if (check_fwstate(pmlmepriv, _FW_LINKED) == true) {
wrqu->freq.m = ieee80211_wlan_frequencies[
@@ -1111,7 +1111,7 @@ static int r8711_wx_get_wap(struct net_device *dev,
{
struct _adapter *padapter = netdev_priv(dev);
struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
- struct ndis_wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
+ struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
wrqu->ap_addr.sa_family = ARPHRD_ETHER;
if (check_fwstate(pmlmepriv, _FW_LINKED | WIFI_ADHOC_MASTER_STATE |
@@ -1327,7 +1327,7 @@ static int r8711_wx_get_essid(struct net_device *dev,
{
struct _adapter *padapter = netdev_priv(dev);
struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
- struct ndis_wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
+ struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
u32 len, ret = 0;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE)) {
@@ -1419,7 +1419,7 @@ static int r8711_wx_get_rate(struct net_device *dev,
{
struct _adapter *padapter = netdev_priv(dev);
struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
- struct ndis_wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
+ struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
struct ieee80211_ht_cap *pht_capie;
unsigned char rf_type = padapter->registrypriv.rf_config;
int i;
diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c b/drivers/staging/rtl8712/rtl871x_mlme.c
index 6b3451f..7af9699 100644
--- a/drivers/staging/rtl8712/rtl871x_mlme.c
+++ b/drivers/staging/rtl8712/rtl871x_mlme.c
@@ -208,7 +208,7 @@ void r8712_generate_random_ibss(u8 *pibss)
pibss[5] = (u8)((curtime>>16) & 0xff);
}
-uint r8712_get_ndis_wlan_bssid_ex_sz(struct ndis_wlan_bssid_ex *bss)
+uint r8712_get_ndis_wlan_bssid_ex_sz(struct wlan_bssid_ex *bss)
{
return sizeof(*bss) + bss->IELength - MAX_IE_SZ;
}
@@ -276,8 +276,8 @@ int r8712_is_same_ibss(struct _adapter *adapter, struct wlan_network *pnetwork)
}
-static int is_same_network(struct ndis_wlan_bssid_ex *src,
- struct ndis_wlan_bssid_ex *dst)
+static int is_same_network(struct wlan_bssid_ex *src,
+ struct wlan_bssid_ex *dst)
{
u16 s_cap, d_cap;
@@ -322,8 +322,8 @@ struct wlan_network *r8712_get_oldest_wlan_network(
return oldest;
}
-static void update_network(struct ndis_wlan_bssid_ex *dst,
- struct ndis_wlan_bssid_ex *src,
+static void update_network(struct wlan_bssid_ex *dst,
+ struct wlan_bssid_ex *src,
struct _adapter *padapter)
{
u32 last_evm = 0, tmpVal;
@@ -360,7 +360,7 @@ static void update_network(struct ndis_wlan_bssid_ex *dst,
}
static void update_current_network(struct _adapter *adapter,
- struct ndis_wlan_bssid_ex *pnetwork)
+ struct wlan_bssid_ex *pnetwork)
{
struct mlme_priv *pmlmepriv = &adapter->mlmepriv;
@@ -378,7 +378,7 @@ static void update_current_network(struct _adapter *adapter,
Caller must hold pmlmepriv->lock first.
*/
static void update_scanned_network(struct _adapter *adapter,
- struct ndis_wlan_bssid_ex *target)
+ struct wlan_bssid_ex *target)
{
struct list_head *plist, *phead;
@@ -441,7 +441,7 @@ static void update_scanned_network(struct _adapter *adapter,
}
static void rtl8711_add_network(struct _adapter *adapter,
- struct ndis_wlan_bssid_ex *pnetwork)
+ struct wlan_bssid_ex *pnetwork)
{
unsigned long irqL;
struct mlme_priv *pmlmepriv = &(((struct _adapter *)adapter)->mlmepriv);
@@ -497,10 +497,10 @@ void r8712_survey_event_callback(struct _adapter *adapter, u8 *pbuf)
{
unsigned long flags;
u32 len;
- struct ndis_wlan_bssid_ex *pnetwork;
+ struct wlan_bssid_ex *pnetwork;
struct mlme_priv *pmlmepriv = &adapter->mlmepriv;
- pnetwork = (struct ndis_wlan_bssid_ex *)pbuf;
+ pnetwork = (struct wlan_bssid_ex *)pbuf;
#ifdef __BIG_ENDIAN
/* endian_convert */
pnetwork->Length = le32_to_cpu(pnetwork->Length);
@@ -1658,8 +1658,7 @@ void r8712_update_registrypriv_dev_network(struct _adapter *adapter)
*/
sz = r8712_generate_ie(pregistrypriv);
pdev_network->IELength = sz;
- pdev_network->Length = r8712_get_ndis_wlan_bssid_ex_sz(
- (struct ndis_wlan_bssid_ex *)pdev_network);
+ pdev_network->Length = r8712_get_ndis_wlan_bssid_ex_sz(pdev_network);
}
/*the function is at passive_level*/
diff --git a/drivers/staging/rtl8712/rtl871x_mlme.h b/drivers/staging/rtl8712/rtl871x_mlme.h
index 42bd0bf..47bb9c5 100644
--- a/drivers/staging/rtl8712/rtl871x_mlme.h
+++ b/drivers/staging/rtl8712/rtl871x_mlme.h
@@ -202,7 +202,7 @@ sint r8712_set_key(struct _adapter *adapter,
struct security_priv *psecuritypriv, sint keyid);
sint r8712_set_auth(struct _adapter *adapter,
struct security_priv *psecuritypriv);
-uint r8712_get_ndis_wlan_bssid_ex_sz(struct ndis_wlan_bssid_ex *bss);
+uint r8712_get_ndis_wlan_bssid_ex_sz(struct wlan_bssid_ex *bss);
void r8712_generate_random_ibss(u8 *pibss);
u8 *r8712_get_capability_from_ie(u8 *ie);
struct wlan_network *r8712_get_oldest_wlan_network(
diff --git a/drivers/staging/rtl8712/rtl871x_mp_ioctl.c b/drivers/staging/rtl8712/rtl871x_mp_ioctl.c
index 0b54612..c77b63a 100644
--- a/drivers/staging/rtl8712/rtl871x_mp_ioctl.c
+++ b/drivers/staging/rtl8712/rtl871x_mp_ioctl.c
@@ -160,13 +160,13 @@ static int mp_start_test(struct _adapter *padapter)
struct mp_priv *pmppriv = &padapter->mppriv;
struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
struct wlan_network *tgt_network = &pmlmepriv->cur_network;
- struct ndis_wlan_bssid_ex bssid;
+ struct wlan_bssid_ex bssid;
struct sta_info *psta;
unsigned long length;
unsigned long irqL;
int res = _SUCCESS;
- /* 3 1. initialize a new struct ndis_wlan_bssid_ex */
+ /* 3 1. initialize a new struct wlan_bssid_ex */
memcpy(bssid.MacAddress, pmppriv->network_macaddr, ETH_ALEN);
bssid.Ssid.SsidLength = 16;
memcpy(bssid.Ssid.Ssid, (unsigned char *)"mp_pseudo_adhoc",
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 8c5d6e7..cd3e62a 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,7 +83,7 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-struct ndis_wlan_bssid_ex {
+struct wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
u8 Reserved[2];
@@ -203,7 +203,7 @@ struct wlan_network {
unsigned int last_scanned; /*timestamp for the network */
int aid; /*will only be valid when a BSS is joined. */
int join_res;
- struct ndis_wlan_bssid_ex network; /*must be the last item */
+ struct wlan_bssid_ex network; /*must be the last item */
};
enum VRTL_CARRIER_SENSE {
@@ -234,24 +234,5 @@ enum UAPSD_MAX_SP {
#define NUM_PRE_AUTH_KEY 16
#define NUM_PMKID_CACHE NUM_PRE_AUTH_KEY
-/*
- * WPA2
- */
-struct wlan_bssid_ex {
- u32 Length;
- unsigned char MacAddress[6];
- u8 Reserved[2];
- struct ndis_802_11_ssid Ssid;
- u32 Privacy;
- s32 Rssi;
- enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
- struct NDIS_802_11_CONFIGURATION Configuration;
- enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
- u32 IELength;
- u8 IEs[MAX_IE_SZ]; /* (timestamp, beacon interval, and capability
- * information) */
-};
-
#endif /* #ifndef WLAN_BSSDEF_H_ */
--
2.4.6
^ permalink raw reply related [flat|nested] 27+ messages in thread
* [PATCH V4 6/8] staging: rtl8712: rename function
2015-07-28 4:41 [PATCH V3 0/8] clean up wlan_bssdef.h Joshua Clayton
` (13 preceding siblings ...)
2015-07-29 13:50 ` [PATCH V4 5/8] staging: rtl8712: remove duplicate struct Joshua Clayton
@ 2015-07-29 13:50 ` Joshua Clayton
2015-07-29 13:50 ` [PATCH V4 7/8] staging: rtl8712: remove typedefs Joshua Clayton
2015-07-29 13:50 ` [PATCH V4 8/8] staging: rtl8712: change SupportedRates to rates Joshua Clayton
16 siblings, 0 replies; 27+ messages in thread
From: Joshua Clayton @ 2015-07-29 13:50 UTC (permalink / raw)
To: Larry Finger, Florian Schilhabel, Greg Kroah-Hartman
Cc: Sudip Mukherjee, Nitin Kuppelur, Joshua Clayton, Julia Lawall,
Dan Carpenter, devel, linux-kernel
Rename r8712_get_ndis_wlan_bssid_ex_sz() to r8712_get_wlan_bssid_ex_sz(),
which corresponds to the struct whose size it measures.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_cmd.c | 8 ++++----
drivers/staging/rtl8712/rtl871x_mlme.c | 16 ++++++++--------
drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 2 +-
4 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c
index 06d9844..ef71829 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.c
+++ b/drivers/staging/rtl8712/rtl871x_cmd.c
@@ -456,7 +456,7 @@ u8 r8712_createbss_cmd(struct _adapter *padapter)
INIT_LIST_HEAD(&pcmd->list);
pcmd->cmdcode = _CreateBss_CMD_;
pcmd->parmbuf = (unsigned char *)pdev_network;
- pcmd->cmdsz = r8712_get_ndis_wlan_bssid_ex_sz(pdev_network);
+ pcmd->cmdsz = r8712_get_wlan_bssid_ex_sz(pdev_network);
pcmd->rsp = NULL;
pcmd->rspsz = 0;
/* notes: translate IELength & Length after assign to cmdsz; */
@@ -564,7 +564,7 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork)
memcpy(&psecuritypriv->supplicant_ie[1], &psecnetwork->IEs[0],
255);
/* get cmdsz before endian conversion */
- pcmd->cmdsz = r8712_get_ndis_wlan_bssid_ex_sz(psecnetwork);
+ pcmd->cmdsz = r8712_get_wlan_bssid_ex_sz(psecnetwork);
#ifdef __BIG_ENDIAN
/* wlan_network endian conversion */
psecnetwork->Length = cpu_to_le32(psecnetwork->Length);
@@ -946,11 +946,11 @@ void r8712_createbss_cmd_callback(struct _adapter *padapter,
} else
list_add_tail(&(pwlan->list),
&pmlmepriv->scanned_queue.queue);
- pnetwork->Length = r8712_get_ndis_wlan_bssid_ex_sz(pnetwork);
+ pnetwork->Length = r8712_get_wlan_bssid_ex_sz(pnetwork);
memcpy(&(pwlan->network), pnetwork, pnetwork->Length);
pwlan->fixed = true;
memcpy(&tgt_network->network, pnetwork,
- (r8712_get_ndis_wlan_bssid_ex_sz(pnetwork)));
+ (r8712_get_wlan_bssid_ex_sz(pnetwork)));
if (pmlmepriv->fw_state & _FW_UNDER_LINKING)
pmlmepriv->fw_state ^= _FW_UNDER_LINKING;
/* we will set _FW_LINKED when there is one more sat to
diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c b/drivers/staging/rtl8712/rtl871x_mlme.c
index 7af9699..fc5dbea 100644
--- a/drivers/staging/rtl8712/rtl871x_mlme.c
+++ b/drivers/staging/rtl8712/rtl871x_mlme.c
@@ -208,7 +208,7 @@ void r8712_generate_random_ibss(u8 *pibss)
pibss[5] = (u8)((curtime>>16) & 0xff);
}
-uint r8712_get_ndis_wlan_bssid_ex_sz(struct wlan_bssid_ex *bss)
+uint r8712_get_wlan_bssid_ex_sz(struct wlan_bssid_ex *bss)
{
return sizeof(*bss) + bss->IELength - MAX_IE_SZ;
}
@@ -356,7 +356,7 @@ static void update_network(struct wlan_bssid_ex *dst,
src->Rssi = padapter->recvpriv.signal;
} else
src->Rssi = (src->Rssi + dst->Rssi) / 2;
- memcpy((u8 *)dst, (u8 *)src, r8712_get_ndis_wlan_bssid_ex_sz(src));
+ memcpy((u8 *)dst, (u8 *)src, r8712_get_wlan_bssid_ex_sz(src));
}
static void update_current_network(struct _adapter *adapter,
@@ -416,7 +416,7 @@ static void update_scanned_network(struct _adapter *adapter,
target->Rssi = (pnetwork->network.Rssi +
target->Rssi) / 2;
memcpy(&pnetwork->network, target,
- r8712_get_ndis_wlan_bssid_ex_sz(target));
+ r8712_get_wlan_bssid_ex_sz(target));
pnetwork->last_scanned = jiffies;
} else {
/* Otherwise just pull from the free list */
@@ -424,7 +424,7 @@ static void update_scanned_network(struct _adapter *adapter,
pnetwork = alloc_network(pmlmepriv);
if (pnetwork == NULL)
return;
- bssid_ex_sz = r8712_get_ndis_wlan_bssid_ex_sz(target);
+ bssid_ex_sz = r8712_get_wlan_bssid_ex_sz(target);
target->Length = bssid_ex_sz;
memcpy(&pnetwork->network, target, bssid_ex_sz);
list_add_tail(&pnetwork->list, &queue->queue);
@@ -528,7 +528,7 @@ void r8712_survey_event_callback(struct _adapter *adapter, u8 *pbuf)
le32_to_cpu(pnetwork->InfrastructureMode);
pnetwork->IELength = le32_to_cpu(pnetwork->IELength);
#endif
- len = r8712_get_ndis_wlan_bssid_ex_sz(pnetwork);
+ len = r8712_get_wlan_bssid_ex_sz(pnetwork);
if (len > sizeof(struct wlan_bssid_ex))
return;
spin_lock_irqsave(&pmlmepriv->lock2, flags);
@@ -759,7 +759,7 @@ void r8712_joinbss_event_callback(struct _adapter *adapter, u8 *pbuf)
the_same_macaddr = !memcmp(pnetwork->network.MacAddress,
cur_network->network.MacAddress, ETH_ALEN);
pnetwork->network.Length =
- r8712_get_ndis_wlan_bssid_ex_sz(&pnetwork->network);
+ r8712_get_wlan_bssid_ex_sz(&pnetwork->network);
spin_lock_irqsave(&pmlmepriv->lock, irqL);
if (pnetwork->network.Length > sizeof(struct wlan_bssid_ex))
goto ignore_joinbss_callback;
@@ -991,7 +991,7 @@ void r8712_stadel_event_callback(struct _adapter *adapter, u8 *pbuf)
pdev_network = &(adapter->registrypriv.dev_network);
pibss = adapter->registrypriv.dev_network.MacAddress;
memcpy(pdev_network, &tgt_network->network,
- r8712_get_ndis_wlan_bssid_ex_sz(&tgt_network->
+ r8712_get_wlan_bssid_ex_sz(&tgt_network->
network));
memcpy(&pdev_network->Ssid,
&pmlmepriv->assoc_ssid,
@@ -1658,7 +1658,7 @@ void r8712_update_registrypriv_dev_network(struct _adapter *adapter)
*/
sz = r8712_generate_ie(pregistrypriv);
pdev_network->IELength = sz;
- pdev_network->Length = r8712_get_ndis_wlan_bssid_ex_sz(pdev_network);
+ pdev_network->Length = r8712_get_wlan_bssid_ex_sz(pdev_network);
}
/*the function is at passive_level*/
diff --git a/drivers/staging/rtl8712/rtl871x_mlme.h b/drivers/staging/rtl8712/rtl871x_mlme.h
index 47bb9c5..08d6c98 100644
--- a/drivers/staging/rtl8712/rtl871x_mlme.h
+++ b/drivers/staging/rtl8712/rtl871x_mlme.h
@@ -202,7 +202,7 @@ sint r8712_set_key(struct _adapter *adapter,
struct security_priv *psecuritypriv, sint keyid);
sint r8712_set_auth(struct _adapter *adapter,
struct security_priv *psecuritypriv);
-uint r8712_get_ndis_wlan_bssid_ex_sz(struct wlan_bssid_ex *bss);
+uint r8712_get_wlan_bssid_ex_sz(struct wlan_bssid_ex *bss);
void r8712_generate_random_ibss(u8 *pibss);
u8 *r8712_get_capability_from_ie(u8 *ie);
struct wlan_network *r8712_get_oldest_wlan_network(
diff --git a/drivers/staging/rtl8712/rtl871x_mp_ioctl.c b/drivers/staging/rtl8712/rtl871x_mp_ioctl.c
index c77b63a..77f01bf 100644
--- a/drivers/staging/rtl8712/rtl871x_mp_ioctl.c
+++ b/drivers/staging/rtl8712/rtl871x_mp_ioctl.c
@@ -174,7 +174,7 @@ static int mp_start_test(struct _adapter *padapter)
bssid.InfrastructureMode = Ndis802_11IBSS;
bssid.NetworkTypeInUse = Ndis802_11DS;
bssid.IELength = 0;
- length = r8712_get_ndis_wlan_bssid_ex_sz(&bssid);
+ length = r8712_get_wlan_bssid_ex_sz(&bssid);
if (length % 4) {
/*round up to multiple of 4 bytes.*/
bssid.Length = ((length >> 2) + 1) << 2;
--
2.4.6
^ permalink raw reply related [flat|nested] 27+ messages in thread
* [PATCH V4 7/8] staging: rtl8712: remove typedefs
2015-07-28 4:41 [PATCH V3 0/8] clean up wlan_bssdef.h Joshua Clayton
` (14 preceding siblings ...)
2015-07-29 13:50 ` [PATCH V4 6/8] staging: rtl8712: rename function Joshua Clayton
@ 2015-07-29 13:50 ` Joshua Clayton
2015-07-29 13:50 ` [PATCH V4 8/8] staging: rtl8712: change SupportedRates to rates Joshua Clayton
16 siblings, 0 replies; 27+ messages in thread
From: Joshua Clayton @ 2015-07-29 13:50 UTC (permalink / raw)
To: Larry Finger, Florian Schilhabel, Greg Kroah-Hartman
Cc: Sudip Mukherjee, Nitin Kuppelur, Joshua Clayton, Julia Lawall,
Dan Carpenter, devel, linux-kernel
Coding style fix.
Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX
Undo any casting that was done as a result of the typedef.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++++++------
drivers/staging/rtl8712/wlan_bssdef.h | 7 +------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 4f5f69c..83d4bca 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,13 +203,13 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included((u8 *)&pnetwork->network.
+ if ((r8712_is_cckratesonly_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)&pnetwork->network.
+ } else if ((r8712_is_cckrates_included(pnetwork->network.
SupportedRates)) == true) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
@@ -635,7 +635,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u8 ht_cap = false;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
- NDIS_802_11_RATES_EX *prates = NULL;
+ u8 *prates;
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
true) {
@@ -644,15 +644,15 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = &pcur_bss->SupportedRates;
- if (r8712_is_cckratesonly_included((u8 *)prates) == true) {
+ prates = pcur_bss->SupportedRates;
+ if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bn");
else
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11b");
- } else if ((r8712_is_cckrates_included((u8 *)prates)) == true) {
+ } else if ((r8712_is_cckrates_included(prates)) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
"IEEE 802.11bgn");
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index cd3e62a..ff86fbd 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -32,11 +32,6 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-/* Set of 8 data rates*/
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];
-/* Set of 16 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];
-
struct ndis_802_11_ssid {
u32 SsidLength;
u8 Ssid[32];
@@ -93,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- NDIS_802_11_RATES_EX SupportedRates;
+ u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
^ permalink raw reply related [flat|nested] 27+ messages in thread
* [PATCH V4 8/8] staging: rtl8712: change SupportedRates to rates
2015-07-28 4:41 [PATCH V3 0/8] clean up wlan_bssdef.h Joshua Clayton
` (15 preceding siblings ...)
2015-07-29 13:50 ` [PATCH V4 7/8] staging: rtl8712: remove typedefs Joshua Clayton
@ 2015-07-29 13:50 ` Joshua Clayton
16 siblings, 0 replies; 27+ messages in thread
From: Joshua Clayton @ 2015-07-29 13:50 UTC (permalink / raw)
To: Larry Finger, Florian Schilhabel, Greg Kroah-Hartman
Cc: Sudip Mukherjee, Nitin Kuppelur, Joshua Clayton, Julia Lawall,
Dan Carpenter, devel, linux-kernel
Change the value to a name that conforms to Linux coding style.
"rates" is equally expressive in this context, and I have left alone
a comment and function name that describe the rates as supported rates.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/staging/rtl8712/ieee80211.c | 25 +++++++++++--------------
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 18 ++++++++----------
drivers/staging/rtl8712/wlan_bssdef.h | 2 +-
3 files changed, 20 insertions(+), 25 deletions(-)
diff --git a/drivers/staging/rtl8712/ieee80211.c b/drivers/staging/rtl8712/ieee80211.c
index 5786808..c5527c1 100644
--- a/drivers/staging/rtl8712/ieee80211.c
+++ b/drivers/staging/rtl8712/ieee80211.c
@@ -134,22 +134,20 @@ u8 *r8712_get_ie(u8 *pbuf, sint index, sint *len, sint limit)
return NULL;
}
-static void set_supported_rate(u8 *SupportedRates, uint mode)
+static void set_supported_rate(u8 *rates, uint mode)
{
- memset(SupportedRates, 0, NDIS_802_11_LENGTH_RATES_EX);
+ memset(rates, 0, NDIS_802_11_LENGTH_RATES_EX);
switch (mode) {
case WIRELESS_11B:
- memcpy(SupportedRates, WIFI_CCKRATES,
- IEEE80211_CCK_RATE_LEN);
+ memcpy(rates, WIFI_CCKRATES, IEEE80211_CCK_RATE_LEN);
break;
case WIRELESS_11G:
case WIRELESS_11A:
- memcpy(SupportedRates, WIFI_OFDMRATES,
- IEEE80211_NUM_OFDM_RATESLEN);
+ memcpy(rates, WIFI_OFDMRATES, IEEE80211_NUM_OFDM_RATESLEN);
break;
case WIRELESS_11BG:
- memcpy(SupportedRates, WIFI_CCKRATES, IEEE80211_CCK_RATE_LEN);
- memcpy(SupportedRates + IEEE80211_CCK_RATE_LEN, WIFI_OFDMRATES,
+ memcpy(rates, WIFI_CCKRATES, IEEE80211_CCK_RATE_LEN);
+ memcpy(rates + IEEE80211_CCK_RATE_LEN, WIFI_OFDMRATES,
IEEE80211_NUM_OFDM_RATESLEN);
break;
}
@@ -195,17 +193,16 @@ int r8712_generate_ie(struct registry_priv *pregistrypriv)
ie = r8712_set_ie(ie, _SSID_IE_, pdev_network->Ssid.SsidLength,
pdev_network->Ssid.Ssid, &sz);
/*supported rates*/
- set_supported_rate(pdev_network->SupportedRates,
- pregistrypriv->wireless_mode);
- rateLen = r8712_get_rateset_len(pdev_network->SupportedRates);
+ set_supported_rate(pdev_network->rates, pregistrypriv->wireless_mode);
+ rateLen = r8712_get_rateset_len(pdev_network->rates);
if (rateLen > 8) {
ie = r8712_set_ie(ie, _SUPPORTEDRATES_IE_, 8,
- pdev_network->SupportedRates, &sz);
+ pdev_network->rates, &sz);
ie = r8712_set_ie(ie, _EXT_SUPPORTEDRATES_IE_, (rateLen - 8),
- (pdev_network->SupportedRates + 8), &sz);
+ (pdev_network->rates + 8), &sz);
} else
ie = r8712_set_ie(ie, _SUPPORTEDRATES_IE_,
- rateLen, pdev_network->SupportedRates, &sz);
+ rateLen, pdev_network->rates, &sz);
/*DS parameter set*/
ie = r8712_set_ie(ie, _DSSET_IE_, 1,
(u8 *)&(pdev_network->Configuration.DSConfig), &sz);
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 83d4bca..143be0f 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -203,14 +203,12 @@ static inline char *translate_scan(struct _adapter *padapter,
}
/* Add the protocol name */
iwe.cmd = SIOCGIWNAME;
- if ((r8712_is_cckratesonly_included(pnetwork->network.
- SupportedRates)) == true) {
+ if (r8712_is_cckratesonly_included(pnetwork->network.rates)) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
else
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
- } else if ((r8712_is_cckrates_included(pnetwork->network.
- SupportedRates)) == true) {
+ } else if (r8712_is_cckrates_included(pnetwork->network.rates)) {
if (ht_cap == true)
snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
else
@@ -270,9 +268,9 @@ static inline char *translate_scan(struct _adapter *padapter,
iwe.u.bitrate.disabled = 0;
iwe.u.bitrate.value = 0;
i = 0;
- while (pnetwork->network.SupportedRates[i] != 0) {
+ while (pnetwork->network.rates[i] != 0) {
/* Bit rate given in 500 kb/s units */
- iwe.u.bitrate.value = (pnetwork->network.SupportedRates[i++] &
+ iwe.u.bitrate.value = (pnetwork->network.rates[i++] &
0x7F) * 500000;
current_val = iwe_stream_add_value(info, start, current_val,
stop, &iwe, IW_EV_PARAM_LEN);
@@ -644,7 +642,7 @@ static int r8711_wx_get_name(struct net_device *dev,
&ht_ielen, pcur_bss->IELength - 12);
if (p && ht_ielen > 0)
ht_cap = true;
- prates = pcur_bss->SupportedRates;
+ prates = pcur_bss->rates;
if (r8712_is_cckratesonly_included(prates) == true) {
if (ht_cap == true)
snprintf(wrqu->name, IFNAMSIZ,
@@ -1444,9 +1442,9 @@ static int r8711_wx_get_rate(struct net_device *dev,
(IEEE80211_HT_CAP_SGI_20 |
IEEE80211_HT_CAP_SGI_40)) ? 1 : 0;
}
- while ((pcur_bss->SupportedRates[i] != 0) &&
- (pcur_bss->SupportedRates[i] != 0xFF)) {
- rate = pcur_bss->SupportedRates[i] & 0x7F;
+ while ((pcur_bss->rates[i] != 0) &&
+ (pcur_bss->rates[i] != 0xFF)) {
+ rate = pcur_bss->rates[i] & 0x7F;
if (rate > max_rate)
max_rate = rate;
wrqu->bitrate.fixed = 0; /* no auto select */
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index ff86fbd..fda5707 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -88,7 +88,7 @@ struct wlan_bssid_ex {
enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
- u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
+ u8 rates[NDIS_802_11_LENGTH_RATES_EX];
/* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
--
2.4.6
^ permalink raw reply related [flat|nested] 27+ messages in thread
end of thread, other threads:[~2015-07-29 13:52 UTC | newest]
Thread overview: 27+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-28 4:41 [PATCH V3 0/8] clean up wlan_bssdef.h Joshua Clayton
2015-07-28 4:41 ` [PATCH V3 1/8] staging: rtl8712: fix buggy size calculation Joshua Clayton
2015-07-28 11:46 ` Sudip Mukherjee
2015-07-28 12:27 ` Joshua Clayton
2015-07-28 4:41 ` [PATCH V3 2/8] staging: rtl8712: simplify " Joshua Clayton
2015-07-28 4:41 ` [PATCH V3 3/8] staging: rtl8712: fix comment Joshua Clayton
2015-07-28 4:41 ` [PATCH V3 4/8] staging: rtl8712: removed unused wrapper structs Joshua Clayton
2015-07-28 4:41 ` [PATCH V3 7/8] staging: rtl8712: remove typedefs Joshua Clayton
2015-07-28 5:27 ` [PATCH V3 0/8] clean up wlan_bssdef.h Julia Lawall
2015-07-28 12:38 ` Joshua Clayton
2015-07-28 14:15 ` [PATCH V3 RESEND 5/8] staging: rtl8712: remove duplicate struct Joshua Clayton
2015-07-28 14:15 ` [PATCH V3 RESEND 6/8] staging: rtl8712: rename function Joshua Clayton
2015-07-28 14:16 ` [PATCH V3 RESEND 8/8] staging: rtl8712: change SupportedRates to rates Joshua Clayton
2015-07-28 15:37 ` Julia Lawall
2015-07-28 15:50 ` Joshua Clayton
2015-07-28 15:53 ` Julia Lawall
2015-07-28 15:56 ` Dan Carpenter
2015-07-28 17:49 ` Joshua Clayton
2015-07-28 22:07 ` Dan Carpenter
2015-07-29 13:49 ` [PATCH V4 1/8] staging: rtl8712: fix buggy size calculation Joshua Clayton
2015-07-29 13:49 ` [PATCH V4 2/8] staging: rtl8712: simplify " Joshua Clayton
2015-07-29 13:50 ` [PATCH V4 3/8] staging: rtl8712: fix comment Joshua Clayton
2015-07-29 13:50 ` [PATCH V4 4/8] staging: rtl8712: removed unused wrapper structs Joshua Clayton
2015-07-29 13:50 ` [PATCH V4 5/8] staging: rtl8712: remove duplicate struct Joshua Clayton
2015-07-29 13:50 ` [PATCH V4 6/8] staging: rtl8712: rename function Joshua Clayton
2015-07-29 13:50 ` [PATCH V4 7/8] staging: rtl8712: remove typedefs Joshua Clayton
2015-07-29 13:50 ` [PATCH V4 8/8] staging: rtl8712: change SupportedRates to rates Joshua Clayton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).