* [PATCH RT 0/6] Linux 3.14.48-rt49-rc1
@ 2015-08-06 22:17 Steven Rostedt
2015-08-06 22:17 ` [PATCH RT 1/6] Revert "slub: delay ctor until the object is requested" Steven Rostedt
` (6 more replies)
0 siblings, 7 replies; 10+ messages in thread
From: Steven Rostedt @ 2015-08-06 22:17 UTC (permalink / raw)
To: linux-kernel, linux-rt-users
Cc: Thomas Gleixner, Carsten Emde, Sebastian Andrzej Siewior,
John Kacur, Paul Gortmaker
Dear RT Folks,
This is the RT stable review cycle of patch 3.14.48-rt49-rc1.
Please scream at me if I messed something up. Please test the patches too.
The -rc release will be uploaded to kernel.org and will be deleted when
the final release is out. This is just a review release (or release candidate).
The pre-releases will not be pushed to the git repository, only the
final release is.
If all goes well, this patch will be converted to the next main release
on 8/10/2015.
Note, these changes appear to make NO_HZ_FULL work as well as 3.18-rt does.
Enjoy,
-- Steve
To build 3.14.48-rt49-rc1 directly, the following patches should be applied:
http://www.kernel.org/pub/linux/kernel/v3.x/linux-3.14.tar.xz
http://www.kernel.org/pub/linux/kernel/v3.x/patch-3.14.48.xz
http://www.kernel.org/pub/linux/kernel/projects/rt/3.14/patch-3.14.48-rt49-rc1.patch.xz
You can also build from 3.14.48-rt48 by applying the incremental patch:
http://www.kernel.org/pub/linux/kernel/projects/rt/3.14/incr/patch-3.14.48-rt48-rt49-rc1.patch.xz
Changes from 3.14.48-rt48:
---
Bogdan Purcareata (1):
powerpc/kvm: Disable in-kernel MPIC emulation for PREEMPT_RT_FULL
Frederic Weisbecker (1):
x86-Tell-irq-work-about-self-IPI-support-3.14
Sebastian Andrzej Siewior (1):
Revert "slub: delay ctor until the object is requested"
Steven Rostedt (1):
xfs: Disable percpu SB on PREEMPT_RT_FULL
Steven Rostedt (Red Hat) (1):
Linux 3.14.48-rt49-rc1
Thomas Gleixner (1):
mm/slub: move slab initialization into irq enabled region
----
arch/powerpc/kvm/Kconfig | 1 +
arch/x86/include/asm/Kbuild | 1 -
arch/x86/include/asm/irq_work.h | 11 ++++++
arch/x86/kernel/irq_work.c | 2 +-
fs/xfs/xfs_linux.h | 2 +-
localversion-rt | 2 +-
mm/slub.c | 86 +++++++++++++++++++----------------------
7 files changed, 54 insertions(+), 51 deletions(-)
create mode 100644 arch/x86/include/asm/irq_work.h
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH RT 1/6] Revert "slub: delay ctor until the object is requested"
2015-08-06 22:17 [PATCH RT 0/6] Linux 3.14.48-rt49-rc1 Steven Rostedt
@ 2015-08-06 22:17 ` Steven Rostedt
2015-08-06 22:17 ` [PATCH RT 2/6] mm/slub: move slab initialization into irq enabled region Steven Rostedt
` (5 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: Steven Rostedt @ 2015-08-06 22:17 UTC (permalink / raw)
To: linux-kernel, linux-rt-users
Cc: Thomas Gleixner, Carsten Emde, Sebastian Andrzej Siewior,
John Kacur, Paul Gortmaker, stable-rt
[-- Attachment #1: 0001-Revert-slub-delay-ctor-until-the-object-is-requested.patch --]
[-- Type: text/plain, Size: 1178 bytes --]
3.14.48-rt49-rc1 stable review patch.
If anyone has any objections, please let me know.
------------------
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
This approach is broken with SLAB_DESTROY_BY_RCU allocations.
Reported by Steven Rostedt and Koehrer Mathias.
Cc: stable-rt@vger.kernel.org
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
mm/slub.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/mm/slub.c b/mm/slub.c
index 93eeaca6cb53..5b0e9ee52f79 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -1403,10 +1403,8 @@ static void setup_object(struct kmem_cache *s, struct page *page,
void *object)
{
setup_object_debug(s, page, object);
-#ifndef CONFIG_PREEMPT_RT_FULL
if (unlikely(s->ctor))
s->ctor(object);
-#endif
}
static struct page *new_slab(struct kmem_cache *s, gfp_t flags, int node)
@@ -2519,10 +2517,6 @@ redo:
if (unlikely(gfpflags & __GFP_ZERO) && object)
memset(object, 0, s->object_size);
-#ifdef CONFIG_PREEMPT_RT_FULL
- if (unlikely(s->ctor) && object)
- s->ctor(object);
-#endif
slab_post_alloc_hook(s, gfpflags, object);
--
2.1.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH RT 2/6] mm/slub: move slab initialization into irq enabled region
2015-08-06 22:17 [PATCH RT 0/6] Linux 3.14.48-rt49-rc1 Steven Rostedt
2015-08-06 22:17 ` [PATCH RT 1/6] Revert "slub: delay ctor until the object is requested" Steven Rostedt
@ 2015-08-06 22:17 ` Steven Rostedt
2015-08-06 22:17 ` [PATCH RT 3/6] x86-Tell-irq-work-about-self-IPI-support-3.14 Steven Rostedt
` (4 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: Steven Rostedt @ 2015-08-06 22:17 UTC (permalink / raw)
To: linux-kernel, linux-rt-users
Cc: Thomas Gleixner, Carsten Emde, Sebastian Andrzej Siewior,
John Kacur, Paul Gortmaker, Christoph Lameter, Pekka Enberg,
David Rientjes, Joonsoo Kim, Peter Zijlstra, Andrew Morton
[-- Attachment #1: 0002-mm-slub-move-slab-initialization-into-irq-enabled-re.patch --]
[-- Type: text/plain, Size: 4427 bytes --]
3.14.48-rt49-rc1 stable review patch.
If anyone has any objections, please let me know.
------------------
From: Thomas Gleixner <tglx@linutronix.de>
Initializing a new slab can introduce rather large latencies because most
of the initialization runs always with interrupts disabled.
There is no point in doing so. The newly allocated slab is not visible
yet, so there is no reason to protect it against concurrent alloc/free.
Move the expensive parts of the initialization into allocate_slab(), so
for all allocations with GFP_WAIT set, interrupts are enabled.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Christoph Lameter <cl@linux.com>
Cc: Pekka Enberg <penberg@kernel.org>
Cc: David Rientjes <rientjes@google.com>
Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
mm/slub.c | 80 +++++++++++++++++++++++++++++++--------------------------------
1 file changed, 39 insertions(+), 41 deletions(-)
diff --git a/mm/slub.c b/mm/slub.c
index 5b0e9ee52f79..f21e9bcb9094 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -1316,6 +1316,14 @@ struct slub_free_list {
};
static DEFINE_PER_CPU(struct slub_free_list, slub_free_list);
+static void setup_object(struct kmem_cache *s, struct page *page,
+ void *object)
+{
+ setup_object_debug(s, page, object);
+ if (unlikely(s->ctor))
+ s->ctor(object);
+}
+
/*
* Slab allocation and freeing
*/
@@ -1338,6 +1346,8 @@ static struct page *allocate_slab(struct kmem_cache *s, gfp_t flags, int node)
struct kmem_cache_order_objects oo = s->oo;
gfp_t alloc_gfp;
bool enableirqs;
+ void *start, *last, *p;
+ int idx, order;
flags &= gfp_allowed_mask;
@@ -1364,13 +1374,13 @@ static struct page *allocate_slab(struct kmem_cache *s, gfp_t flags, int node)
* Try a lower order alloc if possible
*/
page = alloc_slab_page(flags, node, oo);
-
- if (page)
- stat(s, ORDER_FALLBACK);
+ if (unlikely(!page))
+ goto out;
+ stat(s, ORDER_FALLBACK);
}
- if (kmemcheck_enabled && page
- && !(s->flags & (SLAB_NOTRACK | DEBUG_DEFAULT_FLAGS))) {
+ if (kmemcheck_enabled &&
+ !(s->flags & (SLAB_NOTRACK | DEBUG_DEFAULT_FLAGS))) {
int pages = 1 << oo_order(oo);
kmemcheck_alloc_shadow(page, oo_order(oo), flags, node);
@@ -1385,45 +1395,9 @@ static struct page *allocate_slab(struct kmem_cache *s, gfp_t flags, int node)
kmemcheck_mark_unallocated_pages(page, pages);
}
- if (enableirqs)
- local_irq_disable();
- if (!page)
- return NULL;
-
page->objects = oo_objects(oo);
- mod_zone_page_state(page_zone(page),
- (s->flags & SLAB_RECLAIM_ACCOUNT) ?
- NR_SLAB_RECLAIMABLE : NR_SLAB_UNRECLAIMABLE,
- 1 << oo_order(oo));
-
- return page;
-}
-
-static void setup_object(struct kmem_cache *s, struct page *page,
- void *object)
-{
- setup_object_debug(s, page, object);
- if (unlikely(s->ctor))
- s->ctor(object);
-}
-
-static struct page *new_slab(struct kmem_cache *s, gfp_t flags, int node)
-{
- struct page *page;
- void *start;
- void *last;
- void *p;
- int order;
-
- BUG_ON(flags & GFP_SLAB_BUG_MASK);
-
- page = allocate_slab(s,
- flags & (GFP_RECLAIM_MASK | GFP_CONSTRAINT_MASK), node);
- if (!page)
- goto out;
order = compound_order(page);
- inc_slabs_node(s, page_to_nid(page), page->objects);
memcg_bind_pages(s, order);
page->slab_cache = s;
__SetPageSlab(page);
@@ -1447,10 +1421,34 @@ static struct page *new_slab(struct kmem_cache *s, gfp_t flags, int node)
page->freelist = start;
page->inuse = page->objects;
page->frozen = 1;
+
out:
+ if (enableirqs)
+ local_irq_disable();
+ if (!page)
+ return NULL;
+
+ mod_zone_page_state(page_zone(page),
+ (s->flags & SLAB_RECLAIM_ACCOUNT) ?
+ NR_SLAB_RECLAIMABLE : NR_SLAB_UNRECLAIMABLE,
+ 1 << oo_order(oo));
+
+ inc_slabs_node(s, page_to_nid(page), page->objects);
+
return page;
}
+static struct page *new_slab(struct kmem_cache *s, gfp_t flags, int node)
+{
+ if (unlikely(flags & GFP_SLAB_BUG_MASK)) {
+ pr_emerg("gfp: %u\n", flags & GFP_SLAB_BUG_MASK);
+ BUG();
+ }
+
+ return allocate_slab(s,
+ flags & (GFP_RECLAIM_MASK | GFP_CONSTRAINT_MASK), node);
+}
+
static void __free_slab(struct kmem_cache *s, struct page *page)
{
int order = compound_order(page);
--
2.1.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH RT 3/6] x86-Tell-irq-work-about-self-IPI-support-3.14
2015-08-06 22:17 [PATCH RT 0/6] Linux 3.14.48-rt49-rc1 Steven Rostedt
2015-08-06 22:17 ` [PATCH RT 1/6] Revert "slub: delay ctor until the object is requested" Steven Rostedt
2015-08-06 22:17 ` [PATCH RT 2/6] mm/slub: move slab initialization into irq enabled region Steven Rostedt
@ 2015-08-06 22:17 ` Steven Rostedt
2015-08-06 22:17 ` [PATCH RT 4/6] xfs: Disable percpu SB on PREEMPT_RT_FULL Steven Rostedt
` (3 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: Steven Rostedt @ 2015-08-06 22:17 UTC (permalink / raw)
To: linux-kernel, linux-rt-users
Cc: Thomas Gleixner, Carsten Emde, Sebastian Andrzej Siewior,
John Kacur, Paul Gortmaker, Peter Zijlstra (Intel),
Ingo Molnar, Paul E. McKenney, Frederic Weisbecker
[-- Attachment #1: 0003-x86-Tell-irq-work-about-self-IPI-support-3.14.patch --]
[-- Type: text/plain, Size: 2256 bytes --]
3.14.48-rt49-rc1 stable review patch.
If anyone has any objections, please let me know.
------------------
From: Frederic Weisbecker <fweisbec@gmail.com>
commit 3010279f0fc36f0388872203e63ca49912f648fd
Author: Frederic Weisbecker <fweisbec@gmail.com>
Date: Sat Aug 16 18:47:15 2014 +0200
x86: Tell irq work about self IPI support
x86 supports irq work self-IPIs when local apic is available. This is
partly known on runtime so lets implement arch_irq_work_has_interrupt()
accordingly.
This should be safely called after setup_arch().
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
arch/x86/include/asm/Kbuild | 1 -
arch/x86/include/asm/irq_work.h | 11 +++++++++++
arch/x86/kernel/irq_work.c | 2 +-
3 files changed, 12 insertions(+), 2 deletions(-)
create mode 100644 arch/x86/include/asm/irq_work.h
diff --git a/arch/x86/include/asm/Kbuild b/arch/x86/include/asm/Kbuild
index 1eb77ac0613c..7f669853317a 100644
--- a/arch/x86/include/asm/Kbuild
+++ b/arch/x86/include/asm/Kbuild
@@ -5,4 +5,3 @@ genhdr-y += unistd_64.h
genhdr-y += unistd_x32.h
generic-y += clkdev.h
-generic-y += irq_work.h
diff --git a/arch/x86/include/asm/irq_work.h b/arch/x86/include/asm/irq_work.h
new file mode 100644
index 000000000000..78162f8e248b
--- /dev/null
+++ b/arch/x86/include/asm/irq_work.h
@@ -0,0 +1,11 @@
+#ifndef _ASM_IRQ_WORK_H
+#define _ASM_IRQ_WORK_H
+
+#include <asm/processor.h>
+
+static inline bool arch_irq_work_has_interrupt(void)
+{
+ return cpu_has_apic;
+}
+
+#endif /* _ASM_IRQ_WORK_H */
diff --git a/arch/x86/kernel/irq_work.c b/arch/x86/kernel/irq_work.c
index 1de84e3ab4e0..15d741ddfeeb 100644
--- a/arch/x86/kernel/irq_work.c
+++ b/arch/x86/kernel/irq_work.c
@@ -41,7 +41,7 @@ __visible void smp_trace_irq_work_interrupt(struct pt_regs *regs)
void arch_irq_work_raise(void)
{
#ifdef CONFIG_X86_LOCAL_APIC
- if (!cpu_has_apic)
+ if (!arch_irq_work_has_interrupt())
return;
apic->send_IPI_self(IRQ_WORK_VECTOR);
--
2.1.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH RT 4/6] xfs: Disable percpu SB on PREEMPT_RT_FULL
2015-08-06 22:17 [PATCH RT 0/6] Linux 3.14.48-rt49-rc1 Steven Rostedt
` (2 preceding siblings ...)
2015-08-06 22:17 ` [PATCH RT 3/6] x86-Tell-irq-work-about-self-IPI-support-3.14 Steven Rostedt
@ 2015-08-06 22:17 ` Steven Rostedt
2015-08-06 22:17 ` [PATCH RT 5/6] powerpc/kvm: Disable in-kernel MPIC emulation for PREEMPT_RT_FULL Steven Rostedt
` (2 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: Steven Rostedt @ 2015-08-06 22:17 UTC (permalink / raw)
To: linux-kernel, linux-rt-users
Cc: Thomas Gleixner, Carsten Emde, Sebastian Andrzej Siewior,
John Kacur, Paul Gortmaker, stable-rt, Dave Chinner
[-- Attachment #1: 0004-xfs-Disable-percpu-SB-on-PREEMPT_RT_FULL.patch --]
[-- Type: text/plain, Size: 3367 bytes --]
3.14.48-rt49-rc1 stable review patch.
If anyone has any objections, please let me know.
------------------
From: Steven Rostedt <rostedt@goodmis.org>
Running a test on a large CPU count box with xfs, I hit a live lock
with the following backtraces on several CPUs:
Call Trace:
[<ffffffff812c34f8>] __const_udelay+0x28/0x30
[<ffffffffa033ab9a>] xfs_icsb_lock_cntr+0x2a/0x40 [xfs]
[<ffffffffa033c871>] xfs_icsb_modify_counters+0x71/0x280 [xfs]
[<ffffffffa03413e1>] xfs_trans_reserve+0x171/0x210 [xfs]
[<ffffffffa0378cfd>] xfs_create+0x24d/0x6f0 [xfs]
[<ffffffff8124c8eb>] ? avc_has_perm_flags+0xfb/0x1e0
[<ffffffffa0336eeb>] xfs_vn_mknod+0xbb/0x1e0 [xfs]
[<ffffffffa0337043>] xfs_vn_create+0x13/0x20 [xfs]
[<ffffffff811b0edd>] vfs_create+0xcd/0x130
[<ffffffff811b21ef>] do_last+0xb8f/0x1240
[<ffffffff811b39b2>] path_openat+0xc2/0x490
Looking at the code I see it was stuck at:
STATIC void
xfs_icsb_lock_cntr(
xfs_icsb_cnts_t *icsbp)
{
while (test_and_set_bit(XFS_ICSB_FLAG_LOCK, &icsbp->icsb_flags)) {
ndelay(1000);
}
}
In xfs_icsb_modify_counters() the code is fine. There's a
preempt_disable() called when taking this bit spinlock and a
preempt_enable() after it is released. The issue is that not all
locations are protected by preempt_disable() when PREEMPT_RT is set.
Namely the places that grab all CPU cntr locks.
STATIC void
xfs_icsb_lock_all_counters(
xfs_mount_t *mp)
{
xfs_icsb_cnts_t *cntp;
int i;
for_each_online_cpu(i) {
cntp = (xfs_icsb_cnts_t *)per_cpu_ptr(mp->m_sb_cnts, i);
xfs_icsb_lock_cntr(cntp);
}
}
STATIC void
xfs_icsb_disable_counter()
{
[...]
xfs_icsb_lock_all_counters(mp);
[...]
xfs_icsb_unlock_all_counters(mp);
}
STATIC void
xfs_icsb_balance_counter_locked()
{
[...]
xfs_icsb_disable_counter();
[...]
}
STATIC void
xfs_icsb_balance_counter(
xfs_mount_t *mp,
xfs_sb_field_t fields,
int min_per_cpu)
{
spin_lock(&mp->m_sb_lock);
xfs_icsb_balance_counter_locked(mp, fields, min_per_cpu);
spin_unlock(&mp->m_sb_lock);
}
Now, when PREEMPT_RT is not enabled, that spin_lock() disables
preemption. But for PREEMPT_RT, it does not. Although with my test box I
was not able to produce a task state of all tasks, but I'm assuming that
some task called the xfs_icsb_lock_all_counters() and was preempted by
an RT task and could not finish, causing all callers of that lock to
block indefinitely.
Dave Chinner has stated that the scalability of that code will probably
be negated by PREEMPT_RT, and that it is probably best to just disable
the code in question. Also, this code has been rewritten in newer kernels.
Link: http://lkml.kernel.org/r/20150504004844.GA21261@dastard
Cc: stable-rt@vger.kernel.org
Suggested-by: Dave Chinner <david@fromorbit.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
fs/xfs/xfs_linux.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/xfs/xfs_linux.h b/fs/xfs/xfs_linux.h
index f9bb590acc0e..8483f8cf432a 100644
--- a/fs/xfs/xfs_linux.h
+++ b/fs/xfs/xfs_linux.h
@@ -131,7 +131,7 @@ typedef __uint64_t __psunsigned_t;
/*
* Feature macros (disable/enable)
*/
-#ifdef CONFIG_SMP
+#if defined(CONFIG_SMP) && !defined(CONFIG_PREEMPT_RT_FULL)
#define HAVE_PERCPU_SB /* per cpu superblock counters are a 2.6 feature */
#else
#undef HAVE_PERCPU_SB /* per cpu superblock counters are a 2.6 feature */
--
2.1.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH RT 5/6] powerpc/kvm: Disable in-kernel MPIC emulation for PREEMPT_RT_FULL
2015-08-06 22:17 [PATCH RT 0/6] Linux 3.14.48-rt49-rc1 Steven Rostedt
` (3 preceding siblings ...)
2015-08-06 22:17 ` [PATCH RT 4/6] xfs: Disable percpu SB on PREEMPT_RT_FULL Steven Rostedt
@ 2015-08-06 22:17 ` Steven Rostedt
2015-08-06 22:17 ` [PATCH RT 6/6] Linux 3.14.48-rt49-rc1 Steven Rostedt
2015-08-08 23:10 ` [PATCH RT 0/6] " Paul Gortmaker
6 siblings, 0 replies; 10+ messages in thread
From: Steven Rostedt @ 2015-08-06 22:17 UTC (permalink / raw)
To: linux-kernel, linux-rt-users
Cc: Thomas Gleixner, Carsten Emde, Sebastian Andrzej Siewior,
John Kacur, Paul Gortmaker, stable-rt, Scott Wood,
Bogdan Purcareata
[-- Attachment #1: 0005-powerpc-kvm-Disable-in-kernel-MPIC-emulation-for-PRE.patch --]
[-- Type: text/plain, Size: 1920 bytes --]
3.14.48-rt49-rc1 stable review patch.
If anyone has any objections, please let me know.
------------------
From: Bogdan Purcareata <bogdan.purcareata@freescale.com>
While converting the openpic emulation code to use a raw_spinlock_t enables
guests to run on RT, there's still a performance issue. For interrupts sent in
directed delivery mode with a multiple CPU mask, the emulated openpic will loop
through all of the VCPUs, and for each VCPUs, it call IRQ_check, which will loop
through all the pending interrupts for that VCPU. This is done while holding the
raw_lock, meaning that in all this time the interrupts and preemption are
disabled on the host Linux. A malicious user app can max both these number and
cause a DoS.
This temporary fix is sent for two reasons. First is so that users who want to
use the in-kernel MPIC emulation are aware of the potential latencies, thus
making sure that the hardware MPIC and their usage scenario does not involve
interrupts sent in directed delivery mode, and the number of possible pending
interrupts is kept small. Secondly, this should incentivize the development of a
proper openpic emulation that would be better suited for RT.
Cc: stable-rt@vger.kernel.org
Acked-by: Scott Wood <scottwood@freescale.com>
Signed-off-by: Bogdan Purcareata <bogdan.purcareata@freescale.com>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
arch/powerpc/kvm/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/kvm/Kconfig b/arch/powerpc/kvm/Kconfig
index 141b2027189a..a0258b2b0f72 100644
--- a/arch/powerpc/kvm/Kconfig
+++ b/arch/powerpc/kvm/Kconfig
@@ -172,6 +172,7 @@ config KVM_E500MC
config KVM_MPIC
bool "KVM in-kernel MPIC emulation"
depends on KVM && E500
+ depends on !PREEMPT_RT_FULL
select HAVE_KVM_IRQCHIP
select HAVE_KVM_IRQ_ROUTING
select HAVE_KVM_MSI
--
2.1.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH RT 6/6] Linux 3.14.48-rt49-rc1
2015-08-06 22:17 [PATCH RT 0/6] Linux 3.14.48-rt49-rc1 Steven Rostedt
` (4 preceding siblings ...)
2015-08-06 22:17 ` [PATCH RT 5/6] powerpc/kvm: Disable in-kernel MPIC emulation for PREEMPT_RT_FULL Steven Rostedt
@ 2015-08-06 22:17 ` Steven Rostedt
2015-08-08 23:10 ` [PATCH RT 0/6] " Paul Gortmaker
6 siblings, 0 replies; 10+ messages in thread
From: Steven Rostedt @ 2015-08-06 22:17 UTC (permalink / raw)
To: linux-kernel, linux-rt-users
Cc: Thomas Gleixner, Carsten Emde, Sebastian Andrzej Siewior,
John Kacur, Paul Gortmaker
[-- Attachment #1: 0006-Linux-3.14.48-rt49-rc1.patch --]
[-- Type: text/plain, Size: 414 bytes --]
3.14.48-rt49-rc1 stable review patch.
If anyone has any objections, please let me know.
------------------
From: "Steven Rostedt (Red Hat)" <rostedt@goodmis.org>
---
localversion-rt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/localversion-rt b/localversion-rt
index 24707986c321..623b4c9cb701 100644
--- a/localversion-rt
+++ b/localversion-rt
@@ -1 +1 @@
--rt48
+-rt49-rc1
--
2.1.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH RT 0/6] Linux 3.14.48-rt49-rc1
2015-08-06 22:17 [PATCH RT 0/6] Linux 3.14.48-rt49-rc1 Steven Rostedt
` (5 preceding siblings ...)
2015-08-06 22:17 ` [PATCH RT 6/6] Linux 3.14.48-rt49-rc1 Steven Rostedt
@ 2015-08-08 23:10 ` Paul Gortmaker
2015-08-08 23:23 ` Steven Rostedt
6 siblings, 1 reply; 10+ messages in thread
From: Paul Gortmaker @ 2015-08-08 23:10 UTC (permalink / raw)
To: Steven Rostedt
Cc: linux-kernel, linux-rt-users, Thomas Gleixner, Carsten Emde,
Sebastian Andrzej Siewior, John Kacur
[[PATCH RT 0/6] Linux 3.14.48-rt49-rc1] On 06/08/2015 (Thu 18:17) Steven Rostedt wrote:
>
> Dear RT Folks,
>
> This is the RT stable review cycle of patch 3.14.48-rt49-rc1.
>
> Please scream at me if I messed something up. Please test the patches too.
>
> The -rc release will be uploaded to kernel.org and will be deleted when
> the final release is out. This is just a review release (or release candidate).
>
> The pre-releases will not be pushed to the git repository, only the
> final release is.
>
> If all goes well, this patch will be converted to the next main release
> on 8/10/2015.
>
> Note, these changes appear to make NO_HZ_FULL work as well as 3.18-rt does.
Appears to pass a simple sanity test here as well. Built basically a
defconfig + RT_FULL + NOHZ_FULL + FHANDLE + DEVTMPFS and ran this simple
test "t" -- meant to test 1st NOHZ and then NOHZ_FULL (loaded core).
Bootargs (below) and irqaffine and rcu-affine scripts (also below) are
meant to dump all housekeeping crap onto core zero.
---------------------------------------
root@testbox:/home/paul# cat t
cat /proc/interrupts |grep LOC
sleep 5
cat /proc/interrupts |grep LOC
taskset -c 5 ./eatme &
sleep 5
cat /proc/interrupts |grep LOC
kill %
root@testbox:/home/paul# ./t
LOC: 220787 1635 1614 1597 1579 1563 1543 1529 1512 1492 1414 1392 1375 1360 1342 1327 1307 1290 1277 1260 Local timer interrupts
LOC: 225795 1637 1616 1597 1579 1563 1543 1529 1512 1492 1414 1392 1375 1362 1345 1329 1310 1293 1279 1262 Local timer interrupts
LOC: 230800 1637 1616 1599 1582 1583 1545 1532 1514 1494 1416 1394 1377 1362 1345 1329 1310 1293 1279 1262 Local timer interrupts
root@testbox:/home/paul# jobs
root@testbox:/home/paul# cat /proc/version
Linux version 3.14.48-rt49-rc1-00071-g3fdc6bccf1b7 (paul@yow-dellw-pg2) (gcc version 4.8.2 (Ubuntu 4.8.2-19ubuntu1) ) #1 SMP PREEMPT RT Sat Aug 8 15:08:25 EDT 2015
root@testbox:/home/paul# cat /proc/cmdline
root=/dev/sda2 ro console=ttyS0,115200 isolcpus=1-20 rcu_nocbs=1-20 rcu_nocb_poll nohz_full=1-20 irqaffinity=0 idle=poll tsc=perfect
root@testbox:/home/paul# cat no-rcu
for i in `pgrep rcuo` ; do taskset -c -p 0 $i ; done
root@testbox:/home/paul# cat clear-core
#!/bin/bash
# for all interrupting devices; move them to core zero; assumes that
for i in `cat /proc/interrupts | grep '^ *[0-9]*[0-9]:' |awk {'print $1}'|sed 's/:$//' `; do
# Timer
if [ "$i" = "0" ]; then
continue
fi
# cascade
if [ "$i" = "2" ]; then
continue
fi
echo setting $i to affine for core zero
echo 1 > /proc/irq/$i/smp_affinity
done
root@testbox:/home/paul#
---------------------------------------
So we took 20 IRQs in 5s, or 4/s ; not quite the 1/s minimum, but definitely not
the HZ/s we'd get w/o NOHZ_FULL. Re-running it got consistently 18-20 IRQ / 5s.
I specifically did NOT unplug and replug cores to "clean" them of tasks; the
hotplug code just seems to unstable for that from what I've seen in the past,
and by the looks of the irq counts above, there was no need to either.
The rootfs was basically a ubu 14.10 server install (no X11/gfx) -- not that
it should matter - so long as other tasks weren't running on the nohz cores.
Paul.
--
>
> Enjoy,
>
> -- Steve
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH RT 0/6] Linux 3.14.48-rt49-rc1
2015-08-08 23:10 ` [PATCH RT 0/6] " Paul Gortmaker
@ 2015-08-08 23:23 ` Steven Rostedt
2015-08-09 0:06 ` Paul Gortmaker
0 siblings, 1 reply; 10+ messages in thread
From: Steven Rostedt @ 2015-08-08 23:23 UTC (permalink / raw)
To: Paul Gortmaker
Cc: linux-kernel, linux-rt-users, Thomas Gleixner, Carsten Emde,
Sebastian Andrzej Siewior, John Kacur
On Sat, 8 Aug 2015 19:10:17 -0400
Paul Gortmaker <paul.gortmaker@windriver.com> wrote:
> So we took 20 IRQs in 5s, or 4/s ; not quite the 1/s minimum, but definitely not
> the HZ/s we'd get w/o NOHZ_FULL. Re-running it got consistently 18-20 IRQ / 5s.
OK, so NO_HZ_FULL still isn't great on -rt, but this shows that it
keeps disturbances much lower than without it.
Thanks for the report!
-- Steve
>
> I specifically did NOT unplug and replug cores to "clean" them of tasks; the
> hotplug code just seems to unstable for that from what I've seen in the past,
> and by the looks of the irq counts above, there was no need to either.
>
> The rootfs was basically a ubu 14.10 server install (no X11/gfx) -- not that
> it should matter - so long as other tasks weren't running on the nohz cores.
>
> Paul.
> --
>
> >
> > Enjoy,
> >
> > -- Steve
> >
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH RT 0/6] Linux 3.14.48-rt49-rc1
2015-08-08 23:23 ` Steven Rostedt
@ 2015-08-09 0:06 ` Paul Gortmaker
0 siblings, 0 replies; 10+ messages in thread
From: Paul Gortmaker @ 2015-08-09 0:06 UTC (permalink / raw)
To: Steven Rostedt
Cc: linux-kernel, linux-rt-users, Thomas Gleixner, Carsten Emde,
Sebastian Andrzej Siewior, John Kacur
[Re: [PATCH RT 0/6] Linux 3.14.48-rt49-rc1] On 08/08/2015 (Sat 19:23) Steven Rostedt wrote:
> On Sat, 8 Aug 2015 19:10:17 -0400
> Paul Gortmaker <paul.gortmaker@windriver.com> wrote:
>
>
> > So we took 20 IRQs in 5s, or 4/s ; not quite the 1/s minimum, but definitely not
> > the HZ/s we'd get w/o NOHZ_FULL. Re-running it got consistently 18-20 IRQ / 5s.
>
> OK, so NO_HZ_FULL still isn't great on -rt, but this shows that it
> keeps disturbances much lower than without it.
Here is several runs on vanilla ("make oldconfig" of the -rt .config)
and all else (bootargs, isolation, rcu offload) the same:
--------------------------------------------------
root@testbox:/home/paul# ./t
LOC: 86341 740 724 708 694 679 663 649 633 619 545 526 512 494 481 463 448 434 420 404 Local timer interrupts
LOC: 91349 742 727 708 694 679 663 649 633 619 545 526 512 496 483 465 450 436 423 406 Local timer interrupts
LOC: 96353 742 727 710 697 709 665 651 635 622 547 528 514 496 483 465 450 436 423 406 Local timer interrupts
root@testbox:/home/paul# ./t
LOC: 106188 744 729 712 699 711 667 653 638 624 549 530 514 498 485 467 452 438 425 408 Local timer interrupts
LOC: 111194 746 729 712 699 711 667 653 638 624 549 530 516 500 487 469 454 440 427 410 Local timer interrupts
LOC: 116199 746 731 714 701 729 669 655 640 626 551 532 516 500 487 469 454 440 427 410 Local timer interrupts
root@testbox:/home/paul# ./t
LOC: 122860 748 733 716 703 731 669 655 640 626 551 532 518 502 489 471 456 442 429 412 Local timer interrupts
LOC: 127866 748 733 716 703 731 671 657 642 628 553 534 520 504 492 473 456 442 429 412 Local timer interrupts
LOC: 132872 750 735 718 706 748 671 657 642 628 553 534 520 504 492 473 458 444 431 415 Local timer interrupts
root@testbox:/home/paul# cat /proc/version
Linux version 3.14.48 (paul@yow-dellw-pg2) (gcc version 4.8.2 (Ubuntu 4.8.2-19ubuntu1) ) #2 SMP PREEMPT Sat Aug 8 19:52:12 EDT 2015
root@testbox:/home/paul#
--------------------------------------------------
So 30, 18, and 17 per 5s interval. I'd say that is statisitcally close
enough to -rt on this simple test to call -rt on par with vanilla.
Things might show a difference with more complicated tests, more cores
doing real work etc etc. -- this really is just a simple sanity test
though... but at least it is a test that we now can pass!
Paul.
--
>
> Thanks for the report!
>
> -- Steve
>
> >
> > I specifically did NOT unplug and replug cores to "clean" them of tasks; the
> > hotplug code just seems to unstable for that from what I've seen in the past,
> > and by the looks of the irq counts above, there was no need to either.
> >
> > The rootfs was basically a ubu 14.10 server install (no X11/gfx) -- not that
> > it should matter - so long as other tasks weren't running on the nohz cores.
> >
> > Paul.
> > --
> >
> > >
> > > Enjoy,
> > >
> > > -- Steve
> > >
>
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2015-08-09 0:07 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-08-06 22:17 [PATCH RT 0/6] Linux 3.14.48-rt49-rc1 Steven Rostedt
2015-08-06 22:17 ` [PATCH RT 1/6] Revert "slub: delay ctor until the object is requested" Steven Rostedt
2015-08-06 22:17 ` [PATCH RT 2/6] mm/slub: move slab initialization into irq enabled region Steven Rostedt
2015-08-06 22:17 ` [PATCH RT 3/6] x86-Tell-irq-work-about-self-IPI-support-3.14 Steven Rostedt
2015-08-06 22:17 ` [PATCH RT 4/6] xfs: Disable percpu SB on PREEMPT_RT_FULL Steven Rostedt
2015-08-06 22:17 ` [PATCH RT 5/6] powerpc/kvm: Disable in-kernel MPIC emulation for PREEMPT_RT_FULL Steven Rostedt
2015-08-06 22:17 ` [PATCH RT 6/6] Linux 3.14.48-rt49-rc1 Steven Rostedt
2015-08-08 23:10 ` [PATCH RT 0/6] " Paul Gortmaker
2015-08-08 23:23 ` Steven Rostedt
2015-08-09 0:06 ` Paul Gortmaker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).