linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH xen-tip] xen/PMU: xen_amd_read_pmc() can be static
  2015-08-11 12:08 [xen-tip:linux-next 21/23] arch/x86/xen/pmu.c:211:20: sparse: symbol 'xen_amd_read_pmc' was not declared. Should it be static? kbuild test robot
@ 2015-08-11 12:08 ` kbuild test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kbuild test robot @ 2015-08-11 12:08 UTC (permalink / raw)
  To: Boris Ostrovsky
  Cc: kbuild-all, David Vrabel, Konrad Rzeszutek Wilk, Thomas Gleixner,
	Ingo Molnar, H. Peter Anvin, x86, xen-devel, linux-kernel


Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 pmu.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/xen/pmu.c b/arch/x86/xen/pmu.c
index cbd68dd..2b81722 100644
--- a/arch/x86/xen/pmu.c
+++ b/arch/x86/xen/pmu.c
@@ -208,7 +208,7 @@ bool pmu_msr_write(unsigned int msr, uint32_t low, uint32_t high, int *err)
 	return false;
 }
 
-unsigned long long xen_amd_read_pmc(int counter)
+static unsigned long long xen_amd_read_pmc(int counter)
 {
 	uint32_t msr;
 	int err;
@@ -217,7 +217,7 @@ unsigned long long xen_amd_read_pmc(int counter)
 	return native_read_msr_safe(msr, &err);
 }
 
-unsigned long long xen_intel_read_pmc(int counter)
+static unsigned long long xen_intel_read_pmc(int counter)
 {
 	int err;
 	uint32_t msr;

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [xen-tip:linux-next 21/23] arch/x86/xen/pmu.c:211:20: sparse: symbol 'xen_amd_read_pmc' was not declared. Should it be static?
@ 2015-08-11 12:08 kbuild test robot
  2015-08-11 12:08 ` [PATCH xen-tip] xen/PMU: xen_amd_read_pmc() can be static kbuild test robot
  0 siblings, 1 reply; 2+ messages in thread
From: kbuild test robot @ 2015-08-11 12:08 UTC (permalink / raw)
  To: Boris Ostrovsky
  Cc: kbuild-all, David Vrabel, Konrad Rzeszutek Wilk, Thomas Gleixner,
	Ingo Molnar, H. Peter Anvin, x86, xen-devel, linux-kernel

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip linux-next
head:   0d26d72cab825a0227c8d8e0e42161125b3116fd
commit: 80ef65bb2362fd9eedcb4ec1d41d8a6d0b99dfbb [21/23] xen/PMU: Intercept PMU-related MSR and APIC accesses
reproduce:
  # apt-get install sparse
  git checkout 80ef65bb2362fd9eedcb4ec1d41d8a6d0b99dfbb
  make ARCH=x86_64 allmodconfig
  make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

   arch/x86/xen/pmu.c:18:1: sparse: symbol '__pcpu_scope_xenpmu_shared' was not declared. Should it be static?
>> arch/x86/xen/pmu.c:211:20: sparse: symbol 'xen_amd_read_pmc' was not declared. Should it be static?
>> arch/x86/xen/pmu.c:220:20: sparse: symbol 'xen_intel_read_pmc' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-08-11 12:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-08-11 12:08 [xen-tip:linux-next 21/23] arch/x86/xen/pmu.c:211:20: sparse: symbol 'xen_amd_read_pmc' was not declared. Should it be static? kbuild test robot
2015-08-11 12:08 ` [PATCH xen-tip] xen/PMU: xen_amd_read_pmc() can be static kbuild test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).