* [PATCH] ath9k_htc: drv_init: match wait_for_completion_timeout return type
@ 2015-05-14 16:25 Nicholas Mc Guire
2015-08-13 12:26 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Nicholas Mc Guire @ 2015-05-14 16:25 UTC (permalink / raw)
To: QCA ath9k Development
Cc: Kalle Valo, linux-wireless, ath9k-devel, netdev, linux-kernel,
Nicholas Mc Guire
Return type of wait_for_completion_timeout is unsigned long not int.
As time_left is exclusively used for wait_for_completion_timeout here its
type is simply changed to unsigned long.
API conformance testing for completions with coccinelle spatches are being
used to locate API usage inconsistencies:
./drivers/net/wireless/ath/ath9k/htc_drv_init.c:81
int return assigned to unsigned long
Patch was compile tested with x86_64_defconfig + CONFIG_ATH_CARDS=m,
CONFIG_ATH9K_HTC=m
Patch is against 4.1-rc3 (localversion-next is -next-20150514)
Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
---
drivers/net/wireless/ath/ath9k/htc_drv_init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_init.c b/drivers/net/wireless/ath/ath9k/htc_drv_init.c
index 7468562..6c001b8 100644
--- a/drivers/net/wireless/ath/ath9k/htc_drv_init.c
+++ b/drivers/net/wireless/ath/ath9k/htc_drv_init.c
@@ -74,7 +74,7 @@ static struct ath_ps_ops ath9k_htc_ps_ops = {
static int ath9k_htc_wait_for_target(struct ath9k_htc_priv *priv)
{
- int time_left;
+ unsigned long time_left;
if (atomic_read(&priv->htc->tgt_ready) > 0) {
atomic_dec(&priv->htc->tgt_ready);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: ath9k_htc: drv_init: match wait_for_completion_timeout return type
2015-05-14 16:25 [PATCH] ath9k_htc: drv_init: match wait_for_completion_timeout return type Nicholas Mc Guire
@ 2015-08-13 12:26 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2015-08-13 12:26 UTC (permalink / raw)
To: Nicholas Mc Guire
Cc: QCA ath9k Development, linux-wireless, ath9k-devel, netdev,
linux-kernel, Nicholas Mc Guire
> Return type of wait_for_completion_timeout is unsigned long not int.
> As time_left is exclusively used for wait_for_completion_timeout here its
> type is simply changed to unsigned long.
>
> API conformance testing for completions with coccinelle spatches are being
> used to locate API usage inconsistencies:
> ./drivers/net/wireless/ath/ath9k/htc_drv_init.c:81
> int return assigned to unsigned long
>
> Patch was compile tested with x86_64_defconfig + CONFIG_ATH_CARDS=m,
> CONFIG_ATH9K_HTC=m
>
> Patch is against 4.1-rc3 (localversion-next is -next-20150514)
>
> Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
Thanks, applied to wireless-drivers-next.git.
Kalle Valo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-08-13 12:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-14 16:25 [PATCH] ath9k_htc: drv_init: match wait_for_completion_timeout return type Nicholas Mc Guire
2015-08-13 12:26 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).