* [PATCH] drm: panel: simple: add QiaoDian qd43003c0-40
@ 2015-07-31 22:44 Alexandre Belloni
2015-08-17 10:09 ` Thierry Reding
0 siblings, 1 reply; 4+ messages in thread
From: Alexandre Belloni @ 2015-07-31 22:44 UTC (permalink / raw)
To: Thierry Reding
Cc: David Airlie, dri-devel, linux-arm-kernel, Boris Brezillon,
Nicolas Ferre, linux-kernel, Josh Wu, Alexandre Belloni
From: Josh Wu <josh.wu@atmel.com>
The QiaoDian Xianshi QD43003C0-40 is a 4"3 TFT LCD panel.
Timings from the OTA5180A document, ver 0.9, section
10.1.1:
http://www.orientdisplay.com/pdf/OTA5180A.pdf
Signed-off-by: Josh Wu <josh.wu@atmel.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
.../devicetree/bindings/panel/qd,qd43003c0-40.txt | 7 ++++++
drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++
2 files changed, 33 insertions(+)
create mode 100644 Documentation/devicetree/bindings/panel/qd,qd43003c0-40.txt
diff --git a/Documentation/devicetree/bindings/panel/qd,qd43003c0-40.txt b/Documentation/devicetree/bindings/panel/qd,qd43003c0-40.txt
new file mode 100644
index 000000000000..900bc6ebeaff
--- /dev/null
+++ b/Documentation/devicetree/bindings/panel/qd,qd43003c0-40.txt
@@ -0,0 +1,7 @@
+QiaoDian XianShi Corporation 4"3 TFT LCD panel
+
+Required properties:
+- compatible: should be "qd,qd43003c0-40"
+
+This binding is compatible with the simple-panel binding, which is specified
+in simple-panel.txt in this directory.
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index f94201b6e882..e688fa545ae3 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -967,6 +967,29 @@ static const struct panel_desc ortustech_com43h4m85ulc = {
.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
};
+static const struct drm_display_mode qd43003c0_40_mode = {
+ .clock = 9000,
+ .hdisplay = 480,
+ .hsync_start = 480 + 8,
+ .hsync_end = 480 + 8 + 4,
+ .htotal = 480 + 8 + 4 + 39,
+ .vdisplay = 272,
+ .vsync_start = 272 + 4,
+ .vsync_end = 272 + 4 + 10,
+ .vtotal = 272 + 4 + 10 + 2,
+ .vrefresh = 60,
+};
+
+static const struct panel_desc qd43003c0_40 = {
+ .modes = &qd43003c0_40_mode,
+ .num_modes = 1,
+ .size = {
+ .width = 95,
+ .height = 53,
+ },
+ .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
+};
+
static const struct drm_display_mode samsung_ltn101nt05_mode = {
.clock = 54030,
.hdisplay = 1024,
@@ -1116,6 +1139,9 @@ static const struct of_device_id platform_of_match[] = {
.compatible = "ortustech,com43h4m85ulc",
.data = &ortustech_com43h4m85ulc,
}, {
+ .compatible = "qd,qd43003c0-40",
+ .data = &qd43003c0_40,
+ }, {
.compatible = "samsung,ltn101nt05",
.data = &samsung_ltn101nt05,
}, {
--
2.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm: panel: simple: add QiaoDian qd43003c0-40
2015-07-31 22:44 [PATCH] drm: panel: simple: add QiaoDian qd43003c0-40 Alexandre Belloni
@ 2015-08-17 10:09 ` Thierry Reding
2015-08-17 10:57 ` Alexandre Belloni
0 siblings, 1 reply; 4+ messages in thread
From: Thierry Reding @ 2015-08-17 10:09 UTC (permalink / raw)
To: Alexandre Belloni
Cc: David Airlie, dri-devel, linux-arm-kernel, Boris Brezillon,
Nicolas Ferre, linux-kernel, Josh Wu
[-- Attachment #1: Type: text/plain, Size: 2777 bytes --]
On Sat, Aug 01, 2015 at 12:44:31AM +0200, Alexandre Belloni wrote:
> From: Josh Wu <josh.wu@atmel.com>
>
> The QiaoDian Xianshi QD43003C0-40 is a 4"3 TFT LCD panel.
>
> Timings from the OTA5180A document, ver 0.9, section
> 10.1.1:
> http://www.orientdisplay.com/pdf/OTA5180A.pdf
>
> Signed-off-by: Josh Wu <josh.wu@atmel.com>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
> .../devicetree/bindings/panel/qd,qd43003c0-40.txt | 7 ++++++
> drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++
> 2 files changed, 33 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/panel/qd,qd43003c0-40.txt
You didn't run this through scripts/get_maintainer.pl, did you? It would
also help to use the standard prefix ("drm/panel: ") because I end up
filtering for that occasionally in case somebody didn't Cc me on panel
patches.
I only came across this by accident, and it's going to miss 4.3 now.
Also two comments below...
> diff --git a/Documentation/devicetree/bindings/panel/qd,qd43003c0-40.txt b/Documentation/devicetree/bindings/panel/qd,qd43003c0-40.txt
> new file mode 100644
> index 000000000000..900bc6ebeaff
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/panel/qd,qd43003c0-40.txt
> @@ -0,0 +1,7 @@
> +QiaoDian XianShi Corporation 4"3 TFT LCD panel
> +
> +Required properties:
> +- compatible: should be "qd,qd43003c0-40"
> +
> +This binding is compatible with the simple-panel binding, which is specified
> +in simple-panel.txt in this directory.
I don't see a vendor prefix for QiaoDian XianShi Corporation in
Documentation/devicetree/bindings/vendor-prefixes.txt.
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index f94201b6e882..e688fa545ae3 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -967,6 +967,29 @@ static const struct panel_desc ortustech_com43h4m85ulc = {
> .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
> };
>
> +static const struct drm_display_mode qd43003c0_40_mode = {
> + .clock = 9000,
> + .hdisplay = 480,
> + .hsync_start = 480 + 8,
> + .hsync_end = 480 + 8 + 4,
> + .htotal = 480 + 8 + 4 + 39,
> + .vdisplay = 272,
> + .vsync_start = 272 + 4,
> + .vsync_end = 272 + 4 + 10,
> + .vtotal = 272 + 4 + 10 + 2,
> + .vrefresh = 60,
> +};
> +
> +static const struct panel_desc qd43003c0_40 = {
> + .modes = &qd43003c0_40_mode,
> + .num_modes = 1,
> + .size = {
> + .width = 95,
> + .height = 53,
> + },
> + .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
> +};
Can you also add .bpc = 8 above so that drivers that don't support the
.bus_format can still support this panel?
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm: panel: simple: add QiaoDian qd43003c0-40
2015-08-17 10:09 ` Thierry Reding
@ 2015-08-17 10:57 ` Alexandre Belloni
2015-08-17 12:11 ` Thierry Reding
0 siblings, 1 reply; 4+ messages in thread
From: Alexandre Belloni @ 2015-08-17 10:57 UTC (permalink / raw)
To: Thierry Reding
Cc: David Airlie, dri-devel, linux-arm-kernel, Boris Brezillon,
Nicolas Ferre, linux-kernel, Josh Wu
On 17/08/2015 at 12:09:14 +0200, Thierry Reding wrote :
> On Sat, Aug 01, 2015 at 12:44:31AM +0200, Alexandre Belloni wrote:
> > From: Josh Wu <josh.wu@atmel.com>
> >
> > The QiaoDian Xianshi QD43003C0-40 is a 4"3 TFT LCD panel.
> >
> > Timings from the OTA5180A document, ver 0.9, section
> > 10.1.1:
> > http://www.orientdisplay.com/pdf/OTA5180A.pdf
> >
> > Signed-off-by: Josh Wu <josh.wu@atmel.com>
> > Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> > ---
> > .../devicetree/bindings/panel/qd,qd43003c0-40.txt | 7 ++++++
> > drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++
> > 2 files changed, 33 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/panel/qd,qd43003c0-40.txt
>
> You didn't run this through scripts/get_maintainer.pl, did you? It would
> also help to use the standard prefix ("drm/panel: ") because I end up
> filtering for that occasionally in case somebody didn't Cc me on panel
> patches.
>
I'm pretty sure I did as you were the only one in the To: field.
Maybe you want to check your spam filter.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm: panel: simple: add QiaoDian qd43003c0-40
2015-08-17 10:57 ` Alexandre Belloni
@ 2015-08-17 12:11 ` Thierry Reding
0 siblings, 0 replies; 4+ messages in thread
From: Thierry Reding @ 2015-08-17 12:11 UTC (permalink / raw)
To: Alexandre Belloni
Cc: David Airlie, dri-devel, linux-arm-kernel, Boris Brezillon,
Nicolas Ferre, linux-kernel, Josh Wu
[-- Attachment #1: Type: text/plain, Size: 1367 bytes --]
On Mon, Aug 17, 2015 at 12:57:24PM +0200, Alexandre Belloni wrote:
> On 17/08/2015 at 12:09:14 +0200, Thierry Reding wrote :
> > On Sat, Aug 01, 2015 at 12:44:31AM +0200, Alexandre Belloni wrote:
> > > From: Josh Wu <josh.wu@atmel.com>
> > >
> > > The QiaoDian Xianshi QD43003C0-40 is a 4"3 TFT LCD panel.
> > >
> > > Timings from the OTA5180A document, ver 0.9, section
> > > 10.1.1:
> > > http://www.orientdisplay.com/pdf/OTA5180A.pdf
> > >
> > > Signed-off-by: Josh Wu <josh.wu@atmel.com>
> > > Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> > > ---
> > > .../devicetree/bindings/panel/qd,qd43003c0-40.txt | 7 ++++++
> > > drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++
> > > 2 files changed, 33 insertions(+)
> > > create mode 100644 Documentation/devicetree/bindings/panel/qd,qd43003c0-40.txt
> >
> > You didn't run this through scripts/get_maintainer.pl, did you? It would
> > also help to use the standard prefix ("drm/panel: ") because I end up
> > filtering for that occasionally in case somebody didn't Cc me on panel
> > patches.
> >
>
> I'm pretty sure I did as you were the only one in the To: field.
> Maybe you want to check your spam filter.
Looking again, I see that you did indeed. Not sure what I was looking at
before. I apologize.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-08-17 12:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-31 22:44 [PATCH] drm: panel: simple: add QiaoDian qd43003c0-40 Alexandre Belloni
2015-08-17 10:09 ` Thierry Reding
2015-08-17 10:57 ` Alexandre Belloni
2015-08-17 12:11 ` Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).