* [PATCH] mtd: denali: Use module_pci_driver()
@ 2015-07-08 5:54 Rajat Jain
2015-08-19 0:29 ` Brian Norris
0 siblings, 1 reply; 2+ messages in thread
From: Rajat Jain @ 2015-07-08 5:54 UTC (permalink / raw)
To: David Woodhouse, Brian Norris, linux-mtd
Cc: linux-kernel, Rajat Jain, Rajat Jain
Use module_pci_driver, since init and exit functions only register
and unregister the pci driver, respectively.
Signed-off-by: Rajat Jain <rajatja@google.com>
Signed-off-by: Rajat Jain <rajatxjain@gmail.com>
---
drivers/mtd/nand/denali_pci.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/mtd/nand/denali_pci.c b/drivers/mtd/nand/denali_pci.c
index 6e2f387..29e5d0c 100644
--- a/drivers/mtd/nand/denali_pci.c
+++ b/drivers/mtd/nand/denali_pci.c
@@ -129,14 +129,4 @@ static struct pci_driver denali_pci_driver = {
.remove = denali_pci_remove,
};
-static int denali_init_pci(void)
-{
- return pci_register_driver(&denali_pci_driver);
-}
-module_init(denali_init_pci);
-
-static void denali_exit_pci(void)
-{
- pci_unregister_driver(&denali_pci_driver);
-}
-module_exit(denali_exit_pci);
+module_pci_driver(denali_pci_driver);
--
2.4.3.573.g4eafbef
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mtd: denali: Use module_pci_driver()
2015-07-08 5:54 [PATCH] mtd: denali: Use module_pci_driver() Rajat Jain
@ 2015-08-19 0:29 ` Brian Norris
0 siblings, 0 replies; 2+ messages in thread
From: Brian Norris @ 2015-08-19 0:29 UTC (permalink / raw)
To: Rajat Jain; +Cc: David Woodhouse, linux-mtd, linux-kernel, Rajat Jain
On Tue, Jul 07, 2015 at 10:54:03PM -0700, Rajat Jain wrote:
> Use module_pci_driver, since init and exit functions only register
> and unregister the pci driver, respectively.
>
> Signed-off-by: Rajat Jain <rajatja@google.com>
> Signed-off-by: Rajat Jain <rajatxjain@gmail.com>
I pushed an identical patch to l2-mtd.git from another author. Didn't
notice yours until now. Thanks anyway!
Brian
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-08-19 0:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-08 5:54 [PATCH] mtd: denali: Use module_pci_driver() Rajat Jain
2015-08-19 0:29 ` Brian Norris
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).