linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] of/irq: export of_get_irq_byname()
@ 2015-08-26  0:04 Dmitry Torokhov
  2015-08-26  0:24 ` Stephen Rothwell
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Dmitry Torokhov @ 2015-08-26  0:04 UTC (permalink / raw)
  To: Grant Likely
  Cc: Rob Herring, Laurent Pinchart, Jeremy Linton, Geert Uytterhoeven,
	Wolfram Sang, Stephen Rothwell, Vignesh R, devicetree,
	linux-kernel

Similarly to of_get_irq(), let's export of_irq_get_byname(), so if a bus core
can be compiled as a module (such as I2C) it can have access to the symbol.

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
 drivers/of/irq.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/of/irq.c b/drivers/of/irq.c
index 7ef837e..1a7911d 100644
--- a/drivers/of/irq.c
+++ b/drivers/of/irq.c
@@ -446,6 +446,7 @@ int of_irq_get_byname(struct device_node *dev, const char *name)
 
 	return of_irq_get(dev, index);
 }
+EXPORT_SYMBOL_GPL(of_irq_get_byname);
 
 /**
  * of_irq_count - Count the number of IRQs a node uses
-- 
2.5.0.457.gab17608


-- 
Dmitry

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] of/irq: export of_get_irq_byname()
  2015-08-26  0:04 [PATCH] of/irq: export of_get_irq_byname() Dmitry Torokhov
@ 2015-08-26  0:24 ` Stephen Rothwell
  2015-08-26  7:40   ` Wolfram Sang
  2015-08-26 13:16 ` Rob Herring
  2015-08-26 16:36 ` Wolfram Sang
  2 siblings, 1 reply; 5+ messages in thread
From: Stephen Rothwell @ 2015-08-26  0:24 UTC (permalink / raw)
  To: Dmitry Torokhov
  Cc: Grant Likely, Rob Herring, Laurent Pinchart, Jeremy Linton,
	Geert Uytterhoeven, Wolfram Sang, Vignesh R, devicetree,
	linux-kernel

Hi Dmitry,

On Tue, 25 Aug 2015 17:04:02 -0700 Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
>
> Similarly to of_get_irq(), let's export of_irq_get_byname(), so if a bus core
> can be compiled as a module (such as I2C) it can have access to the symbol.
> 
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

I applied that to linux-next today.  Pelase get it applied to the i2c
tree (with appropriate acks).

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] of/irq: export of_get_irq_byname()
  2015-08-26  0:24 ` Stephen Rothwell
@ 2015-08-26  7:40   ` Wolfram Sang
  0 siblings, 0 replies; 5+ messages in thread
From: Wolfram Sang @ 2015-08-26  7:40 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Dmitry Torokhov, Grant Likely, Rob Herring, Laurent Pinchart,
	Jeremy Linton, Geert Uytterhoeven, Vignesh R, devicetree,
	linux-kernel

[-- Attachment #1: Type: text/plain, Size: 694 bytes --]

On Wed, Aug 26, 2015 at 10:24:25AM +1000, Stephen Rothwell wrote:
> Hi Dmitry,
> 
> On Tue, 25 Aug 2015 17:04:02 -0700 Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
> >
> > Similarly to of_get_irq(), let's export of_irq_get_byname(), so if a bus core
> > can be compiled as a module (such as I2C) it can have access to the symbol.
> > 
> > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > Reported-by: kbuild test robot <fengguang.wu@intel.com>
> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> 
> I applied that to linux-next today.  Pelase get it applied to the i2c
> tree (with appropriate acks).

Waiting for Rob's Ack, then I'll pick it up...


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] of/irq: export of_get_irq_byname()
  2015-08-26  0:04 [PATCH] of/irq: export of_get_irq_byname() Dmitry Torokhov
  2015-08-26  0:24 ` Stephen Rothwell
@ 2015-08-26 13:16 ` Rob Herring
  2015-08-26 16:36 ` Wolfram Sang
  2 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2015-08-26 13:16 UTC (permalink / raw)
  To: Dmitry Torokhov
  Cc: Grant Likely, Rob Herring, Laurent Pinchart, Jeremy Linton,
	Geert Uytterhoeven, Wolfram Sang, Stephen Rothwell, Vignesh R,
	devicetree, linux-kernel

On Tue, Aug 25, 2015 at 7:04 PM, Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
> Similarly to of_get_irq(), let's export of_irq_get_byname(), so if a bus core
> can be compiled as a module (such as I2C) it can have access to the symbol.
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

Acked-by: Rob Herring <robh@kernel.org>

> ---
>  drivers/of/irq.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/of/irq.c b/drivers/of/irq.c
> index 7ef837e..1a7911d 100644
> --- a/drivers/of/irq.c
> +++ b/drivers/of/irq.c
> @@ -446,6 +446,7 @@ int of_irq_get_byname(struct device_node *dev, const char *name)
>
>         return of_irq_get(dev, index);
>  }
> +EXPORT_SYMBOL_GPL(of_irq_get_byname);
>
>  /**
>   * of_irq_count - Count the number of IRQs a node uses
> --
> 2.5.0.457.gab17608
>
>
> --
> Dmitry

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] of/irq: export of_get_irq_byname()
  2015-08-26  0:04 [PATCH] of/irq: export of_get_irq_byname() Dmitry Torokhov
  2015-08-26  0:24 ` Stephen Rothwell
  2015-08-26 13:16 ` Rob Herring
@ 2015-08-26 16:36 ` Wolfram Sang
  2 siblings, 0 replies; 5+ messages in thread
From: Wolfram Sang @ 2015-08-26 16:36 UTC (permalink / raw)
  To: Dmitry Torokhov
  Cc: Grant Likely, Rob Herring, Laurent Pinchart, Jeremy Linton,
	Geert Uytterhoeven, Stephen Rothwell, Vignesh R, devicetree,
	linux-kernel

[-- Attachment #1: Type: text/plain, Size: 441 bytes --]

On Tue, Aug 25, 2015 at 05:04:02PM -0700, Dmitry Torokhov wrote:
> Similarly to of_get_irq(), let's export of_irq_get_byname(), so if a bus core
> can be compiled as a module (such as I2C) it can have access to the symbol.
> 
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

Applied to for-next, thanks!


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2015-08-26 16:37 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-08-26  0:04 [PATCH] of/irq: export of_get_irq_byname() Dmitry Torokhov
2015-08-26  0:24 ` Stephen Rothwell
2015-08-26  7:40   ` Wolfram Sang
2015-08-26 13:16 ` Rob Herring
2015-08-26 16:36 ` Wolfram Sang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).