From: Ingo Molnar <mingo@kernel.org>
To: Jason Baron <jbaron@akamai.com>
Cc: Jonathan Corbet <corbet@lwn.net>, Ingo Molnar <mingo@elte.hu>,
LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] locking/static_keys: fix a silly typo
Date: Sun, 13 Sep 2015 10:15:33 +0200 [thread overview]
Message-ID: <20150913081532.GA8488@gmail.com> (raw)
In-Reply-To: <55EF0730.3080906@akamai.com>
* Jason Baron <jbaron@akamai.com> wrote:
> On 09/07/2015 03:18 PM, Jonathan Corbet wrote:
> > 412758cb2670 (jump label, locking/static_keys: Update docs) introduced a
> > typo that might as well get fixed.
> >
> > Signed-off-by: Jonathan Corbet <corbet@lwn.net>
> > ---
> > Documentation/static-keys.txt | 2 +-
> > include/linux/jump_label.h | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/static-keys.txt b/Documentation/static-keys.txt
> > index f4cb0b2..ec91158 100644
> > --- a/Documentation/static-keys.txt
> > +++ b/Documentation/static-keys.txt
> > @@ -16,7 +16,7 @@ The updated API replacements are:
> > DEFINE_STATIC_KEY_TRUE(key);
> > DEFINE_STATIC_KEY_FALSE(key);
> > static_key_likely()
> > -statick_key_unlikely()
> > +static_key_unlikely()
> >
> > 0) Abstract
> >
> > diff --git a/include/linux/jump_label.h b/include/linux/jump_label.h
> > index 7f653e8..0684bd3 100644
> > --- a/include/linux/jump_label.h
> > +++ b/include/linux/jump_label.h
> > @@ -22,7 +22,7 @@
> > * DEFINE_STATIC_KEY_TRUE(key);
> > * DEFINE_STATIC_KEY_FALSE(key);
> > * static_key_likely()
> > - * statick_key_unlikely()
> > + * static_key_unlikely()
> > *
> > * Jump labels provide an interface to generate dynamic branches using
> > * self-modifying code. Assuming toolchain and architecture support, if we
> >
>
> Thanks. I actually messed this up further. That's supposed to be,
> 'static_branch_likely()', and 'static_branch_unlikely()'. So:
>
> s/static_key_likely()/static_branch_likely()
>
> and
>
> s/static_key_unlikely()/static_branch_unlikely()
>
> The rest of the doc appears to have it correctly. There are a few more
> typos in there as well:
>
> 1)
>
> s/addtion/addition
>
> 2)
>
> "
> The inc()/dec() interface is meant to be used exclusively from the
> inc()/dec() for a given key.
> "
>
> Was supposed to read:
>
> "
> The inc()/dec() interface is meant to be used exclusively from the
> enable()/disable() interface for a given key.
> "
>
> However, I think we should just delete this sentence. As the API
> inherently doesn't prevent this. The user just may need to be aware to
> properly serialize operations.
Would be nice to turn this into a patch!
Thanks,
Ingo
next prev parent reply other threads:[~2015-09-13 8:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-07 19:18 [PATCH] locking/static_keys: fix a silly typo Jonathan Corbet
2015-09-08 7:03 ` Ingo Molnar
2015-09-08 7:06 ` [tip:locking/urgent] locking/static_keys: Fix " tip-bot for Jonathan Corbet
2015-09-08 16:05 ` [PATCH] locking/static_keys: fix " Jason Baron
2015-09-13 8:15 ` Ingo Molnar [this message]
2015-09-17 1:04 ` Chuck Ebbert
2015-09-17 15:34 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150913081532.GA8488@gmail.com \
--to=mingo@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=corbet@lwn.net \
--cc=jbaron@akamai.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).