[PATCH 0/2] alpha: fix build failure

[PATCH 0/2] alpha: fix build failure

[Sudip Mukherjee]

We were getting build failure on allmodconfig. Mainly two causes
ioremap_uc was not defined and __delay was not exported.

regards
sudip

Sudip Mukherjee (2):
  alpha: io: define ioremap_uc
  alpha: lib: export __delay

 arch/alpha/include/asm/io.h | 4 +++-
 arch/alpha/lib/udelay.c     | 1 +
 2 files changed, 4 insertions(+), 1 deletion(-)

-- 
1.9.1

[PATCH 1/2] alpha: io: define ioremap_uc

[Sudip Mukherjee]

ioremap_uc was not defined and as a result while building with
allmodconfig were getting build error of:
implicit declaration of function 'ioremap_uc'.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
 arch/alpha/include/asm/io.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/alpha/include/asm/io.h b/arch/alpha/include/asm/io.h
index f05bdb4..ff40491 100644
--- a/arch/alpha/include/asm/io.h
+++ b/arch/alpha/include/asm/io.h
@@ -297,7 +297,9 @@ static inline void __iomem * ioremap_nocache(unsigned long offset,
 					     unsigned long size)
 {
 	return ioremap(offset, size);
-} 
+}
+
+#define ioremap_uc ioremap_nocache
 
 static inline void iounmap(volatile void __iomem *addr)
 {
-- 
1.9.1

[PATCH 2/2] alpha: lib: export __delay

[Sudip Mukherjee]

__delay was not exported as a result while building with allmodconfig we
were getting build error of undefined symbol. __delay is being used by:
drivers/net/phy/mdio-octeon.c

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
 arch/alpha/lib/udelay.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/alpha/lib/udelay.c b/arch/alpha/lib/udelay.c
index 69d52aa..f2d81ff 100644
--- a/arch/alpha/lib/udelay.c
+++ b/arch/alpha/lib/udelay.c
@@ -30,6 +30,7 @@ __delay(int loops)
 		"	bgt %0,1b"
 		: "=&r" (tmp), "=r" (loops) : "1"(loops));
 }
+EXPORT_SYMBOL(__delay);
 
 #ifdef CONFIG_SMP
 #define LPJ	 cpu_data[smp_processor_id()].loops_per_jiffy
-- 
1.9.1

Re: [PATCH 0/2] alpha: fix build failure

[Guenter Roeck]

On Mon, Sep 14, 2015 at 05:19:27PM +0530, Sudip Mukherjee wrote:
> We were getting build failure on allmodconfig. Mainly two causes
> ioremap_uc was not defined and __delay was not exported.
> 
I already submitted patches to fix those problems some 6+ weeks ago.
Hope you'll have more luck.

Guenter

> regards
> sudip
> 
> Sudip Mukherjee (2):
>   alpha: io: define ioremap_uc
>   alpha: lib: export __delay
> 
>  arch/alpha/include/asm/io.h | 4 +++-
>  arch/alpha/lib/udelay.c     | 1 +
>  2 files changed, 4 insertions(+), 1 deletion(-)
> 
> -- 
> 1.9.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 
> 

Re: [PATCH 0/2] alpha: fix build failure

[Andrew Morton]

On Mon, 14 Sep 2015 14:22:08 -0700 Guenter Roeck <linux@roeck-us.net> wrote:

> On Mon, Sep 14, 2015 at 05:19:27PM +0530, Sudip Mukherjee wrote:
> > We were getting build failure on allmodconfig. Mainly two causes
> > ioremap_uc was not defined and __delay was not exported.
> > 
> I already submitted patches to fix those problems some 6+ weeks ago.
> Hope you'll have more luck.

I have both of these patches queued for 4.3.  Cc'ing me is a way of
preventing stuff from falling through cracks..

But I didn't tag these patches for -stable backport.  Should I have
done so?  If 4.2 is busted on alpha then I guess "yes".

Re: [PATCH 0/2] alpha: fix build failure

[Guenter Roeck]

On Mon, Sep 14, 2015 at 02:29:55PM -0700, Andrew Morton wrote:
> On Mon, 14 Sep 2015 14:22:08 -0700 Guenter Roeck <linux@roeck-us.net> wrote:
> 
> > On Mon, Sep 14, 2015 at 05:19:27PM +0530, Sudip Mukherjee wrote:
> > > We were getting build failure on allmodconfig. Mainly two causes
> > > ioremap_uc was not defined and __delay was not exported.
> > > 
> > I already submitted patches to fix those problems some 6+ weeks ago.
> > Hope you'll have more luck.
> 
> I have both of these patches queued for 4.3.  Cc'ing me is a way of
> preventing stuff from falling through cracks..
> 
Ok, I'll do that next time.

> But I didn't tag these patches for -stable backport.  Should I have
> done so?  If 4.2 is busted on alpha then I guess "yes".
> 
No, this only affects 4.3-rc1 and -next.

Guenter

Re: [PATCH 0/2] alpha: fix build failure

[Sudip Mukherjee]

On Mon, Sep 14, 2015 at 02:22:08PM -0700, Guenter Roeck wrote:
> On Mon, Sep 14, 2015 at 05:19:27PM +0530, Sudip Mukherjee wrote:
> > We were getting build failure on allmodconfig. Mainly two causes
> > ioremap_uc was not defined and __delay was not exported.
> > 
> I already submitted patches to fix those problems some 6+ weeks ago.
> Hope you'll have more luck.
For my allmodconfig test with next-20150915 alpha, m32r and openrisc
failed. And ofcourse mn10300 is broken since many months now.
Have you already done something with m32r or should I try? If both of us
are trying the same it will be a wastage of time. So asking you.

regards
sudip

Re: [PATCH 0/2] alpha: fix build failure

[Guenter Roeck]

On 09/15/2015 01:21 AM, Sudip Mukherjee wrote:
> On Mon, Sep 14, 2015 at 02:22:08PM -0700, Guenter Roeck wrote:
>> On Mon, Sep 14, 2015 at 05:19:27PM +0530, Sudip Mukherjee wrote:
>>> We were getting build failure on allmodconfig. Mainly two causes
>>> ioremap_uc was not defined and __delay was not exported.
>>>
>> I already submitted patches to fix those problems some 6+ weeks ago.
>> Hope you'll have more luck.
> For my allmodconfig test with next-20150915 alpha, m32r and openrisc
> failed. And ofcourse mn10300 is broken since many months now.
> Have you already done something with m32r or should I try? If both of us
> are trying the same it will be a wastage of time. So asking you.
>

I am not building m32r:allmodconfig or openrisc:allmodconfig.

You can always check http://server.roeck-us.net:8010/builders to see
what is covered by my builds and tests.

Guenter

Re: [PATCH 0/2] alpha: fix build failure

[Sudip Mukherjee]

On Tue, Sep 15, 2015 at 06:28:40AM -0700, Guenter Roeck wrote:
> On 09/15/2015 01:21 AM, Sudip Mukherjee wrote:
> >On Mon, Sep 14, 2015 at 02:22:08PM -0700, Guenter Roeck wrote:
> >>On Mon, Sep 14, 2015 at 05:19:27PM +0530, Sudip Mukherjee wrote:
> 
> I am not building m32r:allmodconfig or openrisc:allmodconfig.
> 
> You can always check http://server.roeck-us.net:8010/builders to see
> what is covered by my builds and tests.
ok, openrisc:defconfig and allnoconfig.

Well, the first error on allmodconfig is:
drivers/vhost/vhost.c: In function 'vhost_vring_ioctl':
drivers/vhost/vhost.c:818:3: error: call to '__compiletime_assert_818' declared with attribute error: BUILD_BUG_ON failed: __alignof__
*vq->avail > VRING_AVAIL_ALIGN_SIZE

Any hint about this one?

regards
sudip

Re: [PATCH 0/2] alpha: fix build failure

[Guenter Roeck]

On 09/15/2015 06:50 AM, Sudip Mukherjee wrote:
> On Tue, Sep 15, 2015 at 06:28:40AM -0700, Guenter Roeck wrote:
>> On 09/15/2015 01:21 AM, Sudip Mukherjee wrote:
>>> On Mon, Sep 14, 2015 at 02:22:08PM -0700, Guenter Roeck wrote:
>>>> On Mon, Sep 14, 2015 at 05:19:27PM +0530, Sudip Mukherjee wrote:
>>
>> I am not building m32r:allmodconfig or openrisc:allmodconfig.
>>
>> You can always check http://server.roeck-us.net:8010/builders to see
>> what is covered by my builds and tests.
> ok, openrisc:defconfig and allnoconfig.
>
> Well, the first error on allmodconfig is:
> drivers/vhost/vhost.c: In function 'vhost_vring_ioctl':
> drivers/vhost/vhost.c:818:3: error: call to '__compiletime_assert_818' declared with attribute error: BUILD_BUG_ON failed: __alignof__
> *vq->avail > VRING_AVAIL_ALIGN_SIZE
>
> Any hint about this one?
>

No idea, sorry. Is that a new problem ?

Guenter

Re: [PATCH 0/2] alpha: fix build failure

[Sudip Mukherjee]

On Tue, Sep 15, 2015 at 07:26:34AM -0700, Guenter Roeck wrote:
> On 09/15/2015 06:50 AM, Sudip Mukherjee wrote:
> >On Tue, Sep 15, 2015 at 06:28:40AM -0700, Guenter Roeck wrote:
> >>On 09/15/2015 01:21 AM, Sudip Mukherjee wrote:
> >>>On Mon, Sep 14, 2015 at 02:22:08PM -0700, Guenter Roeck wrote:
> >>>>On Mon, Sep 14, 2015 at 05:19:27PM +0530, Sudip Mukherjee wrote:
> >>
> >>I am not building m32r:allmodconfig or openrisc:allmodconfig.
> >>
> >>You can always check http://server.roeck-us.net:8010/builders to see
> >>what is covered by my builds and tests.
> >ok, openrisc:defconfig and allnoconfig.
> >
> >Well, the first error on allmodconfig is:
> >drivers/vhost/vhost.c: In function 'vhost_vring_ioctl':
> >drivers/vhost/vhost.c:818:3: error: call to '__compiletime_assert_818' declared with attribute error: BUILD_BUG_ON failed: __alignof__
> >*vq->avail > VRING_AVAIL_ALIGN_SIZE
> >
> >Any hint about this one?
> >
> 
> No idea, sorry. Is that a new problem ?
I think no. Not sure though, as I have started testing these just
recently.

regards
sudip