* [PATCH] PM / AVS: rockchip-io: Fix module autoload for OF platform driver
@ 2015-09-18 16:52 Luis de Bethencourt
2015-10-02 14:08 ` Heiko Stübner
0 siblings, 1 reply; 2+ messages in thread
From: Luis de Bethencourt @ 2015-09-18 16:52 UTC (permalink / raw)
To: linux-kernel
Cc: Kevin Hilman, Nishanth Menon, Heiko Stuebner, linux-pm,
linux-arm-kernel, linux-rockchip
This platform driver has a OF device ID table but the OF module
alias information is not created so module autoloading won't work.
Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
---
Hello,
This patch adds the missing MODULE_DEVICE_TABLE() for OF to export
that information so modules have the correct aliases built-in and
autoloading works correctly.
A longer explanation by Javier Canillas can be found here:
https://lkml.org/lkml/2015/7/30/519
Thanks,
Luis
drivers/power/avs/rockchip-io-domain.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/power/avs/rockchip-io-domain.c b/drivers/power/avs/rockchip-io-domain.c
index 2e30002..8099456 100644
--- a/drivers/power/avs/rockchip-io-domain.c
+++ b/drivers/power/avs/rockchip-io-domain.c
@@ -271,6 +271,7 @@ static const struct of_device_id rockchip_iodomain_match[] = {
},
{ /* sentinel */ },
};
+MODULE_DEVICE_TABLE(of, rockchip_iodomain_match);
static int rockchip_iodomain_probe(struct platform_device *pdev)
{
--
2.4.6
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] PM / AVS: rockchip-io: Fix module autoload for OF platform driver
2015-09-18 16:52 [PATCH] PM / AVS: rockchip-io: Fix module autoload for OF platform driver Luis de Bethencourt
@ 2015-10-02 14:08 ` Heiko Stübner
0 siblings, 0 replies; 2+ messages in thread
From: Heiko Stübner @ 2015-10-02 14:08 UTC (permalink / raw)
To: Luis de Bethencourt
Cc: linux-kernel, Kevin Hilman, Nishanth Menon, linux-pm,
linux-arm-kernel, linux-rockchip
Am Freitag, 18. September 2015, 18:52:58 schrieb Luis de Bethencourt:
> This platform driver has a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.
>
> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
looks obviously correct.
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
depending on how Kevin wants to handle that single patch, you might want to
resent it with Rafael Wysocki in the to-list though
Heiko
> ---
>
> Hello,
>
> This patch adds the missing MODULE_DEVICE_TABLE() for OF to export
> that information so modules have the correct aliases built-in and
> autoloading works correctly.
>
> A longer explanation by Javier Canillas can be found here:
> https://lkml.org/lkml/2015/7/30/519
>
> Thanks,
> Luis
>
> drivers/power/avs/rockchip-io-domain.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/power/avs/rockchip-io-domain.c
> b/drivers/power/avs/rockchip-io-domain.c index 2e30002..8099456 100644
> --- a/drivers/power/avs/rockchip-io-domain.c
> +++ b/drivers/power/avs/rockchip-io-domain.c
> @@ -271,6 +271,7 @@ static const struct of_device_id
> rockchip_iodomain_match[] = { },
> { /* sentinel */ },
> };
> +MODULE_DEVICE_TABLE(of, rockchip_iodomain_match);
>
> static int rockchip_iodomain_probe(struct platform_device *pdev)
> {
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-02 14:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-18 16:52 [PATCH] PM / AVS: rockchip-io: Fix module autoload for OF platform driver Luis de Bethencourt
2015-10-02 14:08 ` Heiko Stübner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).