Re: [PATCH 2/3] usb: gadget: at91_udc: mention proper dependency

From: Felipe Balbi <balbi@ti.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Haavard Skinnemoen <hskinnemoen@gmail.com>,
	Hans-Christian Egtvedt <egtvedt@samfundet.no>,
	Felipe Balbi <balbi@ti.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	<linux-kernel@vger.kernel.org>, <linux-usb@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 2/3] usb: gadget: at91_udc: mention proper dependency
Date: Sun, 20 Sep 2015 11:15:28 -0500	[thread overview]
Message-ID: <20150920161528.GB1447@saruman.tx.rr.com> (raw)
In-Reply-To: <1442682779-20077-3-git-send-email-sudipm.mukherjee@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1382 bytes --]

On Sat, Sep 19, 2015 at 10:42:58PM +0530, Sudip Mukherjee wrote:
> While building allmodconfig on avr32 the build failed with the error:
> "at91_pmc_base" [drivers/usb/gadget/udc/atmel_usba_udc.ko] undefined!
> 
> On checking the code it turned out that if CONFIG_OF is defined then it
> is using at91_pmc_read() which is using at91_pmc_base. And unless
> COMMON_CLK_AT91 is defined we donot have at91_pmc_base. And
> COMMON_CLK_AT91 is available with AT91 architecture.
> Mention the dependency such that this driver builds with avr32 only if
> OF is not enabled.
> 
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
> 
> Tested build with at91_dt_defconfig and allmodconfig of avr32. Build log
> at:
> https://travis-ci.org/sudipm-mukherjee/parport/builds/81168845
> 
>  drivers/usb/gadget/udc/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/gadget/udc/Kconfig b/drivers/usb/gadget/udc/Kconfig
> index 9a3a6b0..cdbff54 100644
> --- a/drivers/usb/gadget/udc/Kconfig
> +++ b/drivers/usb/gadget/udc/Kconfig
> @@ -55,7 +55,7 @@ config USB_LPC32XX
>  
>  config USB_ATMEL_USBA
>  	tristate "Atmel USBA"
> -	depends on AVR32 || ARCH_AT91
> +	depends on ((AVR32 && !OF) || ARCH_AT91)

any chance you can add || COMPILE_TEST here ? I'd like to make
sure this builds on my end too.

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]