From: Lee Jones <lee.jones@linaro.org>
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: "Thierry Reding" <thierry.reding@gmail.com>,
linux-pwm@vger.kernel.org, "Mark Brown" <broonie@kernel.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Jingoo Han" <jingoohan1@gmail.com>,
linux-fbdev@vger.kernel.org, "Bryan Wu" <cooloney@gmail.com>,
"Richard Purdie" <rpurdie@rpsys.net>,
"Jacek Anaszewski" <j.anaszewski@samsung.com>,
linux-leds@vger.kernel.org,
"Maxime Ripard" <maxime.ripard@free-electrons.com>,
linux-sunxi@googlegroups.com, "Heiko Stuebner" <heiko@sntech.de>,
linux-rockchip@lists.infradead.org,
"Jean-Christophe Plagniol-Villard" <plagnioj@jcrosoft.com>,
"Tomi Valkeinen" <tomi.valkeinen@ti.com>,
"Daniel Mack" <daniel@zonque.org>,
"Haojian Zhuang" <haojian.zhuang@gmail.com>,
"Robert Jarzmik" <robert.jarzmik@free.fr>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
"Doug Anderson" <dianders@google.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH v3 04/12] backlight: pwm_bl: remove useless call to pwm_set_period
Date: Tue, 22 Sep 2015 23:12:18 +0100 [thread overview]
Message-ID: <20150922221218.GA9317@x1> (raw)
In-Reply-To: <1442828009-6241-5-git-send-email-boris.brezillon@free-electrons.com>
On Mon, 21 Sep 2015, Boris Brezillon wrote:
> The PWM period will be set when calling pwm_config. Remove this useless
> call to pwm_set_period, which might mess up with the initial PWM state
> once we have added proper support for PWM init state retrieval.
>
> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> ---
> drivers/video/backlight/pwm_bl.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
Acked-by: Lee Jones <lee.jones@linaro.org>
> diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c
> index ae498c1..71944f8 100644
> --- a/drivers/video/backlight/pwm_bl.c
> +++ b/drivers/video/backlight/pwm_bl.c
> @@ -293,12 +293,14 @@ static int pwm_backlight_probe(struct platform_device *pdev)
> * period, parsed from the DT, in the PWM device. For the non-DT case,
> * set the period from platform data if it has not already been set
> * via the PWM lookup table.
> + * FIXME: This assignment should be dropped as soon as all the boards
> + * have moved to the PWM lookup table approach. The same goes for the
> + * pb->period field which should be replaced by
> + * pwm_get_default_period() calls.
> */
> pb->period = pwm_get_default_period(pb->pwm);
> - if (!pb->period && (data->pwm_period_ns > 0)) {
> + if (!pb->period && (data->pwm_period_ns > 0))
> pb->period = data->pwm_period_ns;
> - pwm_set_period(pb->pwm, data->pwm_period_ns);
> - }
>
> pb->lth_brightness = data->lth_brightness * (pb->period / pb->scale);
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2015-09-22 22:12 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-21 9:33 [PATCH v3 00/12] pwm: add support for atomic update Boris Brezillon
2015-09-21 9:33 ` [PATCH v3 01/12] pwm: introduce default period and polarity concepts Boris Brezillon
2015-09-21 18:20 ` Robert Jarzmik
2015-09-22 6:36 ` Jacek Anaszewski
2015-09-22 21:49 ` Lee Jones
2015-11-07 2:35 ` Alexandre Belloni
2015-09-21 9:33 ` [PATCH v3 02/12] pwm: define a new pwm_state struct Boris Brezillon
2015-09-21 9:33 ` [PATCH v3 03/12] pwm: move the enabled/disabled info to " Boris Brezillon
2015-09-21 9:33 ` [PATCH v3 04/12] backlight: pwm_bl: remove useless call to pwm_set_period Boris Brezillon
2015-09-22 22:12 ` Lee Jones [this message]
2015-09-21 9:33 ` [PATCH v3 05/12] pwm: declare a default PWM state Boris Brezillon
2015-09-21 9:33 ` [PATCH v3 06/12] pwm: add the PWM initial state retrieval infra Boris Brezillon
2015-09-21 9:33 ` [PATCH v3 07/12] pwm: add the core infrastructure to allow atomic update Boris Brezillon
2015-09-21 9:33 ` [PATCH v3 08/12] pwm: add information about polarity, duty cycle and period to debugfs Boris Brezillon
2015-09-21 9:33 ` [PATCH v3 09/12] pwm: rockchip: add initial state retrieval Boris Brezillon
2015-09-21 9:33 ` [PATCH v3 10/12] pwm: rockchip: add support for atomic update Boris Brezillon
2015-09-21 9:33 ` [PATCH v3 11/12] regulator: pwm: implement ->enable(), ->disable() and ->is_enabled methods Boris Brezillon
2015-09-21 21:13 ` Mark Brown
2015-09-21 9:33 ` [PATCH v3 12/12] regulator: pwm: properly initialize the ->state field Boris Brezillon
2015-09-21 21:10 ` Mark Brown
2015-09-21 22:30 ` [PATCH v3 00/12] pwm: add support for atomic update Heiko Stübner
2015-10-09 21:02 ` Boris Brezillon
2015-10-10 15:11 ` [PATCH v3 pre-03/12] pwm: rcar: make use of pwm_is_enabled() Boris Brezillon
2015-10-19 10:12 ` [PATCH v3 00/12] pwm: add support for atomic update Heiko Stübner
2015-11-10 17:34 ` Thierry Reding
2015-11-10 18:26 ` Boris Brezillon
2016-01-25 16:28 ` Doug Anderson
2016-01-25 17:08 ` Thierry Reding
2016-01-25 17:55 ` Boris Brezillon
2016-01-25 18:51 ` Doug Anderson
2016-02-03 14:53 ` Thierry Reding
2016-02-03 19:04 ` Doug Anderson
2016-02-04 11:02 ` Mark Brown
2016-02-04 14:01 ` Boris Brezillon
2016-02-23 14:57 ` Thierry Reding
2016-02-22 16:27 ` Doug Anderson
2016-02-22 17:59 ` Thierry Reding
2016-02-22 19:15 ` Doug Anderson
2016-02-22 21:24 ` Mark Brown
2016-02-23 3:03 ` Doug Anderson
2016-02-23 14:38 ` Thierry Reding
2016-02-23 17:35 ` Doug Anderson
2016-02-23 18:14 ` Thierry Reding
2016-02-23 18:42 ` Doug Anderson
2016-02-25 23:14 ` Doug Anderson
2016-03-07 16:34 ` Doug Anderson
2016-03-10 17:54 ` Thierry Reding
2016-03-11 9:51 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150922221218.GA9317@x1 \
--to=lee.jones@linaro.org \
--cc=boris.brezillon@free-electrons.com \
--cc=broonie@kernel.org \
--cc=cooloney@gmail.com \
--cc=daniel@zonque.org \
--cc=dianders@google.com \
--cc=haojian.zhuang@gmail.com \
--cc=heiko@sntech.de \
--cc=j.anaszewski@samsung.com \
--cc=jingoohan1@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-sunxi@googlegroups.com \
--cc=maxime.ripard@free-electrons.com \
--cc=plagnioj@jcrosoft.com \
--cc=robert.jarzmik@free.fr \
--cc=rpurdie@rpsys.net \
--cc=thierry.reding@gmail.com \
--cc=tomi.valkeinen@ti.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).