drivers/media/pci/netup_unidvb/netup_unidvb_core.c:417:18: error: too many arguments to function 'horus3a_attach'

drivers/media/pci/netup_unidvb/netup_unidvb_core.c:417:18: error: too many arguments to function 'horus3a_attach'

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 4299 bytes --]

Hi Kozlov,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   4a06c8ac2fb3ef484579ce44f9b809bd310fad48
commit: 52b1eaf4c59a3bbd07afbb4ab4f43418a807d02e [media] netup_unidvb: NetUP Universal DVB-S/S2/T/T2/C PCI-E card driver
date:   9 weeks ago
config: x86_64-randconfig-s1-10110708 (attached as .config)
reproduce:
        git checkout 52b1eaf4c59a3bbd07afbb4ab4f43418a807d02e
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   In file included from drivers/media/pci/netup_unidvb/netup_unidvb_core.c:34:0:
   drivers/media/dvb-frontends/horus3a.h:51:13: warning: 'struct cxd2820r_config' declared inside parameter list
         struct i2c_adapter *i2c)
                ^
   drivers/media/dvb-frontends/horus3a.h:51:13: warning: its scope is only this definition or declaration, which is probably not what you want
   In file included from include/media/videobuf2-dvb.h:4:0,
                    from drivers/media/pci/netup_unidvb/netup_unidvb.h:26,
                    from drivers/media/pci/netup_unidvb/netup_unidvb_core.c:32:
   drivers/media/pci/netup_unidvb/netup_unidvb_core.c: In function 'netup_unidvb_dvb_init':
   drivers/media/pci/netup_unidvb/netup_unidvb_core.c:417:34: warning: passing argument 1 of 'horus3a_attach' from incompatible pointer type [-Wincompatible-pointer-types]
     if (!dvb_attach(horus3a_attach, fe0->dvb.frontend,
                                     ^
   drivers/media/dvb-core/dvbdev.h:170:11: note: in definition of macro 'dvb_attach'
     FUNCTION(ARGS); \
              ^
   In file included from drivers/media/pci/netup_unidvb/netup_unidvb_core.c:34:0:
   drivers/media/dvb-frontends/horus3a.h:49:36: note: expected 'const struct cxd2820r_config *' but argument is of type 'struct dvb_frontend *'
    static inline struct dvb_frontend *horus3a_attach(
                                       ^
   In file included from include/media/videobuf2-dvb.h:4:0,
                    from drivers/media/pci/netup_unidvb/netup_unidvb.h:26,
                    from drivers/media/pci/netup_unidvb/netup_unidvb_core.c:32:
   drivers/media/pci/netup_unidvb/netup_unidvb_core.c:418:4: warning: passing argument 2 of 'horus3a_attach' from incompatible pointer type [-Wincompatible-pointer-types]
       &horus3a_conf, &ndev->i2c[num].adap)) {
       ^
   drivers/media/dvb-core/dvbdev.h:170:11: note: in definition of macro 'dvb_attach'
     FUNCTION(ARGS); \
              ^
   In file included from drivers/media/pci/netup_unidvb/netup_unidvb_core.c:34:0:
   drivers/media/dvb-frontends/horus3a.h:49:36: note: expected 'struct i2c_adapter *' but argument is of type 'struct horus3a_config *'
    static inline struct dvb_frontend *horus3a_attach(
                                       ^
   In file included from include/media/videobuf2-dvb.h:4:0,
                    from drivers/media/pci/netup_unidvb/netup_unidvb.h:26,
                    from drivers/media/pci/netup_unidvb/netup_unidvb_core.c:32:
>> drivers/media/pci/netup_unidvb/netup_unidvb_core.c:417:18: error: too many arguments to function 'horus3a_attach'
     if (!dvb_attach(horus3a_attach, fe0->dvb.frontend,
                     ^
   drivers/media/dvb-core/dvbdev.h:170:2: note: in definition of macro 'dvb_attach'
     FUNCTION(ARGS); \
     ^
   In file included from drivers/media/pci/netup_unidvb/netup_unidvb_core.c:34:0:
   drivers/media/dvb-frontends/horus3a.h:49:36: note: declared here
    static inline struct dvb_frontend *horus3a_attach(
                                       ^

vim +/horus3a_attach +417 drivers/media/pci/netup_unidvb/netup_unidvb_core.c

   411			dev_dbg(&ndev->pci_dev->dev,
   412				"%s(): unable to attach DVB-S/S2 frontend\n",
   413				__func__);
   414			goto frontend_detach;
   415		}
   416		horus3a_conf.set_tuner_priv = &ndev->dma[num];
 > 417		if (!dvb_attach(horus3a_attach, fe0->dvb.frontend,
   418				&horus3a_conf, &ndev->i2c[num].adap)) {
   419			dev_dbg(&ndev->pci_dev->dev,
   420				"%s(): unable to attach DVB-S/S2 tuner frontend\n",

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 26070 bytes --]