From: Mark Brown <broonie@kernel.org>
To: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
Cc: lee.jones@linaro.org, linus.walleij@linaro.org,
patches@opensource.wolfsonmicro.com,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-gpio@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH v2 3/3] ASoC: cs47l24: Add driver for Cirrus Logic CS47L24 and WM1831 codecs
Date: Thu, 22 Oct 2015 13:40:57 +0100 [thread overview]
Message-ID: <20151022124057.GG8232@sirena.org.uk> (raw)
In-Reply-To: <1445264027-7357-4-git-send-email-rf@opensource.wolfsonmicro.com>
[-- Attachment #1: Type: text/plain, Size: 583 bytes --]
On Mon, Oct 19, 2015 at 03:13:47PM +0100, Richard Fitzgerald wrote:
> @@ -134,6 +134,7 @@ config SND_SOC_ALL_CODECS
> select SND_SOC_WM5100 if I2C
> select SND_SOC_WM5102 if MFD_WM5102
> select SND_SOC_WM5110 if MFD_WM5110
> + select SND_SOC_CS47L24 if MFD_CS47L24
> select SND_SOC_WM8350 if MFD_WM8350
> select SND_SOC_WM8400 if MFD_WM8400
> select SND_SOC_WM8510 if SND_SOC_I2C_AND_SPI
Please keep the Makefile and Kconfig sorted.
> +config SND_SOC_CS47L24
> + tristate "TEST cs47l24"
> +
This isn't a good help text for the symbol.
Otherwise the code looks good.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-10-22 23:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-19 14:13 [PATCH v2 0/3] Add support for Cirrus Logic CS47L24 and WM1831 codecs Richard Fitzgerald
2015-10-19 14:13 ` [PATCH v2 1/3] mfd: arizona: Support Cirrus Logic CS47L24 and WM1831 Richard Fitzgerald
2015-10-30 18:29 ` Lee Jones
2015-10-19 14:13 ` [PATCH v2 2/3] gpio: " Richard Fitzgerald
2015-10-27 9:58 ` Linus Walleij
2015-10-28 11:42 ` Lee Jones
2015-10-29 14:29 ` Linus Walleij
2015-10-19 14:13 ` [PATCH v2 3/3] ASoC: cs47l24: Add driver for Cirrus Logic CS47L24 and WM1831 codecs Richard Fitzgerald
2015-10-22 12:40 ` Mark Brown [this message]
2015-10-19 14:52 ` [alsa-devel] [PATCH v2 0/3] Add support " Caleb Crome
2015-10-19 15:04 ` Richard Fitzgerald
2015-10-19 15:10 ` Caleb Crome
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151022124057.GG8232@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=rf@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).