Re: [PATCH v2 1/3] mfd: arizona: Support Cirrus Logic CS47L24 and WM1831

[Lee Jones <lee.jones@linaro.org>]

On Mon, 19 Oct 2015, Richard Fitzgerald wrote:

> This patch adds the regmap configuration tables and
> core MFD handling for the CS47L24 and WM1831 codecs.
> 
> Note that compared to the other Arizona codecs, these devices
> do not have an LDO1 or micsupp regulators, extcon driver, or
> the DCVDD isolation control.
> 
> Signed-off-by: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
> ---
>  Documentation/devicetree/bindings/mfd/arizona.txt |    4 +-

Separate patch please.

>  drivers/mfd/Kconfig                               |   19 +-
>  drivers/mfd/Makefile                              |    3 +
>  drivers/mfd/arizona-core.c                        |   74 +-
>  drivers/mfd/arizona-irq.c                         |   40 +-
>  drivers/mfd/arizona-spi.c                         |    7 +
>  drivers/mfd/arizona.h                             |    4 +
>  drivers/mfd/cs47l24-tables.c                      | 1629 +++++++++++++++++++++
>  include/linux/mfd/arizona/core.h                  |    3 +
>  9 files changed, 1757 insertions(+), 26 deletions(-)
>  create mode 100644 drivers/mfd/cs47l24-tables.c
> 
> diff --git a/Documentation/devicetree/bindings/mfd/arizona.txt b/Documentation/devicetree/bindings/mfd/arizona.txt
> index a8fee60..73f28fa 100644
> --- a/Documentation/devicetree/bindings/mfd/arizona.txt
> +++ b/Documentation/devicetree/bindings/mfd/arizona.txt
> @@ -1,4 +1,4 @@
> -Wolfson Arizona class audio SoCs
> +Cirrus Logic/Wolfson Microelectronics Arizona class audio SoCs
>  
>  These devices are audio SoCs with extensive digital capabilites and a range
>  of analogue I/O.
> @@ -12,6 +12,8 @@ Required properties:
>          "wlf,wm8997"
>          "wlf,wm8998"
>          "wlf,wm1814"
> +        "wlf,wm1831"
> +        "cirrus,cs47l24"
>  
>    - reg : I2C slave address when connected using I2C, chip select number when
>      using SPI.
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 4d92df6..d25bbb3 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -1370,24 +1370,24 @@ config MFD_ARIZONA
>  	bool
>  
>  config MFD_ARIZONA_I2C
> -	tristate "Wolfson Microelectronics Arizona platform with I2C"
> +	tristate "Cirrus Logic/Wolfson Microelectronics Arizona platform with I2C"
>  	select MFD_ARIZONA
>  	select MFD_CORE
>  	select REGMAP_I2C
>  	depends on I2C
>  	help
> -	  Support for the Wolfson Microelectronics Arizona platform audio SoC
> -	  core functionality controlled via I2C.
> +	  Support for the Cirrus Logic/Wolfson Microelectronics Arizona platform
> +	  audio SoC core functionality controlled via I2C.
>  
>  config MFD_ARIZONA_SPI
> -	tristate "Wolfson Microelectronics Arizona platform with SPI"
> +	tristate "Cirrus Logic/Wolfson Microelectronics Arizona platform with SPI"
>  	select MFD_ARIZONA
>  	select MFD_CORE
>  	select REGMAP_SPI
>  	depends on SPI_MASTER
>  	help
> -	  Support for the Wolfson Microelectronics Arizona platform audio SoC
> -	  core functionality controlled via I2C.
> +	  Support for the Cirrus Logic/Wolfson Microelectronics Arizona platform
> +	  audio SoC core functionality controlled via I2C.
>  
>  config MFD_WM5102
>  	bool "Wolfson Microelectronics WM5102"
> @@ -1414,6 +1414,13 @@ config MFD_WM8998
>  	help
>  	  Support for Wolfson Microelectronics WM8998 low power audio SoC
>  
> +config MFD_CS47L24
> +	bool "Cirrus Logic CS47L24 and WM1831"
> +	depends on MFD_ARIZONA
> +	help
> +	  Support for Cirrus Logic CS47L24 and WM1831 low power audio SoC
> +
> +

Superflous '\n'.

[...]

> diff --git a/drivers/mfd/cs47l24-tables.c b/drivers/mfd/cs47l24-tables.c
> new file mode 100644
> index 0000000..f877586
> --- /dev/null
> +++ b/drivers/mfd/cs47l24-tables.c
> @@ -0,0 +1,1629 @@
> +/*
> + * cs47l24-tables.c  --  data tables for CS47L24 codec

Please remove this filename.

They have a habit of becoming unaligned.

> + * Copyright 2015 Cirrus Logic, Inc.
> + *
> + * Author: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + */

[...]

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog