From: David Miller <davem@davemloft.net>
To: ast@plumgrid.com
Cc: mingo@kernel.org, a.p.zijlstra@chello.nl, wangnan0@huawei.com,
hekuang@huawei.com, xiakaixu@huawei.com, daniel@iogearbox.net,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 net-next] bpf: fix bpf_perf_event_read() helper
Date: Mon, 26 Oct 2015 21:50:57 -0700 (PDT) [thread overview]
Message-ID: <20151026.215057.1299451307191406499.davem@davemloft.net> (raw)
In-Reply-To: <1445559014-4667-1-git-send-email-ast@kernel.org>
From: Alexei Starovoitov <ast@plumgrid.com>
Date: Thu, 22 Oct 2015 17:10:14 -0700
> Fix safety checks for bpf_perf_event_read():
> - only non-inherited events can be added to perf_event_array map
> (do this check statically at map insertion time)
> - dynamically check that event is local and !pmu->count
> Otherwise buggy bpf program can cause kernel splat.
>
> Also fix error path after perf_event_attrs()
> and remove redundant 'extern'.
>
> Fixes: 35578d798400 ("bpf: Implement function bpf_perf_event_read() that get the selected hardware PMU conuter")
> Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Applied, although my tendancy is to agree with the sentiment that you must
respect the entire universe of valid 64-bit counter values. I do not buy
the arguments about values overlapping error codes being unlikely or not
worth worrying about.
Just FYI...
prev parent reply other threads:[~2015-10-27 4:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-23 0:10 [PATCH v3 net-next] bpf: fix bpf_perf_event_read() helper Alexei Starovoitov
2015-10-23 2:21 ` Wangnan (F)
2015-10-23 2:30 ` Alexei Starovoitov
2015-10-23 3:47 ` Wangnan (F)
2015-10-23 12:03 ` Peter Zijlstra
2015-10-23 14:42 ` Alexei Starovoitov
2015-10-23 14:54 ` Peter Zijlstra
2015-10-25 9:21 ` Ingo Molnar
2015-10-25 16:23 ` Alexei Starovoitov
2015-10-26 12:32 ` Peter Zijlstra
2015-10-26 12:54 ` Wangnan (F)
2015-10-26 21:28 ` Alexei Starovoitov
2015-10-27 4:50 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151026.215057.1299451307191406499.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=a.p.zijlstra@chello.nl \
--cc=ast@plumgrid.com \
--cc=daniel@iogearbox.net \
--cc=hekuang@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wangnan0@huawei.com \
--cc=xiakaixu@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).