* [PATCH 2/2] Drivers:staging:wlan_ng: fix all coding style isuues in file prism2usb.c
@ 2015-10-26 21:47 Bogicevic Sasa
2015-10-27 8:15 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Bogicevic Sasa @ 2015-10-26 21:47 UTC (permalink / raw)
To: gregkh; +Cc: linux-kernel, Bogicevic Sasa
Fixed all coding style issues based on checkpatch.pl warnings and errors
Signed-off-by: Bogicevic Sasa <brutallesale@gmail.com>
---
drivers/staging/wlan-ng/prism2usb.c | 40 ++++++++++++++++++++++---------------
1 file changed, 24 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/wlan-ng/prism2usb.c b/drivers/staging/wlan-ng/prism2usb.c
index e92bbc1..816d7e0 100644
--- a/drivers/staging/wlan-ng/prism2usb.c
+++ b/drivers/staging/wlan-ng/prism2usb.c
@@ -6,7 +6,7 @@
#define PRISM_DEV(vid, pid, name) \
{ USB_DEVICE(vid, pid), \
- .driver_info = (unsigned long) name }
+ .driver_info = (unsigned long)name }
static struct usb_device_id usb_prism_tbl[] = {
PRISM_DEV(0x04bb, 0x0922, "IOData AirPort WN-B11/USBS"),
@@ -46,12 +46,18 @@ static struct usb_device_id usb_prism_tbl[] = {
PRISM_DEV(0x124a, 0x4017, "Pheenet WL-503IA 802.11b USB Adapter"),
PRISM_DEV(0x0bb2, 0x0302, "Ambit Microsystems Corp."),
PRISM_DEV(0x9016, 0x182d, "Sitecom WL-022 802.11b USB Adapter"),
- PRISM_DEV(0x0543, 0x0f01,
- "ViewSonic Airsync USB Adapter 11Mbps (Prism2.5)"),
- PRISM_DEV(0x067c, 0x1022,
- "Siemens SpeedStream 1022 11Mbps WLAN USB Adapter"),
- PRISM_DEV(0x049f, 0x0033,
- "Compaq/Intel W100 PRO/Wireless 11Mbps multiport WLAN Adapter"),
+ PRISM_DEV(
+ 0x0543, 0x0f01,
+ "ViewSonic Airsync USB Adapter 11Mbps (Prism2.5)"
+ ),
+ PRISM_DEV(
+ 0x067c, 0x1022,
+ "Siemens SpeedStream 1022 11Mbps WLAN USB Adapter"
+ ),
+ PRISM_DEV(
+ 0x049f, 0x0033,
+ "Compaq/Intel W100 PRO/Wireless 11Mbps multiport WLAN Adapter"
+ ),
{ } /* terminator */
};
MODULE_DEVICE_TABLE(usb, usb_prism_tbl);
@@ -67,14 +73,14 @@ static int prism2sta_probe_usb(struct usb_interface *interface,
dev = interface_to_usbdev(interface);
wlandev = create_wlan();
- if (wlandev == NULL) {
+ if (!wlandev) {
dev_err(&interface->dev, "Memory allocation failure.\n");
result = -EIO;
goto failed;
}
hw = wlandev->priv;
- if (wlan_setup(wlandev, &(interface->dev)) != 0) {
+ if (wlan_setup(wlandev, &interface->dev) != 0) {
dev_err(&interface->dev, "wlan_setup() failed.\n");
result = -EIO;
goto failed;
@@ -87,7 +93,7 @@ static int prism2sta_probe_usb(struct usb_interface *interface,
/* Register the wlandev, this gets us a name and registers the
* linux netdevice.
*/
- SET_NETDEV_DEV(wlandev->netdev, &(interface->dev));
+ SET_NETDEV_DEV(wlandev->netdev, &interface->dev);
/* Do a chip-level reset on the MAC */
if (prism2_doreset) {
@@ -136,8 +142,8 @@ static void prism2sta_disconnect_usb(struct usb_interface *interface)
{
wlandevice_t *wlandev;
- wlandev = (wlandevice_t *) usb_get_intfdata(interface);
- if (wlandev != NULL) {
+ wlandev = (wlandevice_t *)usb_get_intfdata(interface);
+ if (!wlandev) {
LIST_HEAD(cleanlist);
struct list_head *entry;
struct list_head *temp;
@@ -223,13 +229,15 @@ exit:
}
#ifdef CONFIG_PM
-static int prism2sta_suspend(struct usb_interface *interface,
- pm_message_t message)
+static int prism2sta_suspend(
+ struct usb_interface *interface,
+ pm_message_t message
+ )
{
hfa384x_t *hw = NULL;
wlandevice_t *wlandev;
- wlandev = (wlandevice_t *) usb_get_intfdata(interface);
+ wlandev = (wlandevice_t *)usb_get_intfdata(interface);
if (!wlandev)
return -ENODEV;
@@ -252,7 +260,7 @@ static int prism2sta_resume(struct usb_interface *interface)
hfa384x_t *hw = NULL;
wlandevice_t *wlandev;
- wlandev = (wlandevice_t *) usb_get_intfdata(interface);
+ wlandev = (wlandevice_t *)usb_get_intfdata(interface);
if (!wlandev)
return -ENODEV;
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 2/2] Drivers:staging:wlan_ng: fix all coding style isuues in file prism2usb.c
2015-10-26 21:47 [PATCH 2/2] Drivers:staging:wlan_ng: fix all coding style isuues in file prism2usb.c Bogicevic Sasa
@ 2015-10-27 8:15 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2015-10-27 8:15 UTC (permalink / raw)
To: Bogicevic Sasa; +Cc: linux-kernel
On Mon, Oct 26, 2015 at 10:47:37PM +0100, Bogicevic Sasa wrote:
> Fixed all coding style issues based on checkpatch.pl warnings and errors
>
> Signed-off-by: Bogicevic Sasa <brutallesale@gmail.com>
> ---
> drivers/staging/wlan-ng/prism2usb.c | 40 ++++++++++++++++++++++---------------
> 1 file changed, 24 insertions(+), 16 deletions(-)
Again, please break up.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-27 8:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-26 21:47 [PATCH 2/2] Drivers:staging:wlan_ng: fix all coding style isuues in file prism2usb.c Bogicevic Sasa
2015-10-27 8:15 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).