[PATCH] backlight: pm8941-wled: fix ptr_ret.cocci warnings

[PATCH] backlight: pm8941-wled: fix ptr_ret.cocci warnings

[kbuild test robot]

drivers/video/backlight/pm8941-wled.c:404:1-3: WARNING: PTR_ERR_OR_ZERO can be used


 Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR

Generated by: scripts/coccinelle/api/ptr_ret.cocci

CC: Bjorn Andersson <bjorn.andersson@sonymobile.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 pm8941-wled.c |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

--- a/drivers/video/backlight/pm8941-wled.c
+++ b/drivers/video/backlight/pm8941-wled.c
@@ -401,10 +401,7 @@ static int pm8941_wled_probe(struct plat
 	bl = devm_backlight_device_register(&pdev->dev, wled->name,
 					    &pdev->dev, wled,
 					    &pm8941_wled_ops, &props);
-	if (IS_ERR(bl))
-		return PTR_ERR(bl);
-
-	return 0;
+	return PTR_ERR_OR_ZERO(bl);
 };
 
 static const struct of_device_id pm8941_wled_match_table[] = {

drivers/video/backlight/pm8941-wled.c:404:1-3: WARNING: PTR_ERR_OR_ZERO can be used

[kbuild test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   85051e295fb7487fd22546f86058e99d5266dd88
commit: 7ddbc2423c3301280b883bbb04b998203f30312c backlight: pm8941-wled: Move PM8941 WLED driver to backlight
date:   9 weeks ago


coccinelle warnings: (new ones prefixed by >>)

>> drivers/video/backlight/pm8941-wled.c:404:1-3: WARNING: PTR_ERR_OR_ZERO can be used

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Re: [PATCH] backlight: pm8941-wled: fix ptr_ret.cocci warnings

[Bjorn Andersson]

On Mon, Oct 26, 2015 at 11:26 AM, kbuild test robot
<fengguang.wu@intel.com> wrote:
> drivers/video/backlight/pm8941-wled.c:404:1-3: WARNING: PTR_ERR_OR_ZERO can be used
>
>
>  Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
>
> Generated by: scripts/coccinelle/api/ptr_ret.cocci
>

Cool, I didn't know that. Thanks

Acked-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>

> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

Regards,
Bjorn

Re: [PATCH] backlight: pm8941-wled: fix ptr_ret.cocci warnings

[Lee Jones]

On Tue, 27 Oct 2015, kbuild test robot wrote:

> drivers/video/backlight/pm8941-wled.c:404:1-3: WARNING: PTR_ERR_OR_ZERO can be used
> 
> 
>  Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
> 
> Generated by: scripts/coccinelle/api/ptr_ret.cocci
> 
> CC: Bjorn Andersson <bjorn.andersson@sonymobile.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
> 
>  pm8941-wled.c |    5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)

Applied, thanks.

> --- a/drivers/video/backlight/pm8941-wled.c
> +++ b/drivers/video/backlight/pm8941-wled.c
> @@ -401,10 +401,7 @@ static int pm8941_wled_probe(struct plat
>  	bl = devm_backlight_device_register(&pdev->dev, wled->name,
>  					    &pdev->dev, wled,
>  					    &pm8941_wled_ops, &props);
> -	if (IS_ERR(bl))
> -		return PTR_ERR(bl);
> -
> -	return 0;
> +	return PTR_ERR_OR_ZERO(bl);
>  };
>  
>  static const struct of_device_id pm8941_wled_match_table[] = {

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog