From: Stephen Hemminger <stephen@networkplumber.org>
To: Mans Rullgard <mans@mansr.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, slash.tmp@free.fr
Subject: Re: [PATCH v3 2/2] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller
Date: Tue, 27 Oct 2015 15:02:09 +0900 [thread overview]
Message-ID: <20151027150209.043946d4@samsung9> (raw)
In-Reply-To: <1445895295-16778-2-git-send-email-mans@mansr.com>
> +
> +static struct ethtool_ops nb8800_ethtool_ops = {
Ops should be const
> + .get_settings = nb8800_get_settings,
> + .set_settings = nb8800_set_settings,
> + .nway_reset = nb8800_nway_reset,
> + .get_link = ethtool_op_get_link,
> +};
> +
Since you are implementing ethtool please add a driver
info function.
next prev parent reply other threads:[~2015-10-27 6:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-26 21:34 [PATCH v3 1/2] devicetree: add binding for Aurora VLSI NB8800 Ethernet controller Mans Rullgard
2015-10-26 21:34 ` [PATCH v3 2/2] net: ethernet: add driver " Mans Rullgard
2015-10-27 6:02 ` Stephen Hemminger [this message]
2015-10-27 12:40 ` Måns Rullgård
2015-10-26 21:40 ` [PATCH v3 1/2] devicetree: add binding " Måns Rullgård
2015-11-12 14:44 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151027150209.043946d4@samsung9 \
--to=stephen@networkplumber.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mans@mansr.com \
--cc=netdev@vger.kernel.org \
--cc=slash.tmp@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).