From: Vinod Koul <vinod.koul@intel.com>
To: Yao Yuan <yao.yuan@freescale.com>
Cc: "stefan@agner.ch" <stefan@agner.ch>,
"arnd@arndb.de" <arnd@arndb.de>,
"dan.j.williams@intel.com" <dan.j.williams@intel.com>,
"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3] dmaengine: fsl-edma: add PM suspend/resume support
Date: Wed, 28 Oct 2015 15:49:17 +0900 [thread overview]
Message-ID: <20151028064915.GD3041@vkoul-mobl.iind.intel.com> (raw)
In-Reply-To: <BLUPR03MB134DA9E483023953813E03783220@BLUPR03MB134.namprd03.prod.outlook.com>
On Tue, Oct 27, 2015 at 03:58:31AM +0000, Yao Yuan wrote:
> Hi Vinod,
>
Please do not top post
> Thanks for your review.
> I did the test and it seems that it should be ok when CONFIG_PM is not defined.
> So I removed the protection code to make it more readable.
> Do you think is it ok?
Yes I did check, this seems okay, pls ignore this comment. You still need to
explain why you use late/early calls
--
~Vinod
prev parent reply other threads:[~2015-10-28 6:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-19 8:31 [PATCH v3] dmaengine: fsl-edma: add PM suspend/resume support Yuan Yao
2015-10-27 2:00 ` Vinod Koul
2015-10-27 3:58 ` Yao Yuan
2015-10-28 6:49 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151028064915.GD3041@vkoul-mobl.iind.intel.com \
--to=vinod.koul@intel.com \
--cc=arnd@arndb.de \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stefan@agner.ch \
--cc=yao.yuan@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).