From: Eduardo Valentin <edubezval@gmail.com>
To: Punit Agrawal <punit.agrawal@arm.com>
Cc: Viresh Kumar <viresh.kumar@linaro.org>,
Dawei Chien <dawei.chien@mediatek.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Daniel Kurtz <djkurtz@chromium.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com,
Sascha Hauer <kernel@pengutronix.de>
Subject: Re: [PATCH v3 0/2] thermal: mediatek: Add cpu power cooling model
Date: Wed, 4 Nov 2015 11:36:46 -0800 [thread overview]
Message-ID: <20151104193645.GB14127@localhost.localdomain> (raw)
In-Reply-To: <9hh4mh4bdoi.fsf@e105922-lin.cambridge.arm.com>
On Mon, Nov 02, 2015 at 03:53:33PM +0000, Punit Agrawal wrote:
> Viresh Kumar <viresh.kumar@linaro.org> writes:
>
> > On 22-10-15, 20:02, Dawei Chien wrote:
> >> Use Intelligent Power Allocation (IPA) technical to add static/dynamic power model for binding CPU thermal zone.
> >> The power allocator governor allocates power budget to control CPU temperature.
> >>
> >> Power Allocator governor is able to keep SOC temperature within a
> >> defined temperature range to avoid SOC overheat and keep it's
> >> performance. mt8173-cpufreq.c need to register its' own power model
> >> with power allocator thermal governor, so that power allocator
> >> governor can allocates suitable power budget to control CPU
> >> temperature.
> >>
> >> PATCH1 is base on
> >> https://patchwork.kernel.org/patch/7034601/
> >>
> >> PATCH2 is base on Sascha's thermal driver V9
> >> https://patchwork.kernel.org/patch/7249821/
> >> https://patchwork.kernel.org/patch/7249861/
> >> https://patchwork.kernel.org/patch/7249891/
> >>
> >> Change since V1:
> >> include mt8171.h and sort header file for mt8173.dtsi
> >>
> >> Change since V2:
> >> Move dynamic/static power model in device tree
> >>
> >> Dawei.Chien (2):
> >> thermal: mediatek: Add cpu power cooling model.
> >> arm64: dts: mt8173: Add thermal zone node for mt8173.
> >
> > Sorry for being extremely late in reviewing this stuff. You are
> > already on v3 and I haven't reviewed it once. Mostly due to bad timing
> > of my holidays and other work pressure.
> >
> > Now, there are few things that I feel are not properly addressed here,
> > and I may be wrong:
> > - Where are the bindings for static-power-points and
> > dynamic-power-coefficient. Sorry I failed to see them in this or
> > other series you mentioned.
>
> For dynamic power, I had posted some patches[0][1][2] introducing the
> binding as well as updating cooling device registration via cpufreq
> driver. Now that the SCPI hwmon driver is merged, I should re-send the
> remaining patches.
>
> [0] http://lkml.iu.edu/hypermail/linux/kernel/1508.0/01020.html
Are you sure this binding is applicable only to ARM cpus?
> [1] http://lkml.iu.edu/hypermail/linux/kernel/1508.0/01022.html
> [3] http://lkml.iu.edu/hypermail/linux/kernel/1508.0/01031.html
>
> > - Even then, why should we be adding another table into DT for
> > voltage/power ? And not reuse and extend the opp-v2 stuff which is
> > already mainlined now.
> > - There are few issues with the code as well, but I want to see where
> > the bindings should go first. And then only discuss the code
> > further.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2015-11-04 19:36 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-22 12:02 [PATCH v3 0/2] thermal: mediatek: Add cpu power cooling model Dawei Chien
2015-10-22 12:02 ` [PATCH v3 1/2] " Dawei Chien
2015-11-04 19:40 ` Eduardo Valentin
2015-11-05 11:10 ` dawei chien
2015-11-06 3:24 ` Viresh Kumar
2015-11-10 11:20 ` Javi Merino
2015-11-10 18:41 ` Eduardo Valentin
2015-11-11 9:36 ` Javi Merino
2015-11-13 5:02 ` Viresh Kumar
2015-10-22 12:02 ` [PATCH v3 2/2] arm64: dts: mt8173: Add thermal zone node for mt8173 Dawei Chien
2015-10-28 15:39 ` Viresh Kumar
2015-11-02 10:51 ` dawei chien
2015-11-04 19:41 ` Eduardo Valentin
2015-11-05 11:10 ` dawei chien
2015-10-28 15:44 ` [PATCH v3 0/2] thermal: mediatek: Add cpu power cooling model Viresh Kumar
2015-11-02 10:46 ` dawei chien
2015-11-02 12:10 ` Viresh Kumar
2015-11-05 11:09 ` dawei chien
2015-11-06 3:20 ` Viresh Kumar
2015-11-11 12:00 ` dawei chien
2015-11-02 15:53 ` Punit Agrawal
2015-11-02 16:10 ` Viresh Kumar
2015-11-04 19:36 ` Eduardo Valentin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151104193645.GB14127@localhost.localdomain \
--to=edubezval@gmail.com \
--cc=daniel.lezcano@linaro.org \
--cc=dawei.chien@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=djkurtz@chromium.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=pawel.moll@arm.com \
--cc=punit.agrawal@arm.com \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=srv_heupstream@mediatek.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).