Re: [PATCH 3/4] dm verity: add support for forward error correction

From: kbuild test robot <lkp@intel.com>
To: Sami Tolvanen <samitolvanen@google.com>
Cc: kbuild-all@01.org, Mikulas Patocka <mpatocka@redhat.com>,
	Mandeep Baines <msb@chromium.org>, Will Drewry <wad@chromium.org>,
	Alasdair Kergon <agk@redhat.com>,
	Mike Snitzer <snitzer@redhat.com>,
	dm-devel@redhat.com, linux-kernel@vger.kernel.org,
	Kees Cook <keescook@chromium.org>,
	Mark Salyzyn <salyzyn@google.com>,
	Sami Tolvanen <samitolvanen@google.com>
Subject: Re: [PATCH 3/4] dm verity: add support for forward error correction
Date: Fri, 6 Nov 2015 06:06:17 +0800	[thread overview]
Message-ID: <201511060627.6n5B3CI9%fengguang.wu@intel.com> (raw)
In-Reply-To: <1446688954-29589-4-git-send-email-samitolvanen@google.com>

[-- Attachment #1: Type: text/plain, Size: 1869 bytes --]

Hi Sami,

[auto build test WARNING on: dm/for-next]
[also build test WARNING on: v4.3 next-20151105]

url:    https://github.com/0day-ci/linux/commits/Sami-Tolvanen/dm-verity-clean-up-duplicate-hashing-code/20151105-124458
base:   https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git for-next
config: s390-allyesconfig (attached as .config)
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=s390 

All warnings (new ones prefixed by >>):

   drivers/md/dm-verity.c: In function 'verity_fec_decode_rsb':
>> drivers/md/dm-verity.c:812:1: warning: 'verity_fec_decode_rsb' uses dynamic stack allocation
    }
    ^

vim +/verity_fec_decode_rsb +812 drivers/md/dm-verity.c

   796		if (r < 0)
   797			return r;
   798	
   799		r = verity_hash(v, io_hash_desc(v, io), io->fec_buf,
   800				1 << v->data_dev_block_bits, io_real_digest(v, io));
   801		if (unlikely(r < 0))
   802			return r;
   803	
   804		if (memcmp(io_real_digest(v, io), io_want_digest(v, io),
   805				v->digest_size)) {
   806			DMERR_LIMIT("%s: FEC %llu: failed to correct (%d erasures)",
   807				    v->data_dev->name, (unsigned long long)rsb, neras);
   808			return -1;
   809		}
   810	
   811		return 0;
 > 812	}
   813	
   814	static int verity_fec_bv_copy(struct dm_verity *v, struct dm_verity_io *io,
   815				      u8 *data, size_t len)
   816	{
   817		BUG_ON(io->fec_pos + len > 1 << v->data_dev_block_bits);
   818		memcpy(data, &io->fec_buf[io->fec_pos], len);
   819		io->fec_pos += len;
   820		return 0;

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 38647 bytes --]