From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Jeremiah Mahler <jmmahler@gmail.com>,
tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
peterhuewe@gmx.de, gregkh@linuxfoundation.org,
jgunthorpe@obsidianresearch.com, dhowells@redhat.com,
artem.bityutskiy@linux.intel.com, Tejun Heo <tj@kernel.org>,
NeilBrown <neilb@suse.de>, Guenter Roeck <linux@roeck-us.net>,
"Eric W. Biederman" <ebiederm@xmission.com>
Subject: Re: [BUG, PATCH 03/10] sysfs: added __compat_only_sysfs_link_entry_to_kobj()
Date: Sun, 8 Nov 2015 02:49:06 +0200 [thread overview]
Message-ID: <20151108004906.GA25843@intel.com> (raw)
In-Reply-To: <20151107231147.GA9273@newt.localdomain>
On Sat, Nov 07, 2015 at 03:11:47PM -0800, Jeremiah Mahler wrote:
> Jarkko,
>
> On Sun, Nov 08, 2015 at 12:31:09AM +0200, Jarkko Sakkinen wrote:
> > On Sat, Nov 07, 2015 at 10:08:56AM -0800, Jeremiah Mahler wrote:
> > > Jarkko,
> > >
> > > On Sat, Nov 07, 2015 at 01:41:37PM +0200, Jarkko Sakkinen wrote:
> > > > On Sat, Nov 07, 2015 at 12:55:43PM +0200, Jarkko Sakkinen wrote:
> > > > > On Fri, Nov 06, 2015 at 06:55:18PM -0800, Jeremiah Mahler wrote:
> > > > > > Jarkko,
> > > > > >
> [...]
> > > > I pushed a fix over here:
> > > >
> > > > https://github.com/jsakkine/linux-tpmdd/tree/fixes
> > > >
> > > This fix does work since it effectively avoids the call to
> > > __compat_only_sysfs_link_entry_to_kobj().
> > >
> > > Have you tested cases where __compat_only_sysfs_link_entry_to_kobj()
> > > is actually used?
> >
> > Yes, of course I have. And I checked your DSDT and my assumption was
> > correct. There was no DSM in the ACPI object.
> >
> > However, there is probably another regression but it is caused by some
> > patch that was added earlier. I strongly believe it is not caused by any
> > of my 4.4 patches.
> >
> > I think what was happening with you was that
> > __compat_only_sysfs_link_entry_to_kobj() was returning -ENOENT, which it
> > should do when target is not found. This was propagated to tpm_tis and
> > it probably messes up clean up somehow.
> >
> > I have to test my hypothesis as soon as possible. The fix that I pushed
> > is still valid no matter which way the things are.
> >
> > > [...]
> > >
> > > --
> > > - Jeremiah Mahler
> >
> > /Jarkko
>
> It sounds like you have the problem figured out and have a good fix.
> If I can do anything else to help let me know :-)
Turns out that after all the second issue that I described was also
because of this patch.
Clean up was not done properly when that function. I revised my fix.
If you want to help, check that the revised patch works I'll add
Tested-by to the patch. Thank you!
> --
> - Jeremiah Mahler
/Jarkko
next prev parent reply other threads:[~2015-11-08 0:49 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-16 18:40 [PATCH 00/10] TPM2 updates for 4.4 Jarkko Sakkinen
2015-10-16 18:40 ` [PATCH 01/10] tpm, tpm_crb: fix unaligned read of the command buffer address Jarkko Sakkinen
2015-10-18 3:02 ` Peter Hüwe
2015-10-18 11:15 ` Jarkko Sakkinen
2015-10-16 18:40 ` [PATCH 02/10] tpm, tpm_tis: fix tpm_tis ACPI detection issue with TPM 2.0 Jarkko Sakkinen
2015-10-16 18:40 ` [PATCH 03/10] sysfs: added __compat_only_sysfs_link_entry_to_kobj() Jarkko Sakkinen
2015-10-18 1:37 ` Peter Hüwe
2015-10-18 11:21 ` Jarkko Sakkinen
2015-11-07 0:23 ` Jeremiah Mahler
2015-11-09 22:32 ` Jason Gunthorpe
2015-11-07 2:55 ` [BUG, PATCH " Jeremiah Mahler
2015-11-07 10:55 ` Jarkko Sakkinen
2015-11-07 11:41 ` Jarkko Sakkinen
2015-11-07 18:08 ` Jeremiah Mahler
2015-11-07 22:31 ` Jarkko Sakkinen
2015-11-07 23:11 ` Jeremiah Mahler
2015-11-08 0:49 ` Jarkko Sakkinen [this message]
2015-11-08 3:04 ` Jeremiah Mahler
2015-11-08 7:46 ` Jarkko Sakkinen
2015-10-16 18:40 ` [PATCH 04/10] tpm: move the PPI attributes to character device directory Jarkko Sakkinen
2015-11-04 18:17 ` [BUG, bisect, PATCH " Jeremiah Mahler
2015-11-05 9:22 ` Jarkko Sakkinen
2015-11-05 11:05 ` [tpmdd-devel] " Jarkko Sakkinen
2015-11-05 16:47 ` Jeremiah Mahler
2015-11-05 17:46 ` Jarkko Sakkinen
2015-11-05 18:17 ` Jeremiah Mahler
2015-11-06 13:45 ` Jarkko Sakkinen
2015-11-07 2:54 ` Jeremiah Mahler
2015-10-16 18:40 ` [PATCH 05/10] tpm: update PPI documentation to address the location change Jarkko Sakkinen
2015-10-16 18:40 ` [PATCH 06/10] tpm: introduce tpm_buf Jarkko Sakkinen
2015-10-18 2:57 ` Peter Hüwe
2015-10-18 11:19 ` Jarkko Sakkinen
2015-10-16 18:40 ` [PATCH 07/10] keys, trusted: move struct trusted_key_options to trusted-type.h Jarkko Sakkinen
2015-10-16 18:40 ` [PATCH 08/10] tpm: seal/unseal for TPM 2.0 Jarkko Sakkinen
2015-11-07 18:58 ` Jeremiah Mahler
2015-11-07 21:39 ` Jarkko Sakkinen
2015-10-16 18:40 ` [PATCH 09/10] keys, trusted: seal/unseal with TPM 2.0 chips Jarkko Sakkinen
2015-10-16 18:40 ` [PATCH 10/10] MAINTAINERS: add new maintainer for TPM DEVICE DRIVER Jarkko Sakkinen
2015-10-16 19:06 ` [tpmdd-devel] [PATCH 00/10] TPM2 updates for 4.4 Kevin Strasser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151108004906.GA25843@intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=artem.bityutskiy@linux.intel.com \
--cc=dhowells@redhat.com \
--cc=ebiederm@xmission.com \
--cc=gregkh@linuxfoundation.org \
--cc=jgunthorpe@obsidianresearch.com \
--cc=jmmahler@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=neilb@suse.de \
--cc=peterhuewe@gmx.de \
--cc=tj@kernel.org \
--cc=tpmdd-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).