From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Jeremiah Mahler <jmmahler@gmail.com>,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
peterhuewe@gmx.de, gregkh@linuxfoundation.org,
dhowells@redhat.com, artem.bityutskiy@linux.intel.com,
Tejun Heo <tj@kernel.org>, NeilBrown <neilb@suse.de>,
Guenter Roeck <linux@roeck-us.net>,
"Eric W. Biederman" <ebiederm@xmission.com>
Subject: Re: [PATCH 03/10] sysfs: added __compat_only_sysfs_link_entry_to_kobj()
Date: Mon, 9 Nov 2015 15:32:16 -0700 [thread overview]
Message-ID: <20151109223216.GA1305@obsidianresearch.com> (raw)
In-Reply-To: <20151107002356.GA6026@newt.localdomain>
On Fri, Nov 06, 2015 at 04:23:56PM -0800, Jeremiah Mahler wrote:
> On Fri, Oct 16, 2015 at 09:40:22PM +0300, Jarkko Sakkinen wrote:
> > Added a new function __compat_only_sysfs_link_group_to_kobj() that adds
> > a symlink from attribute or group to a kobject. This needed for
> > maintaining backwards compatibility with PPI attributes in the TPM
> > driver.
> One problem with this patch is that it adds a bunch of code but none of
> it is used. So if there is a bug, git bisect will point to a later
> patch instead of this one.
It is fairly standard practice to split cross-subsystem patches like
this, it aids review. git bisect is not a perfect tool.
Jason
next prev parent reply other threads:[~2015-11-09 22:32 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-16 18:40 [PATCH 00/10] TPM2 updates for 4.4 Jarkko Sakkinen
2015-10-16 18:40 ` [PATCH 01/10] tpm, tpm_crb: fix unaligned read of the command buffer address Jarkko Sakkinen
2015-10-18 3:02 ` Peter Hüwe
2015-10-18 11:15 ` Jarkko Sakkinen
2015-10-16 18:40 ` [PATCH 02/10] tpm, tpm_tis: fix tpm_tis ACPI detection issue with TPM 2.0 Jarkko Sakkinen
2015-10-16 18:40 ` [PATCH 03/10] sysfs: added __compat_only_sysfs_link_entry_to_kobj() Jarkko Sakkinen
2015-10-18 1:37 ` Peter Hüwe
2015-10-18 11:21 ` Jarkko Sakkinen
2015-11-07 0:23 ` Jeremiah Mahler
2015-11-09 22:32 ` Jason Gunthorpe [this message]
2015-11-07 2:55 ` [BUG, PATCH " Jeremiah Mahler
2015-11-07 10:55 ` Jarkko Sakkinen
2015-11-07 11:41 ` Jarkko Sakkinen
2015-11-07 18:08 ` Jeremiah Mahler
2015-11-07 22:31 ` Jarkko Sakkinen
2015-11-07 23:11 ` Jeremiah Mahler
2015-11-08 0:49 ` Jarkko Sakkinen
2015-11-08 3:04 ` Jeremiah Mahler
2015-11-08 7:46 ` Jarkko Sakkinen
2015-10-16 18:40 ` [PATCH 04/10] tpm: move the PPI attributes to character device directory Jarkko Sakkinen
2015-11-04 18:17 ` [BUG, bisect, PATCH " Jeremiah Mahler
2015-11-05 9:22 ` Jarkko Sakkinen
2015-11-05 11:05 ` [tpmdd-devel] " Jarkko Sakkinen
2015-11-05 16:47 ` Jeremiah Mahler
2015-11-05 17:46 ` Jarkko Sakkinen
2015-11-05 18:17 ` Jeremiah Mahler
2015-11-06 13:45 ` Jarkko Sakkinen
2015-11-07 2:54 ` Jeremiah Mahler
2015-10-16 18:40 ` [PATCH 05/10] tpm: update PPI documentation to address the location change Jarkko Sakkinen
2015-10-16 18:40 ` [PATCH 06/10] tpm: introduce tpm_buf Jarkko Sakkinen
2015-10-18 2:57 ` Peter Hüwe
2015-10-18 11:19 ` Jarkko Sakkinen
2015-10-16 18:40 ` [PATCH 07/10] keys, trusted: move struct trusted_key_options to trusted-type.h Jarkko Sakkinen
2015-10-16 18:40 ` [PATCH 08/10] tpm: seal/unseal for TPM 2.0 Jarkko Sakkinen
2015-11-07 18:58 ` Jeremiah Mahler
2015-11-07 21:39 ` Jarkko Sakkinen
2015-10-16 18:40 ` [PATCH 09/10] keys, trusted: seal/unseal with TPM 2.0 chips Jarkko Sakkinen
2015-10-16 18:40 ` [PATCH 10/10] MAINTAINERS: add new maintainer for TPM DEVICE DRIVER Jarkko Sakkinen
2015-10-16 19:06 ` [tpmdd-devel] [PATCH 00/10] TPM2 updates for 4.4 Kevin Strasser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151109223216.GA1305@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=artem.bityutskiy@linux.intel.com \
--cc=dhowells@redhat.com \
--cc=ebiederm@xmission.com \
--cc=gregkh@linuxfoundation.org \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jmmahler@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=neilb@suse.de \
--cc=peterhuewe@gmx.de \
--cc=tj@kernel.org \
--cc=tpmdd-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).