From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Peter Robinson <pbrobinson@gmail.com>
Cc: Lee Jones <lee.jones@linaro.org>,
<patches@opensource.wolfsonmicro.com>,
<linux-kernel@vger.kernel.org>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
<stable@vger.kernel.org>
Subject: Re: [PATCH] mfd: wm8994: Add module description/author/license information
Date: Tue, 10 Nov 2015 10:10:04 +0000 [thread overview]
Message-ID: <20151110101004.GH2549@ck-lbox> (raw)
In-Reply-To: <1446913539-8940-2-git-send-email-pbrobinson@gmail.com>
On Sat, Nov 07, 2015 at 04:25:39PM +0000, Peter Robinson wrote:
> When compiled as a module we get a tainted kernel because of the lack
> of the module information and the following errors. Add details to
> fix the issue when wm8994_irq/wm8994_regmap are modular.
>
> wm8994_irq: module license 'unspecified' taints kernel.
>
> wm8994_irq: Unknown symbol irq_domain_xlate_twocell (err 0)
> wm8994_irq: Unknown symbol regmap_write (err 0)
> wm8994_irq: Unknown symbol gpiod_to_irq (err 0)
> wm8994_irq: Unknown symbol irq_modify_status (err 0)
> wm8994_irq: Unknown symbol irq_set_chip_and_handler_name (err 0)
> wm8994_irq: Unknown symbol regmap_add_irq_chip (err 0)
> wm8994_irq: Unknown symbol gpiod_get_raw_value_cansleep (err 0)
> wm8994_irq: Unknown symbol handle_nested_irq (err 0)
> wm8994_irq: Unknown symbol __irq_domain_add (err 0)
> wm8994_irq: Unknown symbol irq_create_mapping (err 0)
> wm8994_irq: Unknown symbol gpio_to_desc (err 0)
> wm8994_irq: Unknown symbol regmap_del_irq_chip (err 0)
> wm8994_regmap: module license 'unspecified' taints kernel.
>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> ---
This looks like the intention was for 8994 to be a single module
can you try the following and see if that also fixes your issue.
Thanks,
Charles
>From ba8cea5e6193c501070553f2f78d1ac59aae252d Mon Sep 17 00:00:00 2001
From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Date: Tue, 10 Nov 2015 10:06:29 +0000
Subject: [PATCH] mfd: wm8994: Ensure that the whole MFD is built into a single module
Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
---
drivers/mfd/Makefile | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile
index ef09bf1..b9c229d 100644
--- a/drivers/mfd/Makefile
+++ b/drivers/mfd/Makefile
@@ -63,7 +63,8 @@ wm8350-objs := wm8350-core.o wm8350-regmap.o wm8350-gpio.o
wm8350-objs += wm8350-irq.o
obj-$(CONFIG_MFD_WM8350) += wm8350.o
obj-$(CONFIG_MFD_WM8350_I2C) += wm8350-i2c.o
-obj-$(CONFIG_MFD_WM8994) += wm8994-core.o wm8994-irq.o wm8994-regmap.o
+wm8994-objs := wm8994-core.o wm8994-irq.o wm8994-regmap.o
+obj-$(CONFIG_MFD_WM8994) += wm8994.o
obj-$(CONFIG_TPS6105X) += tps6105x.o
obj-$(CONFIG_TPS65010) += tps65010.o
--
1.7.2.5
next prev parent reply other threads:[~2015-11-10 10:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-07 16:25 v2 mfd: wm8994: Add module description/author/license Peter Robinson
2015-11-07 16:25 ` [PATCH] mfd: wm8994: Add module description/author/license information Peter Robinson
2015-11-10 10:10 ` Charles Keepax [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-11-07 12:28 Peter Robinson
2015-11-07 13:55 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151110101004.GH2549@ck-lbox \
--to=ckeepax@opensource.wolfsonmicro.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=pbrobinson@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).