From: David Miller <davem@davemloft.net>
To: rweikusat@mobileactivedefense.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix inverted test in __skb_recv_datagram
Date: Tue, 08 Dec 2015 11:30:42 -0500 (EST) [thread overview]
Message-ID: <20151208.113042.982813461385384189.davem@davemloft.net> (raw)
In-Reply-To: <87io4980c3.fsf@doppelsaurus.mobileactivedefense.com>
From: Rainer Weikusat <rweikusat@mobileactivedefense.com>
Date: Tue, 08 Dec 2015 14:46:36 +0000
> David Miller <davem@davemloft.net> writes:
>> From: Rainer Weikusat <rweikusat@mobileactivedefense.com>
>> Date: Mon, 07 Dec 2015 23:30:58 +0000
>>
>>> As the kernel generally uses negated error numbers, *err needs to be
>>> compared with -EAGAIN (d'oh).
>>>
>>> Signed-off-by: Rainer Weikusat <rweikusat@mobileactivedefense.com>
>>> Fixes: ea3793ee29d3
>>
>> Improperly formatted Fixes: tag, you must also include the commit
>> header line, in parenthesis and double quotes, after the SHA_ID.
>>
>> Futhermore this is the wrong SHA_ID.
>
> https://git.kernel.org/cgit/linux/kernel/git/davem/net-next.git/commit/?id=ea3793ee29d3
>
> displays the commit I was referring to, namely, the one containing this
My bad.
next prev parent reply other threads:[~2015-12-08 16:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-06 21:11 [PATCH 01/02] core: enable more fine-grained datagram reception control Rainer Weikusat
2015-12-07 4:30 ` David Miller
2015-12-07 23:15 ` breaks blocking receive for other users (was: [PATCH 01/02] core: enable more fine-grained datagram reception control) Rainer Weikusat
2015-12-07 23:30 ` [PATCH] fix inverted test in __skb_recv_datagram Rainer Weikusat
2015-12-08 3:28 ` David Miller
2015-12-08 14:46 ` Rainer Weikusat
2015-12-08 16:30 ` David Miller [this message]
2015-12-08 14:47 ` Rainer Weikusat
2015-12-08 16:31 ` David Miller
2015-12-08 20:11 ` Rainer Weikusat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151208.113042.982813461385384189.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rweikusat@mobileactivedefense.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).