From: Andrew Morton <akpm@linux-foundation.org>
To: Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH] hexdump: Add ability to do endian conversions in print_hex_dump functions
Date: Wed, 9 Dec 2015 14:45:35 -0800 [thread overview]
Message-ID: <20151209144535.1e8f4ed8a8d5d070d574d59f@linux-foundation.org> (raw)
In-Reply-To: <1449699396.25389.76.camel@perches.com>
On Wed, 09 Dec 2015 14:16:36 -0800 Joe Perches <joe@perches.com> wrote:
> On Wed, 2015-12-09 at 14:09 -0800, Andrew Morton wrote:
> > On Wed,____9 Dec 2015 13:59:30 -0800 Joe Perches <joe@perches.com> wrote:
> >
> > > There are use cases for dumping buffers with specific endian types
> > > for 2, 4, and 8 byte variables in arrays.
> > >
> > > Add an enum for DUMP_TYPE_(LE|BE|CPU) to enable emitting them as such.
> > >
> > > Rename groupsize to groupflags in the functions and add documentation
> > > to the kernel-doc to describe the use of the DUMP_TYPE_ enum.
> >
> > What are these use cases?
>
> Buffers that contain LE or BE arrays that want
> to be emitted by print_hex_dump.
Make that "where are".
> > Will patches be forthcoming to convert them?
>
> Sure, after a settling period for Masahiro's patch
> to be applied upstream.
>
> https://lkml.org/lkml/2015/12/8/480
One single callsite under #ifdef DEBUG? Doesn't seem to warrant adding
code and complexity to core library functions.
next prev parent reply other threads:[~2015-12-09 22:45 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-08 16:07 [PATCH v2] of/address: replace printk() with pr_debug() / pr_err() Masahiro Yamada
2015-12-08 16:16 ` Joe Perches
2015-12-08 17:03 ` Joe Perches
2015-12-08 21:28 ` Rob Herring
2015-12-09 0:03 ` Joe Perches
2015-12-09 12:03 ` Andy Shevchenko
2015-12-09 19:28 ` Joe Perches
2015-12-09 20:02 ` Andy Shevchenko
2015-12-09 20:09 ` Joe Perches
2015-12-09 20:17 ` Rasmus Villemoes
2015-12-09 20:36 ` Andy Shevchenko
2015-12-09 20:42 ` Joe Perches
2015-12-09 21:59 ` [PATCH] hexdump: Add ability to do endian conversions in print_hex_dump functions Joe Perches
2015-12-09 22:09 ` Andrew Morton
2015-12-09 22:16 ` Joe Perches
2015-12-09 22:45 ` Andrew Morton [this message]
2015-12-09 23:02 ` Joe Perches
2015-12-09 22:11 ` Andy Shevchenko
2015-12-09 22:22 ` Joe Perches
2015-12-09 23:09 ` Andy Shevchenko
2015-12-09 23:15 ` Joe Perches
2015-12-10 5:55 ` kbuild test robot
2015-12-10 6:20 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151209144535.1e8f4ed8a8d5d070d574d59f@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=andy.shevchenko@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).